lebedev.ri added inline comments.
================ Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:55 + IgnoreMacros(Options.getLocalOrGlobal("IgnoreMacros", true)), + UseLegacyFunction(Options.getLocalOrGlobal("UseLegacyFunction", false)) {} ---------------- I'm not sure it makes sense to look for global `UseLegacyFunction`? It doesn't sound all that common. ================ Comment at: docs/clang-tidy/checks/modernize-make-unique.rst:52 + +.. option:: UseLegacyFunction + ---------------- Name is too cryptic i'd say. Maybe just `IgnoreInitListExprs` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55044/new/ https://reviews.llvm.org/D55044 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits