[PATCH] D59087: [clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not working if an "else" statement is present

reuk accepted this revision. reuk added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59087/new/ https://reviews.llvm.org/D59087 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D56990: Bugfix for Replacement of tied operand of inline asm

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM; I'll merge it tonight or tomorrow. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56990/new/ https://reviews.llvm.org/D56990 __

[PATCH] D59279: [Analyzer] Checker for non-determinism caused by iteration of unordered container of pointers

mgrang created this revision. mgrang added reviewers: NoQ, george.karpenkov, whisperity, Szelethus. mgrang added a project: clang. Herald added subscribers: Charusso, jdoerfert, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, mgorny. Added a check

[PATCH] D59279: [Analyzer] Checker for non-determinism caused by iteration of unordered container of pointers

mgrang added a comment. Following are the assumptions/limitations of this patch: 1. The assumption is that iteration of ordered containers of pointers is not non-deterministic. 2. Currently we only detect std::unordered_set. Detection of unordered_map can be added later. 3. Currentl

[PATCH] D59282: [Parse] Parse '#pragma clang attribute' as an external-declaration

erik.pilkington created this revision. erik.pilkington added reviewers: aaron.ballman, arphaman, rsmith. Herald added subscribers: dexonsmith, jkorous. Herald added a project: clang. Previously, we parsed it only in the top level, which excludes namespaces and `extern "C"` blocks. rdar://problem

[PATCH] D56370: [clangd] Add support for type hierarchy (super types only for now)

nridge added a comment. > In D56370#1424180 , @nridge wrote: > >> Unfortunately, there is a further problem: the Theia client-side >> implementation of type hierarchy has recently merged, and their code has >> changed so that they do require `typeHierarc

[PATCH] D56370: [clangd] Add support for type hierarchy (super types only for now)

nridge added a comment. In D56370#1426234 , @kadircet wrote: > Unfortunately we usually test LSP layer with lit tests, and since we don't > have any lit tests for this use-case it wasn't caught. Could you add a lit > test for overall use case? You can se

[PATCH] D59283: Fixed global constant/variable naming check on C++ class for ObjC++ files.

Wizard created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D59283 Files: clang-tidy/google/GlobalVariableDeclarationCheck.cpp test/clang-tidy/google-objc-global-variable-declaration.m te

r356005 - Delete unused declaration of DeclContextPrintAction after the removal of -print-decl-contexts by D52529

Author: maskray Date: Tue Mar 12 20:22:33 2019 New Revision: 356005 URL: http://llvm.org/viewvc/llvm-project?rev=356005&view=rev Log: Delete unused declaration of DeclContextPrintAction after the removal of -print-decl-contexts by D52529 Modified: cfe/trunk/include/clang/Frontend/FrontendAct

[PATCH] D59282: [Parse] Parse '#pragma clang attribute' as an external-declaration

rsmith accepted this revision. rsmith marked an inline comment as done. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Parser/pragma-attribute-context.cpp:29 +struct InStruct { + // FIXME: This asserts in Objective-C++! + /

r356008 - [X86] Remove 'cx16' from 'prescott' and 'yonah' as they are 32-bit only CPUs and cmpxchg16b requires 64-bit mode.

Author: ctopper Date: Tue Mar 12 22:14:52 2019 New Revision: 356008 URL: http://llvm.org/viewvc/llvm-project?rev=356008&view=rev Log: [X86] Remove 'cx16' from 'prescott' and 'yonah' as they are 32-bit only CPUs and cmpxchg16b requires 64-bit mode. Modified: cfe/trunk/lib/Basic/Targets/X86.cp

r356007 - [X86] Add 'yonah' test to predefined-arch-macros.c test.

Author: ctopper Date: Tue Mar 12 22:14:50 2019 New Revision: 356007 URL: http://llvm.org/viewvc/llvm-project?rev=356007&view=rev Log: [X86] Add 'yonah' test to predefined-arch-macros.c test. Modified: cfe/trunk/test/Preprocessor/predefined-arch-macros.c Modified: cfe/trunk/test/Preprocessor/

[PATCH] D59264: [Driver] Support compiler-rt crtbegin.o/crtend.o for Linux

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:563 + crtend = Args.hasArg(options::OPT_shared) || IsPIE || IsStaticPIE ? + "crtend_shared" : "crtend"; + CmdArgs.push_back(ToolChain.getCompilerRTArgString(

[PATCH] D56370: [clangd] Add support for type hierarchy (super types only for now)

nridge updated this revision to Diff 190375. nridge added a comment. Address remaining review comments (I figure out how to write a lit test) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56370/new/ https://reviews.llvm.org/D56370 Files: clang-

[PATCH] D59264: [Driver] Support compiler-rt crtbegin.o/crtend.o for Linux

phosek marked an inline comment as done. phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:563 + crtend = Args.hasArg(options::OPT_shared) || IsPIE || IsStaticPIE ? + "crtend_shared" : "crtend"; + CmdArgs.push_back(ToolCh

[PATCH] D59287: [X86] Only define __GCC_HAVE_SYNC_COMPARE_AND_SWAP_16 in 64-bit mode.

craig.topper created this revision. craig.topper added reviewers: RKSimon, spatel, efriedma, jyknight. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. This define should correspond to CMPXCHG16B being available which requires 64-bit mode. I checked and gcc also seems t

[PATCH] D59264: [Driver] Support compiler-rt crtbegin.o/crtend.o for Linux

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:563 + crtend = Args.hasArg(options::OPT_shared) || IsPIE || IsStaticPIE ? + "crtend_shared" : "crtend"; + CmdArgs.push_back(ToolChain.getCompilerRTArgString(

[libclc] r356009 - travis: Use gcc-6 for llvm-7 build

Author: jvesely Date: Tue Mar 12 23:58:51 2019 New Revision: 356009 URL: http://llvm.org/viewvc/llvm-project?rev=356009&view=rev Log: travis: Use gcc-6 for llvm-7 build llvm does not expose -std=c++11 in cxx flags. gcc-6 switched default from c++98 to c++14 Reviewers: Aaron Watry, Tom Stellard S

[libclc] r356010 - travis: Deduplicate LLVM_CONFIG variable

Author: jvesely Date: Tue Mar 12 23:58:53 2019 New Revision: 356010 URL: http://llvm.org/viewvc/llvm-project?rev=356010&view=rev Log: travis: Deduplicate LLVM_CONFIG variable Reviewers: Aaron Watry, Tom Stellard Signed-off-by: Jan Vesely Modified: libclc/trunk/.travis.yml Modified: libclc/

<    1   2