[PATCH] D59013: [CMake][runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/

smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: libcxx/CMakeLists.txt:420-421 if(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND NOT APPLE) - set(DEFAULT_INSTALL_PREFIX lib${LLVM_LIBDIR_SUFFIX}/clang/

[PATCH] D58665: [analyzer] Handle comparison between non-default AS symbol and constant

dstenb added a comment. Thanks for the review! I'll submit this shortly then. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58665/new/ https://reviews.llvm.org/D58665 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D45978: dllexport const variables must have external linkage.

zahiraam updated this revision to Diff 189659. zahiraam marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D45978/new/ https://reviews.llvm.org/D45978 Files: lib/Sema/SemaDecl.cpp test/CodeGen/dllexport-1.c test/Sema/dllexport-1.cpp test/Sema/dllexport

[PATCH] D58894: [analyzer] Handle modification of vars inside an expr with comma operator

djtodoro marked an inline comment as done. djtodoro added a comment. > Anyways, this looks good in this state. > Thank you for working on this! Thanks! > If you don't intend to immediately work on fixing the rest of , cases here, > *please* do file a bug so it won't get lost. (and link it here)

[PATCH] D59013: [CMake][runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/

phosek marked an inline comment as done. phosek added inline comments. Comment at: libcxx/CMakeLists.txt:420-421 if(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND NOT APPLE) - set(DEFAULT_INSTALL_PREFIX lib${LLVM_LIBDIR_SUFFIX}/clang/${CLANG_VERSION}/${LLVM_DEFAULT_TARGET_TRIPLE}/) -

[PATCH] D58894: [analyzer] Handle modification of vars inside an expr with comma operator

djtodoro updated this revision to Diff 189661. djtodoro added a comment. -add support for the rest of direct mutation cases CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58894/new/ https://reviews.llvm.org/D58894 Files: include/clang/AST/Expr.h lib/Analysis/ExprMutationAnalyzer.cpp

[PATCH] D58894: [analyzer] Handle modification of vars inside an expr with comma operator

lebedev.ri accepted this revision. lebedev.ri added a comment. Still LG. I'm sure you have verified that there is test coverage for all the newly-supported cases. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58894/new/ https://reviews.llvm.org/D58894 ___

r355585 - [IR][ARM] Add function pointer alignment to datalayout

Author: michaelplatings Date: Thu Mar 7 01:15:23 2019 New Revision: 355585 URL: http://llvm.org/viewvc/llvm-project?rev=355585&view=rev Log: [IR][ARM] Add function pointer alignment to datalayout Use this feature to fix a bug on ARM where 4 byte alignment is incorrectly assumed. Differential Re

[PATCH] D59079: [clang][Tooling] Delete dots and dotdots when generating absolute paths

kadircet created this revision. kadircet added a reviewer: hokein. Herald added a project: clang. Herald added a subscriber: cfe-commits. GetAllFiles interface returns absolute paths, but keeps dots and dot dots. This patch makes those paths canonical by deleting them. Repository: rC Clang ht

[PATCH] D58494: [ASTImporter] Handle redecl chain of FunctionTemplateDecls

martong updated this revision to Diff 189665. martong marked 6 inline comments as done. martong added a comment. - Add asserts Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58494/new/ https://reviews.llvm.org/D58494 Files: lib/AST/ASTImporter.cpp unittests/A

[PATCH] D58494: [ASTImporter] Handle redecl chain of FunctionTemplateDecls

martong added inline comments. Comment at: lib/AST/ASTImporter.cpp:4967 +template static auto getTemplateDefinition(T *D) -> T * { + auto *ToTemplatedDef = D->getTemplatedDecl()->getDefinition(); if (!ToTemplatedDef) shafik wrote: > shafik wrote: > > Can we

[PATCH] D48866: [clang-tidy] Add incorrect-pointer-cast checker

steakhal added a comment. Herald added a subscriber: jdoerfert. Herald added a project: clang. @hgabii Are you planning on finishing this? If not, I'd happily commandeer if not. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48866/new/ https://revie

[PATCH] D59079: [clang][Tooling] Delete dots and dotdots when generating absolute paths

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: lib/Tooling/JSONCompilationDatabase.cpp:373 llvm::sys::path::append(AbsolutePath, FileName); + llvm::sys::path::remove_dots(AbsolutePath, true);

r355586 - [libclang] Fix CXTranslationUnit_KeepGoing

Author: yvvan Date: Thu Mar 7 02:13:50 2019 New Revision: 355586 URL: http://llvm.org/viewvc/llvm-project?rev=355586&view=rev Log: [libclang] Fix CXTranslationUnit_KeepGoing Since commit 56f5487e4387a69708f70724d00e9e076153 [modules] Round-trip -Werror flag through explicit module build.

[PATCH] D58501: [libclang] Fix CXTranslationUnit_KeepGoing

This revision was automatically updated to reflect the committed changes. Closed by commit rL355586: [libclang] Fix CXTranslationUnit_KeepGoing (authored by yvvan, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llv

[PATCH] D57891: [analyzer] Fix infinite recursion in printing macros

bruntib updated this revision to Diff 189670. bruntib added a comment. Herald added subscribers: Charusso, jdoerfert, whisperity. I added a test case for this recursive case. There is also a TODO in the code indicating the place where an additional fix will be required. Repository: rC Clang

[PATCH] D57891: [analyzer] Fix infinite recursion in printing macros

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. Well, yea, getting rid of a crash is great, it's kind of bummer that can't expand the macro properly in the testfile. I really fear that we need a far greater overhaul of this entire eff

[PATCH] D59083: [clangd] Store explicit template specializations in index for code navigation purposes

kadircet created this revision. kadircet added reviewers: hokein, gribozavr. Herald added subscribers: cfe-commits, jdoerfert, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Herald added a project: clang. This introduces ~4k new symbols, and ~10k refs for LLVM. We need that information for pr

[PATCH] D59084: [clangd] Remove ./ and ../ in the file paths

kadircet created this revision. kadircet added a reviewer: hokein. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Herald added a project: clang. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D59084 Files: clangd/index/Background.cpp

[PATCH] D59038: [8.0 Regression] Fix handling of `__builtin_constant_p` inside the enable_if attribute.

hans added a comment. I think I'll have to defer to Richard for reviewing this, since I'm not familiar with the code. Since it's a regression we probably want to merge it to clang 8. Can you give any guidance to how bad a regression this is, e.g. does it break some important piece of code? Re

[PATCH] D59083: [clangd] Store explicit template specializations in index for code navigation purposes

gribozavr accepted this revision. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: clangd/CodeComplete.cpp:1513 +template bool explicitTemplateSpecialization(const NamedDecl &ND) { + if (const auto *TD = dyn_cast(&ND))

[PATCH] D59086: [clangd] Adjust compile commands to be applicable for tooling

kadircet created this revision. kadircet added reviewers: gribozavr, hokein. Herald added subscribers: cfe-commits, jdoerfert, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Herald added a project: clang. As can be seen in https://github.com/llvm-mirror/clang/blob/master/lib/Tooling/Tooling.

[PATCH] D59086: [clangd] Adjust compile commands to be applicable for tooling

kadircet updated this revision to Diff 189682. kadircet added a comment. - Update the diff, sorry for the confusion Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59086/new/ https://reviews.llvm.org/D59086 Files: clangd/GlobalCompilationDatabase.c

[PATCH] D59087: [clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not working if an "else" statement is present

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: klimek, djasper, JonasToth, alexfh, krasimir. MyDeveloperDay added a project: clang-tools-extra. Herald added a subscriber: jdoerfert. Addressing: PR25010 - https://bugs.llvm.org/show_bug.cgi?id=25010 Code like: if(true) var

[PATCH] D59083: [clangd] Store explicit template specializations in index for code navigation purposes

ioeric added a comment. > We need that information for providing better code navigation support, like > find references, children/base classes etc. It's not trivial how they make code navigation better. Can you explain and provide examples in the summary? Thanks! Comment at:

[PATCH] D59086: [clangd] Adjust compile commands to be applicable for tooling

ioeric added inline comments. Comment at: clangd/GlobalCompilationDatabase.h:116 + /// Adjusts given compile command for clangd. + tooling::CompileCommand adjustArguments(tooling::CompileCommand Cmd) const; + This doesn't seem to be used in this patch (except f

[PATCH] D59038: [8.0 Regression] Fix handling of `__builtin_constant_p` inside the enable_if attribute.

EricWF added a comment. In D59038#1421310 , @hans wrote: > I think I'll have to defer to Richard for reviewing this, since I'm not > familiar with the code. Since it's a regression we probably want to merge it > to clang 8. Can you give any guidance to h

[PATCH] D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check

JonasToth added inline comments. Comment at: test/clang-tidy/cppcoreguidelines-use-raii-locks.cpp:90 + for (auto i = 0; i < 3; i++) { +m.lock(); +// CHECK-MESSAGES: :[[@LINE-1]]:5: warning: use RAII JonasToth wrote: > lewmpk wrote: > > JonasToth wrote: >

[PATCH] D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check

JonasToth added a comment. IMHO the check is close to being finished. please address the notes and mark them as done if finished with it. So its clear to see whats outstanding. In my opinion the user-facing documentation misses a "Limitations" sections that shows the artificial `goto` example, t

[PATCH] D59086: [clangd] Adjust compile commands to be applicable for tooling

hokein added inline comments. Comment at: clangd/GlobalCompilationDatabase.h:116 + /// Adjusts given compile command for clangd. + tooling::CompileCommand adjustArguments(tooling::CompileCommand Cmd) const; + ioeric wrote: > This doesn't seem to be used in this

[PATCH] D59084: [clangd] Remove ./ and ../ in the file paths

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. It would be nicer to have a unittest (if it doesn't take too much effort to create one). Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59084/new/

r355592 - [analyzer] Handle comparison between non-default AS symbol and constant

Author: dstenb Date: Thu Mar 7 05:01:17 2019 New Revision: 355592 URL: http://llvm.org/viewvc/llvm-project?rev=355592&view=rev Log: [analyzer] Handle comparison between non-default AS symbol and constant Summary: When comparing a symbolic region and a constant, the constant would be widened or t

r355593 - [ASTImporter] Handle redecl chain of FunctionTemplateDecls

Author: martong Date: Thu Mar 7 05:01:51 2019 New Revision: 355593 URL: http://llvm.org/viewvc/llvm-project?rev=355593&view=rev Log: [ASTImporter] Handle redecl chain of FunctionTemplateDecls Summary: Redecl chains of function templates are not handled well currently. We want to handle them simi

[PATCH] D58494: [ASTImporter] Handle redecl chain of FunctionTemplateDecls

This revision was automatically updated to reflect the committed changes. Closed by commit rC355593: [ASTImporter] Handle redecl chain of FunctionTemplateDecls (authored by martong, committed by ). Changed prior to commit: https://reviews.llvm.org/D58494?vs=189665&id=189694#toc Repository: r

[PATCH] D58665: [analyzer] Handle comparison between non-default AS symbol and constant

This revision was automatically updated to reflect the committed changes. Closed by commit rC355592: [analyzer] Handle comparison between non-default AS symbol and constant (authored by dstenb, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58665/new

[PATCH] D58814: [clang][Index] Constructors and Destructors do not reference class

kadircet updated this revision to Diff 189695. kadircet added a comment. - Add NameReference role kind, and tag references from constructors/destructors to the class with that kind. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58814/new/ https://reviews.llvm.or

[PATCH] D59086: [clangd] Adjust compile commands to be applicable for tooling

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clangd/GlobalCompilationDatabase.h:116 + /// Adjusts given compile command for clangd. + tooling::CompileCommand adjustArguments(tooling::CompileCommand Cmd) const; + hokein

[PATCH] D58814: [clang][Index] Constructors and Destructors do not reference class

gribozavr accepted this revision. gribozavr added a comment. Do we also need to change anything for constructor calls? If not, please add a test for that. Comment at: lib/Index/IndexDecl.cpp:251 + Ctor->getParent(), Ctor->getDeclContext(), +

[PATCH] D53818: [ASTImporter] Changed use of Import to Import_New in ASTImporter.

balazske updated this revision to Diff 189696. balazske added a comment. Herald added a reviewer: martong. Herald added a subscriber: jdoerfert. - Small style corrections. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53818/new/ https://reviews.llvm.org/D53818 F

[PATCH] D58673: [ASTImporter] Fix redecl failures of ClassTemplateSpec

martong marked 2 inline comments as done. martong added inline comments. Comment at: lib/AST/ASTImporter.cpp:5147 } +} else { // ODR violation. + // FIXME HandleNameConflict shafik wrote: > ODR violations are ill-formed no diagnostic required. So

r355596 - [ASTImporter] Import member expr with explicit template args

Author: martong Date: Thu Mar 7 05:38:20 2019 New Revision: 355596 URL: http://llvm.org/viewvc/llvm-project?rev=355596&view=rev Log: [ASTImporter] Import member expr with explicit template args Summary: Member expressions with explicit template arguments were not imported correctly: the DeclRefE

[PATCH] D59054: [analyzer] C++17: PR40022: Support aggregate initialization with compound values in presence of base classes.

alexfh added a comment. LG in general. A couple of comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:2348 +// Virtual bases still aren't allowed. Multiple bases are fine though. +for (auto B : CRD->bases()) { + assert(B.isVirtual() == false); ---

[PATCH] D58830: [ASTImporter] Import member expr with explicit template args

This revision was automatically updated to reflect the committed changes. Closed by commit rL355596: [ASTImporter] Import member expr with explicit template args (authored by martong, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHA

[PATCH] D58216: Support attribute used in member funcs of class templates II

davezarzycki added a subscriber: bob.wilson. davezarzycki added a comment. I can't get Swift top-of-tree to build with gcc (8.3.1 20190223 (Red Hat 8.3.1-2)), and I doubt that it is supported, but I could be wrong. In any case, the requested change to the Swift compiler source sounds reasonable

[PATCH] D58814: [clang][Index] Constructors and Destructors do not reference class

kadircet added a comment. As discussed offline constructor calls are a different issue, coming from even a different layer than Indexing API. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58814/new/ https://reviews.llvm.org/D58814

[PATCH] D58814: [clang][Index] Constructors and Destructors do not reference class

kadircet updated this revision to Diff 189703. kadircet marked 2 inline comments as done. kadircet added a comment. - Delete extra parens Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58814/new/ https://reviews.llvm.org/D58814 Files: include/clang/Index/IndexS

r355598 - [ASTImporter] Changed use of Import to Import_New in ASTImporter.

Author: balazske Date: Thu Mar 7 06:09:18 2019 New Revision: 355598 URL: http://llvm.org/viewvc/llvm-project?rev=355598&view=rev Log: [ASTImporter] Changed use of Import to Import_New in ASTImporter. Reviewers: a.sidorin, shafik, a_sidorin, martong Reviewed By: a_sidorin Subscribers: rnkovacs,

[PATCH] D53818: [ASTImporter] Changed use of Import to Import_New in ASTImporter.

This revision was automatically updated to reflect the committed changes. Closed by commit rC355598: [ASTImporter] Changed use of Import to Import_New in ASTImporter. (authored by balazske, committed by ). Changed prior to commit: https://reviews.llvm.org/D53818?vs=189696&id=189704#toc Reposit

[PATCH] D57464: Generalize method overloading on addr spaces to C++

ebevhan added a comment. Any more input on this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57464/new/ https://reviews.llvm.org/D57464 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D59086: [clangd] Adjust compile commands to be applicable for tooling

kadircet updated this revision to Diff 189706. kadircet marked 2 inline comments as done. kadircet added a comment. - Change testing strategy Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59086/new/ https://reviews.llvm.org/D59086 Files: clangd/G

[clang-tools-extra] r355599 - [clangd] Strip plugin arguments in clangd-indexer.

Author: hokein Date: Thu Mar 7 06:47:17 2019 New Revision: 355599 URL: http://llvm.org/viewvc/llvm-project?rev=355599&view=rev Log: [clangd] Strip plugin arguments in clangd-indexer. Summary: This would allow clangd-indexer runs on chromium repo. Reviewers: kadircet Reviewed By: kadircet Subs

[PATCH] D59022: [clangd] Strip plugin arguments in clangd-indexer.

This revision was automatically updated to reflect the committed changes. Closed by commit rL355599: [clangd] Strip plugin arguments in clangd-indexer. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE

[PATCH] D59092: [clangd] Deduplicate Refs on the fly.

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: arphaman, mgrang, jkorous, MaskRay, ioeric, ilya-biryukov. Herald added a project: clang. Currently, we only do deduplication when we flush final results. We may have huge duplications (refs from headers) d

[PATCH] D45978: dllexport const variables must have external linkage.

aaron.ballman added inline comments. Comment at: lib/Sema/SemaDecl.cpp:5970 auto *VD = dyn_cast(&ND); -if (!ND.isExternallyVisible() || (VD && VD->isStaticLocal())) { +const NamespaceDecl *NS = nullptr; +bool isAnonymousNS = false; This can be lo

r355601 - expected-no-diagnostics@ does not make sense, switching to a more idiomatic form; NFC.

Author: aaronballman Date: Thu Mar 7 07:03:06 2019 New Revision: 355601 URL: http://llvm.org/viewvc/llvm-project?rev=355601&view=rev Log: expected-no-diagnostics@ does not make sense, switching to a more idiomatic form; NFC. Modified: cfe/trunk/test/SemaObjCXX/vararg-non-pod.mm Modified: c

[PATCH] D58878: [Diagnostics] Warn for assignments in bool contexts

xbolva00 updated this revision to Diff 189711. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58878/new/ https://reviews.llvm.org/D58878 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaExprCXX.cpp test/CodeCompletion/crash-ski

[PATCH] D58878: [Diagnostics] Warn for assignments in bool contexts

xbolva00 added a comment. Addressed notes. Not sure why we miss _Bool warn3(int x, _Bool a) { return x = 0 || a; } in C mode :/ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58878/new/ https://reviews.llvm.org/D58878 ___ cfe-commits m

[PATCH] D58930: Add XCOFF triple object format type for AIX

jasonliu updated this revision to Diff 189713. jasonliu added a comment. Share the same "unsupported error" message with WASM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58930/new/ https://reviews.llvm.org/D58930 Files: clang/lib/CodeGen/Back

[PATCH] D53757: [ASTImporter] Changed use of Import to Import_New in ASTNodeImporter.

martong added a comment. Herald added a reviewer: martong. Herald added a project: clang. Ping. This patch is the next in the series of patches to finish the proper error handling (i.e. using Error and Expected). Please see the "Stack" column above. Repository: rC Clang CHANGES SINCE LAST A

[PATCH] D59094: [ARM] Fix bug 39982 - pcs("aapcs-vfp") is not consistent

carwil created this revision. Herald added subscribers: cfe-commits, jdoerfert, kristof.beyls, javed.absar. Herald added a project: clang. See: https://bugs.llvm.org/show_bug.cgi?id=39982 When considering how to classify homogeneous aggregates as return/argument types, the ABI of the function (s

[PATCH] D53757: [ASTImporter] Changed use of Import to Import_New in ASTNodeImporter.

martong added a comment. Herald added a subscriber: rnkovacs. > This patch is the next in the series of patches to finish the proper error > handling (i.e. using Error and Expected). Please see the "Stack" column > above. @balazske Or is it superseded by this one? https://reviews.llvm.org/D5381

[PATCH] D59054: [analyzer] C++17: PR40022: Support aggregate initialization with compound values in presence of base classes.

Szelethus added a comment. At first glance this looks OK, but I'll take the time to understand the infrastructure behind it and give a proper review. Comment at: clang/test/Analysis/array-struct-region.cpp:3 // RUN: %clang_analyze_cc1 -analyzer-checker=core,alpha.core,debug.

[PATCH] D59086: [clangd] Adjust compile commands to be applicable for tooling

gribozavr accepted this revision. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: clangd/GlobalCompilationDatabase.cpp:24 llvm::StringRef ResourceDir) { + // Clangd does not generate dependency file. + Cmd.Comm

[PATCH] D59086: [clangd] Adjust compile commands to be applicable for tooling

ioeric added inline comments. Comment at: clangd/GlobalCompilationDatabase.cpp:25 + // Clangd does not generate dependency file. + Cmd.CommandLine = tooling::getClangStripDependencyFileAdjuster()( + Cmd.CommandLine, Cmd.Filename); Please use `clang::toolin

[PATCH] D58894: [analyzer] Handle modification of vars inside an expr with comma operator

This revision was automatically updated to reflect the committed changes. Closed by commit rL355605: [analyzer] handle modification of vars inside an expr with comma operator (authored by petarj, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D59092: [clangd] Deduplicate Refs on the fly.

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clangd/index/Ref.cpp:44 RefSlab RefSlab::Builder::build() && { // We can reuse the arena, as it only has unique strings and we need them all. -

r355606 - [PR40778] Preserve addr space in Derived to Base cast.

Author: stulova Date: Thu Mar 7 08:23:15 2019 New Revision: 355606 URL: http://llvm.org/viewvc/llvm-project?rev=355606&view=rev Log: [PR40778] Preserve addr space in Derived to Base cast. The address space for the Base class pointer when up-casting from Derived should be taken from the Derived c

r355608 - [PR40778][Sema] Adjust addr space of operands in builtin operators.

Author: stulova Date: Thu Mar 7 08:43:41 2019 New Revision: 355608 URL: http://llvm.org/viewvc/llvm-project?rev=355608&view=rev Log: [PR40778][Sema] Adjust addr space of operands in builtin operators. Adjust address space for references and pointer operands of builtin operators. Currently this

[PATCH] D58719: [PR40778][Sema] Adjust address space of operands in builtin operators

This revision was automatically updated to reflect the committed changes. Closed by commit rC355608: [PR40778][Sema] Adjust addr space of operands in builtin operators. (authored by stulova, committed by ). Herald added a subscriber: kristina. Herald added a project: clang. Changed prior to commi

r355609 - [Sema] Change addr space diagnostics in casts to follow C++ style.

Author: stulova Date: Thu Mar 7 09:06:30 2019 New Revision: 355609 URL: http://llvm.org/viewvc/llvm-project?rev=355609&view=rev Log: [Sema] Change addr space diagnostics in casts to follow C++ style. This change adds a new diagnostic for mismatching address spaces to be used for C++ casts (only

[PATCH] D58346: [Sema] Change addr space diagnostics in casts to follow C++ style

This revision was automatically updated to reflect the committed changes. Closed by commit rL355609: [Sema] Change addr space diagnostics in casts to follow C++ style. (authored by stulova, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to com

[PATCH] D58708: [PR40778] Preserve addr space in Derived to Base cast

Anastasia closed this revision. Anastasia added a comment. Committed in r355606. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58708/new/ https://reviews.llvm.org/D58708 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D58216: Support attribute used in member funcs of class templates II

bob.wilson added a comment. OK, that doesn't sound like it will be a problem Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58216/new/ https://reviews.llvm.org/D58216 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D59086: [clangd] Adjust compile commands to be applicable for tooling

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clangd/GlobalCompilationDatabase.cpp:24 llvm::StringRef ResourceDir) { + // Clangd does not generate dependency file. + Cmd.CommandLine = tooling::getClangStripDependenc

[PATCH] D59086: [clangd] Adjust compile commands to be applicable for tooling

gribozavr added inline comments. Comment at: clangd/GlobalCompilationDatabase.cpp:24 llvm::StringRef ResourceDir) { + // Clangd does not generate dependency file. + Cmd.CommandLine = tooling::getClangStripDependencyFileAdjuster()( kadircet

r355614 - [OPENMP 5.0]Add initial support for 'allocate' directive.

Author: abataev Date: Thu Mar 7 09:54:44 2019 New Revision: 355614 URL: http://llvm.org/viewvc/llvm-project?rev=355614&view=rev Log: [OPENMP 5.0]Add initial support for 'allocate' directive. Added parsing/sema analysis/serialization/deserialization support for 'allocate' directive. Added: c

r355616 - Rollback of rL355585.

Author: hctim Date: Thu Mar 7 10:13:39 2019 New Revision: 355616 URL: http://llvm.org/viewvc/llvm-project?rev=355616&view=rev Log: Rollback of rL355585. Introduces memory leak in FunctionTest.GetPointerAlignment that breaks sanitizer buildbots: ``` =

r355605 - [analyzer] handle modification of vars inside an expr with comma operator

Author: petarj Date: Thu Mar 7 07:50:52 2019 New Revision: 355605 URL: http://llvm.org/viewvc/llvm-project?rev=355605&view=rev Log: [analyzer] handle modification of vars inside an expr with comma operator We should track mutation of a variable within a comma operator expression. Current code in

[PATCH] D58814: [clang][Index] Constructors and Destructors do not reference class

nathawes accepted this revision. nathawes added a comment. This revision is now accepted and ready to land. Thank you! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58814/new/ https://reviews.llvm.org/D58814 ___ cfe-

[PATCH] D59034: Delete x86_64 ShadowCallStack support

vlad.tsyrklevich updated this revision to Diff 189750. vlad.tsyrklevich added a comment. - Keep x86_64 doc link Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59034/new/ https://reviews.llvm.org/D59034 Files: clang/docs/ShadowCallStack.rst comp

[PATCH] D59076: [coroutines][PR40978] Emit error for co_yield within catch block

lewissbaker added inline comments. Comment at: lib/Sema/SemaCoroutine.cpp:197-200 - if (S.isUnevaluatedContext()) { -S.Diag(Loc, diag::err_coroutine_unevaluated_context) << Keyword; -return false; - } Does removing this check now mean that we're not che

[PATCH] D59103: [clang-tidy] New checker bugprone-incomplete-comparison-operator

kallehuttunen created this revision. kallehuttunen added reviewers: alexfh, hokein, JonasToth, aaron.ballman. kallehuttunen added a project: clang-tools-extra. Herald added subscribers: jdoerfert, xazax.hun, mgorny. Herald added a project: clang. The checker detects comparison operators that don't

[PATCH] D58530: Add PragmaHandler for MSVC pragma execution_character_set

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks! Would you like someone to land this for you? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58530/new/ https://reviews.llvm.org/D58530 __

[PATCH] D59103: [clang-tidy] New checker bugprone-incomplete-comparison-operator

lebedev.ri added a comment. Thank you for working on this! This looks questionable to me. Is this based on some coding standard? Are there any numbers on the false-positive rate of theck? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59103/new/ htt

[PATCH] D58530: Add PragmaHandler for MSVC pragma execution_character_set

sigatrev added a comment. Yeah, that would be great. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58530/new/ https://reviews.llvm.org/D58530 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

r355624 - Delete x86_64 ShadowCallStack support

Author: vlad.tsyrklevich Date: Thu Mar 7 10:56:36 2019 New Revision: 355624 URL: http://llvm.org/viewvc/llvm-project?rev=355624&view=rev Log: Delete x86_64 ShadowCallStack support Summary: ShadowCallStack on x86_64 suffered from the same racy security issues as Return Flow Guard and had performa

[PATCH] D59034: Delete x86_64 ShadowCallStack support

This revision was automatically updated to reflect the committed changes. Closed by commit rCRT355624: Delete x86_64 ShadowCallStack support (authored by vlad.tsyrklevich, committed by ). Changed prior to commit: https://reviews.llvm.org/D59034?vs=189750&id=189756#toc Repository: rCRT Compil

r355625 - Fix some clang analysis tests passing arguments incorrectly

Author: rnk Date: Thu Mar 7 10:57:04 2019 New Revision: 355625 URL: http://llvm.org/viewvc/llvm-project?rev=355625&view=rev Log: Fix some clang analysis tests passing arguments incorrectly Modified: cfe/trunk/unittests/Analysis/ExprMutationAnalyzerTest.cpp Modified: cfe/trunk/unittests/Anal

[PATCH] D59103: [clang-tidy] New checker bugprone-incomplete-comparison-operator

kallehuttunen added a comment. The checker gives quite many warnings on LLVM code base. For example, running it for lib/Transforms/Scalar: /home/kalle/llvm/lib/Transforms/Scalar/GVN.cpp:119:3: warning: incomplete comparison operator [bugprone-incomplete-comparison-operator] bool operator=

[PATCH] D59103: [clang-tidy] New checker bugprone-incomplete-comparison-operator

kallehuttunen added a comment. In D59103#1421875 , @lebedev.ri wrote: > Thank you for working on this! > > This looks questionable to me. > Is this based on some coding standard? > Are there any numbers on the false-positive rate of theck? It's not bas

[PATCH] D59103: [clang-tidy] New checker bugprone-incomplete-comparison-operator

lebedev.ri added inline comments. Comment at: clang-tidy/bugprone/IncompleteComparisonOperatorCheck.cpp:242-243 +diag(Operator->getBeginLoc(), "incomplete comparison operator"); +Lhs->diagFields(*this, Operator->getBeginLoc()); +Rhs->diagFields(*this, Operator->getBeg

r355627 - Recommit "Support attribute used in member funcs of class templates"

Author: rafauler Date: Thu Mar 7 11:14:30 2019 New Revision: 355627 URL: http://llvm.org/viewvc/llvm-project?rev=355627&view=rev Log: Recommit "Support attribute used in member funcs of class templates" The patch originally broke code that was incompatible with GCC, but we want to follow GCC beh

[PATCH] D59094: [ARM] Fix bug 39982 - pcs("aapcs-vfp") is not consistent

efriedma added a comment. It looks like every call to getABIKind() is doing the wrong thing; I'm worried that's going to lead to some sort of subtle miscompile without some sort of centralized fix to compute the correct calling convention for every place that checks it. Not sure how to write a

[PATCH] D59103: [clang-tidy] New checker bugprone-incomplete-comparison-operator

MyDeveloperDay added a comment. I definately been burnt by not handling all the cases, but imagine a string class class mystring { const char *ptr; int size; int numallocated; } to compare the strings I wouldn't want to compare all the fields? I think this could lead to a lot of false

[PATCH] D59076: [coroutines][PR40978] Emit error for co_yield within catch block

modocache added inline comments. Comment at: lib/Sema/SemaCoroutine.cpp:197-200 - if (S.isUnevaluatedContext()) { -S.Diag(Loc, diag::err_coroutine_unevaluated_context) << Keyword; -return false; - } lewissbaker wrote: > Does removing this check now mean

[PATCH] D59103: [clang-tidy] New checker bugprone-incomplete-comparison-operator

JonasToth added a comment. @lebedev.ri @kallehuttunen what do you think of putting this into context of the proposal (i believe its being standardized with c++20) of `operator==() = default` and the spaceship-operator. This check could serve as a basis to modernize the `operator==` to the defaul

[PATCH] D59076: [coroutines][PR40978] Emit error for co_yield within catch block

modocache updated this revision to Diff 189763. modocache added a comment. Add test case for executing a lambda using co_yield within a catch block. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59076/new/ https://reviews.llvm.org/D59076 Files: include/clang/B

[PATCH] D59076: [coroutines][PR40978] Emit error for co_yield within catch block

modocache marked an inline comment as done. modocache added inline comments. Comment at: lib/Sema/SemaCoroutine.cpp:675 + // Second emphasis of [expr.await]p2: must be outside of an exception handler. + if (S.getCurScope()->getFlags() & Scope::CatchScope) { +S.Diag(Loc, di

[PATCH] D59103: [clang-tidy] New checker bugprone-incomplete-comparison-operator

Eugene.Zelenko added inline comments. Comment at: clang-tidy/bugprone/IncompleteComparisonOperatorCheck.cpp:197 + + const auto Ops = utils::options::parseStringList(CheckedFunctions); + Finder->addMatcher( Please don't use auto where return type is not obvious.

[PATCH] D58530: Add PragmaHandler for MSVC pragma execution_character_set

thakis added a comment. Does our serialization machinery serialize these correctly automatically? What happens if you compiler a header saying `execution_character_set_push, "utf-8")` in a header, compile that to a pch, then include that through the pch in a .c file that does pop? My guess is

  1   2   >