[PATCH] D58317: [clang] Add install targets for development headers

phosek added a comment. In D58317#1400223 , @smeenai wrote: > I'm not entirely happy with the name clang-dev-headers, and am open to > suggestions. It's unfortunate clang-headers was already taken for something > different, but renaming that target or in

r354527 - [clang] Add CMake target for installing clang's CMake exports

Author: smeenai Date: Wed Feb 20 15:16:15 2019 New Revision: 354527 URL: http://llvm.org/viewvc/llvm-project?rev=354527&view=rev Log: [clang] Add CMake target for installing clang's CMake exports This mirrors LLVM's install-cmake-exports target. Differential Revision: https://reviews.llvm.org/D5

[PATCH] D58317: [clang] Add install targets for development headers

smeenai added a comment. In D58317#1404961 , @phosek wrote: > In D58317#1400223 , @smeenai wrote: > > > I'm not entirely happy with the name clang-dev-headers, and am open to > > suggestions. It's unfortunate clang

[PATCH] D58480: [clang] Add CMake target for installing clang's CMake exports

This revision was automatically updated to reflect the committed changes. Closed by commit rL354527: [clang] Add CMake target for installing clang's CMake exports (authored by smeenai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D58365: [attributes] Add a MIG server routine attribute.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM with a minor documentation nit. Comment at: clang/include/clang/Basic/AttrDocs.td:4049 +it will be automatically applied to overrides if the method is virtual. The +attribute can be written using C++11 sy

[PATCH] D58317: [clang] Add install targets for development headers

phosek added a comment. In D58317#1404966 , @smeenai wrote: > In D58317#1404961 , @phosek wrote: > > > In D58317#1400223 , @smeenai wrote: > > > > > I'm not entirely happy wi

[PATCH] D18360: Add AIX Target/ToolChain to Clang Driver

hubert.reinterpretcast added a comment. Herald added subscribers: jdoerfert, arphaman. @apaprocki, as mentioned in our recent RFC ( http://lists.llvm.org/pipermail/llvm-dev/2019-February/130175.html ), IBM is working on AIX support for Clang and LLVM. We would like to continue the work on this

r354530 - [attributes] Add an attribute for server routines in Mach kernel and extensions.

Author: dergachev Date: Wed Feb 20 16:01:02 2019 New Revision: 354530 URL: http://llvm.org/viewvc/llvm-project?rev=354530&view=rev Log: [attributes] Add an attribute for server routines in Mach kernel and extensions. The new __attribute__ ((mig_server_routine)) is going to be used for annotating

[PATCH] D58365: [attributes] Add a MIG server routine attribute.

This revision was automatically updated to reflect the committed changes. Closed by commit rL354530: [attributes] Add an attribute for server routines in Mach kernel and extensions. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Chan

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 7PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r354531 - [attributes] Fix buildbot after r354530.

Author: dergachev Date: Wed Feb 20 16:19:24 2019 New Revision: 354531 URL: http://llvm.org/viewvc/llvm-project?rev=354531&view=rev Log: [attributes] Fix buildbot after r354530. Update the test after adding more attribute subjects. Differential Revision: https://reviews.llvm.org/D58365 Modified:

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

a_sidorin added a comment. Hi Tom, Thank for the fixes, now the patch looks almost fine. I have a small nit inline, but I think the patch can land after this fix. Comment at: lib/AST/ASTImporter.cpp:6140 +ExpectedStmt ASTNodeImporter::VisitChooseExpr(ChooseExpr *E) { + auto

[PATCH] D58478: [index-while-building] FileIndexRecord

Eugene.Zelenko added inline comments. Comment at: clang/include/clang/Index/DeclOccurrence.h:1 +//===--- DeclOccurrence.h - An occurrence of a decl within a file -===// +// Missing C++ tag. See other headers as example. Comment at: cla

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

aaron.ballman added inline comments. Comment at: lib/AST/ASTImporter.cpp:6140 +ExpectedStmt ASTNodeImporter::VisitChooseExpr(ChooseExpr *E) { + auto Imp = importSeq(E->getCond(), E->getLHS(), E->getRHS(), + E->getBuiltinLoc(), E->getRParenLoc(), E->getType(

[PATCH] D58095: [clang-tidy] Make google-objc-function-naming ignore implicit functions 🙈

This revision was automatically updated to reflect the committed changes. stephanemoore marked an inline comment as done. Closed by commit rCTE354534: [clang-tidy] Make google-objc-function-naming ignore implicit functions 🙈 (authored by stephanemoore, committed by ). Changed prior to commit: h

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

mgrang updated this revision to Diff 187695. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50488/new/ https://reviews.llvm.org/D50488 Files: docs/analyzer/checkers.rst include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

aaron.ballman added inline comments. Comment at: lib/AST/ASTImporter.cpp:6140 +ExpectedStmt ASTNodeImporter::VisitChooseExpr(ChooseExpr *E) { + auto Imp = importSeq(E->getCond(), E->getLHS(), E->getRHS(), + E->getBuiltinLoc(), E->getRParenLoc(), E->getType(

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

mgrang added a comment. In D50488#1403653 , @Szelethus wrote: > In D50488#1403197 , @mgrang wrote: > > > > It's because it invokes CodeChecker, which by default enables > > > valist.Uninitialized, but not ValistBas

RE: [clang-tools-extra] r354517 - [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer

Hi Jonas, Your commit seems to hit a compilation error on our internal build bot when built on Windows using Visual Studio 2015. Can you take a look? ExceptionAnalyzer.cpp c:\src\upstream\llvm_clean\tools\clang\tools\extra\clang-tidy\utils\ExceptionAnalyzer.h(112): error C3431: 'State': a sco

[PATCH] D58368: [analyzer] MIGChecker: Implement bug reporter visitors.

NoQ marked 3 inline comments as done. NoQ added a comment. Thx! Comment at: clang/lib/StaticAnalyzer/Checkers/MIGChecker.cpp:109 +llvm::raw_svector_ostream OS(Str); +OS << "Deallocating object passed through parameter '" << PVD->getName() + << '\''; --

[PATCH] D58306: [AArch64] Change size suffix for FP16FML intrinsics.

This revision was automatically updated to reflect the committed changes. Closed by commit rL354538: [AArch64] Change size suffix for FP16FML intrinsics. (authored by ab, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revi

r354538 - [AArch64] Change size suffix for FP16FML intrinsics.

Author: ab Date: Wed Feb 20 17:13:27 2019 New Revision: 354538 URL: http://llvm.org/viewvc/llvm-project?rev=354538&view=rev Log: [AArch64] Change size suffix for FP16FML intrinsics. These currently use _u32, but they should instead use _f16, the types of the multiplication (matching the various i

[PATCH] D58306: [AArch64] Change size suffix for FP16FML intrinsics.

ab added a comment. Thanks for checking, much appreciated! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58306/new/ https://reviews.llvm.org/D58306 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D58317: [clang] Add install targets for library headers

smeenai updated this revision to Diff 187697. smeenai added a comment. Switch to clang-library-headers pending cfe-dev discussion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58317/new/ https://reviews.llvm.org/D58317 Files: clang/CMakeLists.tx

[PATCH] D58317: [clang] Add install targets for library headers

smeenai updated this revision to Diff 187698. smeenai retitled this revision from "[clang] Add install targets for development headers" to "[clang] Add install targets for library headers". smeenai edited the summary of this revision. smeenai added a comment. Update description Repository: rG

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

mgrang added a comment. So I was able compile a couple of C++ code bases through csa-testbench. I built cppcheck and tinyxml2 without any problems. cppcheck has one invocation std::sort but the keys are not pointers whereas tinyxml2 does not use std::sort. I tried bitcoin, rtags, xerces but run

[PATCH] D56900: [Fixed Point Arithmetic] Fixed Point and Integer Conversions

leonardchan updated this revision to Diff 187706. leonardchan marked an inline comment as done. Herald added a subscriber: jdoerfert. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56900/new/ https://reviews.llvm.org/D56900 Files: clang/include/clang/AST/Operatio

[PATCH] D56900: [Fixed Point Arithmetic] Fixed Point and Integer Conversions

leonardchan added inline comments. Comment at: clang/test/Frontend/fixed_point_conversions.c:437 + // DEFAULT-NEXT: [[RES:%[a-z0-9]+]] = trunc i39 [[SATMIN]] to i16 + // DEFAULT-NEXT: store i16 [[RES]], i16* %sat_sa, align 2 + ebevhan wrote: > leonardchan wrote

[PATCH] D56900: [Fixed Point Arithmetic] Fixed Point and Integer Conversions

leonardchan marked an inline comment as done. leonardchan added inline comments. Comment at: clang/test/Frontend/fixed_point_conversions.c:437 + // DEFAULT-NEXT: [[RES:%[a-z0-9]+]] = trunc i39 [[SATMIN]] to i16 + // DEFAULT-NEXT: store i16 [[RES]], i16* %sat_sa, align 2 + -

[PATCH] D58477: [Driver] Fix float ABI default for Android ARMv8.

srhines accepted this revision. srhines added a comment. Dan, this seems pretty important for the NDK. If you submit this, would you want it cherry-picked ASAP? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58477/new/ https://reviews.llvm.org/D584

[PATCH] D58367: [analyzer] NFC: Improve upon the concept of BugReporterVisitor.

NoQ added a comment. Thx!~ In D58368#1404747 , @Charusso wrote: > This is a cool approach, but it is difficult to use this API in other > checkers. If you do not out-chain D58367 I > would like to see something like tha

[PATCH] D57523: Fix uninitialized value in ABIArgInfo

serge-sans-paille added a comment. @hans agreed; Thanks for taking the time to try to reproduce the original issue o/ Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57523/new/ https://reviews.llvm.org/D57523 ___ cfe-

[clang-tools-extra] r354545 - Attempt to fix VS2015 build breakage from r354517. NFCI.

Author: dyung Date: Wed Feb 20 20:55:31 2019 New Revision: 354545 URL: http://llvm.org/viewvc/llvm-project?rev=354545&view=rev Log: Attempt to fix VS2015 build breakage from r354517. NFCI. Modified: clang-tools-extra/trunk/clang-tidy/utils/ExceptionAnalyzer.h Modified: clang-tools-extra/trun

r354546 - [NFC] Always initialize all members in ABIArgInfo

Author: serge_sans_paille Date: Wed Feb 20 20:55:50 2019 New Revision: 354546 URL: http://llvm.org/viewvc/llvm-project?rev=354546&view=rev Log: [NFC] Always initialize all members in ABIArgInfo Differential Revision: https://reviews.llvm.org/D57523 Modified: cfe/trunk/include/clang/CodeGen/C

[PATCH] D57523: Fix uninitialized value in ABIArgInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rL354546: [NFC] Always initialize all members in ABIArgInfo (authored by serge_sans_paille, committed by ). Herald added a project: LLVM. Changed prior to commit: https://reviews.llvm.org/D57523?vs=184529

RE: [clang-tools-extra] r354517 - [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer

Hi Jonas, I've committed what I think should be a fix for the build issue in r354545. Douglas Yung -Original Message- From: cfe-commits On Behalf Of via cfe-commits Sent: Wednesday, February 20, 2019 16:57 To: jonas.t...@gmail.com Cc: cfe-commits@lists.llvm.org Subject: RE: [clang-tool

r354548 - Fix typo in r354546

Author: serge_sans_paille Date: Wed Feb 20 22:12:41 2019 New Revision: 354548 URL: http://llvm.org/viewvc/llvm-project?rev=354548&view=rev Log: Fix typo in r354546 Modified: cfe/trunk/include/clang/CodeGen/CGFunctionInfo.h Modified: cfe/trunk/include/clang/CodeGen/CGFunctionInfo.h URL: http

r354549 - Revert r354546

Author: serge_sans_paille Date: Wed Feb 20 22:59:21 2019 New Revision: 354549 URL: http://llvm.org/viewvc/llvm-project?rev=354549&view=rev Log: Revert r354546 This triggers an ICE on gcc 7, see http://lab.llvm.org:8011/builders/clang-cmake-aarch64-quick/builds/17598/steps/build%20stage%201/logs/

<    1   2