[PATCH] D57528: [tools] Fix python DeprecationWarning: invalid escape sequence

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. Herald added a project: clang. LGTM, do you have commit right? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57528/new/ https://reviews.l

[PATCH] D57951: [Lex] Allow to set missing include error to not fatal

yvvan planned changes to this revision. yvvan added a comment. It's probably not needed because I don't see a path which checked for the fatal errors in 8.0. So i will probably abandon this one or update if it does not cover the case I need. CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D28248: Work around GCC PR37804

chandlerc added a comment. Hey Marshall and Michael, As mentioned in my email to all the lists[1], patches posted to Phabricator before the new license was installed should be confirmed as under the new license before being rebased and applied. Not sure that happened here as the file headers a

[PATCH] D57532: [Index] Make sure c-index-test finds libc++ on Mac

ilya-biryukov planned changes to this revision. ilya-biryukov added a comment. Still need to figure out why the test fails and fix it before submitting the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57532/new/ https://reviews.llvm.org/D

[PATCH] D57896: Variable names rule

michaelplatings added a comment. In D57896#1390517 , @MyDeveloperDay wrote: > Should we come up with a new style? say `UpperOrLowerCamelCase`, I don't > mind going and doing that in the readability-identifier-naming check, given > that I just wrote u

[PATCH] D56370: [clangd] Add support for type hierarchy (super types only for now)

sammccall added a comment. In D56370#1391924 , @nridge wrote: > As far as reworking the tests to use these functions, I've thought about that > a bit: > > - These functions return AST nodes. It's not clear to me how I would come up > with "expected" AST

Re: [PATCH] D56370: [clangd] Add support for type hierarchy (super types only for now)

(Sorry, hit enter too soon and truncated one of the comments) On Mon, Feb 11, 2019 at 10:32 AM Sam McCall via Phabricator < revi...@reviews.llvm.org> wrote: > sammccall added a comment. > > In D56370#1391924 , @nridge > wrote: > > > As far as reworking the

[PATCH] D58029: [clangd] Make system header mappings available for PreambleParsedCallback

kadircet created this revision. kadircet added a reviewer: hokein. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Herald added a project: clang. SystemHeaderMappings were added only after takeIncludes call, which resulted in getting mapping on main file

[PATCH] D56370: [clangd] Add support for type hierarchy (super types only for now)

kadircet added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:925 +CXXRD = VD->getType().getTypePtr()->getAsCXXRecordDecl(); + } else if (const CXXMethodDecl *Method = dyn_cast(D)) { +// If this is a method, use the type of the class. nr

[PATCH] D57739: [clangd] Format tweak's replacements.

sammccall added a comment. In D57739#1390374 , @ilya-biryukov wrote: > In D57739#1390321 , @sammccall wrote: > > > It's not about stability or whether the functionality is desired, but > > layering. > > Unit test

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

pgousseau updated this revision to Diff 186201. pgousseau added a comment. Move num bits constant inside class. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57914/new/ https://reviews.llvm.org/D57914 Files: include/clang/Basic/Attr.td include/clang/Basic/Sanitizers.h include/cla

[PATCH] D54978: Move the SMT API to LLVM

Szelethus added a comment. Shouldn't that be off by default? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54978/new/ https://reviews.llvm.org/D54978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D57232: [ASTImporter] Check visibility/linkage of functions and variables

martong added a comment. Ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57232/new/ https://reviews.llvm.org/D57232 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D57943: [clangd] **Prototype**: clang-tidy-based tweaks

sammccall added a comment. This is an intriguing idea, and is at least useful to prototype new tweaks. I'm not sure whether clang-tidy is the ultimately right API to write tweaks: - it doesn't have the needed constraints to ensure prepare() is fast (e.g. it emits diagnostics and fixes eagerly)

[PATCH] D57236: [ASTImporter] Unify redecl chain tests as type parameterized tests

martong added a comment. Ping. Please raise your objections if you have any until the 18th of February (that date I am going to commit if there are no objections). Also, please let me know if you find this deadline too strict. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews

r353684 - [ASTImporter] Add test RedeclChainShouldBeCorrectAmongstNamespaces

Author: martong Date: Mon Feb 11 02:27:58 2019 New Revision: 353684 URL: http://llvm.org/viewvc/llvm-project?rev=353684&view=rev Log: [ASTImporter] Add test RedeclChainShouldBeCorrectAmongstNamespaces Summary: We add a new test to show that redecl chains are not handled properly amongst namespace

[PATCH] D57901: [ASTImporter] Add test RedeclChainShouldBeCorrectAmongstNamespaces

This revision was automatically updated to reflect the committed changes. Closed by commit rL353684: [ASTImporter] Add test RedeclChainShouldBeCorrectAmongstNamespaces (authored by martong, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LL

[clang-tools-extra] r353687 - [clangd] Make system header mappings available for PreambleParsedCallback

Author: kadircet Date: Mon Feb 11 02:31:13 2019 New Revision: 353687 URL: http://llvm.org/viewvc/llvm-project?rev=353687&view=rev Log: [clangd] Make system header mappings available for PreambleParsedCallback Summary: SystemHeaderMappings were added only after takeIncludes call, which resulted in

[PATCH] D58029: [clangd] Make system header mappings available for PreambleParsedCallback

This revision was automatically updated to reflect the committed changes. Closed by commit rL353687: [clangd] Make system header mappings available for PreambleParsedCallback (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository:

[PATCH] D57579: [analyzer][WIP] Enable subcheckers to possess checker options

xazax.hun accepted this revision. xazax.hun added a comment. LGTM! But having a lit test that fails before and passes after would be great. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57579/new/ https://reviews.llvm.org/D57579 ___

[PATCH] D57739: [clangd] Format tweak's replacements.

hokein added a comment. In D57739#1392453 , @sammccall wrote: > In D57739#1390374 , @ilya-biryukov > wrote: > > > In D57739#1390321 , @sammccall > > wrote: > > > > > It's n

[PATCH] D57662: [clang-tidy] Parallelise clang-tidy-diff.py

MyDeveloperDay added a comment. Just a question.. If clang tidy is running with -fix in parallel, what stops each clang-tidy invocation altering a common header at the same time? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57662/new/ https://reviews.llvm.org/D57662 ___

r353690 - [libclang] Add attribute support for 'convergent'.

Author: svenvh Date: Mon Feb 11 03:00:56 2019 New Revision: 353690 URL: http://llvm.org/viewvc/llvm-project?rev=353690&view=rev Log: [libclang] Add attribute support for 'convergent'. This bumps CINDEX_VERSION_MINOR up (to 51). Patch by Hsin-Hsiao Lin. Differential Revision: https://reviews.llv

[PATCH] D57662: [clang-tidy] Parallelise clang-tidy-diff.py

zinovy.nis added a comment. In D57662#1392509 , @MyDeveloperDay wrote: > Just a question.. If clang tidy is running with -fix in parallel, what stops > each clang-tidy invocation altering a common header at the same time? You are right. May be it worth

[PATCH] D57946: [libclang] Add attribute support for 'convergent'.

This revision was automatically updated to reflect the committed changes. Closed by commit rC353690: [libclang] Add attribute support for 'convergent'. (authored by svenvh, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57946/new/ https://reviews.ll

[PATCH] D55562: Atomics: support min/max orthogonally

algrant added a comment. Herald added a project: clang. Some targets (e.g. AArch64) support 8-bit, 16-bit and 64-bit atomics. max/min in Clang 7.0 only supported 32-bit max/min, even though the other atomics supported multiple widths. Is the intention here to support all (four) offered widths,

[PATCH] D57896: Variable names rule

MyDeveloperDay added a comment. > Sounds good to me. I see that you've made D57966 > a child of this issue, but we could swap > the dependency around so that once your patch is applied I can update this > patch to use `camelBackOrCase`. I'm OK if we want to do

[PATCH] D57265: [PM/CC1] Add -f[no-]split-cold-code CC1 options to toggle splitting

philip.pfaffe added a comment. I'd prefer not adding this kind of state to PassBuilder. `SplitColdCode` is soemthing that refers to the construction of //one// particular pipeline, not to pipeline-building in general. It should be an argument passed down through the build*Pipeline calls. CHAN

[PATCH] D57855: [analyzer] Reimplement checker options

xazax.hun added a comment. We have `examples/analyzer-plugin`. I would prefer to add an example option to the example plugin so people do see how to do this when they are registering a checker from a plugin. Comment at: include/clang/StaticAnalyzer/Checkers/Checkers.td:48 +

[PATCH] D57922: [analyzer] Insert checker options into AnalyzerOption::ConfigTable

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LG! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57922/new/ https://reviews.llvm.org/D57922 ___ cfe-commi

[PATCH] D57890: [analyzer] Fix in self assignment checker

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LG! Just wanted to make sure I get it right. You did not add a test since it is only reproducible with an internal (non-upstreamed) checker. Since the change is trivial, I think it is o

[PATCH] D57662: [clang-tidy] Parallelise clang-tidy-diff.py

MyDeveloperDay added a comment. > You are right. May be it worth disabling `-fix` for `j != 1`. I only say this because I think I might have seen it happen when I was running `run-clang-tidy.py` over a large code base with a fairly aggressive check/fixit, but frankly I was too new to LLVM to kn

[PATCH] D57662: [clang-tidy] Parallelise clang-tidy-diff.py

zinovy.nis added a comment. > I only say this because I think I might have seen it happen when I was > running `run-clang-tidy.py` over a large code base with a fairly aggressive > check/fixit, but frankly I was too new to LLVM to know it wasn't something I > might have done wrong. A bit stran

[PATCH] D58037: [clangd] Prefer location from codegen files when merging symbols.

ioeric created this revision. ioeric added a reviewer: sammccall. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. For example, if an index symbol has location in a .proto file and an AST symbol has location in a generated

[clang-tools-extra] r353694 - [clangd] Fix broken windows build bots.

Author: kadircet Date: Mon Feb 11 05:01:47 2019 New Revision: 353694 URL: http://llvm.org/viewvc/llvm-project?rev=353694&view=rev Log: [clangd] Fix broken windows build bots. Modified: clang-tools-extra/trunk/unittests/clangd/FileIndexTests.cpp Modified: clang-tools-extra/trunk/unittests/cla

[PATCH] D57949: [clang][Index] Add a knob to index function parameters in declarations

This revision was automatically updated to reflect the committed changes. Closed by commit rL353695: [clang][Index] Add a knob to index function parameters in declarations (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: r

r353695 - [clang][Index] Add a knob to index function parameters in declarations

Author: kadircet Date: Mon Feb 11 05:02:21 2019 New Revision: 353695 URL: http://llvm.org/viewvc/llvm-project?rev=353695&view=rev Log: [clang][Index] Add a knob to index function parameters in declarations Summary: Parameters in declarations are useful for clangd, so that we can provide symbol in

[PATCH] D57950: [clangd] Index parameters in function decls

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE353696: [clangd] Index parameters in function decls (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D57950?vs=185967&id=186235#toc Repository: rCTE Clang To

[clang-tools-extra] r353696 - [clangd] Index parameters in function decls

Author: kadircet Date: Mon Feb 11 05:03:08 2019 New Revision: 353696 URL: http://llvm.org/viewvc/llvm-project?rev=353696&view=rev Log: [clangd] Index parameters in function decls Reviewers: hokein Subscribers: ilya-biryukov, ioeric, MaskRay, jkorous, arphaman, cfe-commits Tags: #clang Differen

[PATCH] D17444: PR26672: [MSVC] Clang does not recognize "static_assert" keyword in C mode

thakis added a comment. I just ran into this and I'm a bit confused about the discussion here. This snippet (in a .c file) #include static_assert(4 == 4 , ""); builds in all compilers except clang-cl. How does not supporting this make sense? Instead of this patch we could have an asse

[PATCH] D57855: [analyzer] Reimplement checker options

Szelethus marked an inline comment as done. Szelethus added a comment. In D57855#1392560 , @xazax.hun wrote: > We have `examples/analyzer-plugin`. I would prefer to add an example option > to the example plugin so people do see how to do this when they ar

[PATCH] D57906: [CTU] Do not allow different CPP dialects in CTU

martong added a comment. > How is #if __cplusplus >= 201103L qualitatively different from #ifndef NDEBUG > or #if MYLIB_ABI_VERSION==2 or #if __DATE__ == "2018-04-01"? Ideally, all macros should be the same in the two TUs... If we were very strict then we could check for that, but that might be

[PATCH] D57984: PR40642: Fix determination of whether the final statement of a statementexpression is a discarded-value expression.

aaron.ballman added a comment. Thank you for working on this! It looks like we did have to add the new AST node after all, but the changes seem pretty good. Should anything be updated in the AST dumper for this (such as printing whether a Stmt is a value-producing statement or not)?

[PATCH] D45978: dllexport const variables must have external linkage.

aaron.ballman added a comment. It looks like the patch got mucked up somehow, I only see three testing files in the patch now? Comment at: test/Sema/dllexport.c:168 + +// CHECK: @y = common dso_local dllexport global i32 0, align 4 + Nothing runs FileCheck in

r353697 - Format isInSystemMacro after D55782

Author: maskray Date: Mon Feb 11 05:30:04 2019 New Revision: 353697 URL: http://llvm.org/viewvc/llvm-project?rev=353697&view=rev Log: Format isInSystemMacro after D55782 Modified: cfe/trunk/include/clang/Basic/SourceManager.h Modified: cfe/trunk/include/clang/Basic/SourceManager.h URL: http

[PATCH] D58037: [clangd] Prefer location from codegen files when merging symbols.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clangd/XRefs.cpp:261 } +// Returns the preferred location between an AST location and an index location. +SymbolLocation getPreferredLocation(const Lo

[PATCH] D57948: [Sema] Fix a regression introduced in "[AST][Sema] Remove CallExpr::setNumArgs"

aaron.ballman added inline comments. Comment at: lib/AST/Expr.cpp:1272-1274 + for (unsigned I = NumArgs; I != NumArgsAllocated; ++I) { +TrailingArgs[I] = nullptr; } Could use `std::fill()` here to remove the for-loop. Your call whether that looks cleaner

[PATCH] D58051: Revert "[clangd] Format tweak's replacements."

hokein created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Herald added a project: clang. This reverts commit r353306. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D58051 Files: clangd/ClangdServer.cpp

[PATCH] D58051: Revert "[clangd] Format tweak's replacements."

hokein updated this revision to Diff 186239. hokein added a comment. - [clangd] Re-submit format replacement for tweaks. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58051/new/ https://reviews.llvm.org/D58051 Files: clangd/ClangdServer.cpp cla

r353698 - [analyzer] New checker for detecting usages of unsafe I/O functions

Author: szelethus Date: Mon Feb 11 05:46:43 2019 New Revision: 353698 URL: http://llvm.org/viewvc/llvm-project?rev=353698&view=rev Log: [analyzer] New checker for detecting usages of unsafe I/O functions There are certain unsafe or deprecated (since C11) buffer handling functions which should be

[PATCH] D57918: Add an attribute that causes clang to emit fortified calls to C stdlib functions

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:987-989 +The first argument to the attribute is the type passed to +`__builtin_object_size`, and the second is the flag that the fortified format +functions accept. Maybe I'm b

[PATCH] D35068: [analyzer] Detect usages of unsafe I/O functions

This revision was automatically updated to reflect the committed changes. Closed by commit rL353698: [analyzer] New checker for detecting usages of unsafe I/O functions (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D33841: [clang-tidy] redundant keyword check

aaron.ballman added inline comments. Comment at: docs/clang-tidy/checks/readability-redundant-extern.rst:4 +readability-redundant-extern += + The underlining here is too long. Comment at: docs/clang-tidy/checks/reada

[PATCH] D58037: [clangd] Prefer location from codegen files when merging symbols.

ioeric updated this revision to Diff 186245. ioeric marked 3 inline comments as done. ioeric added a comment. - Address review comments. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58037/new/ https://reviews.llvm.org/D58037 Files: clangd/XRefs.

[PATCH] D58051: Revamp the "[clangd] Format tweak's replacements"

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Comment at: clangd/ClangdServer.cpp:382 +auto Style = getFormatStyleForFile(File, InpAST->Inputs.Contents, + FSPr

r353705 - Make some helper functions static. NFC.

Author: d0k Date: Mon Feb 11 06:52:15 2019 New Revision: 353705 URL: http://llvm.org/viewvc/llvm-project?rev=353705&view=rev Log: Make some helper functions static. NFC. Modified: cfe/trunk/lib/Sema/SemaCodeComplete.cpp cfe/trunk/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCount

[PATCH] D57528: [tools] Fix python DeprecationWarning: invalid escape sequence

MarcoFalke added a comment. No, I don't have commit right Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57528/new/ https://reviews.llvm.org/D57528 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D58051: Revamp the "[clangd] Format tweak's replacements"

hokein updated this revision to Diff 186246. hokein added a comment. Address review comment. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58051/new/ https://reviews.llvm.org/D58051 Files: clangd/ClangdServer.cpp clangd/ClangdUnit.cpp clangd/

r353707 - [tools] Fix python DeprecationWarning: invalid escape sequence

Author: serge_sans_paille Date: Mon Feb 11 07:03:17 2019 New Revision: 353707 URL: http://llvm.org/viewvc/llvm-project?rev=353707&view=rev Log: [tools] Fix python DeprecationWarning: invalid escape sequence The python documentation says "it’s highly recommended that you use raw strings for all b

[PATCH] D57528: [tools] Fix python DeprecationWarning: invalid escape sequence

This revision was automatically updated to reflect the committed changes. Closed by commit rL353707: [tools] Fix python DeprecationWarning: invalid escape sequence (authored by serge_sans_paille, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[clang-tools-extra] r353708 - [clangd] Prefer location from codegen files when merging symbols.

Author: ioeric Date: Mon Feb 11 07:05:29 2019 New Revision: 353708 URL: http://llvm.org/viewvc/llvm-project?rev=353708&view=rev Log: [clangd] Prefer location from codegen files when merging symbols. Summary: For example, if an index symbol has location in a .proto file and an AST symbol has locat

[PATCH] D57528: [tools] Fix python DeprecationWarning: invalid escape sequence

serge-sans-paille added a comment. @MarcoFalke it's in, thanks for the patch o/ Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57528/new/ https://reviews.llvm.org/D57528 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D58037: [clangd] Prefer location from codegen files when merging symbols.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE353708: [clangd] Prefer location from codegen files when merging symbols. (authored by ioeric, committed by ). Changed prior to commit: https://reviews.llvm.org/D58037?vs=186245&id=186251#toc Reposit

[PATCH] D57768: [SYCL] Add SYCL device compilation flow.

bader added a comment. In D57768#1386941 , @ABataev wrote: > In D57768#1386933 , @bader wrote: > > > In D57768#1386924 , @ABataev wrote: > > > > > This definitely requires a

r353711 - Fixed header underline in docs.

Author: alexfh Date: Mon Feb 11 07:17:13 2019 New Revision: 353711 URL: http://llvm.org/viewvc/llvm-project?rev=353711&view=rev Log: Fixed header underline in docs. + Removed trailing whitespace. Modified: cfe/trunk/docs/analyzer/checkers.rst Modified: cfe/trunk/docs/analyzer/checkers.rst U

[PATCH] D58051: Revamp the "[clangd] Format tweak's replacements"

This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rCTE353712: Revamp the "[clangd] Format tweak's replacements" (authored by hokein, committed by ). Changed prior to commit: https://reviews.llvm.org/D58051?vs=1862

[clang-tools-extra] r353712 - Revamp the "[clangd] Format tweak's replacements"

Author: hokein Date: Mon Feb 11 07:18:11 2019 New Revision: 353712 URL: http://llvm.org/viewvc/llvm-project?rev=353712&view=rev Log: Revamp the "[clangd] Format tweak's replacements" Summary: This patch contains two parts: 1) reverts commit r353306. 2) move the format logic out from tweaks, keep

[PATCH] D57943: [clangd] **Prototype**: clang-tidy-based tweaks

hokein added a comment. > This is an intriguing idea, and is at least useful to prototype new tweaks. > > I'm not sure whether clang-tidy is the ultimately right API to write tweaks: > > it doesn't have the needed constraints to ensure prepare() is fast (e.g. it > emits diagnostics and fixes ea

[PATCH] D57943: [clangd] **Prototype**: clang-tidy-based tweaks

hokein updated this revision to Diff 186261. hokein marked 5 inline comments as done. hokein added a comment. Update the comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57943/new/ https://reviews.llvm.org/D57943 Files: clangd/refactor/twea

[PATCH] D54978: Move the SMT API to LLVM

brzycki added a comment. > @brzycki, I can't reproduce your error. Maybe you're missing > `-DLLVM_ENABLE_Z3_SOLVER=OFF`? Hello @mikhail.ramalho, here are my exact reproduction steps. I just verified them about 5 minutes ago. # Setup Ubuntu's Z3 lsb_release -a No LSB modules are available

[PATCH] D57768: [SYCL] Add SYCL device compilation flow.

ABataev added a comment. In D57768#1392975 , @bader wrote: > In D57768#1386941 , @ABataev wrote: > > > In D57768#1386933 , @bader wrote: > > > > > In D57768#1386924

r353718 - Make test actually test something (colons were missing)

Author: nico Date: Mon Feb 11 08:37:02 2019 New Revision: 353718 URL: http://llvm.org/viewvc/llvm-project?rev=353718&view=rev Log: Make test actually test something (colons were missing) Modified: cfe/trunk/test/CodeGen/ms-x86-intrinsics.c Modified: cfe/trunk/test/CodeGen/ms-x86-intrinsics.c

Re: r353718 - Make test actually test something (colons were missing)

On Mon, Feb 11, 2019 at 11:36 AM Nico Weber via cfe-commits wrote: > > Author: nico > Date: Mon Feb 11 08:37:02 2019 > New Revision: 353718 > > URL: http://llvm.org/viewvc/llvm-project?rev=353718&view=rev > Log: > Make test actually test something (colons were missing) Good catch! I wonder if we

[PATCH] D38606: [CodeGen] Emit a helper function for __builtin_os_log_format to reduce code size

thakis added inline comments. Herald added subscribers: llvm-commits, jkorous. Herald added a project: LLVM. Comment at: cfe/trunk/test/CodeGenObjC/os_log.m:53 + // CHECK-O0: %[[V5:.*]] = bitcast %[[V0]]* %[[V3]] to i8* + // CHECK-O0-NOT call void (...) @clang.arc.use({{.*}} +

[PATCH] D58056: Look through typedefs in getFunctionTypeWithExceptionSpec

sberg created this revision. sberg added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://bugs.llvm.org/show_bug.cgi?id=40658 Repository: rC Clang https://reviews.llvm.org/D58056 Files: clang/lib/AST/ASTContext.cpp clang/test/AST/fu

Re: r331745 - [C++2a] Implement operator<=>: Fix another bug in the code gen tests.

On Tue, May 8, 2018 at 3:59 AM Eric Fiselier via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ericwf > Date: Tue May 8 00:56:05 2018 > New Revision: 331745 > > URL: http://llvm.org/viewvc/llvm-project?rev=331745&view=rev > Log: > [C++2a] Implement operator<=>: Fix another bug in the

[PATCH] D58057: Allow bundle size to be 0 in clang-offload-bundler

yaxunl created this revision. yaxunl added a reviewer: rjmccall. HIP uses clang-offload-bundler to create fat binary. The bundle for host is empty. Currently clang-offload-bundler checks if the bundle size is 0 when unbundling. If so it will exit without unbundling the remaining bundles. This cau

[PATCH] D58056: Look through typedefs in getFunctionTypeWithExceptionSpec

sberg added a comment. The change itself should probably be uncontroversial (the bad cast had been there ever since getFunctionTypeWithExceptionSpec had been introduced with r221918), but I'm not sure about the test: It tests the relevant code somewhat indirectly; is it fine in clang/test/AST/?

Re: r353718 - Make test actually test something (colons were missing)

On Mon, Feb 11, 2019 at 7:38 PM Aaron Ballman via cfe-commits wrote: > > On Mon, Feb 11, 2019 at 11:36 AM Nico Weber via cfe-commits > wrote: > > > > Author: nico > > Date: Mon Feb 11 08:37:02 2019 > > New Revision: 353718 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=353718&view=rev > > L

[PATCH] D57736: [WebAssembly] Bulk memory intrinsics and builtins

aheejin added inline comments. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:29 +// Bulk memory builtins +TARGET_BUILTIN(__builtin_wasm_memory_init, "vIiv*ii", "", "bulk-memory") +TARGET_BUILTI

[PATCH] D58060: Fix diagnostic for addr spaces in static_cast

Anastasia created this revision. Anastasia added a reviewer: rjmccall. Herald added a subscriber: ebevhan. When we diagnose `static_cast` we should prevent accidental address space conversions unless the conversion is safe (i.e. converting to an address space that is a super set is safe!). Some

[PATCH] D58061: Fix a few tests that were missing ':' on CHECK lines and weren't testing anything.

thakis created this revision. thakis added a reviewer: rjmccall. Herald added subscribers: kristof.beyls, javed.absar. Found by `git grep '\/\/ CHECK-[^: ]* ' clang/test/ | grep -v RUN:`. Also tweak CodeGenCXX/arm-swiftcall.cpp to still pass now that it checks more. https://reviews.llvm.org/D58

[PATCH] D45978: dllexport const variables must have external linkage.

zahiraam added a comment. In D45978#1392855 , @aaron.ballman wrote: > It looks like the patch got mucked up somehow, I only see three testing files > in the patch now? Oops! Sorry about that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D4597

[PATCH] D45978: dllexport const variables must have external linkage.

zahiraam updated this revision to Diff 186275. Herald added a subscriber: mstorsjo. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D45978/new/ https://reviews.llvm.org/D45978 Files: lib/Sema/SemaDecl.cpp test/Sema/dllexport-1.c test/Sema/dllexport-1.cpp test/Sema/dllexport-2.cpp

[PATCH] D58062: Support framework import/include auto-completion

dgoldman created this revision. dgoldman added a reviewer: sammccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. Frameworks filesystem representations: UIKit.framework/Headers/%header% Framework import format: #import Thus the completion code must map the input

[PATCH] D57230: [analyzer] Toning down invalidation a bit

xazax.hun added a comment. I think I might have a theory, but I would like to discuss it as I am not familiar with the internals bindings. My theory is the following: when we store the bindings, we store them in a map where the key is a base region. So when we try to look the bindings up wit

Re: r353718 - Make test actually test something (colons were missing)

On Mon, Feb 11, 2019 at 11:38 AM Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Mon, Feb 11, 2019 at 11:36 AM Nico Weber via cfe-commits > wrote: > > > > Author: nico > > Date: Mon Feb 11 08:37:02 2019 > > New Revision: 353718 > > > > URL: http://llvm.org/viewvc/llvm-proj

r353725 - Attempt to pacify bots after r353718

Author: nico Date: Mon Feb 11 09:30:25 2019 New Revision: 353725 URL: http://llvm.org/viewvc/llvm-project?rev=353725&view=rev Log: Attempt to pacify bots after r353718 Modified: cfe/trunk/test/CodeGen/ms-x86-intrinsics.c Modified: cfe/trunk/test/CodeGen/ms-x86-intrinsics.c URL: http://llvm.

[PATCH] D56871: [AMDGPU] Require at least protected visibility for certain symbols

scott.linder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56871/new/ https://reviews.llvm.org/D56871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r353729 - Attempt to pacify bots more after r353718 and r353725

Author: nico Date: Mon Feb 11 10:01:27 2019 New Revision: 353729 URL: http://llvm.org/viewvc/llvm-project?rev=353729&view=rev Log: Attempt to pacify bots more after r353718 and r353725 Modified: cfe/trunk/test/CodeGen/ms-x86-intrinsics.c Modified: cfe/trunk/test/CodeGen/ms-x86-intrinsics.c U

[PATCH] D45978: dllexport const variables must have external linkage.

aaron.ballman added inline comments. Comment at: test/Sema/dllexport-1.c:1-4 +// RUN: %clang_cc1 -triple i686-win32 -emit-llvm -fms-extensions -std=c99 < %s| FileCheck %s +// RUN: %clang_cc1 -triple x86_64-win32 -emit-llvm -fms-extensions -std=c11 < %s | FileCheck %s +// RUN: %

[PATCH] D58062: Support framework import/include auto-completion

sammccall added inline comments. Comment at: lib/Sema/SemaCodeComplete.cpp:8375 + auto AddFilesFromIncludeDir = [&](StringRef IncludeDir, bool IsSystem, +bool isFramework) { +bool stripFrameworkSuffix = false; nit: `IsFram

[PATCH] D58065: [analyzer] Document the frontend library

Szelethus created this revision. Szelethus added reviewers: NoQ, george.karpenkov, xazax.hun, dkrupp, rnkovacs, a.sidorin, aaron.ballman. Herald added subscribers: cfe-commits, gamesh411, donat.nagy, mikhail.ramalho, szepet, baloghadamsoftware, whisperity. Herald added a project: clang. Since I'

[PATCH] D56871: [AMDGPU] Require at least protected visibility for certain symbols

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56871/new/ https://reviews.llvm.org/D56871 ___ cfe-commits mailing list cfe-

[PATCH] D17444: PR26672: [MSVC] Clang does not recognize "static_assert" keyword in C mode

rnk added a comment. In D17444#1392823 , @thakis wrote: > Instead of this patch we could have an assert.h wrapper in lib/Headers that > defines static_assert to _Static_assert in ms mode for C files, and I suppose > that's a cleaner fix. But I hope it's

[PATCH] D58016: fixes copy constructor generation of classes containing 0-length arrays followed by exactly 1 trivial field (fixes #40682)

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Ah, thanks, seems like a reasonable fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58016/new/ https://reviews.llvm.org/D58016 ___

[PATCH] D57991: [Driver][Darwin] Emit an error when using -pg on OS without support for it.

steven_wu accepted this revision. steven_wu added a comment. This revision is now accepted and ready to land. LGTM with a suggestion to make code cleaner. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:101 + "the clang compiler does not support -pg option on Da

[PATCH] D58016: fixes copy constructor generation of classes containing 0-length arrays followed by exactly 1 trivial field (fixes #40682)

jbigalet added a comment. Thanks! I don't have commit rights btw Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58016/new/ https://reviews.llvm.org/D58016 ___ cfe-commits mailing list cfe-commits@lists.

RE: r353718 - Make test actually test something (colons were missing)

I thin the Best Fix is probably to make FileCheck diag if a line starts with (after a few whitelisted comment chars like // and #) a check-prefix but then isn't followed by : (maybe after -NOT, -SAME, -LABEL etc). FileCheck doesn't explicitly pass over leading comment characters, it just patter

[PATCH] D57918: Add an attribute that causes clang to emit fortified calls to C stdlib functions

erik.pilkington marked an inline comment as done. erik.pilkington added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:987-989 +The first argument to the attribute is the type passed to +`__builtin_object_size`, and the second is the flag that the fortified fo

  1   2   >