[PATCH] D57766: [opaque pointer types] Cleanup CGBuilder's Create*GEP.

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Cool :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57766/new/ https://reviews.llvm.org/D57766

[PATCH] D55659: [Sema][ObjC] Disallow non-trivial C struct fields in unions

ahatanak planned changes to this revision. ahatanak added a comment. This patch is unnecessarily complicated and is not correct. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55659/new/ https://reviews.llvm.org/D55659 __

[PATCH] D57767: [opaque pointer types] Cleanup CGBuilder's Create*GEP.

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Great! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57767/new/ https://reviews.llvm.org/D57767 _

[PATCH] D57795: [RISCV] Add FreeBSD targets

jrtc27 created this revision. jrtc27 added a reviewer: asb. Herald added subscribers: cfe-commits, rkruppe, rogfer01, shiva0217, kito-cheng, emaste. Herald added a project: clang. Repository: rC Clang https://reviews.llvm.org/D57795 Files: lib/Basic/Targets.cpp lib/Driver/ToolChains/FreeB

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

rsmith added inline comments. Comment at: lib/AST/Stmt.cpp:457-458 + this->NumLabels = NumLabels; + assert((NumLabels != 0 && NumOutputs == 0) || + (NumOutputs != 0 && NumLabels == 0)); This can be simplified a little: ``` assert(!(NumOutputs && NumLa

[PATCH] D57797: Variable auto-init: fix __block initialization

jfb created this revision. jfb added reviewers: rjmccall, pcc, kcc. Herald added subscribers: cfe-commits, dexonsmith, jkorous. Herald added a project: clang. Automatic initialization [1] of __block variables was happening too late, which caused self-init usage to crash, such as here: typedef str

[PATCH] D57798: [WebAssembly] Add atomics target option

aheejin created this revision. aheejin added a reviewer: tlively. Herald added subscribers: cfe-commits, jfb, sunfish, jgravelle-google, sbc100, dschuff. Herald added a project: clang. Repository: rC Clang https://reviews.llvm.org/D57798 Files: include/clang/Driver/Options.td lib/Basic/Ta

[PATCH] D57798: [WebAssembly] Add atomics target option

tlively added inline comments. Comment at: lib/Basic/Targets/WebAssembly.cpp:172 +} +if (Feature == "0atomics") { + HasAtomics = false; -atomics Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57798/new/ https://revie

[PATCH] D57798: [WebAssembly] Add atomics target option

aheejin updated this revision to Diff 185454. aheejin added a comment. - Fix typo Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57798/new/ https://reviews.llvm.org/D57798 Files: include/clang/Driver/Options.td lib/Basic/Targets/WebAssembly.cpp lib/Basic/Ta

[PATCH] D57798: [WebAssembly] Add atomics target option

tlively accepted this revision. tlively added a comment. This revision is now accepted and ready to land. LGTM Comment at: lib/Basic/Targets/WebAssembly.cpp:172 +} +if (Feature == "0atomics") { + HasAtomics = false; tlively wrote: > -atomics You wo

r353260 - [WebAssembly] Add atomics target option

Author: aheejin Date: Tue Feb 5 17:41:26 2019 New Revision: 353260 URL: http://llvm.org/viewvc/llvm-project?rev=353260&view=rev Log: [WebAssembly] Add atomics target option Reviewers: tlively Subscribers: dschuff, sbc100, jgravelle-google, sunfish, jfb, cfe-commits Tags: #clang Differential R

[PATCH] D57798: [WebAssembly] Add atomics target option

This revision was automatically updated to reflect the committed changes. Closed by commit rL353260: [WebAssembly] Add atomics target option (authored by aheejin, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTIO

[PATCH] D57798: [WebAssembly] Add atomics target option

sbc100 added a comment. How does this relate to the existing ` -mattr=+atomics` of llc? Will it also result in `attributes #0 = { "target-features"="+atomics" }` in the bitcode? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57798/new/ https://reviews.llvm.org/D

[PATCH] D57801: [opaque pointer types] Pass through function types for TLS initialization and global destructor calls.

jyknight created this revision. jyknight added a reviewer: dblaikie. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D57801 Files: clang/lib/CodeGen/CGCXX.cpp clang/lib/CodeGen/CGCXXABI.h clang/lib/CodeGe

[PATCH] D57798: [WebAssembly] Add atomics target option

aheejin added a comment. In D57798#1386470 , @sbc100 wrote: > How does this relate to the existing ` -mattr=+atomics` of llc? Will it also > result in `attributes #0 = { "target-features"="+atomics" }` in the bitcode? Yes Repository: rL LLVM CHAN

[PATCH] D55659: [Sema][ObjC] Disallow non-trivial C struct fields in unions

ahatanak updated this revision to Diff 185466. ahatanak added a comment. Make sure that volatile trivial fields in a struct don't cause Sema to emit a diagnostic. Simplify the code in `Sema::ActOnFields` . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55659/new/

[PATCH] D57804: [opaque pointer types] Make EmitCall pass Function Types to CreateCall/Invoke.

jyknight created this revision. jyknight added a reviewer: dblaikie. Herald added a project: clang. Herald added a subscriber: cfe-commits. Also, remove the getFunctionType() function from CGCallee, since it accesses the pointee type of the value. The only use was in EmitCall, so just inline it in

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

jyu2 updated this revision to Diff 185477. jyu2 marked 4 inline comments as done. jyu2 added a comment. More change from review. Add scope checking for asm-goto. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56571/new/ https://reviews.llvm.org/D56571 Files: include/clang/AST/Stmt.h

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

jyu2 added inline comments. Comment at: lib/AST/Stmt.cpp:457-458 + this->NumLabels = NumLabels; + assert((NumLabels != 0 && NumOutputs == 0) || + (NumOutputs != 0 && NumLabels == 0)); rsmith wrote: > This can be simplified a little: > ``` > assert(!(N

r353268 - [CMake] Unify scripts for generating VCS headers

Author: phosek Date: Tue Feb 5 19:51:00 2019 New Revision: 353268 URL: http://llvm.org/viewvc/llvm-project?rev=353268&view=rev Log: [CMake] Unify scripts for generating VCS headers Previously, there were two different scripts for generating VCS headers: one used by LLVM and one used by Clang and

[PATCH] D57063: [CMake] Unify scripts for generating VCS headers

This revision was automatically updated to reflect the committed changes. Closed by commit rC353268: [CMake] Unify scripts for generating VCS headers (authored by phosek, committed by ). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://revi

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

jhibbits updated this revision to Diff 185487. jhibbits added a comment. Herald added a project: clang. Add feedback from @vit9696, and VAARG fix from @kthomsen. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49754/new/ https://reviews.llvm.org/D49754 Files: in

[PATCH] D57797: Variable auto-init: fix __block initialization

rjmccall added inline comments. Comment at: lib/CodeGen/CGDecl.cpp:1611 drillIntoBlockVariable(*this, Dst, &D); +} defaultInitNonTrivialCStructVar(Dst); Why don't you just initialize the payload right here, after we've drilled down to it? =

[PATCH] D57797: Variable auto-init: fix __block initialization

rjmccall added inline comments. Comment at: lib/CodeGen/CGDecl.cpp:1611 drillIntoBlockVariable(*this, Dst, &D); +} defaultInitNonTrivialCStructVar(Dst); rjmccall wrote: > Why don't you just initialize the payload right here, after we've drilled >

Re: r352930 - [WebAssembly] Add an import_field function attribute

On Tue, Feb 5, 2019 at 11:20 AM Aaron Ballman wrote: > On Fri, Feb 1, 2019 at 8:27 PM Dan Gohman wrote: > > > > > > Indeed, and the existing import_module attribute needs these tests as > well. I'll write some and add them in a follow-up patch. > > > > Thanks for the review! > > Any time! I hav

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

jyu2 updated this revision to Diff 185489. jyu2 added a comment. small fix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56571/new/ https://reviews.llvm.org/D56571 Files: include/clang/AST/Stmt.h include/clang/Basic/DiagnosticASTKinds.td include/clang/Basic/DiagnosticParseKinds.

[PATCH] D57464: Generalize method overloading on addr spaces to C++

rjmccall added a comment. Moving parsed attributes between lists isn't unreasonable if that's what you have to do; we already do that when processing the ObjC ARC qualifiers. The ambiguity with function attributes is pretty much inherent. Alternatively, you shouldn't feel like you can't impose

[PATCH] D57746: [clangd] Add CLI flag "-clang-tidy" to enable/disable running clang-tidy checks.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clangd/tool/ClangdMain.cpp:214 +llvm::cl::desc("Enable clang-tidy diagnostics."), +llvm::cl::init(true)); + I thought we discus

[PATCH] D57787: [clang-tidy] modernize-avoid-c-arrays: avoid main function (PR40604)

JonasToth added inline comments. Comment at: clang-tidy/modernize/AvoidCArraysCheck.cpp:35 + const clang::DeclContext *DC = Node.getDeclContext(); + const clang::FunctionDecl *FD = llvm::dyn_cast(DC); + if (!FD) There is `FunctionDecl->castToDeclContext()` whi

[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

shiva0217 updated this revision to Diff 185491. shiva0217 added a comment. 1. Remove passing path for LTO because Eli raised the concern that whether it would appropriate to assign the same limitation for all files when LTO enabled. 2. Add -msmall-data-limitation= as James pointed out it's the ma

[PATCH] D57787: [clang-tidy] modernize-avoid-c-arrays: avoid main function (PR40604)

lebedev.ri added inline comments. Comment at: test/clang-tidy/modernize-avoid-c-arrays.cpp:90 + +int not_main(int argc, char *argv[]) { + // CHECK-MESSAGES: :[[@LINE-1]]:24: warning: do not declare C-style arrays, use std::array<> instead JonasToth wrote: > `ma

[PATCH] D57787: [clang-tidy] modernize-avoid-c-arrays: avoid main function (PR40604)

lebedev.ri added inline comments. Comment at: clang-tidy/modernize/AvoidCArraysCheck.cpp:35 + const clang::DeclContext *DC = Node.getDeclContext(); + const clang::FunctionDecl *FD = llvm::dyn_cast(DC); + if (!FD) JonasToth wrote: > There is `FunctionDecl->cast

[PATCH] D57787: [clang-tidy] modernize-avoid-c-arrays: avoid main function (PR40604)

lebedev.ri updated this revision to Diff 185492. lebedev.ri marked 4 inline comments as done. lebedev.ri added a comment. Address review notes, adjust docs. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57787/new/ https://reviews.llvm.org/D57787 Fi

<    1   2