lebedev.ri added inline comments.
================
Comment at: test/clang-tidy/modernize-avoid-c-arrays.cpp:90
+
+int not_main(int argc, char *argv[]) {
+ // CHECK-MESSAGES: :[[@LINE-1]]:24: warning: do not declare C-style arrays,
use std::array<> instead
----------------
JonasToth wrote:
> `main` has a third optional argument for environment variables. Please add
> test case for that, too.
> Could add a test for the `char **argv`-form to ensure these are not ignored
> somehow?
`char **argv` form *is* ignored, that is why i have not seen this issue before.
It's not a C-Style array, but a pointer to a pointer to char.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57787/new/
https://reviews.llvm.org/D57787
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
