[PATCH] D57472: [AST] Extract ASTDumpTraverser class from ASTDumper

steveire marked an inline comment as done. steveire added inline comments. Comment at: include/clang/AST/ASTDumpTraverser.h:1 +//===--- ASTDumpTraverser.h - Traversal of AST nodes --===// +// I think I'll rename this to `ASTNodeTraverser`. An

[PATCH] D57472: [AST] Extract ASTDumpTraverser class from ASTDumper

aaron.ballman added inline comments. Comment at: include/clang/AST/ASTDumpTraverser.h:1 +//===--- ASTDumpTraverser.h - Traversal of AST nodes --===// +// steveire wrote: > I think I'll rename this to `ASTNodeTraverser`. Any objections? Nope,

[PATCH] D56326: [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive

Meinersbur added a comment. @lildmh Thanks for the patch. I can commit this patch for you. The tests run fine on my machine. However, for committing on other's behalf, we were asked to make the contributor aware that the contribution will be published under a new license

[PATCH] D56326: [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive

lildmh added a comment. In D56326#1381229 , @Meinersbur wrote: > @lildmh Thanks for the patch. I can commit this patch for you. The tests run > fine on my machine. However, for committing on other's behalf, we were asked > to make the contributor aware t

r352906 - [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive.

Author: meinersbur Date: Fri Feb 1 12:25:04 2019 New Revision: 352906 URL: http://llvm.org/viewvc/llvm-project?rev=352906&view=rev Log: [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive. This patch implements parsing and sema for "omp declare mapper" directive. User defined ma

[PATCH] D56326: [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive

This revision was automatically updated to reflect the committed changes. Closed by commit rC352906: [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive. (authored by Meinersbur, committed by ). Herald added a project: clang. Repository: rC Clang CHANGES SINCE LAST ACTION ht

LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D57615: [AST][OpenMP] OpenMP master Construct contains Structured block

lebedev.ri created this revision. lebedev.ri added reviewers: ABataev, OpenMP. lebedev.ri added projects: clang, OpenMP. Herald added subscribers: openmp-commits, guansong. Much like `single` construct (D57594 ): `OpenMP Application Programming Interface Version 5

[PATCH] D57615: [AST][OpenMP] OpenMP master Construct contains Structured block

ABataev added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:6058 + // longjmp() and throw() must not violate the entry/exit criteria. + cast(AStmt)->getCapturedDecl()->setNothrow(); + Generally speaking, this is not required. It is required only for thos

[PATCH] D57615: [AST][OpenMP] OpenMP master Construct contains Structured block

lebedev.ri added a comment. @ABataev i'm not sure i have fully followed the https://bugs.llvm.org/show_bug.cgi?id=40563#c1 > The outlined function is not generated for the loop, so there is no problem > with the standard compatibility. Are you saying that in these cases of `master`, `critical`

[PATCH] D57615: [AST][OpenMP] OpenMP master Construct contains Structured block

ABataev added a comment. In D57615#1381416 , @lebedev.ri wrote: > @ABataev i'm not sure i have fully followed the > https://bugs.llvm.org/show_bug.cgi?id=40563#c1 > > > The outlined function is not generated for the loop, so there is no problem > > with

Re: r352906 - [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive.

Hi, I never used modules. Can you give me hint where it exactly breaks? Is it line 294 and 298 where it calls getExternalSource of ASTContext? Michael Am Fr., 1. Feb. 2019 um 12:58 Uhr schrieb Eric Fiselier : > > This breaks my build (I have modules enabled). > > DeclOpenMP.h uses ASTContext w

r352919 - Don't use ASTContext in DeclOpenMP.h because it's still incomplete.

Author: ericwf Date: Fri Feb 1 13:19:20 2019 New Revision: 352919 URL: http://llvm.org/viewvc/llvm-project?rev=352919&view=rev Log: Don't use ASTContext in DeclOpenMP.h because it's still incomplete. Modified: cfe/trunk/include/clang/AST/DeclOpenMP.h cfe/trunk/lib/AST/DeclOpenMP.cpp Mod

[PATCH] D57615: [AST][OpenMP] OpenMP master Construct contains Structured block

lebedev.ri added a comment. In D57615#1381418 , @ABataev wrote: > In D57615#1381416 , @lebedev.ri > wrote: > > > @ABataev i'm not sure i have fully followed the > > https://bugs.llvm.org/show_bug.cgi?id=40563#c1 >

[PATCH] D57615: [AST][OpenMP] OpenMP master Construct contains Structured block

ABataev added a comment. In D57615#1381427 , @lebedev.ri wrote: > In D57615#1381418 , @ABataev wrote: > > > In D57615#1381416 , @lebedev.ri > > wrote: > > > > > @ABataev i'm

[PATCH] D57615: [AST][OpenMP] OpenMP master Construct contains Structured block

lebedev.ri added a comment. In D57615#1381428 , @ABataev wrote: > In D57615#1381427 , @lebedev.ri > wrote: > > > In D57615#1381418 , @ABataev wrote: > > > > > In D57615#1381

[PATCH] D57615: [AST][OpenMP] OpenMP master Construct contains Structured block

lebedev.ri abandoned this revision. lebedev.ri added a comment. Let's instead solve the problem of structured block not having an AST representation. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57615/new/ https://reviews.llvm.org/D57615

[PATCH] D57594: [AST][OpenMP] OpenMP single Construct contains Structured block

lebedev.ri abandoned this revision. lebedev.ri added a comment. Let's instead solve the problem of structured block not having an AST representation. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57594/new/ https://reviews.llvm.org/D57594

[PATCH] D57615: [AST][OpenMP] OpenMP master Construct contains Structured block

ABataev added a comment. > Okay, enough is enough :) > I think a very important phrase was repeated a number of times, and it > highlights the **actual** problem here: > >> is not the representation of the structured block It is not a problem! It is the internal implementation design! What do

[PATCH] D57615: [AST][OpenMP] OpenMP master Construct contains Structured block

ABataev added a comment. In D57615#1381443 , @lebedev.ri wrote: > Let's instead solve the problem of structured block not having an AST > representation. Again, this is not a problem for the compiler. If you want this idiom for the analyzer, you need t

[PATCH] D57615: [AST][OpenMP] OpenMP master Construct contains Structured block

lebedev.ri added a comment. In D57615#1381447 , @ABataev wrote: > > Okay, enough is enough :) > > I think a very important phrase was repeated a number of times, and it > > highlights the **actual** problem here: > > > >> is not the representation of th

[PATCH] D57615: [AST][OpenMP] OpenMP master Construct contains Structured block

ABataev added a comment. In D57615#1381467 , @lebedev.ri wrote: > In D57615#1381447 , @ABataev wrote: > > > > Okay, enough is enough :) > > > I think a very important phrase was repeated a number of times, and it

r352925 - Factor out duplication between ExprIterator and ConstExprIterator.

Author: rsmith Date: Fri Feb 1 13:58:17 2019 New Revision: 352925 URL: http://llvm.org/viewvc/llvm-project?rev=352925&view=rev Log: Factor out duplication between ExprIterator and ConstExprIterator. This also exposes a more general iterator cast mechanism suitable for use in http://reviews.llvm.

[PATCH] D53153: [OpenCL] Mark kernel functions with default visibility

scott.linder abandoned this revision. scott.linder added a comment. See https://reviews.llvm.org/D56871 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53153/new/ https://reviews.llvm.org/D53153 ___ cfe-commits mailing list cfe-commits@lists.

r352927 - Improve diagnostic to tell you a type is incomplete.

Author: ericwf Date: Fri Feb 1 14:06:02 2019 New Revision: 352927 URL: http://llvm.org/viewvc/llvm-project?rev=352927&view=rev Log: Improve diagnostic to tell you a type is incomplete. I recently ran into this code: ``` \#include void foo(const std::string &s, const std::string& = ""); \#includ

[PATCH] D57615: [AST][OpenMP] OpenMP master Construct contains Structured block

lebedev.ri added a comment. In D57615#1381461 , @ABataev wrote: > In D57615#1381443 , @lebedev.ri > wrote: > > > Let's instead solve the problem of structured block not having an AST > > representation. > > > Agai

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

rsmith added inline comments. Comment at: include/clang/AST/Stmt.h:1008 + (*iterator_adaptor_base::I)->getStmtClass() <= lastExprConstant); + return *reinterpret_cast(iterator_adaptor_base::I); } Ugh. This cast violates strict aliasing, and

[PATCH] D57464: Generalize method overloading on addr spaces to C++

ebevhan added inline comments. Comment at: test/SemaCXX/address-space-method-overloading.cpp:28 + //inas4.bar(); + noas.bar(); // expected-error{{call to member function 'bar' is ambiguous}} +} rjmccall wrote: > ebevhan wrote: > > Anastasia wrote: > > > ebevh

[PATCH] D46421: [analyzer][CrossTU] Extend CTU to VarDecls with initializer

NoQ added a comment. Fxd the global variable problem in D57619 , thanks! I think you should change back to `getInit()` once D57619 lands. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D46421/new/

r352930 - [WebAssembly] Add an import_field function attribute

Author: djg Date: Fri Feb 1 14:25:23 2019 New Revision: 352930 URL: http://llvm.org/viewvc/llvm-project?rev=352930&view=rev Log: [WebAssembly] Add an import_field function attribute This is similar to import_module, but sets the import field name instead. By default, the import field name is th

Re: r352930 - [WebAssembly] Add an import_field function attribute

On Fri, Feb 1, 2019 at 5:25 PM Dan Gohman via cfe-commits wrote: > > Author: djg > Date: Fri Feb 1 14:25:23 2019 > New Revision: 352930 > > URL: http://llvm.org/viewvc/llvm-project?rev=352930&view=rev > Log: > [WebAssembly] Add an import_field function attribute > > This is similar to import_modu

[PATCH] D57464: Generalize method overloading on addr spaces to C++

rjmccall added inline comments. Comment at: test/SemaCXX/address-space-method-overloading.cpp:28 + //inas4.bar(); + noas.bar(); // expected-error{{call to member function 'bar' is ambiguous}} +} ebevhan wrote: > rjmccall wrote: > > ebevhan wrote: > > > Anasta

r352933 - Revert "[AST][OpenMP] OpenMP Sections / Section constructs contain Structured blocks"

Author: lebedevri Date: Fri Feb 1 14:43:08 2019 New Revision: 352933 URL: http://llvm.org/viewvc/llvm-project?rev=352933&view=rev Log: Revert "[AST][OpenMP] OpenMP Sections / Section constructs contain Structured blocks" Further reviews (D57594, D57615) have revealed that this was not reviewed,

[PATCH] D57438: [Sema][ObjC] Allow declaring ObjC pointer members in C++ unions under ARC

ahatanak marked 2 inline comments as done. ahatanak added inline comments. Comment at: lib/Sema/SemaDeclCXX.cpp:7084 + if (FD->getParent()->isUnion() && + shouldDeleteForVariantObjCPtrMember(FD, FieldType)) rjmccall wrote: > rjmccall wrote: > > I believe

[PATCH] D57438: [Sema][ObjC] Allow declaring ObjC pointer members in C++ unions under ARC

ahatanak updated this revision to Diff 184851. ahatanak marked an inline comment as done. ahatanak added a comment. Add a test case for an anonymous struct nested inside an anonymous union. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57438/new/ https://reviews.

[PATCH] D51204: [COFF, ARM64] Add MS intrinsics: __getReg, _ReadStatusReg, _WriteStatusReg

glandium added a comment. In D51204#1271564 , @dmajor wrote: > In D51204#1253230 , @mgrang wrote: > > > Will abandon this patch since I have implementations of these which I will > > upstream soon. > > > Just to li

r352936 - [WebAssembly] Fix ImportName's position in this test.

Author: djg Date: Fri Feb 1 14:52:29 2019 New Revision: 352936 URL: http://llvm.org/viewvc/llvm-project?rev=352936&view=rev Log: [WebAssembly] Fix ImportName's position in this test. This is a follow-up to r352930. Modified: cfe/trunk/test/Misc/pragma-attribute-supported-attributes-list.te

[PATCH] D57623: [please ignore, v2] Clang test revision for new Herald rules for Github monorepo

benhamilton created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is another test for the new Herald rules to subscribe cfe-commits to revisions sent out from the Github monorepo under the "clang/" subdirectory. Repository: rG LLVM Github Monorepo

r352938 - [analyzer] Hotfix for RetainCountChecker: assert was too strong.

Author: george.karpenkov Date: Fri Feb 1 15:06:44 2019 New Revision: 352938 URL: http://llvm.org/viewvc/llvm-project?rev=352938&view=rev Log: [analyzer] Hotfix for RetainCountChecker: assert was too strong. Bridged casts can happen to non-CF objects as well. Modified: cfe/trunk/lib/StaticA

[PATCH] D57626: Disallow trivial_abi on a class if all copy and move constructors are deleted

ahatanak created this revision. ahatanak added reviewers: rsmith, rjmccall, aaron.ballman. ahatanak added a project: clang. Herald added subscribers: dexonsmith, jkorous. Instead of forcing the class to be passed in registers, which was what r350920 did, issue a warning and inform the user that t

[PATCH] D57619: [analyzer] Canonicalize variable declarations in VarRegion objects.

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Herald added a subscriber: cfe-commits. Looks good, nice catch. :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57619/new/ https://reviews.llvm.org/D576

[PATCH] D57628: [index] Improve indexing support for MSPropertyDecl.

vsapsai created this revision. vsapsai added reviewers: akyrtzi, benlangmuir. Herald added subscribers: arphaman, dexonsmith, jkorous. Currently the symbol for MSPropertyDecl has kind `SymbolKind::Unknown` which can trip up various indexing tools. rdar://problem/46764224 https://reviews.llvm.or

[PATCH] D57438: [Sema][ObjC] Allow declaring ObjC pointer members in C++ unions under ARC

rjmccall added a comment. Asking for a minor tweak, but feel free to commit with that. Comment at: lib/Sema/SemaDeclCXX.cpp:7084 + if (FD->getParent()->isUnion() && + shouldDeleteForVariantObjCPtrMember(FD, FieldType)) ahatanak wrote: > rjmccall wrote:

[PATCH] D57626: Disallow trivial_abi on a class if all copy and move constructors are deleted

rjmccall added inline comments. Comment at: lib/Sema/SemaDeclCXX.cpp:7886 + if (!HasNonDeletedCopyOrMoveConstructor()) { +PrintDiagAndRemoveAttr(); +return; This is not a very useful diagnostic. We have several different reasons why we reject the attri

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

efriedma added inline comments. Comment at: lib/Analysis/CFG.cpp:3137 + + Block = createBlock(false); + Block->setTerminator(G); Passing add_successor=false seems suspect; this could probably use more test coverage. Comment at: lib/CodeGen/C

[PATCH] D56561: [Preprocessor] For missing file in framework add note about framework location.

vsapsai updated this revision to Diff 184866. vsapsai added a comment. - Improve the diagnostic message wording. Rebased the patch, so the diff between 2 revisions can be noisy. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56561/new/ https://reviews.llvm.org/D56561 Files: clang/inc

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

efriedma added a comment. Forgot about protected scopes... This patch is missing code and testcases for JumpScopeChecker. (The behavior should be roughly equivalent to what we do for indirect goto.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56571/new/ https://reviews.llvm.org/D56

[PATCH] D57631: [COFF, ARM64] Add ARM64 support for MS intrinsic _fastfail

TomTan created this revision. TomTan added reviewers: rnk, mstorsjo, efriedma. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. The MSDN document was also updated to reflect this, but it probably will take a few days to show in below link. https://docs.microso

[PATCH] D57631: [COFF, ARM64] Add ARM64 support for MS intrinsic _fastfail

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57631/new/ https://reviews.llvm.org/D57631 ___ cfe-commit

Re: r352930 - [WebAssembly] Add an import_field function attribute

On Fri, Feb 1, 2019 at 2:31 PM Aaron Ballman wrote: > On Fri, Feb 1, 2019 at 5:25 PM Dan Gohman via cfe-commits > wrote: > > > > Author: djg > > Date: Fri Feb 1 14:25:23 2019 > > New Revision: 352930 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=352930&view=rev > > Log: > > [WebAssembly]

r352946 - Remove redundant FunctionDecl argument from a couple functions.

Author: jyknight Date: Fri Feb 1 17:48:23 2019 New Revision: 352946 URL: http://llvm.org/viewvc/llvm-project?rev=352946&view=rev Log: Remove redundant FunctionDecl argument from a couple functions. This argument was added in r254554 in order to support the pass_object_size attribute. However, in

r352948 - [ASan] Do not instrument other runtime functions with `__asan_handle_no_return`

Author: yln Date: Fri Feb 1 18:05:16 2019 New Revision: 352948 URL: http://llvm.org/viewvc/llvm-project?rev=352948&view=rev Log: [ASan] Do not instrument other runtime functions with `__asan_handle_no_return` Summary: Currently, ASan inserts a call to `__asan_handle_no_return` before every `nore

[PATCH] D57489: [ASan] Do not instrument other runtime functions with `__asan_handle_no_return`

This revision was automatically updated to reflect the committed changes. Closed by commit rC352948: [ASan] Do not instrument other runtime functions with `__asan_handle_no_return` (authored by yln, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews

r352949 - [Sema][ObjC] Allow declaring ObjC pointer members with non-trivial

Author: ahatanak Date: Fri Feb 1 18:23:40 2019 New Revision: 352949 URL: http://llvm.org/viewvc/llvm-project?rev=352949&view=rev Log: [Sema][ObjC] Allow declaring ObjC pointer members with non-trivial ownership qualifications in C++ unions under ARC. An ObjC pointer member with non-trivial owner

[PATCH] D57438: [Sema][ObjC] Allow declaring ObjC pointer members in C++ unions under ARC

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. ahatanak marked an inline comment as done. Closed by commit rC352949: [Sema][ObjC] Allow declaring ObjC pointer members with non-trivial (aut

[PATCH] D57634: Support for GCC's `__builtin_va_arg_pack{,_len}`

erik.pilkington created this revision. erik.pilkington added reviewers: rsmith, jfb, aaron.ballman. Herald added subscribers: kristina, dexonsmith, jkorous. Herald added a project: clang. You can read more about these attributes here: https://gcc.gnu.org/onlinedocs/gcc-4.4.2/gcc/Constructing-Call

[PATCH] D57636: [COFF, ARM64] Fix types for _ReadStatusReg, _WriteStatusReg

glandium created this revision. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. r344765 added those intrinsics, but used the wrong types. I /think/ the code in EmitAArch64BuiltinExpr does the right thing, though, but I'm not familiar with it. Th

[PATCH] D51204: [COFF, ARM64] Add MS intrinsics: __getReg, _ReadStatusReg, _WriteStatusReg

glandium added a comment. Opened D57636 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51204/new/ https://reviews.llvm.org/D51204 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D57219: [Fixed Point Arithmetic] Fixed Point Comparisons

leonardchan updated this revision to Diff 184886. leonardchan marked an inline comment as done. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57219/new/ https://reviews.llvm.org/D57219 Files: clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CGExprScalar.cpp

[PATCH] D57219: [Fixed Point Arithmetic] Fixed Point Comparisons

leonardchan added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3444 case BO_NE: +return Builder.CreateICmpNE(FullLHS, FullRHS); + case BO_Mul: rjmccall wrote: > leonardchan wrote: > > rjmccall wrote: > > > Are padding bits guaranteed ze

[PATCH] D57636: [COFF, ARM64] Fix types for _ReadStatusReg, _WriteStatusReg

smeenai added subscribers: hans, smeenai. smeenai added reviewers: rnk, efriedma. smeenai added a comment. +@hans for the release branch. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57636/new/ https://reviews.llvm.org/D57636 _

[PATCH] D57553: [Fixed Point Arithmetic] Avoid resizing for types with the same width

leonardchan updated this revision to Diff 184888. leonardchan retitled this revision from "[Fixed Point Arithmetic] Check against source value when converting during saturation" to "[Fixed Point Arithmetic] Avoid resizing for types with the same width". leonardchan edited the summary of this revi

[PATCH] D57553: [Fixed Point Arithmetic] Avoid resizing for types with the same width

leonardchan added a comment. In D57553#1380157 , @ebevhan wrote: > This doesn't seem to address the particular case in the integer conversion > patch. In fact, I don't see those conversions at all. I was initially planning on rebasing and updating the p

[clang-tools-extra] r352953 - [Clangd] textDocument/definition and textDocument/declaration "bounce" between definition and declaration location when they are distinct.

Author: sammccall Date: Fri Feb 1 21:56:00 2019 New Revision: 352953 URL: http://llvm.org/viewvc/llvm-project?rev=352953&view=rev Log: [Clangd] textDocument/definition and textDocument/declaration "bounce" between definition and declaration location when they are distinct. Summary: This helps m

<    1   2