[PATCH] D56267: [clangd] Interfaces for writing code actions

ilya-biryukov updated this revision to Diff 183949. ilya-biryukov marked 7 inline comments as done. ilya-biryukov added a comment. - s/applyCodeAction/applyTweak - Added a comment to TweakArgs - Added a unit test for sourceLocationInMainFile - Extract a 'validateRegistry' function - Do not log Can

[PATCH] D56267: [clangd] Interfaces for writing code actions

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/Protocol.cpp:425 +const llvm::StringLiteral ExecuteCommandParams::CLANGD_APPLY_TWEAK = +"clangd.applyCodeAction"; + sammccall wrote: > tweak or applyTweak Done. Thanks for spotting this

[PATCH] D57223: [Tooling] Handle #pragma once header guard in include insertion.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Comment at: lib/Tooling/Inclusions/HeaderIncludes.cpp:77 +// before/after header guards (e.g. #ifndef/#define pair, #pragma once). If no +// header guard p

[PATCH] D57353: [clang-tidy] Add the abseil-duration-double-conversion check

Eugene.Zelenko added inline comments. Comment at: clang-tidy/abseil/DurationDoubleConversionCheck.cpp:48 + + if (!isNotInMacro(Result, OuterCall)) return; + Please run Clang-format. Comment at: docs/ReleaseNotes.rst:85 + + Find and fix cases

[PATCH] D57230: [analyzer] Toning down invalidation a bit

george.karpenkov added a comment. I'm in favor of this change, I never understood how invalidating a field invalidates entire structure. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57230/new/ https://reviews.llvm.org/D57230 ___ cfe-commi

[PATCH] D52790: [analyzer][PlistMacroExpansion] New flag to convert macro expansions to events

george.karpenkov added a comment. I personally do use HTML output quite a lot (and we do have non-Xcode projects), and complex macros in HTML are currently totally unusable. I'm not sure whether this is a right approach to handling this, but it's definitely a problem for us. In general - thanks

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

vit9696 added a comment. @jhibbits it appears that va_list is not functional with SPE (va_arg returns garbage for double and stuff like printf is not functional). Is this expected or I miss a patch? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49754/new/ https

r352436 - [ASTImporter] Fix handling of overriden methods during ASTImport

Author: shafik Date: Mon Jan 28 13:55:33 2019 New Revision: 352436 URL: http://llvm.org/viewvc/llvm-project?rev=352436&view=rev Log: [ASTImporter] Fix handling of overriden methods during ASTImport Summary: When importing classes we may add a CXXMethodDecl more than once to a CXXRecordDecl when

[PATCH] D56936: Fix handling of overriden methods during ASTImport

This revision was automatically updated to reflect the committed changes. Closed by commit rC352436: [ASTImporter] Fix handling of overriden methods during ASTImport (authored by shafik, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56936/new/ http

[PATCH] D56871: [AMDGPU] Require at least protected visibility for certain symbols

scott.linder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56871/new/ https://reviews.llvm.org/D56871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D57330: Adjust documentation for git migration.

smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. The amount of duplicated and out-of-date documentation makes me sad, but this is an awesome effort to clean that up. Comment at: lldb/packages/Python/lldbsuite/test/funct

[PATCH] D56723: [CodeComplete] Propagate preferred types through parser in more cases

rsmith added inline comments. Comment at: clang/include/clang/Sema/Sema.h:319-346 +class PreferredTypeBuilder::RestoreRAII { +public: + RestoreRAII(RestoreRAII const &) = delete; + RestoreRAII &operator=(RestoreRAII const &) = delete; + + explicit RestoreRAII(PreferredTypeBuil

[PATCH] D57230: [analyzer] Toning down invalidation a bit

NoQ accepted this revision. NoQ added a comment. In D57230#1373721 , @xazax.hun wrote: > Do you think I should try to reduce additional files? Aha, ok, it reduced an interesting positive into a non-interesting positive. So i guess my method only works w

[PATCH] D53199: Fix the behavior of clang's -w flag.

jyknight added inline comments. Comment at: clang/lib/Basic/DiagnosticIDs.cpp:460-463 + // Honor -w: this disables all messages mapped to Warning severity, and *also* + // any diagnostics which are not Error/Fatal by default (that is, they were + // upgraded by any of the mec

[PATCH] D53199: Fix the behavior of clang's -w flag.

jyknight updated this revision to Diff 183966. jyknight marked 2 inline comments as done. jyknight added a comment. Fix to not disable remarks, reword comment, adjust implementation-of-module.m test-case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53199/new/ https://reviews.llvm.org

[PATCH] D56852: [AArch64] Use LL for 64-bit arguments

efriedma accepted this revision. efriedma added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56852/new/ https://reviews.llvm.org/D56852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[PATCH] D55734: [analyzer] Revise GenericTaintChecker's internal representation

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. In D55734#1372972 , @boga95 wrote: > Is it ready to land? Whops. Yes, right, it's totally ready to land! Sorry. Should i commit? CHANGES SINCE LAST AC

r352443 - AMDGPU: Add ds append/consume builtins

Author: arsenm Date: Mon Jan 28 15:59:18 2019 New Revision: 352443 URL: http://llvm.org/viewvc/llvm-project?rev=352443&view=rev Log: AMDGPU: Add ds append/consume builtins Modified: cfe/trunk/include/clang/Basic/BuiltinsAMDGPU.def cfe/trunk/lib/CodeGen/CGBuiltin.cpp cfe/trunk/test/Cod

[PATCH] D57349: AMDGPU: Add ds append/consume builtins

arsenm closed this revision. arsenm added a comment. r352443 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57349/new/ https://reviews.llvm.org/D57349 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[PATCH] D35068: [analyzer] Detect usages of unsafe I/O functions

NoQ accepted this revision. NoQ added a comment. Ok! I hope that the C11 check would do the trick, let's see how it goes :) In D35068#1364947 , @xazax.hun wrote: > What do we want to validate here? The lack of crashes? Or evaluate false > positive ratio?

[PATCH] D57219: [Fixed Point Arithmetic] Fixed Point Comparisons

leonardchan updated this revision to Diff 183980. leonardchan marked 2 inline comments as done. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57219/new/ https://reviews.llvm.org/D57219 Files: clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CGExprScalar.cpp

[PATCH] D57219: [Fixed Point Arithmetic] Fixed Point Comparisons

leonardchan added inline comments. Comment at: clang/test/Frontend/fixed_point_comparisons.c:56 + +void TestComparisons() { + short _Accum sa; ebevhan wrote: > leonardchan wrote: > > ebevhan wrote: > > > Missing saturating and saturating/non-saturating compariso

[PATCH] D52984: [analyzer] Checker reviewer's checklist

NoQ accepted this revision. NoQ added a comment. Thanks!!~ I'm slow, but at least i admit it... Just made myself a fancier phabricator query so that not to forget about patches, so hopefully i won't forget about patches that often anymore :/ I mean, seriously, i'm very happy that we're all doi

[PATCH] D50563: Fixed frontend clang tests in windows read-only container

stella.stamenova added a comment. @thakis Thanks for the information, I had actually missed that. The way this test is written, it needs to use a directory (so %T is "correct"), but to remove %T, it could be changed to use something like ```%t.doesnotexist.somename``` instead. If you feel stron

[PATCH] D46421: [analyzer][CrossTU] Extend CTU to VarDecls with initializer

NoQ added a comment. In D46421#1354188 , @r.stahl wrote: > In my old version I seemed to get away with the tests, but they failed after > rebasing. It seems like earlier there was only a single VarDecl for the > imported ones with InitExpr. Now after imp

[PATCH] D57278: [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM Since the previous iteration of this was controversial, please wait for at least one more review. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57278/new

[PATCH] D57303: [ToolChains] [NetBSD] Append -rpath for shared compiler-rt runtimes

dlj accepted this revision. dlj added a comment. In D57303#1373163 , @mgorny wrote: > Given that this path changes with every clang release, so you're effectively > making a hard dependency on the clang version used to build the program, I > dare say som

[PATCH] D57278: [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls

vsk added a comment. Is it necessary to remove visitation of 'noreturn' call sites from ASan? I'd expect that to break non-C frontends which emit noreturn calls (rust/swift?). Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57278/new/ https://reviews.llvm.org/D5727

[PATCH] D57086: Ignore trailing NullStmts in StmtExprs for GCC compatibility

domdom updated this revision to Diff 184001. domdom added a comment. Thanks for your comments, @aaron.ballman. I've addressed the comments and added a test case as suggested. This revealed an issue with the code-gen side of things, so I fixed that and added another test case for that as well.

[PATCH] D51329: [Attribute/Diagnostics] Print macro instead of whole attribute for address_space

rsmith added inline comments. Comment at: clang/include/clang/AST/Type.h:4183 +/// Sugar type that represents a type that was defined in a macro. +class MacroDefinedType : public Type { + friend class ASTContext; // ASTContext creates these. This represents a ma

[PATCH] D57188: Disable _Float16 for non ARM/SPIR Targets

yaxunl added a comment. This change causes regressions for CUDA/HIP. As single-source language, CUDA/HIP code contains both device and host code. It has separate compilation for host and device. In host compilation, device function is parsed but not emitted in IR. The device function may have _

[PATCH] D57188: Disable _Float16 for non ARM/SPIR Targets

rjmccall added a comment. In D57188#1374890 , @yaxunl wrote: > This change causes regressions for CUDA/HIP. As single-source language, > CUDA/HIP code contains both device and host code. It has separate compilation > for host and device. > In host compi

[PATCH] D57188: Disable _Float16 for non ARM/SPIR Targets

rjmccall added a comment. Regardless, I think it would be fine if you wanted to add a CUDA/HIP exception to this check in the short term. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57188/new/ https://reviews.llvm.org/D57188 _

r352449 - [CMake][Fuchsia] Temporarily disable modules for second stage

Author: phosek Date: Mon Jan 28 19:38:26 2019 New Revision: 352449 URL: http://llvm.org/viewvc/llvm-project?rev=352449&view=rev Log: [CMake][Fuchsia] Temporarily disable modules for second stage This is breaking some of builders, disable modules until it's resolved. Modified: cfe/trunk/cmake

[PATCH] D55640: [clang-tidy] Implement a check for large Objective-C type encodings 🔍

stephanemoore planned changes to this revision. stephanemoore added a comment. Reiterating outstanding action items: • Evaluate using hasDeclContext instead of hasAncestor. • Include type encoding size information in diagnostic messages. I've been observing some unexpected behaviors with matching

[PATCH] D57369: [CUDA][HIP] Do not diagnose use of _Float16

yaxunl created this revision. yaxunl added reviewers: rjmccall, tra. r352221 caused regressions in CUDA/HIP since device function may use _Float16 whereas host does not support it. In this case host compilation should not diagnose usage of _Float16 in device functions or variables. For now just

[PATCH] D57330: Adjust documentation for git migration.

mehdi_amini added a comment. LGTM, but for one comment that requires a fix I believe (lld on Windows) Comment at: libcxx/docs/BuildingLibcxx.rst:47 - * ``cd build`` - * ``cmake -G [options] `` So nice to see these steps going away :) C

[PATCH] D57369: [CUDA][HIP] Do not diagnose use of _Float16

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57369/new/ https://reviews.llvm.org/D57369 ___ cfe-commits mailing list cfe-comm

r352456 - Remove unused variable to silence compiler warning

Author: uabelho Date: Mon Jan 28 22:53:31 2019 New Revision: 352456 URL: http://llvm.org/viewvc/llvm-project?rev=352456&view=rev Log: Remove unused variable to silence compiler warning Modified: cfe/trunk/lib/AST/ASTImporter.cpp Modified: cfe/trunk/lib/AST/ASTImporter.cpp URL: http://llvm.o

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

kthomsen added a comment. @vit9696 I'm working since 3 days on that issue, and found nothing... PPCISelLowering.cpp has 2 functions: LowerVASTART() and LowerVAARG(). LowerVASTART is correctly called (store the GPR to the internal va_list structure), but LowerVAARG is never called and I don't un

[PATCH] D55734: [analyzer] Revise GenericTaintChecker's internal representation

boga95 added a comment. Yes, thank you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55734/new/ https://reviews.llvm.org/D55734 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

<    1   2