dlj accepted this revision. dlj added a comment. In D57303#1373163 <https://reviews.llvm.org/D57303#1373163>, @mgorny wrote:
> Given that this path changes with every clang release, so you're effectively > making a hard dependency on the clang version used to build the program, I > dare say some systems may either decide not to support shared runtimes at all > or use `ld.so.conf` or equivalent that can be dynamically changed. Yeah, I don't think we should be stamping an `-rpath` unconditionally across targets. On top of static builds and `ld.so.conf`, this could end up nominating the wrong one of `DT_RPATH` and `DT_RUNPATH`, which is, unfortunately, //still// a target-specific distinction. By my quick reading of Driver/ToolChains/Linux.cpp, I think the combination of where we pass `--enable-new-dtags` and where we would pass `-rpath` would get this wrong on some systems (which would, infuriatingly, only //maybe// cause problems; and if so, only at runtime). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57303/new/ https://reviews.llvm.org/D57303 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
