[PATCH] D56936: Fix handling of overriden methods during ASTImport

balazske added inline comments. Comment at: lib/AST/ASTImporter.cpp:2950 +ExpectedStmt ASTNodeImporter::ImportFunctionDeclBody( FunctionDecl *FromFD, FunctionDecl *ToFD ) { +if (Stmt *FromBody = FromFD->getBody()) { It would be better to return `Error` ins

[PATCH] D55850: [OpenCL] Allow address spaces as method qualifiers

ebevhan added a comment. I think the code that comes to mind is mostly like in `GetTypeSourceInfoForDeclarator`: LangAS AS = (ASIdx == LangAS::Default ? LangAS::opencl_generic : ASIdx); It's behind an OpenCLCPlusPlus guard so it won't add generic on anything if it's not OpenCL++, but t

Re: r347205 - [FileManager] getFile(open=true) after getFile(open=false) should open the file.

Thanks for all the digging! I can reproduce locally with your last example and ulimit -n 1000. So it sounds like: - this *is* actually the interaction/behavior I expected from FileManager (we call first with openFile=false then with openFile=true, and the file is opened the second time) - the pr

[PATCH] D57087: [clang-tidy] add OverrideMacro to modernize-use-override check

MyDeveloperDay added inline comments. Comment at: clang-tidy/modernize/UseOverrideCheck.cpp:32 +: ClangTidyCheck(Name, Context), + OverrideMacro(Options.get("OverrideMacro", "override")), + FinalMacro(Options.get("FinalMacro", "final")) {} alexfh wr

[PATCH] D57087: [clang-tidy] add OverrideMacro to modernize-use-override check

MyDeveloperDay updated this revision to Diff 183268. MyDeveloperDay marked 12 inline comments as done. MyDeveloperDay added a comment. Addressing review comments, - reduce changes causing excessive string concats and problems with temporaries - simplify cxx version and macro checks CHANGES SINC

[PATCH] D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class

lebedev.ri added inline comments. Comment at: clang-tidy/bugprone/ExceptionEscapeCheck.cpp:35 + std::vector FunctionsThatShouldNotThrowVec = + utils::options::parseStringList(RawFunctionsThatShouldNotThrow); FunctionsThatShouldNotThrow.insert(FunctionsThatShouldNotThrowV

[PATCH] D56836: [mips] Include whole lpthread when using both -pthread and -static

abeserminji abandoned this revision. abeserminji added a comment. Agreed on this solution D52878 . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56836/new/ https://reviews.llvm.org/D56836 ___

[PATCH] D57093: [CodeComplete] [clangd] Fix crash on ValueDecl with a null type

ilya-biryukov updated this revision to Diff 183273. ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment. - Rename the test - clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57093/new/ https://reviews.llvm.org/D57093 Files: clang-tools-extra/clangd

r352039 - Fix python3 compability issue in clang binding

Author: serge_sans_paille Date: Thu Jan 24 02:34:44 2019 New Revision: 352039 URL: http://llvm.org/viewvc/llvm-project?rev=352039&view=rev Log: Fix python3 compability issue in clang binding The file contents could be of str type. Should use byte length instead of str length, otherwise utf-8 enco

[PATCH] D56429: fix python3 compability issue

This revision was automatically updated to reflect the committed changes. Closed by commit rL352039: Fix python3 compability issue in clang binding (authored by serge_sans_paille, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D56429?v

[PATCH] D56429: fix python3 compability issue

serge-sans-paille added a comment. Thanks @roxma for the patch! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56429/new/ https://reviews.llvm.org/D56429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[clang-tools-extra] r352040 - [CodeComplete] [clangd] Fix crash on ValueDecl with a null type

Author: ibiryukov Date: Thu Jan 24 02:41:43 2019 New Revision: 352040 URL: http://llvm.org/viewvc/llvm-project?rev=352040&view=rev Log: [CodeComplete] [clangd] Fix crash on ValueDecl with a null type Reviewers: kadircet Reviewed By: kadircet Subscribers: ioeric, MaskRay, jkorous, arphaman, cfe-

r352040 - [CodeComplete] [clangd] Fix crash on ValueDecl with a null type

Author: ibiryukov Date: Thu Jan 24 02:41:43 2019 New Revision: 352040 URL: http://llvm.org/viewvc/llvm-project?rev=352040&view=rev Log: [CodeComplete] [clangd] Fix crash on ValueDecl with a null type Reviewers: kadircet Reviewed By: kadircet Subscribers: ioeric, MaskRay, jkorous, arphaman, cfe-

[PATCH] D57093: [CodeComplete] [clangd] Fix crash on ValueDecl with a null type

ilya-biryukov added inline comments. Comment at: clang-tools-extra/unittests/clangd/CodeCompleteTests.cpp:2322 +TEST(CompletionTest, CrashOnNullType) { + auto Results = completions(R"cpp( kadircet wrote: > nit: WorksWithNullType ? it doesn't seem like crashing

[PATCH] D57093: [CodeComplete] [clangd] Fix crash on ValueDecl with a null type

This revision was automatically updated to reflect the committed changes. Closed by commit rL352040: [CodeComplete] [clangd] Fix crash on ValueDecl with a null type (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org

[PATCH] D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class

JonasToth marked 3 inline comments as done. JonasToth added inline comments. Comment at: clang-tidy/bugprone/ExceptionEscapeCheck.cpp:35 + std::vector FunctionsThatShouldNotThrowVec = + utils::options::parseStringList(RawFunctionsThatShouldNotThrow); FunctionsThatShouldN

r352042 - Test commit: fix typo.

Author: pgousseau Date: Thu Jan 24 03:44:24 2019 New Revision: 352042 URL: http://llvm.org/viewvc/llvm-project?rev=352042&view=rev Log: Test commit: fix typo. Modified: cfe/trunk/lib/Driver/SanitizerArgs.cpp Modified: cfe/trunk/lib/Driver/SanitizerArgs.cpp URL: http://llvm.org/viewvc/llvm-p

Re: r347205 - [FileManager] getFile(open=true) after getFile(open=false) should open the file.

So from my reading starting at getFileAndSuggestModule, changing to openFile=false is correct there unless some code is relying on that side effect. All the tests pass, too. The most likely regression is where we previously did open+fstat we'll now do stat+open+fstat. I tried running three comman

[PATCH] D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class

lebedev.ri added inline comments. Comment at: clang-tidy/bugprone/ExceptionEscapeCheck.cpp:35 + std::vector FunctionsThatShouldNotThrowVec = + utils::options::parseStringList(RawFunctionsThatShouldNotThrow); FunctionsThatShouldNotThrow.insert(FunctionsThatShouldNotThrowV

[PATCH] D57108: [clang-tidy] diagnose possibiltiy to add 'noexcept' in modernize-use-noexcept

lebedev.ri added a comment. Hmm, i think this diff is incorrect. Doesn't it also include the changes from D57100 ? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57108/new/ https://reviews.llvm.org/D57108 ___

Re: [clang-tools-extra] r352040 - [CodeComplete] [clangd] Fix crash on ValueDecl with a null type

+Hans Wennborg , could you please merge this fix into the release branch? On Thu, Jan 24, 2019 at 1:41 PM Ilya Biryukov via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ibiryukov > Date: Thu Jan 24 02:41:43 2019 > New Revision: 352040 > > URL: http://llvm.org/viewvc/llvm-project?rev

[PATCH] D57150: [HeaderSearch] don't immediately request that headers are opened in getFileAndSuggestModule().

sammccall updated this revision to Diff 183291. sammccall added a comment. Actually include the relevant code change :-\ Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57150/new/ https://reviews.llvm.org/D57150 Files: lib/Lex/HeaderSearch.cpp test/PCH/leakfil

[PATCH] D57150: [HeaderSearch] don't immediately request that headers are opened in getFileAndSuggestModule().

sammccall added a subscriber: hans. sammccall added a comment. @hans: I think we're going to need either this fix or a revert of rL347205 + dependents cherrypicked for 8.0. I don't know what the constraints/goals are for releases, let me know if you have an op

[PATCH] D57150: [HeaderSearch] don't immediately request that headers are opened in getFileAndSuggestModule().

sammccall created this revision. sammccall added reviewers: thakis, ilya-biryukov, bkramer. Herald added a subscriber: cfe-commits. We don't immediately need the file to be open, and this code does not ensure that it is closed. On at least some code paths (using headers from PCHs) the file is neve

r352047 - [Sema] Don't crash when recovering from a misspelled pseudo destructor call to an incomplete type.

Author: brunoricci Date: Thu Jan 24 05:52:47 2019 New Revision: 352047 URL: http://llvm.org/viewvc/llvm-project?rev=352047&view=rev Log: [Sema] Don't crash when recovering from a misspelled pseudo destructor call to an incomplete type. When attempting to correct a misspelled pseudo destructor ca

[PATCH] D57106: [AST] Introduce GenericSelectionExpr::Association

riccibruno marked an inline comment as done. riccibruno added inline comments. Comment at: include/clang/AST/Expr.h:5103 +using reference = AssociationTy; +using pointer = AssociationTy; +AssociationIteratorTy() = default; aaron.ballman wrote: > Carry

[PATCH] D55850: [OpenCL] Allow address spaces as method qualifiers

ebevhan added inline comments. Comment at: lib/Sema/SemaOverload.cpp:5151 + if (FromTypeCanon.getQualifiers().hasAddressSpace()) { +Qualifiers QualsImplicitParamType = ImplicitParamType.getQualifiers(); I tested this patch with some kludges to let it parse

[PATCH] D56723: [CodeComplete] Propagate preferred types through parser in more cases

ilya-biryukov updated this revision to Diff 183297. ilya-biryukov added a comment. - Remove enterUnknown(), keep token location instead. - Inline update() and remove it CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56723/new/ https://reviews.llvm.org/D56723 Files: clang/include/clang

[PATCH] D57111: Make Clang not crash on calls to destructors on incomplete pointer types

This revision was automatically updated to reflect the committed changes. Closed by commit rL352047: [Sema] Don't crash when recovering from a misspelled pseudo destructor call to… (authored by brunoricci, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[PATCH] D56723: [CodeComplete] Propagate preferred types through parser in more cases

ilya-biryukov marked 3 inline comments as done. ilya-biryukov added inline comments. Comment at: lib/Sema/SemaCodeComplete.cpp:373 +} +Type = QualType(); + }); kadircet wrote: > nit: maybe move this into top and get rid of the return statements inside >

[clang-tools-extra] r352049 - [clangd] Clean the cache of file statuses on vscode-clangd when clangd crashes.

Author: hokein Date: Thu Jan 24 06:25:53 2019 New Revision: 352049 URL: http://llvm.org/viewvc/llvm-project?rev=352049&view=rev Log: [clangd] Clean the cache of file statuses on vscode-clangd when clangd crashes. Summary: Clear the cached file statuses, otherwise we will leave some garbage texts

[PATCH] D56540: [clangd] Clean the cache of file statuses on vscode-clangd when clangd crashes.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE352049: [clangd] Clean the cache of file statuses on vscode-clangd when clangd crashes. (authored by hokein, committed by ). Changed prior to commit: https://reviews.llvm.org/D56540?vs=181035&id=18329

Re: r347205 - [FileManager] getFile(open=true) after getFile(open=false) should open the file.

Can you measure on macOS and Windows too, and maybe with a larger program? The open+fstat (instead of stat+open) optimization was I think done with benchmarking on macOS. I can see why you say you think the new behavior is more consistent, but it's basically changing what information goes into the

[PATCH] D56540: [clangd] Clean the cache of file statuses on vscode-clangd when clangd crashes.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clangd/clients/clangd-vscode/src/extension.ts:127 +(fileStatus) => { status.onFileUpdated(fileStatus); }); +} else if (newState == vscodelc.State.Stopped) { +

[PATCH] D57150: [HeaderSearch] don't immediately request that headers are opened in getFileAndSuggestModule().

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Thanks for the fix! Nice test too. Let's land this and see if anything breaks :-) On the 8.0, I'd probably recommend reverting your change instead, since this feels like a subtle change that

[PATCH] D56723: [CodeComplete] Propagate preferred types through parser in more cases

ilya-biryukov added a comment. In D56723#1366885 , @rsmith wrote: > `ConsumeToken` is a fairly hot function; if you can avoid changes there > that'd be preferable. Done, there are no `enterUnknown` calls anymore and to avoid updating on each call to `C

[PATCH] D56723: [CodeComplete] Propagate preferred types through parser in more cases

ilya-biryukov updated this revision to Diff 183303. ilya-biryukov added a comment. - Improve a comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56723/new/ https://reviews.llvm.org/D56723 Files: clang/include/clang/Parse/Parser.h clang/include/clang/Sema/CodeCompleteConsumer.h

[PATCH] D57155: [WebAssembly] Add a __wasi__ target macro

sunfish created this revision. sunfish added reviewers: sbc100, dschuff, aheejin. Herald added subscribers: llvm-commits, jgravelle-google. sunfish edited the summary of this revision. This adds a `__wasi__` macro for the wasi OS, similar to `__linux__` etc. for other OS's. Repository: rL LLV

r352050 - [ASTImporter] Fix inequality of functions with different attributes

Author: martong Date: Thu Jan 24 06:47:44 2019 New Revision: 352050 URL: http://llvm.org/viewvc/llvm-project?rev=352050&view=rev Log: [ASTImporter] Fix inequality of functions with different attributes Summary: FunctionType::ExtInfo holds such properties of a function which are needed mostly for

[PATCH] D53699: [ASTImporter] Fix inequality of functions with different attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rC352050: [ASTImporter] Fix inequality of functions with different attributes (authored by martong, committed by ). Changed prior to commit: https://reviews.llvm.org/D53699?vs=178060&id=183307#toc Reposi

[PATCH] D57150: [HeaderSearch] don't immediately request that headers are opened in getFileAndSuggestModule().

bkramer accepted this revision. bkramer added inline comments. Comment at: lib/Lex/HeaderSearch.cpp:313 // check whether we'll have a suggestion for a module. - const FileEntry *File = getFileMgr().getFile(FileName, /*OpenFile=*/true); + const FileEntry *File = getFileMgr().

[PATCH] D55850: [OpenCL] Allow address spaces as method qualifiers

Anastasia added a comment. In D55850#1369008 , @ebevhan wrote: > I think the code that comes to mind is mostly like in > `GetTypeSourceInfoForDeclarator`: > > LangAS AS = > (ASIdx == LangAS::Default ? LangAS::opencl_generic : ASIdx); > > > It's

r352054 - [CPU-Dispatch] Make pentium_iii_no_xmm_regs and pentium_iii alias.

Author: erichkeane Date: Thu Jan 24 07:28:57 2019 New Revision: 352054 URL: http://llvm.org/viewvc/llvm-project?rev=352054&view=rev Log: [CPU-Dispatch] Make pentium_iii_no_xmm_regs and pentium_iii alias. I discovered that in ICC (where this list comes from), that the two pentium_iii versions were

[PATCH] D57104: [AST] Pack GenericSelectionExpr

riccibruno marked 2 inline comments as done. riccibruno added inline comments. Comment at: include/clang/AST/Expr.h:5095 - SourceLocation getBeginLoc() const LLVM_READONLY { return GenericLoc; } - SourceLocation getEndLoc() const LLVM_READONLY { return RParenLoc; } --

[PATCH] D57104: [AST] Pack GenericSelectionExpr

steveire added inline comments. Comment at: include/clang/AST/Expr.h:5095 - SourceLocation getBeginLoc() const LLVM_READONLY { return GenericLoc; } - SourceLocation getEndLoc() const LLVM_READONLY { return RParenLoc; } riccibruno wrote: > steveire wrote: > >

[PATCH] D57104: [AST] Pack GenericSelectionExpr

riccibruno marked 3 inline comments as done. riccibruno added inline comments. Comment at: include/clang/AST/Expr.h:5095 - SourceLocation getBeginLoc() const LLVM_READONLY { return GenericLoc; } - SourceLocation getEndLoc() const LLVM_READONLY { return RParenLoc; } --

[PATCH] D57106: [AST] Introduce GenericSelectionExpr::Association

riccibruno updated this revision to Diff 183314. riccibruno added a comment. Made `GenericSelectionExpr::AssociationIterator` a random access iterator. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57106/new/ https://reviews.llvm.org/D57106 Files: include/clan

r352055 - Fix failing buildbots

Author: martong Date: Thu Jan 24 07:42:20 2019 New Revision: 352055 URL: http://llvm.org/viewvc/llvm-project?rev=352055&view=rev Log: Fix failing buildbots Related commit which caused the buildbots to fail: rL352050 Modified: cfe/trunk/unittests/AST/StructuralEquivalenceTest.cpp Modified: c

Re: r347205 - [FileManager] getFile(open=true) after getFile(open=false) should open the file.

Sure. Op counts and linux benchmarks are easy, I could try to get access to mac/windows too... Building clang's HeaderSearch.cpp (without PCH) yields: master: fstat = 341, open = 1039, stat = 211 openFile=false: fstat = 9 (-332), open = 379 (-660), stat = 1203 (+992) revert: fstat = 341 (+0), open

[PATCH] D57150: [HeaderSearch] don't immediately request that headers are opened in getFileAndSuggestModule().

sammccall added a comment. Sigh, this regresses perf by 6%ish in my testing (building HeaderSearch.cpp with -fsyntax-only and a cold disk cache). I think we'll need a more targeted fix: probably passing openFile=false only in the using-PCH case. Plan for now is to revert the original change, li

[PATCH] D57160: [WebAssembly] Add an import_module function attribute

sunfish created this revision. sunfish added reviewers: sbc100, dschuff, aheejin. Herald added subscribers: llvm-commits, jgravelle-google. This adds a C/C++ attribute which corresponds to the LLVM IR wasm-import-module attribute. It allows code to specify an explicit import module. Repository:

[PATCH] D57162: [DEBUG_INFO][NVPTX] Generate correct data about variable address class.

ABataev created this revision. ABataev added reviewers: echristo, probinson. Herald added subscribers: aprantl, jholewinski. Added ability to generate correct debug info data about the variable address class. Currently, for all the locals and globals the default values are used, ADDR_local_space(6

r352060 - Fix failing buildbots

Author: martong Date: Thu Jan 24 08:27:21 2019 New Revision: 352060 URL: http://llvm.org/viewvc/llvm-project?rev=352060&view=rev Log: Fix failing buildbots Fix remaining unittest errors caused by __attribute__((no_caller_saved_registers)) Related commit which caused the buildbots to fail: rL35205

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

ruiu added a comment. In D56554#1357385 , @mgorny wrote: > @ruiu, what do you think? The current logic forces some precedence, i.e. if > you pass `-z nognustack`, further `-z {no,}execstack` are ignored. I suppose > we could just force passing `-z nognus

[PATCH] D57001: [libunwind] Don't define unw_fpreg_t to uint64_t for __ARM_DWARF_EH__

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. `double` should be safe for ARM DWARF EH, though, technically, `long double` is more appropriate of a type definition (the FPU state that is saved should be the widest floating point type)

[PATCH] D57106: [AST] Introduce GenericSelectionExpr::Association

aaron.ballman added reviewers: dblaikie, mclow.lists. aaron.ballman added subscribers: dblaikie, mclow.lists. aaron.ballman added a comment. Adding some additional reviewers to help tease out the iterator design questions. Comment at: include/clang/AST/Expr.h:5103 +using r

[PATCH] D50563: Fixed frontend clang tests in windows read-only container

justice_adams added a comment. @stella.stamenova thanks for the review. I don't have commit access, would you mind committing this for me? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50563/new/ https://reviews.llvm.org/D50563 ___ cfe-com

[PATCH] D57165: [FileManager] Revert r347205 to avoid PCH file-descriptor leak.

sammccall created this revision. sammccall added reviewers: bkramer, thakis. Herald added subscribers: cfe-commits, kadircet, ioeric, ilya-biryukov. r347205 fixed a bug in FileManager: first calling getFile(shouldOpen=false) and then getFile(shouldOpen=true) results in the file not being open. Un

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

mgorny added a comment. Just to be clear, are you suggesting that I add `-z gnustack` as well? Repository: rLLD LLVM Linker CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56554/new/ https://reviews.llvm.org/D56554 ___ cfe-commits mailing

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

ruiu added a comment. No, I'm suggesting you add execstack, noexecstack and nognustack as a tri-state -z flag. Does this sound good? Repository: rLLD LLVM Linker CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56554/new/ https://reviews.llvm.org/D56554 _

[PATCH] D54654: Correct CreateAlignmentAssumption to check sign and power-of-2 (Clang Part)

lebedev.ri abandoned this revision. lebedev.ri added a comment. As disscussed in D54653 (https://reviews.llvm.org/D54653#1318964), this differential will be simply unneeded, that review will address the issue too, so abandoning. Repository: rC Clang CHANGES

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

mgorny added a comment. In D56554#1369592 , @ruiu wrote: > No, I'm suggesting you add execstack, noexecstack and nognustack as a > tri-state -z flag. Does this sound good? Do you mean that of those three options, the last one specified should take prec

r352069 - Revert "[Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls"

Author: yln Date: Thu Jan 24 10:04:21 2019 New Revision: 352069 URL: http://llvm.org/viewvc/llvm-project?rev=352069&view=rev Log: Revert "[Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls" This reverts commit cea84ab93aeb079a358ab1c8aeba6d9140ef8b47. Modi

[PATCH] D57165: [FileManager] Revert r347205 to avoid PCH file-descriptor leak.

thakis added inline comments. Comment at: lib/Basic/FileManager.cpp:295 + llvm::sys::path::remove_dots(AbsPath, /*remove_dot_dot=*/true); + UFE.RealPathName = AbsPath.str(); +} Should this call fillRealPathName() (which was added after your change)?

[PATCH] D56624: [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls

yln reopened this revision. yln added a comment. In D56624#1368966 , @lebedev.ri wrote: > Please revert this. > First, this wasn't reviewed. > Second, the lists weren't subscribed. I apologize for this. It was not my intention to land the revision with

[PATCH] D57165: [FileManager] Revert r347205 to avoid PCH file-descriptor leak.

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. lgtm, but lebtm with call to fillRealPathName() Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57165/new/ https://reviews.llvm.org/D57165 __

[PATCH] D56624: [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls

lebedev.ri added a comment. In D56624#1369626 , @yln wrote: > In D56624#1368966 , @lebedev.ri > wrote: > > > Please revert this. > > First, this wasn't reviewed. > > Second, the lists weren't subscribed. > > > I

[PATCH] D56624: [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls

vsk added a comment. What are the advantages of a generalized expect_noreturn attribute, vs. a narrower attribute or intrinsic? The expect_noreturn semantics do not provide strong guarantees, and are not really orthogonal from the pre-existing cold attribute. In particular, expect_noreturn does

[PATCH] D57076: [ObjC generics] Fix applying `__kindof` to the type parameter.

vsapsai marked 2 inline comments as done. vsapsai added inline comments. Comment at: clang/lib/AST/Type.cpp:1293 + +const auto *newAttrType = dyn_cast(newType.getTypePtr()); +if (newAttrType->getAttrKind() != attr::ObjCKindOf) doug.gregor wrote: > Either

[PATCH] D56326: [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive

lildmh added inline comments. Comment at: lib/AST/DeclOpenMP.cpp:164 + if (NumClauses) { +Clauses = (OMPClause **)C.Allocate(sizeof(OMPClause *) * NumClauses); +setClauses(CL); ABataev wrote: > lildmh wrote: > > ABataev wrote: > > > lildmh wrote: > > > >

[PATCH] D57076: [ObjC generics] Fix applying `__kindof` to the type parameter.

vsapsai updated this revision to Diff 183338. vsapsai added a comment. - Address review comment: don't crash when AttributedType is transformed to another type class. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57076/new/ https://reviews.llvm.org/D57076 Files: clang/lib/AST/Type.c

r352079 - [FileManager] Revert r347205 to avoid PCH file-descriptor leak.

Author: sammccall Date: Thu Jan 24 10:55:24 2019 New Revision: 352079 URL: http://llvm.org/viewvc/llvm-project?rev=352079&view=rev Log: [FileManager] Revert r347205 to avoid PCH file-descriptor leak. Summary: r347205 fixed a bug in FileManager: first calling getFile(shouldOpen=false) and then get

[PATCH] D57165: [FileManager] Revert r347205 to avoid PCH file-descriptor leak.

sammccall updated this revision to Diff 183340. sammccall marked an inline comment as done. sammccall added a comment. avoid revert of fillRealPathName() (thanks Nico!) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57165/new/ https://reviews.llvm.org/D57165 File

[PATCH] D57165: [FileManager] Revert r347205 to avoid PCH file-descriptor leak.

This revision was automatically updated to reflect the committed changes. Closed by commit rC352079: [FileManager] Revert r347205 to avoid PCH file-descriptor leak. (authored by sammccall, committed by ). Changed prior to commit: https://reviews.llvm.org/D57165?vs=183340&id=183347#toc Reposito

[PATCH] D53199: Fix the behavior of clang's -w flag.

jyknight added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53199/new/ https://reviews.llvm.org/D53199 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D57175: [NFC][clang] Test updates for CreateAlignmentAssumption() changes in D54653

lebedev.ri created this revision. Depends on D54653 . Repository: rC Clang https://reviews.llvm.org/D57175 Files: test/CodeGen/alloc-align-attr.c test/CodeGen/catch-alignment-assumption-attribute-alloc_align-on-function-variable.cpp Index: test/CodeGe

[PATCH] D57150: [HeaderSearch] don't immediately request that headers are opened in getFileAndSuggestModule().

hans added a comment. In D57150#1369423 , @sammccall wrote: > Plan for now is to revert the original change, live with the things that are > broken, cherrypick the revert to the llvm8 branch, then revisit. Sgtm for 8.0. I see the revert landed in r35207

[PATCH] D57104: [AST] Pack GenericSelectionExpr

riccibruno updated this revision to Diff 183349. riccibruno marked 6 inline comments as done. riccibruno added a comment. Cleanup the patch by factoring out the NFC changes. @steveire This should be much clearer now. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D57106: [AST] Introduce GenericSelectionExpr::Association

riccibruno updated this revision to Diff 183352. riccibruno added a comment. Rebased on D57104 . No other changes. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57106/new/ https://reviews.llvm.org/D57106 Files: include/clang/AS

[PATCH] D56624: [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls

yln added a comment. @lebedev.ri Thanks for the clarifications! I will split this up into multiple patches once we settled on a design. In D56624#1369635 , @vsk wrote: > What are the advantages of a generalized expect_noreturn attribute, vs. a > narrower

Re: r347205 - [FileManager] getFile(open=true) after getFile(open=false) should open the file.

Reverted as r352079, with a test derived from this thread. https://bugs.llvm.org/show_bug.cgi?id=40448 to cherrypick to branch. I'll work on relanding a fixed version soon. Thanks again for investigating, and sorry for the trouble. On Thu, Jan 24, 2019 at 5:05 PM Sam McCall wrote: > Sure. Op co

r352084 - Add a priority field to availability attributes to prioritize explicit

Author: arphaman Date: Thu Jan 24 11:14:39 2019 New Revision: 352084 URL: http://llvm.org/viewvc/llvm-project?rev=352084&view=rev Log: Add a priority field to availability attributes to prioritize explicit attributes from declaration over attributes from '#pragma clang attribute' Before this comm

[PATCH] D56892: Add a priority field to availability attributes to prioritize explicit attributes from declaration over attributes from '#pragma clang attribute'

This revision was automatically updated to reflect the committed changes. Closed by commit rL352084: Add a priority field to availability attributes to prioritize explicit (authored by arphaman, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.ll

[PATCH] D57175: [NFC][clang] Test updates for CreateAlignmentAssumption() changes in D54653

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Self-accepting since D54653 got reviewed. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57175/new/ https://reviews.ll

[PATCH] D50452: [WIP] clangd XPC adapter

jkorous added a comment. Abandonned in favor of https://reviews.llvm.org/D54428 Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50452/new/ https://reviews.llvm.org/D50452 ___ cfe-commits mailing list cfe-

[PATCH] D56624: [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls

vsk added a comment. In D56624#1369767 , @yln wrote: > In D56624#1369635 , @vsk wrote: > > > What are the advantages of a generalized expect_noreturn attribute, vs. a > > narrower attribute or intrinsic? The expect

[PATCH] D14686: Protect against overloaded comma in random_shuffle and improve tests

mclow.lists closed this revision. mclow.lists added a comment. Herald added a subscriber: llvm-commits. (Finally) committed this as revision 352087. I cut out most of the random_shuffle_rand.pass.cpp test, because it relied on C++11 features, and didn't work for C++03. If you want to re-submit th

[clang-tools-extra] r352088 - [clang-tidy] Rename the absl duration helper functions; NFC

Author: hwright Date: Thu Jan 24 11:23:50 2019 New Revision: 352088 URL: http://llvm.org/viewvc/llvm-project?rev=352088&view=rev Log: [clang-tidy] Rename the absl duration helper functions; NFC Modified: clang-tools-extra/trunk/clang-tidy/abseil/DurationComparisonCheck.cpp clang-tools-ext

[PATCH] D57155: [WebAssembly] Add a __wasi__ target macro

dschuff accepted this revision. dschuff added a comment. This revision is now accepted and ready to land. LGTM; don't forget to include all the context in the future Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57155/new/ https://reviews.llvm.org/D57155 __

[PATCH] D57175: [NFC][clang] Test updates for CreateAlignmentAssumption() changes in D54653

This revision was automatically updated to reflect the committed changes. Closed by commit rL352090: [NFC][clang] Test updates for CreateAlignmentAssumption() changes in D54653 (authored by lebedevri, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

r352090 - [NFC][clang] Test updates for CreateAlignmentAssumption() changes in D54653

Author: lebedevri Date: Thu Jan 24 11:32:49 2019 New Revision: 352090 URL: http://llvm.org/viewvc/llvm-project?rev=352090&view=rev Log: [NFC][clang] Test updates for CreateAlignmentAssumption() changes in D54653 Differential Revision: https://reviews.llvm.org/D57175 Modified: cfe/trunk/test/

[PATCH] D57104: [AST] Pack GenericSelectionExpr

steveire added a comment. Thanks, but I don't see the factored out changes in the repo. Are you going to commit those first? Also, please factor out the introduction and use of `::Create`. It seems to be unrelated to the trailing objects change. Repository: rC Clang CHANGES SINCE LAST ACTI

LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D57104: [AST] Pack GenericSelectionExpr

riccibruno added a comment. In D57104#1369864 , @steveire wrote: > Thanks, but I don't see the factored out changes in the repo. Are you going > to commit those first? > > Also, please factor out the introduction and use of `::Create`. It seems to > be u

r352099 - [WebAssembly] Factor commonality between wasm32 and wasm64 in test/Preprocessor/init.c

Author: djg Date: Thu Jan 24 12:31:11 2019 New Revision: 352099 URL: http://llvm.org/viewvc/llvm-project?rev=352099&view=rev Log: [WebAssembly] Factor commonality between wasm32 and wasm64 in test/Preprocessor/init.c Use the -check-prefixes= feature to merge most of the WEBASSEMBLY32 and WEBASSE

r352100 - [WebAssembly] Support __float128

Author: djg Date: Thu Jan 24 12:33:28 2019 New Revision: 352100 URL: http://llvm.org/viewvc/llvm-project?rev=352100&view=rev Log: [WebAssembly] Support __float128 This enables support for the "__float128" keyword. Differential Revision: https://reviews.llvm.org/D57154 Modified: cfe/trunk/li

[PATCH] D57154: [WebAssembly] Support __float128

This revision was automatically updated to reflect the committed changes. Closed by commit rC352100: [WebAssembly] Support __float128 (authored by djg, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D57154?vs=183302&id=183369#toc Repos

[PATCH] D56561: [Preprocessor] For missing file in framework add note about framework location.

jkorous accepted this revision. jkorous added a comment. This revision is now accepted and ready to land. LGTM with nits about doxygen annotations. Comment at: clang/include/clang/Lex/DirectoryLookup.h:175 + /// \param [out] IsFrameworkFound For a framework directory set to tr

[PATCH] D56411: [CUDA][HIP][Sema] Fix template kernel with function as template parameter

yaxunl added a comment. In D56411#1365745 , @rjmccall wrote: > In D56411#1365727 , @yaxunl wrote: > > > In D56411#1360010 , @rjmccall > > wrote: > > > > > I think the diagno

[PATCH] D57057: [clangd] Log clang-tidy configuration, NFC

jkorous accepted this revision. jkorous added a comment. This revision is now accepted and ready to land. LGTM Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57057/new/ https://reviews.llvm.org/D57057 __

  1   2   >