jkorous accepted this revision. jkorous added a comment. This revision is now accepted and ready to land.
LGTM with nits about doxygen annotations. ================ Comment at: clang/include/clang/Lex/DirectoryLookup.h:175 + /// \param [out] IsFrameworkFound For a framework directory set to true if + /// specified '.framework' directory is found. + /// ---------------- We might make this easier to understand by explaining where/how the '.framework' directory is specified. ================ Comment at: clang/include/clang/Lex/HeaderSearch.h:396 + /// \param IsFrameworkFound If non-null, will be set to true for a framework + /// include and if corresponding '.framework' directory was found. Doesn't + /// guarantee the requested file is found. ---------------- We might try to explain what exactly is meant by corresponding .framework directory. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56561/new/ https://reviews.llvm.org/D56561 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
