[PATCH] D55710: add pragmas to control Software Pipelining optimisation

alexey.lapshin marked 2 inline comments as done. alexey.lapshin added inline comments. Comment at: include/clang/Basic/AttrDocs.td:2655 + dependence violated. This constant interval(in cycles) between the start + of iterations called initiation interval. Cycles number of one it

[PATCH] D55710: add pragmas to control Software Pipelining optimisation

alexey.lapshin updated this revision to Diff 179459. alexey.lapshin added a comment. please consider changes in AttrDocs.td CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55710/new/ https://reviews.llvm.org/D55710 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td

[PATCH] D56059: [gn build] Add build files for clang/tools/{c-arcmt-test, c-index-test} and their dependency clang/tools/libclang

phosek accepted this revision. phosek marked an inline comment as done. phosek added a comment. This revision is now accepted and ready to land. LGTM Comment at: llvm/utils/gn/secondary/clang/tools/libclang/BUILD.gn:16-17 +if (host_os == "linux") { + # Linux needs -fPIC to bui

[PATCH] D47817: [compiler-rt] [sanitizer_common] Fix using libtirpc on Linux

mgorny updated this revision to Diff 179460. mgorny added a comment. Herald added subscribers: srhines, emaste. Updated as requested by @Lekensteyn CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47817/new/ https://reviews.llvm.org/D47817 Files: cmake/Modules/FindLibtirpc.cmake lib/s

[PATCH] D47817: [compiler-rt] [sanitizer_common] Fix using libtirpc on Linux

krytarowski added a comment. If libtirpc is from an external library we shall not sanitize it. If it is a part of libc (on glibc? on solaris?) it shall be sanitized only there. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47817/new/ https://reviews.llvm.org/D47817 _

[PATCH] D56025: [clang-tidy] add IgnoreMacros option to readability-uppercase-literal-suffix

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. LG i guess. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56025/new/ https://reviews.llvm.org/D56025 ___ cfe-commits mailing lis

[PATCH] D55948: Modify DeclaratorChuck::getFunction to use DeclSpec for qualifiers

Anastasia updated this revision to Diff 179469. Anastasia added a comment. - Changed to store DeclSpec only when quals are present. - Renamed to MethodQualifiers. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55948/new/ https://reviews.llvm.org/D55948 Files: include/clang/Sema/DeclSp

[PATCH] D55948: Modify DeclaratorChuck::getFunction to use DeclSpec for qualifiers

Anastasia marked 3 inline comments as done. Anastasia added inline comments. Comment at: lib/Parse/ParseDecl.cpp:6129 + // create DeclSpec here to be populated later. + DS = new DeclSpec(AttrFactory); + rjmccall wrote: > Is it possible to just build int

[PATCH] D56025: [clang-tidy] add IgnoreMacros option to readability-uppercase-literal-suffix

JonasToth accepted this revision. JonasToth added a comment. LGTM, do you have commit rights? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56025/new/ https://reviews.llvm.org/D56025 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

JonasToth added a comment. Sorry for my absence the last week, holidays came in between. I will take a look at the code again and try to find a robuster way of template-type detection :) I do have an idea, but not sure if that works as expected (within this week). Sorry again! CHANGES SINCE L

[PATCH] D56059: [gn build] Add build files for clang/tools/{c-arcmt-test, c-index-test} and their dependency clang/tools/libclang

This revision was automatically updated to reflect the committed changes. Closed by commit rL350054: [gn build] Add build files for clang/tools/{c-arcmt-test,c-index-test} and… (authored by nico, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.l

[PATCH] D56059: [gn build] Add build files for clang/tools/{c-arcmt-test, c-index-test} and their dependency clang/tools/libclang

thakis marked an inline comment as done. thakis added a comment. Thanks Comment at: llvm/utils/gn/secondary/clang/tools/libclang/BUILD.gn:16-17 +if (host_os == "linux") { + # Linux needs -fPIC to build shared libs but they aren't on by default. + # For now, make libclang a st

[PATCH] D56065: [gn build] Make NOSORT line actually work

thakis created this revision. thakis added a reviewer: phosek. GN wants the NOSORT line to be the first line of a comment block, not the last line. I sent https://gn-review.googlesource.com/c/gn/+/3560 to support having it in the last line too, but since it will be a while until everyone has th

[PATCH] D55955: Properly diagnose [[nodiscard]] on the body of a range-based for loop

aaron.ballman updated this revision to Diff 179475. aaron.ballman marked 3 inline comments as done. aaron.ballman added a comment. Updated based on review feedback. The lookahead wasn't too annoying to thread through, but I did run into surprises in TreeTransform where I can't use the lookahead

[clang-tools-extra] r350056 - [clang-tidy] add IgnoreMacros option to readability-uppercase-literal-suffix

Author: vmiklos Date: Mon Dec 24 09:47:32 2018 New Revision: 350056 URL: http://llvm.org/viewvc/llvm-project?rev=350056&view=rev Log: [clang-tidy] add IgnoreMacros option to readability-uppercase-literal-suffix And also enable it by default to be consistent with e.g. modernize-use-using. This he

[PATCH] D56025: [clang-tidy] add IgnoreMacros option to readability-uppercase-literal-suffix

This revision was automatically updated to reflect the committed changes. vmiklos marked an inline comment as done. Closed by commit rL350056: [clang-tidy] add IgnoreMacros option to readability-uppercase-literal-suffix (authored by vmiklos, committed by ). Herald added a subscriber: llvm-commits.

[PATCH] D56025: [clang-tidy] add IgnoreMacros option to readability-uppercase-literal-suffix

vmiklos added a comment. In D56025#1340618 , @JonasToth wrote: > LGTM, do you have commit rights? Yes, thanks. Committed now. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56025/new/ https://reviews.llvm.org/D56025 __

[PATCH] D55955: Properly diagnose [[nodiscard]] on the body of a range-based for loop

rsmith added inline comments. Comment at: include/clang/Sema/Sema.h:5337 ExprResult ActOnFinishFullExpr(Expr *Expr, SourceLocation CC, - bool DiscardedValue = false, + bool WarnOnDiscardedValue = false,

[PATCH] D56066: [OpenCL] Address space for default class members

Anastasia created this revision. Anastasia added reviewers: rjmccall, ebevhan. Herald added a subscriber: yaxunl. Fixed several issues reported in https://reviews.llvm.org/D55656 and https://reviews.llvm.org/D54862 - mainly removed addr space from the `QualType` of the method itself. This shoul

[PATCH] D55656: [OpenCL] Address space for default class members

Anastasia added inline comments. Comment at: lib/AST/ASTContext.cpp:2781 + + return getAddrSpaceQualType(NewT, Orig.getAddressSpace()); } ebevhan wrote: > rjmccall wrote: > > Anastasia wrote: > > > rjmccall wrote: > > > > You're trying to handle a method qualif

[PATCH] D55656: [OpenCL] Address space for default class members

Anastasia requested changes to this revision. Anastasia added a comment. This revision now requires changes to proceed. @mikael can you please close this review, because I opened another one to continue this: https://reviews.llvm.org/D56066. Thanks for your work! Repository: rC Clang CHANGE

r350057 - [analyzer] [NFC] Clean up the mess of constructing argument effects in RetainCountChecker

Author: george.karpenkov Date: Mon Dec 24 10:45:18 2018 New Revision: 350057 URL: http://llvm.org/viewvc/llvm-project?rev=350057&view=rev Log: [analyzer] [NFC] Clean up the mess of constructing argument effects in RetainCountChecker Previously, argument effects were stored in a method variable,

[PATCH] D55955: Properly diagnose [[nodiscard]] on the body of a range-based for loop

aaron.ballman marked 3 inline comments as done. aaron.ballman added inline comments. Comment at: include/clang/Sema/Sema.h:5337 ExprResult ActOnFinishFullExpr(Expr *Expr, SourceLocation CC, - bool DiscardedValue = false, +

[PATCH] D56067: Make test/Driver/darwin-sdk-version.c pass if the host triple is 32-bit

thakis created this revision. thakis added a reviewer: arphaman. For some reason, the cmake build on my macbook has LLVM_HOST_TRIPLE:STRING=i386-apple-darwin16.7.0 . test/Driver/darwin-sdk-version.c assumed that the host triple is 64-bit, so make it resilient against 32-bit host triples. http

[PATCH] D55955: Properly diagnose [[nodiscard]] on the body of a range-based for loop

Quuxplusone added inline comments. Comment at: include/clang/Sema/Sema.h:5337 ExprResult ActOnFinishFullExpr(Expr *Expr, SourceLocation CC, - bool DiscardedValue = false, + bool WarnOnDiscardedValue = false,

[PATCH] D56065: [gn build] Make NOSORT line actually work

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56065/new/ https://reviews.llvm.org/D56065 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D56065: [gn build] Make NOSORT line actually work

This revision was automatically updated to reflect the committed changes. Closed by commit rL350060: [gn build] Make NOSORT line actually work (authored by nico, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D56065?vs=179474&id=179480