phosek accepted this revision.
phosek marked an inline comment as done.
phosek added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: llvm/utils/gn/secondary/clang/tools/libclang/BUILD.gn:16-17
+if (host_os == "linux") {
+ # Linux needs -fPIC to build shared libs but they aren't on by default.
+ # For now, make libclang a static lib there.
+ libclang_target_type = "static_library"
----------------
We can solve this with toolchains, i.e. have a variant of the default toolchain
that includes `-fPIC` which will be used to build `libClang.so`. Not something
to do in this change, but definitely something we should look into in the
future.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56059/new/
https://reviews.llvm.org/D56059
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
