[PATCH] D55916: [clang] Replace getOS() == llvm::Triple::*BSD with isOS*BSD() [NFCI]

mgorny created this revision. mgorny added a reviewer: krytarowski. Herald added subscribers: jsji, atanasyan, jrtc27, fedor.sergeev, kbarton, javed.absar, nemanjai, sdardis, emaste, jyknight. Replace multiple comparisons of getOS() value with FreeBSD, NetBSD, OpenBSD and DragonFly with matching

[PATCH] D55916: [clang] Replace getOS() == llvm::Triple::*BSD with isOS*BSD() [NFCI]

mgorny updated this revision to Diff 179021. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55916/new/ https://reviews.llvm.org/D55916 Files: lib/Basic/Targets/AArch64.cpp lib/Basic/Targets/ARM.cpp lib/Basic/Targets/Mips.h lib/Basic/Targets/PPC.cpp lib/Basic/Targets/PPC.h lib/

[PATCH] D55552: [Sema] Better static assert diagnostics for expressions involving temporaries.

courbet added a comment. Thanks for the comments ! Comment at: include/clang/AST/Type.h:995 void getAsStringInternal(std::string &Str, - const PrintingPolicy &Policy) const { -return getAsStringInternal(split(), Str, Policy); - } +

r349729 - [Sema] Better static assert diagnostics for expressions involving temporaries/casts/....

Author: courbet Date: Thu Dec 20 01:05:15 2018 New Revision: 349729 URL: http://llvm.org/viewvc/llvm-project?rev=349729&view=rev Log: [Sema] Better static assert diagnostics for expressions involving temporaries/casts/ Summary: Handles expressions such as: - `std::is_const()` - `std::is_co

[PATCH] D55552: [Sema] Better static assert diagnostics for expressions involving temporaries.

This revision was automatically updated to reflect the committed changes. Closed by commit rL349729: [Sema] Better static assert diagnostics for expressions involving… (authored by courbet, committed by ). Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D2/new/ ht

[PATCH] D55916: [clang] Replace getOS() == llvm::Triple::*BSD with isOS*BSD() [NFCI]

krytarowski added inline comments. Comment at: lib/Basic/Targets/ARM.cpp:285 default: - if (Triple.getOS() == llvm::Triple::NetBSD) + if (Triple.isOSNetBSD()) setABI("apcs-gnu"); Actually we could use IsNetBSD and IsOpenBSD here. CHANGES

[PATCH] D55918: [clangd] Don't miss the expected type in merge.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D55918 Files: clangd/index/Merge.cpp unittests/clangd/IndexTests.cpp Index: unittests/

[PATCH] D55916: [clang] Replace getOS() == llvm::Triple::*BSD with isOS*BSD() [NFCI]

mgorny updated this revision to Diff 179031. mgorny marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55916/new/ https://reviews.llvm.org/D55916 Files: lib/Basic/Targets/AArch64.cpp lib/Basic/Targets/ARM.cpp lib/Basic/Targets/Mips.h lib/Basic/Targets

[PATCH] D55916: [clang] Replace getOS() == llvm::Triple::*BSD with isOS*BSD() [NFCI]

mgorny added inline comments. Comment at: lib/Basic/Targets/ARM.cpp:285 default: - if (Triple.getOS() == llvm::Triple::NetBSD) + if (Triple.isOSNetBSD()) setABI("apcs-gnu"); krytarowski wrote: > Actually we could use IsNetBSD and IsOpenBSD

[PATCH] D55862: [Sema] Don't try to account for the size of an incomplete type in CheckArrayAccess

riccibruno updated this revision to Diff 179035. riccibruno added a comment. Used `ArrayTy->getElementType()` Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55862/new/ https://reviews.llvm.org/D55862 Files: lib/Sema/SemaChecking.cpp test/SemaCXX/array-bounds.

[PATCH] D42043: c-index: CXString: fix MSAN read-past-end bug

riccibruno added a comment. Is anyone working on this ? This is the only persistent msan failure when doing `check-clang` on my machine. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D42043/new/ https://reviews.llvm.org/D42043 _

r349743 - [X86][SSE] Auto upgrade PADDS/PSUBS intrinsics to SADD_SAT/SSUB_SAT generic intrinsics (clang)

Author: rksimon Date: Thu Dec 20 03:53:45 2018 New Revision: 349743 URL: http://llvm.org/viewvc/llvm-project?rev=349743&view=rev Log: [X86][SSE] Auto upgrade PADDS/PSUBS intrinsics to SADD_SAT/SSUB_SAT generic intrinsics (clang) This emits SADD_SAT/SSUB_SAT generic intrinsics for the SSE signed

[PATCH] D55890: [X86][SSE] Auto upgrade PADDS/PSUBS intrinsics to SADD_SAT/SSUB_SAT generic intrinsics (clang)

This revision was automatically updated to reflect the committed changes. Closed by commit rL349743: [X86][SSE] Auto upgrade PADDS/PSUBS intrinsics to SADD_SAT/SSUB_SAT generic… (authored by RKSimon, committed by ). Changed prior to commit: https://reviews.llvm.org/D55890?vs=178946&id=179036#to

[PATCH] D55363: [clangd] Expose FileStatus in LSP.

hokein updated this revision to Diff 179041. hokein marked 3 inline comments as done. hokein added a comment. address review comments. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55363/new/ https://reviews.llvm.org/D55363 Files: clangd/ClangdLS

[PATCH] D55363: [clangd] Expose FileStatus in LSP.

hokein added a comment. In D55363#1336315 , @ilya-biryukov wrote: > Could we add a capability to the init request to check for this extension? We > don't want to send those notifications to clients that don't have the code to > handle them. yes, I thi

[PATCH] D55918: [clangd] Don't miss the expected type in merge.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55918/new/ https://reviews.llvm.org/D55918 _

[clang-tools-extra] r349750 - [clangd] Don't miss the expected type in merge.

Author: hokein Date: Thu Dec 20 05:05:46 2018 New Revision: 349750 URL: http://llvm.org/viewvc/llvm-project?rev=349750&view=rev Log: [clangd] Don't miss the expected type in merge. Reviewers: ilya-biryukov Subscribers: ioeric, MaskRay, jkorous, arphaman, kadircet, cfe-commits Differential Revis

[PATCH] D55918: [clangd] Don't miss the expected type in merge.

This revision was automatically updated to reflect the committed changes. Closed by commit rL349750: [clangd] Don't miss the expected type in merge. (authored by hokein, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llv

r349751 - [SystemZ] Fix wrong codegen caused by typos in vecintrin.h

Author: uweigand Date: Thu Dec 20 05:09:09 2018 New Revision: 349751 URL: http://llvm.org/viewvc/llvm-project?rev=349751&view=rev Log: [SystemZ] Fix wrong codegen caused by typos in vecintrin.h The following two bugs in SystemZ high-level vector intrinsics are fixes by this patch: - The float ca

r349752 - Replace getOS() == llvm::Triple::*BSD with isOS*BSD() [NFCI]

Author: mgorny Date: Thu Dec 20 05:09:30 2018 New Revision: 349752 URL: http://llvm.org/viewvc/llvm-project?rev=349752&view=rev Log: Replace getOS() == llvm::Triple::*BSD with isOS*BSD() [NFCI] Replace multiple comparisons of getOS() value with FreeBSD, NetBSD, OpenBSD and DragonFly with matching

[PATCH] D55363: [clangd] Expose FileStatus in LSP.

ilya-biryukov added inline comments. Comment at: clangd/Protocol.cpp:769 O.map("fallbackFlags", Opts.fallbackFlags); + O.map("fileStatus", Opts.FileStatus); return true; Ah, there's a non-zero chance of name clash here in case the protocol implements some

[PATCH] D55916: [clang] Replace getOS() == llvm::Triple::*BSD with isOS*BSD() [NFCI]

This revision was automatically updated to reflect the committed changes. Closed by commit rC349752: Replace getOS() == llvm::Triple::*BSD with isOS*BSD() [NFCI] (authored by mgorny, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55916/new/ https://

[PATCH] D55628: Add support for "labels" on push/pop directives in #pragma clang attribute

aaron.ballman accepted this revision. aaron.ballman marked an inline comment as done. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/Parse/ParsePragma.cpp:3161 + if (!Tok.is(tok::period)) { +PP.Diag(Tok.g

[PATCH] D55363: [clangd] Expose FileStatus in LSP.

hokein updated this revision to Diff 179046. hokein marked 4 inline comments as done. hokein added a comment. Remove details. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55363/new/ https://reviews.llvm.org/D55363 Files: clangd/ClangdLSPServer.c

[PATCH] D55363: [clangd] Expose FileStatus in LSP.

hokein updated this revision to Diff 179047. hokein added a comment. Rebase Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55363/new/ https://reviews.llvm.org/D55363 Files: clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h clangd/Protocol.cp

[PATCH] D55363: [clangd] Expose FileStatus in LSP.

hokein added inline comments. Comment at: clangd/index/Merge.cpp:137 S.ReturnType = O.ReturnType; + if (S.Type == "") +S.Type = O.Type; ilya-biryukov wrote: > Accidental change? oops, I rebased this branch on top of my another branch. Fixed. Repositor

[PATCH] D55710: add pragmas to control Software Pipelining optimisation

aaron.ballman added inline comments. Comment at: include/clang/Basic/AttrDocs.td:2673 + +Check `Software pipelining`, `Modulo scheduling` to get more details on optimisation. + "Check" -- check where? Perhaps "Search for" but I still don't think that's very sat

r349754 - [Driver] Fix accidentally reversed condition in r349752

Author: mgorny Date: Thu Dec 20 05:27:37 2018 New Revision: 349754 URL: http://llvm.org/viewvc/llvm-project?rev=349754&view=rev Log: [Driver] Fix accidentally reversed condition in r349752 Modified: cfe/trunk/lib/Driver/ToolChains/CommonArgs.cpp Modified: cfe/trunk/lib/Driver/ToolChains/Comm

r349755 - [Sema][NFC] Add test for static_assert diagnistics with constexpr template functions.

Author: courbet Date: Thu Dec 20 05:30:40 2018 New Revision: 349755 URL: http://llvm.org/viewvc/llvm-project?rev=349755&view=rev Log: [Sema][NFC] Add test for static_assert diagnistics with constexpr template functions. Modified: cfe/trunk/test/SemaCXX/static-assert-cxx17.cpp Modified: cfe/

[PATCH] D55710: add pragmas to control Software Pipelining optimisation

alexey.lapshin marked an inline comment as done. alexey.lapshin added inline comments. Comment at: include/clang/Basic/AttrDocs.td:2673 + +Check `Software pipelining`, `Modulo scheduling` to get more details on optimisation. + aaron.ballman wrote: > "Check" -- c

[PATCH] D55916: [clang] Replace getOS() == llvm::Triple::*BSD with isOS*BSD() [NFCI]

uweigand added a comment. This causes test case failures due to no longer linking with -lrt on Linux. Comment at: lib/Driver/ToolChains/CommonArgs.cpp:606 CmdArgs.push_back("-lpthread"); -if (TC.getTriple().getOS() != llvm::Triple::OpenBSD) +if (TC.getTriple().isOS

[PATCH] D55916: [clang] Replace getOS() == llvm::Triple::*BSD with isOS*BSD() [NFCI]

uweigand added a comment. In D55916#1337427 , @uweigand wrote: > This causes test case failures due to no longer linking with -lrt on Linux. Never mind, already fixed :-) Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D55912: [gn build] Add build files for clang/lib/Lex and clang/lib/AST

This revision was automatically updated to reflect the committed changes. Closed by commit rL349756: [gn build] Add build files for clang/lib/Lex and clang/lib/AST (authored by nico, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D5591

[PATCH] D55710: add pragmas to control Software Pipelining optimisation

aaron.ballman added inline comments. Comment at: include/clang/Basic/AttrDocs.td:2673 + +Check `Software pipelining`, `Modulo scheduling` to get more details on optimisation. + alexey.lapshin wrote: > aaron.ballman wrote: > > "Check" -- check where? Perhaps "Sea

[PATCH] D55913: [gn build] Add build files for clang/lib/{Analysis, Edit, Sema}

This revision was automatically updated to reflect the committed changes. Closed by commit rL349757: [gn build] Add build files for clang/lib/{Analysis,Edit,Sema} (authored by nico, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D55913

[clang-tools-extra] r349758 - [clang-tidy] Use translationUnitDecl() instead of a custom matcher.

Author: alexfh Date: Thu Dec 20 05:50:04 2018 New Revision: 349758 URL: http://llvm.org/viewvc/llvm-project?rev=349758&view=rev Log: [clang-tidy] Use translationUnitDecl() instead of a custom matcher. Modified: clang-tools-extra/trunk/clang-tidy/readability/SimplifyBooleanExprCheck.cpp cl

[PATCH] D55924: [gn build] Add build files for clang-format and lib/{Format, Rewrite, Tooling/Core, Tooling/Inclusions}

thakis created this revision. thakis added a reviewer: phosek. https://reviews.llvm.org/D55924 Files: llvm/utils/gn/secondary/BUILD.gn llvm/utils/gn/secondary/clang/lib/Format/BUILD.gn llvm/utils/gn/secondary/clang/lib/Rewrite/BUILD.gn llvm/utils/gn/secondary/clang/lib/Tooling/Core/BUILD.

[PATCH] D55925: [gn build] Add build file for clang/lib/Parse

thakis created this revision. thakis added a reviewer: phosek. Nothing really interesting. One thing to consider is where the clang_tablegen() invocations that generate files that are private to a library should be. The CMake build puts them in clang/include/clang/Parse (in this case), but maybe

Re: r311958 - Revert "Revert r311552: [Bash-autocompletion] Add support for static analyzer flags"

Have you had a chance to look at making this change? On Mon, Apr 9, 2018 at 9:08 AM Yuka Takahashi wrote: > Sounds good! > > 2018-04-09 15:03 GMT+02:00 Nico Weber : > >> Yes. >> >> On Mon, Apr 9, 2018 at 9:00 AM, Yuka Takahashi wrote: >> >>> Hi Nico, >>> >>> Thanks for your comment! >>> >>> I d

[PATCH] D55927: [gn build] Add build file for clang/lib/Driver

thakis created this revision. thakis added a reviewer: phosek. Herald added subscribers: fedor.sergeev, aheejin, dschuff. Mostly boring, except for the spurious dependency on StaticAnalyzer/Checkers -- see comments in the code. https://reviews.llvm.org/D55927 Files: llvm/utils/gn/secondary/B

[PATCH] D55928: [OpenMP] Add flag for preventing the extension to 64 bits for the collapse loop counter

gtbercea created this revision. gtbercea added reviewers: ABataev, caomhin. Herald added subscribers: cfe-commits, guansong. Introduce a compiler flag for cases when the user knows that the collapsed loop counter can be safely represented using at most 32 bits. This will prevent the emission of

[PATCH] D55927: [gn build] Add build file for clang/lib/Driver

thakis updated this revision to Diff 179067. thakis added a comment. sync CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55927/new/ https://reviews.llvm.org/D55927 Files: llvm/utils/gn/secondary/BUILD.gn llvm/utils/gn/secondary/clang/include/clang/Driver/BUILD.gn llvm/utils/gn/sec

Re: r311958 - Revert "Revert r311552: [Bash-autocompletion] Add support for static analyzer flags"

Sorry I totally forgot. Taking a look now, I will add you to a reviewer when I have an alternative patch! Thanks for the reminder. On Thu, 20 Dec 2018 at 15:20, Nico Weber wrote: > > Have you had a chance to look at making this change? > > On Mon, Apr 9, 2018 at 9:08 AM Yuka Takahashi wrote: >>

[PATCH] D55928: [OpenMP] Add flag for preventing the extension to 64 bits for the collapse loop counter

ABataev added inline comments. Comment at: docs/OpenMPSupport.rst:119 +time. To prevent this conservative choice and use at most 32 bits, +compile your program with the `-fopenmp-max-32bit-collapse-width`. + -fopenmp-optimistic-collapse Comment

[PATCH] D55930: [gn build] Add build files for clang/lib/{Frontend, Frontend/Rewrite, Serialization}

thakis created this revision. thakis added a reviewer: phosek. https://reviews.llvm.org/D55930 Files: llvm/utils/gn/secondary/BUILD.gn llvm/utils/gn/secondary/clang/include/clang/Serialization/BUILD.gn llvm/utils/gn/secondary/clang/lib/Frontend/BUILD.gn llvm/utils/gn/secondary/clang/lib/F

[PATCH] D55928: [OpenMP] Add flag for preventing the extension to 64 bits for the collapse loop counter

kkwli0 added inline comments. Comment at: docs/OpenMPSupport.rst:119 +time. To prevent this conservative choice and use at most 32 bits, +compile your program with the `-fopenmp-max-32bit-collapse-width`. + ABataev wrote: > -fopenmp-optimistic-collapse How about

[PATCH] D55931: [gn build] Add build file for clang/lib/CodeGen and llvm/lib/ProfileData/Coverage

thakis created this revision. thakis added a reviewer: phosek. Herald added subscribers: jfb, hiraditya. https://reviews.llvm.org/D55931 Files: llvm/utils/gn/secondary/BUILD.gn llvm/utils/gn/secondary/clang/lib/CodeGen/BUILD.gn llvm/utils/gn/secondary/llvm/lib/ProfileData/Coverage/BUILD.gn

[PATCH] D55928: [OpenMP] Add flag for preventing the extension to 64 bits for the collapse loop counter

gtbercea updated this revision to Diff 179076. gtbercea marked 4 inline comments as done. gtbercea edited the summary of this revision. gtbercea added a comment. - Address comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55928/new/ https://reviews.llvm.org

[PATCH] D55928: [OpenMP] Add flag for preventing the extension to 64 bits for the collapse loop counter

gtbercea added inline comments. Comment at: include/clang/Basic/LangOptions.def:210 LANGOPT(OpenMPCUDABlocksPerSM , 32, 0, "Number of blocks per SM for CUDA devices.") +LANGOPT(OpenMPMax32BitCollapseWidth , 1, 0, "Use at most 32 bits to represent the collapsed loop nest coun

[PATCH] D55928: [OpenMP] Add flag for preventing the extension to 64 bits for the collapse loop counter

ABataev added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:4429 Args.AddAllArgs(CmdArgs, options::OPT_fopenmp_cuda_blocks_per_sm_EQ); + Args.AddLastArg(CmdArgs, options::OPT_fopenmp_optimistic_collapse, + options::OPT_fno_openmp_op

[PATCH] D55363: [clangd] Expose FileStatus in LSP.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55363/new/ https://reviews.llvm.org/D55363 __

[PATCH] D55932: [Sema] Simplfy static_assert diagnostic code.

courbet created this revision. courbet added reviewers: aaron.ballman, Quuxplusone. We can now remove the specific handling of NestedNameQualifiers as it's now handled by the type printer as of r349729. Repository: rC Clang https://reviews.llvm.org/D55932 Files: include/clang/AST/NestedNam

[PATCH] D55933: [Sema] Do not print default template parameters.

courbet created this revision. courbet added reviewers: aaron.ballman, Quuxplusone. As a followup to D55270 . Repository: rC Clang https://reviews.llvm.org/D55933 Files: include/clang/AST/NestedNameSpecifier.h lib/AST/NestedNameSpecifier.cpp lib/AST/Typ

[PATCH] D55928: [OpenMP] Add flag for preventing the extension to 64 bits for the collapse loop counter

gtbercea updated this revision to Diff 179078. gtbercea added a comment. - Address comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55928/new/ https://reviews.llvm.org/D55928 Files: docs/OpenMPSupport.rst include/clang/Basic/LangOptions.def include/

[PATCH] D55928: [OpenMP] Add flag for preventing the extension to 64 bits for the collapse loop counter

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55928/new/ https://reviews.llvm.org/D55928 ___ cfe-commits ma

[clang-tools-extra] r349768 - [clangd] Expose FileStatus to LSP.

Author: hokein Date: Thu Dec 20 07:39:12 2018 New Revision: 349768 URL: http://llvm.org/viewvc/llvm-project?rev=349768&view=rev Log: [clangd] Expose FileStatus to LSP. Summary: Add an LSP extension "textDocument/clangd.fileStatus" to emit file-status information. Reviewers: ilya-biryukov Subsc

[PATCH] D55363: [clangd] Expose FileStatus in LSP.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE349768: [clangd] Expose FileStatus to LSP. (authored by hokein, committed by ). Changed prior to commit: https://reviews.llvm.org/D55363?vs=179047&id=179080#toc Repository: rCTE Clang Tools Extra

[PATCH] D55928: [OpenMP] Add flag for preventing the extension to 64 bits for the collapse loop counter

gtbercea added inline comments. Comment at: docs/OpenMPSupport.rst:119 +time. To prevent this conservative choice and use at most 32 bits, +compile your program with the `-fopenmp-max-32bit-collapse-width`. + kkwli0 wrote: > ABataev wrote: > > -fopenmp-optimistic

[PATCH] D55374: [clangd] Show FileStatus in vscode-clangd.

hokein updated this revision to Diff 179082. hokein added a comment. Update the patch to reflect LSP file status latest change. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55374/new/ https://reviews.llvm.org/D55374 Files: clangd/clients/clangd-

[PATCH] D55374: [clangd] Show FileStatus in vscode-clangd.

hokein added a comment. The patch is ready for review now. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55374/new/ https://reviews.llvm.org/D55374 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D55374: [clangd] Show FileStatus in vscode-clangd.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55374/new/ https://reviews.llvm.org/D55374 __

[PATCH] D55933: [Sema] Do not print default template parameters.

Quuxplusone added inline comments. Comment at: lib/AST/TypePrinter.cpp:173 + // information about whether default template parameters were actually + // written. + switch (QT.getTypePtr()->getTypeClass()) { FWIW, I don't understand this comment's terminology.

[PATCH] D55710: add pragmas to control Software Pipelining optimisation

alexey.lapshin marked an inline comment as done. alexey.lapshin added inline comments. Comment at: include/clang/Basic/AttrDocs.td:2677-2678 +`language extensions +`_ +for further details,

[PATCH] D55868: [Fixed Point Arithmetic] Fixed Point Addition Constant Expression Evaluation

ebevhan added inline comments. Comment at: clang/include/clang/Basic/FixedPoint.h:98 public: + APFixedPoint() = default; APFixedPoint(const llvm::APInt &Val, const FixedPointSemantics &Sema) rjmccall wrote: > This should be documented to describe what it

[PATCH] D55928: [OpenMP] Add flag for preventing the extension to 64 bits for the collapse loop counter

hfinkel added inline comments. Comment at: docs/OpenMPSupport.rst:120 +compile your program with the `-fopenmp-optimistic-collapse`. + + Can you please clarify here what happens when the loop induction variables are already 64 bits. If any of them are already 64

[clang-tools-extra] r349769 - [clangd] Try to workaround test failure by increasing the timeouts

Author: ibiryukov Date: Thu Dec 20 08:27:19 2018 New Revision: 349769 URL: http://llvm.org/viewvc/llvm-project?rev=349769&view=rev Log: [clangd] Try to workaround test failure by increasing the timeouts Ideally we'd figure out a way to run this test without any sleeps, this workaround is only the

[PATCH] D55792: Allow direct navigation to static analysis checker documentation through SARIF exports

aaron.ballman added a comment. In D55792#1334886 , @Szelethus wrote: > This is awesome. Please wait for either @NoQ or @george.karpenkov to have the > final say. > > Edit: Maybe couple days I guess. I've been digging through these files quite > a lot in

Re: r349752 - Replace getOS() == llvm::Triple::*BSD with isOS*BSD() [NFCI]

On Thu, Dec 20, 2018 at 01:09:30PM -, Michal Gorny via cfe-commits wrote: > Author: mgorny > Date: Thu Dec 20 05:09:30 2018 > New Revision: 349752 > > URL: http://llvm.org/viewvc/llvm-project?rev=349752&view=rev > Log: > Replace getOS() == llvm::Triple::*BSD with isOS*BSD() [NFCI] > > Replace

[PATCH] D55869: Convert some ObjC retain/release msgSends to runtime calls

rjmccall added reviewers: theraven, js. rjmccall added a comment. Okay. That's also presumably true for open-source runtimes that support ARC; tagging David Chisnall and Jonathan Schleifer to get their input. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55869/new/ https://reviews.llv

[PATCH] D55869: Convert some ObjC retain/release msgSends to runtime calls

js added a comment. Thanks for tagging me! The ObjFW runtime itself does not contain anything about release, retain or autorelease - these are all part of ObjFW (as in the framework). As ObjFW also supports the Apple runtime, as well as mixing with Foundation code, it so far only provides objc

[PATCH] D55869: Convert some ObjC retain/release msgSends to runtime calls

dexonsmith added a comment. In D55869#1337692 , @rjmccall wrote: > Okay. That's also presumably true for open-source runtimes that support ARC; > tagging David Chisnall and Jonathan Schleifer to get their input. `shouldUseARCFunctionsForRetainRelease()

[PATCH] D55869: Convert some ObjC retain/release msgSends to runtime calls

js added a comment. In D55869#1337707 , @dexonsmith wrote: > In D55869#1337692 , @rjmccall wrote: > > > Okay. That's also presumably true for open-source runtimes that support > > ARC; tagging David Chisnall and J

[PATCH] D55869: Convert some ObjC retain/release msgSends to runtime calls

dexonsmith added a comment. In D55869#1337706 , @js wrote: > The ObjFW runtime itself does not contain anything about release, retain or > autorelease - these are all part of ObjFW (as in the framework). As ObjFW > also supports the Apple runtime, as wel

[PATCH] D55869: Convert some ObjC retain/release msgSends to runtime calls

js added a comment. In D55869#1337711 , @dexonsmith wrote: > In D55869#1337706 , @js wrote: > > > The ObjFW runtime itself does not contain anything about release, retain or > > autorelease - these are all part of

r349776 - Correct the diagnose_if attribute documentation. Fixes PR35845.

Author: aaronballman Date: Thu Dec 20 09:28:32 2018 New Revision: 349776 URL: http://llvm.org/viewvc/llvm-project?rev=349776&view=rev Log: Correct the diagnose_if attribute documentation. Fixes PR35845. Modified: cfe/trunk/include/clang/Basic/AttrDocs.td Modified: cfe/trunk/include/clang/Bas

[PATCH] D55869: Convert some ObjC retain/release msgSends to runtime calls

rjmccall added a comment. In D55869#1337706 , @js wrote: > Thanks for tagging me! > > The ObjFW runtime itself does not contain anything about release, retain or > autorelease - these are all part of ObjFW (as in the framework). As ObjFW > also supports

[PATCH] D55869: Convert some ObjC retain/release msgSends to runtime calls

pete added a comment. In D55869#1337723 , @js wrote: > In D55869#1337711 , @dexonsmith > wrote: > > > In D55869#1337706 , @js wrote: > > > > > The ObjFW runtime itself does

[PATCH] D55937: [X86] Auto upgrade XOP/AVX512 rotation intrinsics to generic funnel shift intrinsics (clang)

RKSimon created this revision. RKSimon added reviewers: spatel, craig.topper. Herald added a subscriber: llvm-commits. This emits FSHL/FSHR generic intrinsics for the XOP VPROT and AVX512 VPROL/VPROR rotation intrinsics. Repository: rL LLVM https://reviews.llvm.org/D55937 Files: lib/CodeG

[PATCH] D55869: Convert some ObjC retain/release msgSends to runtime calls

rjmccall added a comment. In D55869#1337733 , @pete wrote: > In D55869#1337723 , @js wrote: > > > In D55869#1337711 , @dexonsmith > > wrote: > > > > > In D55869#1337706

r349782 - Use @llvm.objc.clang.arc.use intrinsic instead of clang.arc.use function.

Author: pete Date: Thu Dec 20 10:05:41 2018 New Revision: 349782 URL: http://llvm.org/viewvc/llvm-project?rev=349782&view=rev Log: Use @llvm.objc.clang.arc.use intrinsic instead of clang.arc.use function. Calls to this function are deleted in the ARC optimizer. However when the ARC optimizer was

[PATCH] D55937: [X86] Auto upgrade XOP/AVX512 rotation intrinsics to generic funnel shift intrinsics (clang)

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55937/new/ https://reviews.llvm.org/D55937 ___ cfe

[PATCH] D55792: Allow direct navigation to static analysis checker documentation through SARIF exports

NoQ accepted this revision. NoQ added a comment. Looks great, no objections on my end! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55792/new/ https://reviews.llvm.org/D55792 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://l

r349796 - [X86] Auto upgrade XOP/AVX512 rotation intrinsics to generic funnel shift intrinsics (clang)

Author: rksimon Date: Thu Dec 20 11:01:13 2018 New Revision: 349796 URL: http://llvm.org/viewvc/llvm-project?rev=349796&view=rev Log: [X86] Auto upgrade XOP/AVX512 rotation intrinsics to generic funnel shift intrinsics (clang) This emits FSHL/FSHR generic intrinsics for the XOP VPROT and AVX512

[PATCH] D55937: [X86] Auto upgrade XOP/AVX512 rotation intrinsics to generic funnel shift intrinsics (clang)

This revision was automatically updated to reflect the committed changes. Closed by commit rC349796: [X86] Auto upgrade XOP/AVX512 rotation intrinsics to generic funnel shift… (authored by RKSimon, committed by ). Changed prior to commit: https://reviews.llvm.org/D55937?vs=179089&id=179105#toc

[PATCH] D55792: Allow direct navigation to static analysis checker documentation through SARIF exports

george.karpenkov added a comment. This is amazing, huge thanks for doing this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55792/new/ https://reviews.llvm.org/D55792 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

[PATCH] D55862: [Sema] Don't try to account for the size of an incomplete type in CheckArrayAccess

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55862/new/ https://reviews.llvm.org/D55862 ___ cfe-commit

r349798 - Revert "[analyzer] pr38668: Do not attempt to cast loaded values..."

Author: dergachev Date: Thu Dec 20 11:36:06 2018 New Revision: 349798 URL: http://llvm.org/viewvc/llvm-project?rev=349798&view=rev Log: Revert "[analyzer] pr38668: Do not attempt to cast loaded values..." This reverts commit r349701. The patch was incorrect. The whole point of CastRetrievedVal()

[PATCH] D55875: [analyzer] pr38668: RegionStore: Do not attempt to cast loaded values of non-scalar types.

NoQ reopened this revision. NoQ added a comment. This revision is now accepted and ready to land. Revert! Comment at: lib/StaticAnalyzer/Core/Store.cpp:410 + QualType OrigTy = R->getValueType(); + This is entirely incorrect. The whole point of this function

[PATCH] D55875: [analyzer] pr38668: RegionStore: Do not attempt to cast loaded values of non-scalar types.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: lib/StaticAnalyzer/Core/Store.cpp:410 + QualType OrigTy = R->getValueType(); + NoQ wrote: > This is entirely incorrect. The whole point of this function is to handle the > case when

[PATCH] D55875: [analyzer] pr38668: RegionStore: Do not attempt to cast loaded values of non-scalar types.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: lib/StaticAnalyzer/Core/Store.cpp:410 + QualType OrigTy = R->getValueType(); + NoQ wrote: > NoQ wrote: > > This is entirely incorrect. The whole point of this function is to handle >

r349811 - [Sema] Don't try to account for the size of an incomplete type in CheckArrayAccess

Author: brunoricci Date: Thu Dec 20 12:05:11 2018 New Revision: 349811 URL: http://llvm.org/viewvc/llvm-project?rev=349811&view=rev Log: [Sema] Don't try to account for the size of an incomplete type in CheckArrayAccess When checking that the array access is not out-of-bounds in CheckArrayAccess

[PATCH] D55862: [Sema] Don't try to account for the size of an incomplete type in CheckArrayAccess

This revision was automatically updated to reflect the committed changes. Closed by commit rL349811: [Sema] Don't try to account for the size of an incomplete type in… (authored by brunoricci, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm

[PATCH] D55924: [gn build] Add build files for clang-format and lib/{Format,Rewrite,Tooling/Core,Tooling/Inclusions}

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55924/new/ https://reviews.llvm.org/D55924 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D55925: [gn build] Add build file for clang/lib/Parse

phosek added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55925/new/ https://reviews.llvm.org/D55925 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D55792: Allow direct navigation to static analysis checker documentation through SARIF exports

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks for the reviews! I've commit in r349812. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55792/new/ https://reviews.llvm.org/D55792 ___ cfe-commits mailing list cfe-com

[PATCH] D55927: [gn build] Add build file for clang/lib/Driver

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55927/new/ https://reviews.llvm.org/D55927 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D55948: Modify DeclaratorChuck::getFunction to use DeclSpec for qualifiers

Anastasia created this revision. Anastasia added a reviewer: rjmccall. Herald added a subscriber: jfb. Rather than duplicating data fields, use DeclSpec directly to store qualifiers for the functions/methods. This change is discussed in the following comment: https://reviews.llvm.org/D55850#inli

[PATCH] D55869: Convert some ObjC retain/release msgSends to runtime calls

theraven added a comment. This should be fine for the GNUstep runtime (the GCC runtime doesn't support ARC at all). My main concern is that it will break already-released versions of the runtime built with a newer version of clang. I can easily enable a new flag in the next release, but doing

[PATCH] D51641: [VFS] Cache the current working directory for the real FS.

labath added subscribers: JDevlieghere, labath. labath added a comment. Might I ask what was the motivation for this change? Performance optimalization? I am asking this because this makes the RealFileSystem return bogus values for the CWD if it changes through means other than the VFS::setCurr

r349815 - Fix build failures from r349812 due to a missing argument.

Author: aaronballman Date: Thu Dec 20 12:32:59 2018 New Revision: 349815 URL: http://llvm.org/viewvc/llvm-project?rev=349815&view=rev Log: Fix build failures from r349812 due to a missing argument. Modified: cfe/trunk/unittests/StaticAnalyzer/RegisterCustomCheckersTest.cpp Modified: cfe/trun

  1   2   >