Author: maskray
Date: Tue Nov 20 00:00:00 2018
New Revision: 347293
URL: http://llvm.org/viewvc/llvm-project?rev=347293&view=rev
Log:
[libclang] Unify getCursorDecl and getCursorParentDecl
They do the same thing, thus the latter (which has only 2 call sites) can be
deleted.
Modified:
cfe/tr
Author: void
Date: Tue Nov 20 00:53:30 2018
New Revision: 347294
URL: http://llvm.org/viewvc/llvm-project?rev=347294&view=rev
Log:
Use is.constant intrinsic for __builtin_constant_p
Summary:
A __builtin_constant_p may end up with a constant after inlining. Use
the is.constant intrinsic if it's a
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rC347294: Use is.constant intrinsic for __builtin_constant_p
(authored by void, committed by ).
Changed prior to commit:
Szelethus added a comment.
Herald added subscribers: gamesh411, baloghadamsoftware.
Ping
https://reviews.llvm.org/D54401
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
JonasToth added a comment.
Ok, Thank you for looking into it. You can abondon the revision in
phabricator (Selection above comment field at the bottom of the page) if
you wish.
Am 19.11.18 um 23:36 schrieb Mateusz Maćkowski via Phabricator:
> m4tx added a comment.
>
> After thinking about the p
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: clangd/Function.h:147
+private:
+ static_assert(std::is_same::type, T>::value,
+"use a plain type: event values are always pas
v.g.vassilev added a comment.
ping...
https://reviews.llvm.org/D43871
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
v.g.vassilev added a comment.
Is this change still relevant?
Repository:
rL LLVM
https://reviews.llvm.org/D35559
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54694
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
hokein created this revision.
hokein added reviewers: JonasToth, aaron.ballman.
Herald added a subscriber: xazax.hun.
The fix for aggregate initialization (`std::make_unique(Foo {1, 2})` needs
to see Foo copy constructor, otherwise we will have a compiler error. So we
only emit the check warning.
JonasToth added a comment.
Could you please upload the diff with full context? Especially the parts with
refactoring are harder to judge if the code around is not visible. Thank you :)
Comment at: clang-tidy/abseil/DurationComparisonCheck.cpp:25
+static llvm::Optional getScale
JonasToth added inline comments.
Comment at: test/clang-tidy/abseil-duration-comparison.cpp:89
+ // CHECK-FIXES: d1 > d2;
+
+ // Check against the LHS
JonasToth wrote:
> What would happen for a type, that can implicitly convert to a duration or
> double/int.
>
JonasToth added a comment.
Does make_unique require the copy constructor if it could move?
And would the same argument apply to the move-constructors as the arguments are
forwarded?
What would happen in the obscure case of a public copy-constructor, but private
move-constructor (not saying it ma
sammccall created this revision.
sammccall added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ioeric, javed.absar.
- Reads are never executed if canceled before ready-to run. In practice, we
finalize cancelled reads eagerly and out-of-or
Author: sammccall
Date: Tue Nov 20 02:56:03 2018
New Revision: 347297
URL: http://llvm.org/viewvc/llvm-project?rev=347297&view=rev
Log:
[clangd] Allow observation of changes to global CDBs.
Summary:
Currently, changes *within* CDBs are not tracked (CDB has no facility to do so).
However, discover
This revision was automatically updated to reflect the committed changes.
Closed by commit rL347297: [clangd] Allow observation of changes to global
CDBs. (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D54475
Files
This revision was automatically updated to reflect the committed changes.
Closed by commit rL347298: [clangd] Replay preamble #includes to clang-tidy
checks. (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D54694
Fi
Author: sammccall
Date: Tue Nov 20 02:58:48 2018
New Revision: 347298
URL: http://llvm.org/viewvc/llvm-project?rev=347298&view=rev
Log:
[clangd] Replay preamble #includes to clang-tidy checks.
Summary:
This is needed to correctly handle checks that use IncludeInserter,
which is very common.
I co
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE347298: [clangd] Replay preamble #includes to clang-tidy
checks. (authored by sammccall, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D54694?vs=174621&id=174742#toc
Repository:
martong added a comment.
Herald added a subscriber: gamesh411.
@shafik,
I could run the libcxx tests on my Linux machine (Ubuntu 16.04) by installing
libcxx: `sudo apt-get install libc++-dev`.
From the logs of your build server seems like the crash happened with a
`_gmodules` test.
Unfortunatel
Charusso marked 8 inline comments as done.
Charusso added a comment.
@NoQ thanks you for the great explanation! I really wanted to write out known
constant integers and booleans but I think 'Knowing...' pieces would be more
cool.
I tried to minimize the changes after a little e-mailing with @ge
Author: vvassilev
Date: Tue Nov 20 05:53:20 2018
New Revision: 347304
URL: http://llvm.org/viewvc/llvm-project?rev=347304&view=rev
Log:
Allow force updating the NumCreatedFIDsForFileID.
Our internal clients implement parsing cache based on FileID. In order for the
Preprocessor to reenter the cach
This revision was automatically updated to reflect the committed changes.
Closed by commit rC347304: Allow force updating the NumCreatedFIDsForFileID.
(authored by vvassilev, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D51295
Files:
include/clang/Basic/SourceManager.h
In
uweigand added a comment.
It seems this patch caused the SystemZ build bots to fail, they're now all
running into assertion failures:
ICE cannot be evaluated!
UNREACHABLE executed at
/home/uweigand/sandbox/buildbot/clang-s390x-linux/llvm/tools/clang/lib/AST/ExprConstant.cpp:11442!
See e.g.
ht
Charusso added inline comments.
Comment at: test/Analysis/diagnostics/macros.cpp:33
void testDoubleMacro(double d) {
- if (d == DBL_MAX) { // expected-note {{Taking true branch}}
+ if (d == DBL_MAX) { // expected-note {{Assuming 'd' is equal to DBL_MAX}}
+
krasimir created this revision.
Herald added a subscriber: cfe-commits.
Clang-format is treating all occurences of `is` in js as type matchers. In some
cases this is wrong, as it might be a dict key.
Repository:
rC Clang
https://reviews.llvm.org/D54753
Files:
lib/Format/TokenAnnotator.cpp
hokein updated this revision to Diff 174760.
hokein marked 2 inline comments as done.
hokein added a comment.
Address review comments, handle move constructor as well.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54745
Files:
clang-tidy/modernize/MakeSmartPtrCheck.cpp
tes
hokein added a comment.
Thanks for the review.
In https://reviews.llvm.org/D54745#1303972, @JonasToth wrote:
> Does make_unique require the copy constructor if it could move?
No, in that case, move constructor will be used. I have updated the patch to
include these cases.
> And would the sam
Charusso added a comment.
In https://reviews.llvm.org/D54560#1301870, @NoQ wrote:
> Write down full messages in tests. When the message was updated from `'x' is
> moved'` to `Object 'x' is moved`, the tests were not updated because they
> kept passing because the former is still a sub-string of
Author: martong
Date: Tue Nov 20 06:19:39 2018
New Revision: 347306
URL: http://llvm.org/viewvc/llvm-project?rev=347306&view=rev
Log:
[ASTImporter] Set redecl chain of functions before any other import
Summary:
FunctionDecl import starts with a lookup and then we create a new Decl.
Then in case o
This revision was automatically updated to reflect the committed changes.
Closed by commit rC347306: [ASTImporter] Set redecl chain of functions before
any other import (authored by martong, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53702?vs=171093&id=174763#toc
Reposi
Author: krasimir
Date: Tue Nov 20 06:22:43 2018
New Revision: 347307
URL: http://llvm.org/viewvc/llvm-project?rev=347307&view=rev
Log:
[clang-format] JS: don't treat is: as a type matcher
Summary:
Clang-format is treating all occurences of `is` in js as type matchers. In some
cases this is wrong,
This revision was automatically updated to reflect the committed changes.
Closed by commit rC347307: [clang-format] JS: don't treat is: as a type
matcher (authored by krasimir, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D54753?vs=174759&id=174764#toc
Repository:
rC Cla
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
> Currently the smart_ptr check (modernize-make-unique) generates the fixes
> that cannot compile for cases like below -- because brace list can not be
> deduced in make_unique.
sammccall added inline comments.
Comment at: clangd/ExpectedTypes.h:32
+/// this allows the representation to be stored in the index and compared with
+/// types coming from a different AST later.
+class OpaqueType {
ilya-biryukov wrote:
> sammccall wrote:
> > Do
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Aside from some small nits, LGTM!
Comment at: docs/ReleaseNotes.rst:53
+- ``-Wextra-semi-stmt`` is a new diagnostic, which is, much like
+ ``-Wextra-semi``,
aaron.ballman added a comment.
Ping.
https://reviews.llvm.org/D54450
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Quuxplusone added a comment.
@lebedev.ri ping?
Repository:
rC Clang
https://reviews.llvm.org/D54565
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Quuxplusone added a comment.
Herald added subscribers: libcxx-commits, jfb.
@ericwf ping? (and https://reviews.llvm.org/D47344
https://reviews.llvm.org/D47111 https://reviews.llvm.org/D47358)
Repository:
rCXX libc++
https://reviews.llvm.org/D47360
_
sammccall added inline comments.
Comment at: clangd/index/Index.cpp:118
+static void own(Symbol &S, UniqueStringSaver &Strings,
+BumpPtrAllocator &Arena) {
visitStrings(S, [&](StringRef &V) { V = Strings.save(V); });
why these changes?
==
Author: aaronballman
Date: Tue Nov 20 07:23:07 2018
New Revision: 347312
URL: http://llvm.org/viewvc/llvm-project?rev=347312&view=rev
Log:
Update the documentation for attribute feature tests.
This clarifies that __has_cpp_attribute is no longer always an extension since
it's now available in C+
Author: nico
Date: Tue Nov 20 07:27:43 2018
New Revision: 347314
URL: http://llvm.org/viewvc/llvm-project?rev=347314&view=rev
Log:
Revert 347294, it turned many bots on lab.llvm.org:8011/console red.
Modified:
cfe/trunk/include/clang/AST/Expr.h
cfe/trunk/lib/AST/ASTImporter.cpp
cfe/tr
I reverted this in r347314 for breaking many bots on
lab.llvm.org:8011/console
I've also put a standalone repro at
https://bugs.chromium.org/p/chromium/issues/detail?id=907099#c2.
On Tue, Nov 20, 2018 at 3:56 AM Bill Wendling via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: void
>
sammccall added inline comments.
Comment at: clangd/Quality.h:98
+ /// Whether the item matches the type expected in the completion context.
+ bool TypeMatchesPreferred = false;
/// FIXME: unify with index proximity score - signals should be
you've inserted
sammccall added inline comments.
Comment at: clangd/Quality.cpp:373
+ if (TypeMatchesPreferred)
+Score *= 2.0;
+
is 2 really enough?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52276
___
cf
hokein updated this revision to Diff 174771.
hokein marked 2 inline comments as done.
hokein added a comment.
address comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54704
Files:
clang-tidy/modernize/MakeSmartPtrCheck.cpp
test/clang-tidy/modernize-make-unique.cpp
hokein added a comment.
In https://reviews.llvm.org/D54704#1304176, @aaron.ballman wrote:
> > Currently the smart_ptr check (modernize-make-unique) generates the fixes
> > that cannot compile for cases like below -- because brace list can not be
> > deduced in make_unique.
> >
> > class Bar
Author: hokein
Date: Tue Nov 20 07:45:15 2018
New Revision: 347315
URL: http://llvm.org/viewvc/llvm-project?rev=347315&view=rev
Log:
[clang-tidy] Don't generate incorrect fixes for class constructed from
list-initialized arguments
Summary:
Currently the smart_ptr check (modernize-make-unique) ge
This revision was automatically updated to reflect the committed changes.
Closed by commit rL347315: [clang-tidy] Don't generate incorrect fixes for
class constructed from list… (authored by hokein, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.ll
kpn added a comment.
In https://reviews.llvm.org/D53157#1303398, @cameron.mcinally wrote:
> If we all agree upon that, then we simply have to treat the functions that
> modify the FPEnv, e.g. fesetexcept(...), as barriers. That way it does not
> matter if a FENV_ACCESS=OFF function is translate
probinson created this revision.
probinson added reviewers: dblaikie, aprantl.
probinson added a project: debug-info.
Herald added a subscriber: eraman.
See https://reviews.llvm.org/D54755
Repository:
rC Clang
https://reviews.llvm.org/D54756
Files:
clang/test/CodeGen/debug-info-scope-file.
Author: brunoricci
Date: Tue Nov 20 08:03:33 2018
New Revision: 347317
URL: http://llvm.org/viewvc/llvm-project?rev=347317&view=rev
Log:
[AST][NFC] Pack ArraySubscriptExpr
Use the newly available space in the bit-fields of Stmt.
This saves one pointer per ArraySubscriptExpr.
Modified:
cfe/t
Author: brunoricci
Date: Tue Nov 20 08:09:45 2018
New Revision: 347319
URL: http://llvm.org/viewvc/llvm-project?rev=347319&view=rev
Log:
[AST][NFC] Factor out some repeated code in ArraySubscriptExpr.
Factor out the test for whether the LHS is the base of the
array subscript expression into a pri
donat.nagy created this revision.
donat.nagy added reviewers: alexfh, hokein, aaron.ballman, xazax.hun,
whisperity.
Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs,
mgorny.
Implement a check for detecting if/else if/else chains where two or more
branches are Type I
Author: brunoricci
Date: Tue Nov 20 08:20:40 2018
New Revision: 347320
URL: http://llvm.org/viewvc/llvm-project?rev=347320&view=rev
Log:
[AST] Store the expressions in ParenListExpr in a trailing array
Use the newly available space in the bit-fields of Stmt
and store the expressions in a trailing
This revision was automatically updated to reflect the committed changes.
Closed by commit rL347320: [AST] Store the expressions in ParenListExpr in a
trailing array (authored by brunoricci, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.o
This revision was automatically updated to reflect the committed changes.
Closed by commit rC347320: [AST] Store the expressions in ParenListExpr in a
trailing array (authored by brunoricci, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D54675
Files:
include/clang/AST/Expr.h
Author: erichkeane
Date: Tue Nov 20 08:32:46 2018
New Revision: 347322
URL: http://llvm.org/viewvc/llvm-project?rev=347322&view=rev
Log:
[NFC] Remove MS line endings in diagnostics file.
Change-Id: I74704acf052e2e8fe707f18230bc5655c2bf2a91
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSe
uweigand added a comment.
OK, let me try to expand on my point 3 above, which appears to have confused
everybody :-)
First, let's distinguish two separate requirements: those on floating-point
operations that explicitly run in regions with non-default control modes, and
those on floating-point
ilya-biryukov created this revision.
ilya-biryukov added a reviewer: sammccall.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric,
javed.absar.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54760
Files:
clangd/ClangdServer.cpp
clangd/ClangdServer.h
cl
ilya-biryukov added a comment.
The tests still model the old callbacks using callbacks, unfortunately I see no
good way to test same things in any other way.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54760
___
cfe-commits mail
uweigand added a comment.
In https://reviews.llvm.org/D53157#1303193, @andrew.w.kaylor wrote:
> I agree that it's preferable to re-use these existing options if possible. I
> have some concerns that -ftrapping-math has a partial implementation in place
> that doesn't seem to be well aligned wit
nickdesaulniers added inline comments.
Comment at: lib/AST/ExprConstant.cpp:11391
llvm_unreachable("Invalid StmtClass!");
}
@void , I assume this unreachable is the one reported by @uweigand ? Does the
above switch need a case statement added?
Repository
lebedev.ri added a comment.
In https://reviews.llvm.org/D52695#1304225, @aaron.ballman wrote:
> Aside from some small nits, LGTM!
Thank you for the review!
Will address nits and land.
Repository:
rC Clang
https://reviews.llvm.org/D52695
___
cf
Szelethus added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/MoveChecker.cpp:385-386
+ }
+ // Provide the caller with the classification of the object
+ // we've obtained here accidentally, for later use.
+ return OK;
NoQ wrote:
> Szelethus wrote:
Eugene.Zelenko added inline comments.
Comment at: clang-tidy/bugprone/BranchCloneCheck.cpp:19
+
+namespace {
+
Please use anonymous namespaces only for type declarations. See LLV coding
style guide.
Comment at: clang-tidy/bugprone/BranchCloneC
This revision was automatically updated to reflect the committed changes.
Closed by commit rCRT347338: [cmake] Fix detecting terminfo library (authored
by mgorny, committed by ).
Repository:
rCRT Compiler Runtime
https://reviews.llvm.org/D54641
Files:
cmake/config-ix.cmake
Index: cmake/co
sammccall added a comment.
Nice!
The biggest suggestion I have is merging the callback into ASTCallbacks. That's
awkward in initialization (`makeUpdateCallbacks` probably needs to be called
unconditionally with a maybe-null pointer) but it seems like a natural grouping
in all the places it gets
This revision was automatically updated to reflect the committed changes.
Closed by commit rC347339: [clang][Parse] Diagnose useless null statements /
empty init-statements (authored by lebedevri, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52695?vs=174624&id=174812#toc
Author: lebedevri
Date: Tue Nov 20 10:59:05 2018
New Revision: 347339
URL: http://llvm.org/viewvc/llvm-project?rev=347339&view=rev
Log:
[clang][Parse] Diagnose useless null statements / empty init-statements
Summary:
clang has `-Wextra-semi` (D43162), which is not dictated by the currently
selec
lebedev.ri added inline comments.
Comment at: clang-tidy/bugprone/BranchCloneCheck.cpp:43
+
+ for (unsigned i = 0; i < LHS.size(); i++) {
+if (!areStatementsIdentical(LHS[i]->stripLabelLikeStatements(),
Eugene.Zelenko wrote:
> Please use size_t.
Also
```
for
ldionne accepted this revision.
ldionne added a comment.
LGTM
Repository:
rCXX libc++
https://reviews.llvm.org/D51268
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
richard.barton.arm added a comment.
Hi @nickdesaulniers
I have run into this too recently so would love to see this patch land. Did you
get anywhere with those lld test failures?
Ta
Rich
Repository:
rC Clang
https://reviews.llvm.org/D53210
___
jdenny created this revision.
jdenny added a reviewer: ABataev.
Herald added a subscriber: guansong.
This patch adjusts a test not to depend on deprecated FileCheck
behavior that permits overlapping matches within a block of CHECK-DAG
directives. Thus, this patch also removes uses of FileCheck's
rsmith added a comment.
Thanks! Some simplifications are possible here, but otherwise this looks good.
Comment at: clang/lib/Sema/SemaExpr.cpp:14946
+ // as invalid as well.
+ if (const CXXRecordDecl *RD = FieldType->getAsCXXRecordDecl()) {
+if (RD->isInvalidDecl()) {
---
jdenny created this revision.
jdenny added a reviewer: ABataev.
Herald added a subscriber: guansong.
This patch adjusts a test not to depend on deprecated FileCheck
behavior that permits overlapping matches within a block of CHECK-DAG
directives. Thus, this patch also removes uses of FileCheck's
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
I'm fine with the patch, the original intention was to handle a possible
situation where we may have several debug locations with the same line numbers.
Repository:
rC Clang
https://revi
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rC Clang
https://reviews.llvm.org/D54765
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
rsmith created this revision.
rsmith added a reviewer: rjmccall.
Herald added a subscriber: cfe-commits.
This fixes a miscompile where we'd emit a VTT for a class that ends up
referencing an inline virtual member function that we can't actually
emit a body for (because we never instantiated it in
jdenny added a comment.
In https://reviews.llvm.org/D54764#1304573, @ABataev wrote:
> I'm fine with the patch,
Thanks for the quick reviews. I'll push soon.
> the original intention was to handle a possible situation where we may have
> several debug locations with the same line numbers.
We
hgabii marked 9 inline comments as done.
hgabii added a comment.
I resolved all comments.
Comment at: docs/ReleaseNotes.rst:60
+- New :doc:`misc-incorrect-pointer-cast
+ ` check
Eugene.Zelenko wrote:
> Will be good idea to rebase from trunk and use alphabeti
ABataev added a comment.
In https://reviews.llvm.org/D54764#1304606, @jdenny wrote:
> In https://reviews.llvm.org/D54764#1304573, @ABataev wrote:
>
> > I'm fine with the patch,
>
>
> Thanks for the quick reviews. I'll push soon.
>
> > the original intention was to handle a possible situation whe
lebedev.ri added a comment.
`Warn for cases when the pointed to type is wider than the allocated type.`
What does that mean? Is this talking about the size of the allocation, or the
alignment?
Are you aware of the previous attempts, namely https://reviews.llvm.org/D33826?
Please incorporate the
nickdesaulniers added a comment.
Hi @richard.barton.arm , this has landed already. If you click "show older"
you'll see the UI element that shows this landed as r344536 (Oct 15 2018). If
your clang version is later than r344536 (what will become clang-8) and you
still see this, please open a
Eugene.Zelenko added inline comments.
Comment at: docs/ReleaseNotes.rst:60
+- New :doc:`misc-incorrect-pointer-cast
+ ` check
hgabii wrote:
> Eugene.Zelenko wrote:
> > Will be good idea to rebase from trunk and use alphabetical order.
> It is rebased. I could
JonasToth updated this revision to Diff 174828.
JonasToth added a comment.
add tests for different template instantiations
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54395
Files:
clang-tidy/performance/ForRangeCopyCheck.cpp
clang-tidy/performance/UnnecessaryCopyInitiali
JonasToth added inline comments.
Comment at: unittests/clang-tidy/AddConstTest.cpp:733
+ StringRef T = "template void f(T v) \n";
+ StringRef S = "{ T target = v; }";
+ auto Cat = [&T](StringRef S) { return (T + S).str(); };
alexfh wrote:
> It would be intere
JonasToth added a comment.
IMHO this patch is fine, but i think a language expert (not me :D) should take
a look (@aaron.ballman ?) as its complicated :)
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54745
___
cfe-commits mailing
sammccall added a comment.
Very nice! Mostly just a few style/structure nits.
Comment at: clangd/AST.cpp:69
+std::string printName(const NamedDecl &ND) {
+ const NamedDecl *NameSource = &ND;
+ std::string Name = llvm::to_string(NameSource->getDeclName());
jus
tejohnson updated this revision to Diff 174835.
tejohnson added a comment.
Update to use new module flag
Repository:
rC Clang
https://reviews.llvm.org/D53891
Files:
include/clang/Driver/Options.td
include/clang/Driver/SanitizerArgs.h
include/clang/Frontend/CodeGenOptions.def
lib/Code
rsmith added a comment.
In the past, we've been resistant to adding more fine-grained compat warnings,
because we don't want to encourage subsetting the language (which sounds like
exactly what you're trying to do here). We generally don't think it's Clang's
business to enforce coding style con
tejohnson abandoned this revision.
tejohnson added a comment.
Abandoned in favor of new approach in
https://reviews.llvm.org/D53890/https://reviews.llvm.org/D53891.
Repository:
rC Clang
https://reviews.llvm.org/D53524
___
cfe-commits mailing lis
Author: jdenny
Date: Tue Nov 20 14:04:45 2018
New Revision: 347350
URL: http://llvm.org/viewvc/llvm-project?rev=347350&view=rev
Log:
[OpenMP] Update CHECK-DAG usage in for_codegen.cpp
This patch adjusts a test not to depend on deprecated FileCheck
behavior that permits overlapping matches within
This revision was automatically updated to reflect the committed changes.
Closed by commit rC347351: [OpenMP] Update CHECK-DAG usage in
target_parallel_codegen.cpp (authored by jdenny, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D54765?vs=174817&id=174837#toc
Repository:
This revision was automatically updated to reflect the committed changes.
Closed by commit rC347350: [OpenMP] Update CHECK-DAG usage in for_codegen.cpp
(authored by jdenny, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D54764?vs=174816&id=174836#toc
Repository:
rC Clang
Author: jdenny
Date: Tue Nov 20 14:05:23 2018
New Revision: 347351
URL: http://llvm.org/viewvc/llvm-project?rev=347351&view=rev
Log:
[OpenMP] Update CHECK-DAG usage in target_parallel_codegen.cpp
This patch adjusts a test not to depend on deprecated FileCheck
behavior that permits overlapping mat
Author: sammccall
Date: Tue Nov 20 14:06:54 2018
New Revision: 347352
URL: http://llvm.org/viewvc/llvm-project?rev=347352&view=rev
Log:
[CodeComplete] Penalize inherited ObjC properties for auto-completion
Summary:
Similar to auto-completion for ObjC methods, inherited properties
should be penali
This revision was automatically updated to reflect the committed changes.
Closed by commit rC347352: [CodeComplete] Penalize inherited ObjC properties
for auto-completion (authored by sammccall, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53900?vs=171799&id=174838#toc
Re
phosek added a comment.
@rsmith friendly ping?
Repository:
rC Clang
https://reviews.llvm.org/D53787
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rC Clang
https://reviews.llvm.org/D54768
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
1 - 100 of 124 matches
Mail list logo
