[PATCH] D54598: [CMake] Explicitly list Linux targets for Fuchsia toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rC346997: [CMake] Explicitly list Linux targets for Fuchsia toolchain (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D54598?vs=174273&id=174280#toc Repository: r

[PATCH] D54600: [Clang] Add options -fprofile-filter-files and -fprofile-exclude-files to filter the files to instrument with gcov (after revert https://reviews.llvm.org/rL346659)

calixte created this revision. calixte added a reviewer: marco-c. Herald added a subscriber: cfe-commits. the previous patch (https://reviews.llvm.org/rC346642) has been reverted because of test failure under windows. So this patch fix the test cfe/trunk/test/CodeGen/code-coverage-filter.c. Rep

[clang-tools-extra] r346998 - Remove myself as owner of clang-query.

Author: pcc Date: Thu Nov 15 14:02:10 2018 New Revision: 346998 URL: http://llvm.org/viewvc/llvm-project?rev=346998&view=rev Log: Remove myself as owner of clang-query. I haven't been involved with the project for years, so it's probably best for someone else to be the code owner. Differential R

[PATCH] D54453: Remove myself as owner of clang-query.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE346998: Remove myself as owner of clang-query. (authored by pcc, committed by ). Changed prior to commit: https://reviews.llvm.org/D54453?vs=173776&id=174282#toc Repository: rCTE Clang Tools Extra

[PATCH] D54426: [clang-cl] Do not allow using both /Zc:dllexportInlines- and /fallback flag

thakis added a comment. Thanks! Repository: rC Clang https://reviews.llvm.org/D54426 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54604: Automatic variable initialization

jfb created this revision. jfb added reviewers: kcc, rjmccall, rsmith. Herald added subscribers: dexonsmith, jkorous, JDevlieghere. Add an option to initialize automatic variables with either a pattern or with zeroes. The default is still that automatic variables are uninitialized. Also add attrib

[clang-tools-extra] r347000 - [clang-tidy] Fix reference to -[NSError init] in AvoidNSErrorInitCheck.h

Author: stephanemoore Date: Thu Nov 15 14:38:39 2018 New Revision: 347000 URL: http://llvm.org/viewvc/llvm-project?rev=347000&view=rev Log: [clang-tidy] Fix reference to -[NSError init] in AvoidNSErrorInitCheck.h Modified: clang-tools-extra/trunk/clang-tidy/objc/AvoidNSErrorInitCheck.h Modif

[PATCH] D54425: [AArch64] Add aarch64_vector_pcs function attribute to Clang

rjmccall added inline comments. Comment at: include/clang/Basic/AttrDocs.td:1749-1750 +On 64-bit ARM targets, this argument causes the function to obey the vector +procedural call standard (VPCS) rules as described in the Vector ABI for +AArch64. In particular, the register calle

[PATCH] D54604: Automatic variable initialization

t.p.northover added a comment. > This isn't meant to change the semantics of C and C++. As I said in the cfe-dev thread, that's exactly what it does. Specifically I think this is essentially defining a new dialect of C++, which I have massive concerns about. Additionally, as much as we might cl

[PATCH] D54379: Add Hurd toolchain support to Clang

kristina added reviewers: aaron.ballman, erik.pilkington, rsmith. kristina added a comment. Alright, once this is fully reviewed, if accepted, I can land the LLVMSupport change and add your new target and close the stack. In the meantime, adding some more reviewers who have more experience with

[PATCH] D54604: Automatic variable initialization

kcc added reviewers: glider, vitalybuka, pcc, eugenis, vlad.tsyrklevich. kcc added a comment. exciting. adding more folks FYI and to help review Repository: rC Clang https://reviews.llvm.org/D54604 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D54379: Add Hurd toolchain support to Clang

kristina added a comment. Added first batch of comments regarding the patch. Some style, some semantics-related. Comment at: lib/Basic/Targets/OSTargets.h:283 +Builder.defineMacro("__GLIBC__"); +Builder.defineMacro("__ELF__"); +if (Opts.POSIXThreads) --

[PATCH] D52730: [analyzer] ConversionChecker: handle floating point

Szelethus added a comment. Herald added a subscriber: gamesh411. In https://reviews.llvm.org/D52730#1289989, @donat.nagy wrote: > Could someone with commit rights commit this patch (if it is acceptable)? I > don't have commit rights myself. I'll do the honors. Thanks! Repository: rC Clang

[PATCH] D54379: Add Hurd toolchain support to Clang

kristina added inline comments. Comment at: lib/Driver/Driver.cpp:392 +static void replaceString(std::string &S, + const char *Other, Same as previous comment regarding this type of function. Repository: rC Clang https://reviews.ll

[PATCH] D54604: Automatic variable initialization

jfb added a comment. In https://reviews.llvm.org/D54604#1300544, @t.p.northover wrote: > > This isn't meant to change the semantics of C and C++. > > As I said in the cfe-dev thread, that's exactly what it does. Specifically I > think this is essentially defining a new dialect of C++, which I ha

[PATCH] D54557: [analyzer] MoveChecker Pt.2: Restrict the warning to STL objects and locals.

NoQ added a comment. In https://reviews.llvm.org/D54557#1299899, @Szelethus wrote: > Whenever I compile `Rtags`, I get a bunch of move related warnings, I'm > curious how this patch behaves on that project. I'll take a look. Whoops, sry, i accidentally had a look because i misread your message

[PATCH] D54379: Add Hurd toolchain support to Clang

kristina added a comment. Phab lost this inline command for some reason, but please leave some comment regarding why that part in `Driver.cpp` does what it does (summarize the conclusion of the discussion in https://reviews.llvm.org/D54378). Comment at: lib/Driver/Driver.cpp:

r347005 - [WebAssembly] Change type of wake count to unsigned int

Author: aheejin Date: Thu Nov 15 16:48:58 2018 New Revision: 347005 URL: http://llvm.org/viewvc/llvm-project?rev=347005&view=rev Log: [WebAssembly] Change type of wake count to unsigned int Summary: We discussed this at the Nov 12th CG meeting, and decided to use the unsigned semantics for the wa

[PATCH] D54572: [WebAssembly] Change type of wake count to unsigned int

This revision was automatically updated to reflect the committed changes. Closed by commit rL347005: [WebAssembly] Change type of wake count to unsigned int (authored by aheejin, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D54572 Files

[PATCH] D54572: [WebAssembly] Change type of wake count to unsigned int

This revision was automatically updated to reflect the committed changes. Closed by commit rC347005: [WebAssembly] Change type of wake count to unsigned int (authored by aheejin, committed by ). Changed prior to commit: https://reviews.llvm.org/D54572?vs=174169&id=174302#toc Repository: rL L

r347006 - [analyzer] ConversionChecker: handle floating point

Author: szelethus Date: Thu Nov 15 17:00:55 2018 New Revision: 347006 URL: http://llvm.org/viewvc/llvm-project?rev=347006&view=rev Log: [analyzer] ConversionChecker: handle floating point Extend the alpha.core.Conversion checker to handle implicit converions where a too large integer value is con

[PATCH] D52730: [analyzer] ConversionChecker: handle floating point

This revision was automatically updated to reflect the committed changes. Closed by commit rC347006: [analyzer] ConversionChecker: handle floating point (authored by Szelethus, committed by ). Changed prior to commit: https://reviews.llvm.org/D52730?vs=172922&id=174306#toc Repository: rC Cla

[PATCH] D54245: [VFS] Implement `RedirectingFileSystem::getRealPath`.

This revision was automatically updated to reflect the committed changes. Closed by commit rL347009: [VFS] Implement `RedirectingFileSystem::getRealPath`. (authored by vsapsai, committed by ). Herald added a subscriber: kristina. Changed prior to commit: https://reviews.llvm.org/D54245?vs=17309

r347012 - [VFS] Implement `RedirectingFileSystem::getRealPath`.

Author: vsapsai Date: Thu Nov 15 17:18:04 2018 New Revision: 347012 URL: http://llvm.org/viewvc/llvm-project?rev=347012&view=rev Log: [VFS] Implement `RedirectingFileSystem::getRealPath`. It fixes the case when Objective-C framework is added as a subframework through a symlink. When parent framew

[PATCH] D54557: [analyzer] MoveChecker Pt.2: Restrict the warning to STL objects and locals.

NoQ added a comment. In https://reviews.llvm.org/D54557#1299899, @Szelethus wrote: > I think we should either remove the non-default functionality (which wouldn't > be ideal), or emphasise somewhere (open projects?) that there is still work > to be done, but leaving it to be forgotten and essen

[PATCH] D54557: [analyzer] MoveChecker Pt.2: Restrict the warning to STL objects and locals.

NoQ added a comment. In https://reviews.llvm.org/D54557#1299736, @xazax.hun wrote: > It would be great to have a way to extend the list of (possibly non-stl) > types to check. But I do understand that the analyzer does not have a great > way to set such configuration options right now. Do you

[PATCH] D54473: [sanitizers] Initial implementation for -fsanitize=init-locals

kcc added a comment. I think you can safely abandon this change in favor of https://reviews.llvm.org/D54604 -- please join the review there. Repository: rC Clang https://reviews.llvm.org/D54473 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D54557: [analyzer] MoveChecker Pt.2: Restrict the warning to STL objects and locals.

Szelethus added a comment. In https://reviews.llvm.org/D54557#1300581, @NoQ wrote: > In https://reviews.llvm.org/D54557#1299899, @Szelethus wrote: > > > Whenever I compile `Rtags`, I get a bunch of move related warnings, I'm > > curious how this patch behaves on that project. I'll take a look. >

[PATCH] D53417: [Clang][Sema]Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

This revision was automatically updated to reflect the committed changes. wuzish marked an inline comment as done. Closed by commit rC347019: [Clang][Sema]Choose a better candidate in overload function call if there is a… (authored by wuzish, committed by ). Changed prior to commit: https://rev

r347019 - [Clang][Sema]Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

Author: wuzish Date: Thu Nov 15 19:00:00 2018 New Revision: 347019 URL: http://llvm.org/viewvc/llvm-project?rev=347019&view=rev Log: [Clang][Sema]Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error There are 2 function va

r347021 - [CMake] Use the correct spelling for armv7 in Fuchsia's toolchain

Author: phosek Date: Thu Nov 15 20:09:47 2018 New Revision: 347021 URL: http://llvm.org/viewvc/llvm-project?rev=347021&view=rev Log: [CMake] Use the correct spelling for armv7 in Fuchsia's toolchain We need to explicitly specify the architecture version. Differential Revision: https://reviews.ll

[PATCH] D54613: [CMake] Use the correct spelling for armv7 in Fuchsia's toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rC347021: [CMake] Use the correct spelling for armv7 in Fuchsia's toolchain (authored by phosek, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D

r347025 - [CMake] Support cross-compiling with multi-stage builds

Author: phosek Date: Thu Nov 15 20:46:48 2018 New Revision: 347025 URL: http://llvm.org/viewvc/llvm-project?rev=347025&view=rev Log: [CMake] Support cross-compiling with multi-stage builds When using multi-stage builds, we would like support cross-compilation. Example is 2-stage build when the fi

[PATCH] D54461: [CMake] Support cross-compiling with multi-stage builds

This revision was automatically updated to reflect the committed changes. Closed by commit rC347025: [CMake] Support cross-compiling with multi-stage builds (authored by phosek, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D54461?vs=1

[PATCH] D54463: [CMake] Support cross-compiling with Fuchsia toolchain build

This revision was automatically updated to reflect the committed changes. Closed by commit rL347026: [CMake] Support cross-compiling with Fuchsia toolchain build (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D5446

r347026 - [CMake] Support cross-compiling with Fuchsia toolchain build

Author: phosek Date: Thu Nov 15 20:50:12 2018 New Revision: 347026 URL: http://llvm.org/viewvc/llvm-project?rev=347026&view=rev Log: [CMake] Support cross-compiling with Fuchsia toolchain build When second stage is being cross-compiled for a different platform we need to build enough of first sta

[PATCH] D54334: [AVR] Automatically link CRT and libgcc from the system avr-gcc

dylanmckay added a comment. I'd like feedback on the new AVR-specific warnings, and the new warning group. I have not added a warning or error to clang before, but this seems consistent with how the other targets implement it. Repository: rC Clang https://reviews.llvm.org/D54334

Re: [llvm-dev] mips builders on LLVM buildbot?

Hi Galina, a) "llvm-mips-linux" buildbot is active now. There are some failed tests but I'm working to make the buildbot "green". b) For now "clang-cmake-mips" and "clang-cmake-mipsel" can be removed. Later we probably restore these buildbots. On Sat, Nov 3, 2018 at 11:26 AM Simon Atanasyan wro

[PATCH] D53891: [LTO] Pass down LTOUnit codegen flag to bitcode writer

tejohnson updated this revision to Diff 174329. tejohnson added a comment. - As discussed off-patch, will use a new, separate option to control this splitting, here I am using -f[no]split-lto-unit. - Switch the default of splitting lto units to off by default, unless compiled with CFI or -fwhol

[PATCH] D34654: Allow passing a regex for headers to exclude from clang-tidy

lonico added a comment. > The second way to handle this use case is possible on a different level: one > can run clang-tidy over the whole project with `-header-filter=.*` and then > filter the results and use a specialized tool to display them, e.g. > https://github.com/Ericsson/codechecker.

[PATCH] D53891: [LTO] Pass down LTOUnit codegen flag to bitcode writer

tejohnson updated this revision to Diff 174332. tejohnson added a comment. Update a couple tests due to new default of splitting off and new flag. Repository: rC Clang https://reviews.llvm.org/D53891 Files: include/clang/Driver/Options.td include/clang/Driver/SanitizerArgs.h include/cl

[PATCH] D54355: Use is.constant intrinsic for __builtin_constant_p

void added a comment. Ping? :-) Repository: rC Clang https://reviews.llvm.org/D54355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54253: [OpenCL][NFC] Improve test coverage of test/Index/opencl-types.cl

AlexeySachkov added a comment. I'm running OpenCL on an x886 and everything is fine, but there are a lot of build bots which build different targets on different architectures. Since there are no `target` option specified, `c-index-test` uses native target. I just realized: may be it is better

<    1   2