rsmith added a comment.
In https://reviews.llvm.org/D53787#1279913, @phosek wrote:
> In https://reviews.llvm.org/D53787#1279899, @rsmith wrote:
>
> > Replacing the global new and delete is supposed to be a whole-program
> > operation (you only get one global allocator). Otherwise you couldn't
>
Author: bjope
Date: Tue Oct 30 01:49:26 2018
New Revision: 345573
URL: http://llvm.org/viewvc/llvm-project?rev=345573&view=rev
Log:
[OPENMP] Fix for "error: unused variable 'CED'"
Quick fix to make code compile with -Werror,-Wunused-variable.
Modified:
cfe/trunk/lib/CodeGen/CGStmtOpenMP.cpp
takuto.ikuta added a comment.
In https://reviews.llvm.org/D51340#1278799, @hans wrote:
> I've been thinking more about your example with static locals in lambda and
> how this works with regular dllexport.
>
> It got me thinking more about the problem of exposing inline functions from a
> libra
kadircet added inline comments.
Comment at: lib/Sema/SemaCodeComplete.cpp:5135
+ };
+ auto AddDefaultCtorInit = [&](const char *TypedName,
+const char *TypeName,
ZaMaZaN4iK wrote:
> Is it good idea to capture ALL by reference? Pr
mgorny updated this revision to Diff 171647.
mgorny added a comment.
Rebased.
https://reviews.llvm.org/D47819
Files:
cmake/base-config-ix.cmake
lib/sanitizer_common/CMakeLists.txt
test/msan/lit.cfg
test/msan/lit.site.cfg.in
test/tsan/lit.cfg
test/tsan/lit.site.cfg.in
Index: test/t
mgorny updated this revision to Diff 171646.
mgorny added a comment.
Rebased.
https://reviews.llvm.org/D47817
Files:
lib/sanitizer_common/CMakeLists.txt
lib/sanitizer_common/sanitizer_platform_limits_posix.cc
Index: lib/sanitizer_common/sanitizer_platform_limits_posix.cc
=
sammccall added a comment.
It's not obvious whether/why this is the right thing to do.
One set of reasoning that occurs to me:
- headers without guards produce code in some context-sensitive way, they only
exist in the context of their including file
- for the symbols they produce, we have ways
rjmccall added a comment.
That's interesting. If you think of a list-initialization of an aggregate as
effectively defining an *ad hoc* constructor for it, then yes, we clearly ought
to have access to protected destructors of base classes. And that aligns with
the intuition that people make t
xbolva00 added a comment.
Ping @MTC or @rsmith
https://reviews.llvm.org/D52949
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hans added a comment.
>> $ g++ -fvisibility=hidden -fvisibility-inlines-hidden -fpic -shared -o
>> lib.so lib.cc
>> $ g++ main.cc lib.so
>> /tmp/cc557J3i.o: In function `S::bar()':
>> main.cc:(.text._ZN1S3barEv[_ZN1S3barEv]+0xd): undefined reference to
>> `foo()'
>>
>>
>> So this is a
sammccall added inline comments.
Comment at: clangd/Threading.cpp:102
+void setThreadPriority(std::thread &T, ThreadPriority Priority) {
+#ifdef HAVE_PTHREAD_H
+ sched_param priority;
don't you also need to actually include it?
Comment at: cla
Author: tikuta
Date: Tue Oct 30 02:42:49 2018
New Revision: 345576
URL: http://llvm.org/viewvc/llvm-project?rev=345576&view=rev
Log:
Remove trailing space from clang/Basic/LangOptions.h
Modified:
cfe/trunk/include/clang/Basic/LangOptions.h
Modified: cfe/trunk/include/clang/Basic/LangOptions.
ilya-biryukov added inline comments.
Comment at: clangd/Threading.cpp:101
+void setThreadPriority(std::thread &T, ThreadPriority Priority) {
+#ifdef HAVE_PTHREAD_H
Maybe put this helper into `llvm/Support/Threading.h`?
Comment at: clangd/Thre
ilya-biryukov added inline comments.
Comment at: lib/Sema/SemaCodeComplete.cpp:813
+static void AddTemplateParameterChunks(ASTContext &Context,
+ const PrintingPolicy &Policy,
We don't seem to need this fwd-decl anymore. Re
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Great stuff! Just nits (though a few of them; this is a tricky patch!).
Comment at: clangd/index/Background.cpp:122
+inline BackgroundIndex::FileDigest digest(StringR
kadircet updated this revision to Diff 171655.
kadircet marked 14 inline comments as done.
kadircet added a comment.
- Address comments && Use ThreadPool
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53651
Files:
clangd/Threading.cpp
clangd/Threading.h
clangd/index/Backg
kadircet added inline comments.
Comment at: clangd/Threading.cpp:102
+void setThreadPriority(std::thread &T, ThreadPriority Priority) {
+#ifdef HAVE_PTHREAD_H
+ sched_param priority;
sammccall wrote:
> don't you also need to actually include it?
Turns out it was
kadircet updated this revision to Diff 171658.
kadircet added a comment.
- Delete outdated comment.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53651
Files:
clangd/Threading.cpp
clangd/Threading.h
clangd/index/Background.cpp
clangd/index/Background.h
Index: clangd/i
filcab updated this revision to Diff 171660.
filcab added a comment.
Update with name change, using rjmccall's suggestion
Repository:
rC Clang
https://reviews.llvm.org/D52615
Files:
include/clang/Driver/Options.td
include/clang/Driver/SanitizerArgs.h
include/clang/Frontend/CodeGenOptio
ebevhan added a comment.
In https://reviews.llvm.org/D53738#1279069, @rjmccall wrote:
> > The important difference would be that we separate the semantics of
> > performing the conversion and the operation. I understand that adding a new
> > type could be a bit more involved than baking the con
filcab updated this revision to Diff 171661.
filcab added a comment.
Missed the change in some places
Repository:
rC Clang
https://reviews.llvm.org/D52615
Files:
docs/ClangCommandLineReference.rst
docs/UsersManual.rst
include/clang/Driver/Options.td
include/clang/Driver/SanitizerArgs
JonasToth added a comment.
Hi astrelni,
my 2cents.
Please upload the patch will full context (i believe `diff -U 9`, but check
the man pages if that doesn't work :D)
Comment at: clang-tidy/abseil/UpgradeDurationConversionsCheck.cpp:32
+
+ // a *= b; a /= b;
+ Finder->ad
JonasToth added inline comments.
Comment at: docs/clang-tidy/checks/cppcoreguidelines-macro-usage.rst:30
+
+.. option:: IgnoreLocationless
+
I think the another option name would fit better: how about
`IgnoreCommandLineMacros` or the like?
Repository:
rCTE C
filcab added a comment.
In https://reviews.llvm.org/D52615#1278000, @rjmccall wrote:
> So, three points:
>
> - That's not class-member-specific; you can have a placement `operator new[]`
> at global scope that isn't the special `void*` placement operator and
> therefore still has a cookie, and
whisperity added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:420-465
if (ChecksEnabled[CK_InvalidatedIteratorChecker] &&
isAccessOperator(Func->getOverloadedOperator())) {
// Check for any kind of access of invalidated iterato
mgorny accepted this revision.
mgorny added a comment.
This revision is now accepted and ready to land.
LGTM, presuming the tests pass for you.
https://reviews.llvm.org/D53125
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
Anastasia added a comment.
In https://reviews.llvm.org/D53705#1279086, @rjmccall wrote:
> In https://reviews.llvm.org/D53705#1279068, @svenvh wrote:
>
> > Unlikely, since address spaces are provided in a different way in OpenCL
> > C++ vs OpenCL C.
> >
> > OpenCL C provides qualifiers such as `g
mgorny added a comment.
@philip.pfaffe, did you establish whether this is still necessary or can be
abandoned?
https://reviews.llvm.org/D49486
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
kadircet updated this revision to Diff 171672.
kadircet added a comment.
- Address comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53651
Files:
clangd/Threading.cpp
clangd/Threading.h
clangd/index/Background.cpp
clangd/index/Background.h
Index: clangd/index/Ba
baloghadamsoftware added a comment.
Herald added subscribers: donat.nagy, Szelethus.
@NoQ Any comments/concerns regarding this solution?
Repository:
rC Clang
https://reviews.llvm.org/D50256
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
philip.pfaffe abandoned this revision.
philip.pfaffe added a comment.
It looks like running clang will be good enough. I'm closing this for now!
https://reviews.llvm.org/D49486
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Nice! Sorry about the back and forth with threadpool...
Comment at: clangd/index/Background.cpp:35
+ assert(ThreadPoolSize > 0 && "Thread pool size can't be zero.");
+
kadircet updated this revision to Diff 171675.
kadircet marked 2 inline comments as done.
kadircet added a comment.
- Add comment.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53651
Files:
clangd/Threading.cpp
clangd/Threading.h
clangd/index/Background.cpp
clangd/inde
kadircet added inline comments.
Comment at: clangd/Threading.cpp:101
+void setThreadPriority(std::thread &T, ThreadPriority Priority) {
+#ifdef HAVE_PTHREAD_H
ilya-biryukov wrote:
> Maybe put this helper into `llvm/Support/Threading.h`?
We talked with Sam about
Author: kadircet
Date: Tue Oct 30 05:13:27 2018
New Revision: 345590
URL: http://llvm.org/viewvc/llvm-project?rev=345590&view=rev
Log:
[clangd] Use thread pool for background indexing.
Reviewers: sammccall, ioeric
Reviewed By: sammccall
Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, jf
kadircet updated this revision to Diff 171676.
kadircet marked an inline comment as done.
kadircet added a comment.
- Format the code.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53651
Files:
clangd/Threading.cpp
clangd/Threading.h
clangd/index/Background.cpp
clangd/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345590: [clangd] Use thread pool for background indexing.
(authored by kadircet, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D53651
Files:
c
Author: thegameg
Date: Tue Oct 30 05:18:33 2018
New Revision: 345591
URL: http://llvm.org/viewvc/llvm-project?rev=345591&view=rev
Log:
[CodeGen] Disable the machine verifier on a ThinLTO test
This allows us to turn the machine verifier on by default on X86.
Modified:
cfe/trunk/test/CodeGen/t
donat.nagy updated this revision to Diff 171678.
donat.nagy added a comment.
Use APFloat to determine precision of floating point type
Additionally, fix a typo in the tests.
Repository:
rC Clang
https://reviews.llvm.org/D52730
Files:
lib/StaticAnalyzer/Checkers/ConversionChecker.cpp
tes
xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.
LGTM!
I only wonder if this should be on by default or guarded by a config option. I
do not have strong feelings about any of the options though.
Repository:
rC Clang
https://reviews
Author: lebedevri
Date: Tue Oct 30 05:37:16 2018
New Revision: 345594
URL: http://llvm.org/viewvc/llvm-project?rev=345594&view=rev
Log:
[clang] Move two utility functions into SourceManager
Summary: So we can keep that not-so-great logic in one place.
Reviewers: rsmith, aaron.ballman
Reviewed B
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345594: [clang] Move two utility functions into
SourceManager (authored by lebedevri, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D53837?vs
lebedev.ri added a comment.
In https://reviews.llvm.org/D53837#1279891, @rsmith wrote:
> Thanks, LG. I bet there's a bunch more places we could change to call these
> two.
Thank you for the review.
Repository:
rL LLVM
https://reviews.llvm.org/D53837
donat.nagy marked 7 inline comments as done.
donat.nagy added a comment.
I found a solution for determining the precision value of a floating point
type. Is this acceptable?
Comment at: lib/StaticAnalyzer/Checkers/ConversionChecker.cpp:163
+
+switch (FloatingSize) {
+
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks! Could you please add prefix `[OpenCL]` in the final commit title.
Repository:
rC Clang
https://reviews.llvm.org/D53809
___
lebedev.ri updated this revision to Diff 171683.
lebedev.ri marked an inline comment as done.
lebedev.ri added a comment.
Better option name.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53817
Files:
clang-tidy/cppcoreguidelines/MacroUsageCheck.cpp
clang-tidy/cppcoreguide
ioeric updated this revision to Diff 171684.
ioeric marked 11 inline comments as done.
ioeric added a comment.
- address review comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53433
Files:
clangd/index/Background.cpp
clangd/index/Background.h
clangd/index/FileInd
lebedev.ri added inline comments.
Comment at: docs/clang-tidy/checks/cppcoreguidelines-macro-usage.rst:30
+
+.. option:: IgnoreLocationless
+
JonasToth wrote:
> I think the another option name would fit better: how about
> `IgnoreCommandLineMacros` or the like?
ioeric added inline comments.
Comment at: clangd/index/Background.cpp:311
SPAN_ATTACH(Tracer, "refs", int(Refs.numRefs()));
- // FIXME: partition the symbols by file rather than TU, to avoid duplication.
- IndexedSymbols.update(AbsolutePath,
-llvm::ma
sammccall accepted this revision.
sammccall added inline comments.
Comment at: clangd/index/Background.cpp:311
SPAN_ATTACH(Tracer, "refs", int(Refs.numRefs()));
- // FIXME: partition the symbols by file rather than TU, to avoid duplication.
- IndexedSymbols.update(AbsolutePa
Anastasia added a comment.
In https://reviews.llvm.org/D43783#1272001, @AlexeySotkin wrote:
> In https://reviews.llvm.org/D43783#1215573, @Anastasia wrote:
>
> > In https://reviews.llvm.org/D43783#1212485, @yaxunl wrote:
> >
> > > In https://reviews.llvm.org/D43783#1204353, @svenvh wrote:
> > >
>
aaron.ballman marked 9 inline comments as done.
aaron.ballman added inline comments.
Comment at: Analysis/diagnostics/sarif-diagnostics-taint-test.c:18
+// Test the basics for sanity.
+// CHECK: sarifLog['version'].startswith("2.0.0")
+// CHECK: sarifLog['runs'][0]['tool']['fullN
aaron.ballman updated this revision to Diff 171685.
aaron.ballman added a comment.
Updated based on review feedback -- removed the `Sarif` path generation scheme
as it isn't currently needed, and replaced a FIXME with a better comment.
Testing remains an open question, however.
https://reviews
ymandel marked 2 inline comments as done.
ymandel added inline comments.
Comment at: clang-tidy/readability/ConstValueReturnCheck.cpp:107
+diag(Def->getInnerLocStart(), "return type %0 is 'const'-qualified "
+ "hindering compiler optim
Author: brunoricci
Date: Tue Oct 30 06:42:41 2018
New Revision: 345597
URL: http://llvm.org/viewvc/llvm-project?rev=345597&view=rev
Log:
[AST] Only store the needed data in WhileStmt
Don't store the data for the condition variable if not needed.
This cuts the size of WhileStmt by up to a pointer.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345597: [AST] Only store the needed data in WhileStmt
(authored by brunoricci, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D53715?vs=171338
aaron.ballman added inline comments.
Comment at: clang-tidy/readability/ConstValueReturnCheck.cpp:107
+diag(Def->getInnerLocStart(), "return type %0 is 'const'-qualified "
+ "hindering compiler optimizations")
+<< Def->getRetur
lebedev.ri updated this revision to Diff 171688.
lebedev.ri added a comment.
Rebased, NFC.
Repository:
rC Clang
https://reviews.llvm.org/D50250
Files:
docs/ReleaseNotes.rst
docs/UndefinedBehaviorSanitizer.rst
include/clang/Basic/Sanitizers.def
lib/CodeGen/CGExprScalar.cpp
test/Code
nik created this revision.
Herald added subscribers: cfe-commits, arphaman.
If a header file was processed for the second time, we could end up with
a wrong conditional stack and skipped ranges:
In the particular example, if the header guard is evaluated the second
time and it is decided to skip
gchatelet updated this revision to Diff 171692.
gchatelet added a comment.
- Add more checks, disable bool implicit casts warning, enable ternary operator
warnings.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53488
Files:
clang-tidy/cppcoreguidelines/NarrowingConversionsC
JonasToth accepted this revision.
JonasToth added a comment.
This revision is now accepted and ready to land.
LGTM, @aaron.ballman do you have more comments?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53817
___
cfe-commits maili
Szelethus added a comment.
In https://reviews.llvm.org/D53856#1279887, @NoQ wrote:
> This might be also covered by @rnkovacs's string buffer escape checker -
> either already or eventually, it'll become just yet another string view API
> that the checker supports.
I thought about that too, ad
djasper added a comment.
I think this roughly looks fine. Krasimir, any thoughts?
Comment at: unittests/Format/FormatTest.cpp:11854
+ // case above.
+ {
+auto Style = getGoogleStyle();
No need to use a scope here. Feel free to redefine Style.
If in fact
gchatelet added a comment.
So I've updated the code to add more narrowing conversions.
It now tests constant expressions against receiving type, do not warn about
implicit bool casting, handles ternary operator with constant expressions.
I ran it on our code base: results look legit.
I'll ping b
Author: brunoricci
Date: Tue Oct 30 07:40:49 2018
New Revision: 345605
URL: http://llvm.org/viewvc/llvm-project?rev=345605&view=rev
Log:
[AST] Only store data for the NRVO candidate in ReturnStmt if needed
Only store the NRVO candidate if needed in ReturnStmt.
A good chuck of all of the ReturnStm
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345605: [AST] Only store data for the NRVO candidate in
ReturnStmt if needed (authored by brunoricci, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.ll
This revision was automatically updated to reflect the committed changes.
Closed by commit rC345605: [AST] Only store data for the NRVO candidate in
ReturnStmt if needed (authored by brunoricci, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53716?vs=171131&id=171696#toc
Re
ymandel updated this revision to Diff 171700.
ymandel added a comment.
Reworded diagnostic message and corresponding documentation.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53025
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/ConstValueReturnCheck
ymandel marked 3 inline comments as done.
ymandel added inline comments.
Comment at: clang-tidy/readability/ConstValueReturnCheck.cpp:107
+diag(Def->getInnerLocStart(), "return type %0 is 'const'-qualified "
+ "hindering compiler optim
kadircet updated this revision to Diff 171703.
kadircet marked 8 inline comments as done.
kadircet added a comment.
- Address comments.
Repository:
rC Clang
https://reviews.llvm.org/D53654
Files:
lib/Sema/SemaCodeComplete.cpp
test/CodeCompletion/ctor-initializer.cpp
test/Index/complete
gchatelet added a comment.
So I ran `llvm/tools/clang/tools/extra/clang-tidy/tool/run-clang-tidy.py`
The bare version produces `65664` unique findings.
The version restricted to `cppcoreguidelines-narrowing-conversions` produces
`4323` unique findings. That's about `+7%` of findings.
I can post s
kadircet added inline comments.
Comment at: lib/Sema/SemaCodeComplete.cpp:821
+
+DeclContext::lookup_result getConstructorResults(ASTContext &Context,
+ const CXXRecordDecl *Record,
ilya-biryukov wrote:
> There's a
hans created this revision.
hans added reviewers: rnk, thakis, takuto.ikuta.
In the course of https://reviews.llvm.org/D51340, @takuto.ikuta discovered that
Clang fails to put dllexport/import attributes on static locals during template
instantiation.
For regular functions, this happens in Sema
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53648
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ilya-biryukov added a comment.
Sorry for the delay, it was open in my browser for days...
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53648
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
aaron.ballman updated this revision to Diff 171712.
aaron.ballman added a comment.
Switched to using diff for testing.
https://reviews.llvm.org/D53814
Files:
Analysis/diagnostics/Inputs/expected-sarif/sarif-diagnostics-taint-test.c.sarif
Analysis/diagnostics/sarif-diagnostics-taint-test.c
svenvh created this revision.
svenvh added a reviewer: mantognini.
Herald added subscribers: cfe-commits, Anastasia, yaxunl.
Also rename `invalid-clk-events-cl2.0.cl` to `clk_event_t.cl` and
repurpose it to include both positive and negative clk_event_t tests.
Repository:
rC Clang
https://rev
lebedev.ri added a comment.
In https://reviews.llvm.org/D53817#1280405, @JonasToth wrote:
> LGTM
Thank you for the review!
> @aaron.ballman do you have more comments?
If there are no more comments, i'll land this in a few (~3) hours.
Repository:
rCTE Clang Tools Extra
https://reviews.llv
aaron.ballman added inline comments.
Comment at: Analysis/diagnostics/sarif-diagnostics-taint-test.c:18
+// Test the basics for sanity.
+// CHECK: sarifLog['version'].startswith("2.0.0")
+// CHECK: sarifLog['runs'][0]['tool']['fullName'] == "clang static analyzer"
---
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53817
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
JonasToth requested changes to this revision.
JonasToth added a comment.
This revision now requires changes to proceed.
because this now diverged quite a bit i will revert the lgtm for now and take a
longer look at the new patch.
The numbers you reported sound good.
Comment at
JonasToth added inline comments.
Comment at: docs/ReleaseNotes.rst:77
- New :doc:`abseil-duration-factory-float
` check.
JonasToth wrote:
> that seems to be unrelated
sry for noise, this was part of the history diffs!
Repository:
rCTE Clang Tools Extra
aaron.ballman added inline comments.
Comment at: clang-tidy/readability/ConstValueReturnCheck.cpp:107
+diag(Def->getInnerLocStart(), "return type %0 is 'const'-qualified "
+ "hindering compiler optimizations")
+<< Def->getRetur
Szelethus added inline comments.
Comment at: clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp:14
#include "clang/ASTMatchers/ASTMatchFinder.h"
+#include "llvm/ADT/APInt.h"
+#include "llvm/ADT/APSInt.h"
Is `APInt` used anywhere?
Repository:
rCTE Cl
Author: abataev
Date: Tue Oct 30 08:50:12 2018
New Revision: 345609
URL: http://llvm.org/viewvc/llvm-project?rev=345609&view=rev
Log:
[OPENMP] Support for mapping of the lambdas in target regions.
Added support for mapping of lambdas in the target regions. It scans all
the captures by reference i
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345610: [clang-tidy] cppcoreguidelines-macro-usage: print
macro names (authored by lebedevri, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D
Author: lebedevri
Date: Tue Oct 30 08:52:36 2018
New Revision: 345610
URL: http://llvm.org/viewvc/llvm-project?rev=345610&view=rev
Log:
[clang-tidy] cppcoreguidelines-macro-usage: print macro names
Summary:
The macro may not have location (or more generally, the location may not exist),
e.g. if i
george.karpenkov accepted this revision.
george.karpenkov added a comment.
This revision is now accepted and ready to land.
I much prefer this version.
We've had the same problem with diffing plist output.
One thing we have learned is using a FileCheck was definitely a bad idea, as it
leads to un
gchatelet updated this revision to Diff 171717.
gchatelet marked 4 inline comments as done.
gchatelet added a comment.
- Remove leftover
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53488
Files:
clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp
clang-tidy/cppcore
JonasToth added inline comments.
Comment at: clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp:25
// FIXME: Check double -> float truncation. Pay attention to casts:
void NarrowingConversionsCheck::registerMatchers(MatchFinder *Finder) {
I think this
gchatelet added a comment.
Here are 15 random ones from **llvm** synced at
`8f9fb8bab2e9b5b27fe40d700d2abe967b99fbb5`.
lib/Target/ARM/AsmParser/ARMAsmParser.cpp:3802:31: warning: narrowing
conversion from 'int' to 'unsigned int'
[cppcoreguidelines-narrowing-conversions]
tools/dsymutil/Mach
erik.pilkington updated this revision to Diff 171719.
erik.pilkington marked 7 inline comments as done.
erik.pilkington added a comment.
Address review comments. Thanks!
https://reviews.llvm.org/D53522
Files:
clang/include/clang/Lex/ModuleMap.h
clang/lib/Frontend/DependencyFile.cpp
clang/
erik.pilkington added inline comments.
Comment at: clang/include/clang/Lex/ModuleMap.h:649-650
+ ///This can differ from \c Header's name due to symlinks.
void addHeader(Module *Mod, Module::Header Header,
- ModuleHeaderRole Role, bool Imported = false
martong marked 2 inline comments as done.
martong added a comment.
> I wonder if it is possible to get into situation where non-equivalent decls
> are marked equivalent with this patch? If yes, we can create a mapping
> between decls being imported and original decls as an alternative solution.
martong updated this revision to Diff 171723.
martong marked 2 inline comments as done.
martong added a comment.
- Remove unrelated test
Repository:
rC Clang
https://reviews.llvm.org/D53697
Files:
lib/AST/ASTStructuralEquivalence.cpp
unittests/AST/ASTImporterTest.cpp
Index: unittests/A
ahatanak added a comment.
http://wg21.link/p0968r0#2227 says:
The destructor for each element of class type is potentially invoked (15.4
[class.dtor]) from the context where the aggregate initialization occurs.
[Note: This provision ensures that destructors can be called for
fully-constructed
lebedev.ri added inline comments.
Comment at: clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp:84
"cppcoreguidelines-c-copy-assignment-signature");
+CheckFactories.registerCheck(
+"cppcoreguidelines-avoid-c-arrays");
JonasToth wro
lebedev.ri updated this revision to Diff 171747.
lebedev.ri marked 4 inline comments as done.
lebedev.ri added a comment.
Address review notes.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53771
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelin
hhb updated this revision to Diff 171748.
https://reviews.llvm.org/D53850
Files:
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/builtin-cpu-is.c
test/CodeGen/builtin-cpu-supports.c
Index: test/CodeGen/builtin-cpu-supports.c
===
--- t
vsapsai updated this revision to Diff 171751.
vsapsai added a comment.
- Rename `EmitConstant` to `EmitScalarConstant`.
https://reviews.llvm.org/D53725
Files:
clang/lib/CodeGen/CGExpr.cpp
clang/lib/CodeGen/CGExprScalar.cpp
clang/lib/CodeGen/CodeGenFunction.h
Index: clang/lib/CodeGen/Cod
1 - 100 of 190 matches
Mail list logo
