leonardchan updated this revision to Diff 169516.
Repository:
rC Clang
https://reviews.llvm.org/D52814
Files:
lib/CodeGen/BackendUtil.cpp
test/CodeGen/asan-new-pm.ll
Index: test/CodeGen/asan-new-pm.ll
===
--- /dev/null
+++ t
vsapsai created this revision.
vsapsai added a reviewer: bruno.
Herald added subscribers: dexonsmith, hiraditya.
'ignore-non-existent-contents' stopped working after r342232 in a way
that the actual attribute value isn't used and it works as if it is
always `true`.
Common use case for VFS iterati
orivej created this revision.
orivej added reviewers: rsmith, vsk, aaron.ballman.
Herald added a subscriber: cfe-commits.
If PerformConstructorInitialization of a direct initializer list constructor is
called while instantiating a template, it has brace locations in its BraceLoc
arguments but no
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG with a nit.
Comment at: clang-tidy/modernize/UseEqualsDeleteCheck.h:46
void check(const ast_matchers::MatchFinder::MatchResult &Result) override;
+private:
+ const boo
rsmith added a comment.
It would be nice to have a flag here that's agnostic to the value supplied to
`-rtlib` or `-stdlib`. Perhaps `-static-rtlib` (for either libgcc or
compiler-rt) and `-static-stdlib` (for either libc++ or libstdc++). (Yes, it's
bad that we use `stdlib` to mean "the C++ sta
MaskRay added a comment.
In https://reviews.llvm.org/D37726#1264233, @rsmith wrote:
> It would be nice to have a flag here that's agnostic to the value supplied to
> `-rtlib` or `-stdlib`. Perhaps `-static-rtlib` (for either libgcc or
> compiler-rt) and `-static-stdlib` (for either libc++ or li
rsmith added a comment.
Please extend the tests to check that the `-fclang-abi-compat=7` switch undoes
your change here.
One other comment, and otherwise this looks good. Will you need someone to
commit this for you?
Comment at: test/SemaCXX/align-x86.cpp:4-5
+
+#include
+#
rsmith added a comment.
Yeah, this looks better.
Though this really highlights that the "warn on undefined behavior" behavior of
the constant evaluator should be orthogonal to the evaluation mode... we don't
really need/want to evaluate past a side-effect or non-constant expression here.
http
Eugene.Zelenko added inline comments.
Comment at: docs/ReleaseNotes.rst:113
+
+- New alias :doc:`cppcoreguidelines-non-private-member-variables-in-classes
+
`
Please move new alias after new checks.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.o
Eugene.Zelenko added inline comments.
Comment at: clang-tidy/misc/IncorrectPointerCastCheck.cpp:80
+ }
+} // namespace misc
+
Somehow, misc namespace is closed twice.
Comment at: docs/ReleaseNotes.rst:60
+- New :doc:`misc-incorrect-pointer-c
MaskRay created this revision.
MaskRay added reviewers: martell, rsmith.
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D53238
Files:
include/clang/Driver/Options.td
lib/Driver/ToolChains/CommonArgs.cpp
lib/Driver/ToolChains/Darwin.cpp
lib/Driver/
NoQ created this revision.
NoQ added reviewers: mgorny, delcypher.
Herald added a subscriber: cfe-commits.
@mgorny: These fail for me on macOS too, if LLVM is configured as
cmake ../llvm/ -DCMAKE_BUILD_TYPE=Release -DLLVM_USE_SANITIZER=Address
I guess we might have to outright disable them und
delcypher accepted this revision.
delcypher added a comment.
This revision is now accepted and ready to land.
LGTM. But then I would say that because I wrote the patch 😛...
Repository:
rC Clang
https://reviews.llvm.org/D53239
___
cfe-commits mail
MaskRay updated this revision to Diff 169538.
MaskRay added a comment.
Rename local variables
Repository:
rC Clang
https://reviews.llvm.org/D53238
Files:
include/clang/Driver/Options.td
lib/Driver/ToolChains/CommonArgs.cpp
lib/Driver/ToolChains/Darwin.cpp
lib/Driver/ToolChains/Dragon
bcraig added inline comments.
Comment at: test/Analysis/padding_cpp.cpp:204-212
+// expected-warning@+1{{Excessive padding in 'struct FakeIntSandwich'}}
+struct FakeIntSandwich {
+ char c1;
+ int i;
+ char c2;
+};
+
Looking at this again... what new cases does
EricWF requested changes to this revision.
EricWF added inline comments.
This revision now requires changes to proceed.
Comment at: CMakeLists.txt:550
+endif()
add_compile_flags_if_supported(
+-Wextra -W -Wwrite-strings
Couldn't we keep the "-Wall" here? And
EricWF added inline comments.
Comment at:
test/std/thread/thread.threads/thread.thread.class/thread.thread.constr/F.pass.cpp:121
//allocations.
+int numAllocs;
+
Why?
Comment at:
test/std/thread/thread.threads/thread.thread.class/thread.
EricWF requested changes to this revision.
EricWF added a comment.
This revision now requires changes to proceed.
Requesting changes to move this out of my TODO review queue.
https://reviews.llvm.org/D50860
___
cfe-commits mailing list
cfe-commits@l
mclow.lists added a comment.
This is the first of part of this functionality. Some of these bits are not
here yet.
Comment at:
test/std/utilities/time/time.cal/time.cal.ymwd/time.cal.ymwd.members/ctor.sys_days.pass.cpp:10
+// UNSUPPORTED: c++03, c++11, c++14, c++17
+// XFAIL
kadircet added inline comments.
Comment at: clangd/ClangdLSPServer.cpp:338
+ Command Cmd;
+ if (Action.command && Action.edit)
+return llvm::None;
What would you think about emitting two commands in this case? First the edit
and then the command. I believe
EricWF added inline comments.
Comment at:
test/std/utilities/time/time.cal/time.cal.ymwd/time.cal.ymwd.members/ctor.sys_days.pass.cpp:10
+// UNSUPPORTED: c++03, c++11, c++14, c++17
+// XFAIL
+
mclow.lists wrote:
> EricWF wrote:
> > What?
> The `sys_days` type is
lebedev.ri marked an inline comment as done.
lebedev.ri added inline comments.
Comment at: docs/ReleaseNotes.rst:113
+
+- New alias :doc:`cppcoreguidelines-non-private-member-variables-in-classes
+
`
Eugene.Zelenko wrote:
> Please move new alias after new check
201 - 222 of 222 matches
Mail list logo
