rsmith added a comment.

Please extend the tests to check that the `-fclang-abi-compat=7` switch undoes 
your change here.

One other comment, and otherwise this looks good. Will you need someone to 
commit this for you?



================
Comment at: test/SemaCXX/align-x86.cpp:4-5
+
+#include <complex>
+#include <cstddef>
+
----------------
It's not OK to include standard library headers here -- there's no guarantee 
that anything sensible will be on the include path, and we want our tests to be 
self-contained. (Feel free to define your own mini-`std::complex` in this test.)


Repository:
  rC Clang

https://reviews.llvm.org/D53207



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to