mgorny created this revision.
mgorny added reviewers: sammccall, bkramer, aadg.
Herald added a subscriber: arphaman.
Remove the test checking for compilation db lookup failure.
Since r342228, JSONCompilationDatabasePlugin infers compile commands for
missing files, therefore making the lookup alway
Author: zturner
Date: Fri Oct 12 09:31:08 2018
New Revision: 344358
URL: http://llvm.org/viewvc/llvm-project?rev=344358&view=rev
Log:
Revert "Make YAML quote forward slashes."
This reverts commit b86c16ad8c97dadc1f529da72a5bb74e9eaed344.
This is being reverted because I forgot to write a useful
Author: zturner
Date: Fri Oct 12 09:31:20 2018
New Revision: 344359
URL: http://llvm.org/viewvc/llvm-project?rev=344359&view=rev
Log:
Make YAML quote forward slashes.
If you have the string /usr/bin, prior to this patch it would not
be quoted by our YAML serializer. But a string like C:\src woul
LukeCheeseman updated this revision to Diff 169430.
LukeCheeseman added a comment.
- Stop parsing msign-return-address as a scope and key pair
- pass bti value through to the CC1 driver and handle it, this adds the
branch-target-enforce attribute to functions
https://reviews.llvm.org/D51429
Fi
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
We could verify the fuzzy-matched results, but we have pretty good testing on
the C++ side, so a smoke test here seems fine.
Repository:
rC Clang
https://reviews.llvm.org/D53202
_
Author: zturner
Date: Fri Oct 12 09:41:37 2018
New Revision: 344362
URL: http://llvm.org/viewvc/llvm-project?rev=344362&view=rev
Log:
Fix one additional test broken by the YAML quoting change.
Modified:
clang-tools-extra/trunk/test/include-fixer/merge.test
Modified: clang-tools-extra/trunk/t
sammccall added inline comments.
Comment at: unittests/clangd/BackgroundIndexTests.cpp:14
+
+TEST(BackgroundIndexTest, IndexesOneFile) {
+ MockFSProvider FS;
ioeric wrote:
> sammccall wrote:
> > ioeric wrote:
> > > sammccall wrote:
> > > > ioeric wrote:
> > > >
Author: sammccall
Date: Fri Oct 12 09:51:48 2018
New Revision: 344363
URL: http://llvm.org/viewvc/llvm-project?rev=344363&view=rev
Log:
[clangd] Return Command objects from onCodeAction, rather than ad-hoc JSON. NFC
Modified:
clang-tools-extra/trunk/clangd/ClangdLSPServer.cpp
clang-tools-
mgorny added a comment.
Thanks for the review!
Repository:
rC Clang
https://reviews.llvm.org/D53202
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: mgorny
Date: Fri Oct 12 09:55:44 2018
New Revision: 344365
URL: http://llvm.org/viewvc/llvm-project?rev=344365&view=rev
Log:
[tests] Readd Python binding tests to check-all
Now that both issues found out during the last iteration have been
fixed, reenable the Python binding tests on build
Author: mgorny
Date: Fri Oct 12 09:55:39 2018
New Revision: 344364
URL: http://llvm.org/viewvc/llvm-project?rev=344364&view=rev
Log:
[python] [tests] Remove cdb lookup failure test
Remove the test checking for compilation db lookup failure.
Since r342228, JSONCompilationDatabasePlugin infers comp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344364: [python] [tests] Remove cdb lookup failure test
(authored by mgorny, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D53202?vs=169427&i
tekknolagi created this revision.
tekknolagi added reviewers: bcraig, NoQ.
tekknolagi added a project: clang.
The existing padding checker skips classes that have any base classes. This
patch allows the checker to traverse very simple cases: classes that have no
fields and have one base class.
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Hmm, I'd really like a test for this but I'm not sure it's really testable
as-is because it depends on a non-default configuration value. :(
Repository:
rC Clang
https://reviews.llvm.org/D
Author: danalbert
Date: Fri Oct 12 10:06:31 2018
New Revision: 344367
URL: http://llvm.org/viewvc/llvm-project?rev=344367&view=rev
Log:
[Driver] Add defaults for Android ARM FPUs.
Summary:
Android mandates that devices have at least vfpv3-d16 until
Marshmallow and NEON after that. Still honor the
This revision was automatically updated to reflect the committed changes.
Closed by commit rC344367: [Driver] Add defaults for Android ARM FPUs.
(authored by danalbert, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53121?vs=169291&id=169450#toc
Repository:
rC Clang
http
ubsan created this revision.
ubsan added a reviewer: rsmith.
Herald added a subscriber: cfe-commits.
- Add `UETT_PreferredAlignOf` to account for the difference between `__alignof`
and `alignof`
- `AlignOfType` now returns ABI alignment instead of preferred alignment iff
clang-abi-compat > 7, an
Hi Sam,
Your change is causing build failures on the PS4 Windows bot. Can you take a
look?
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/20638
FAILED: tools/clang/lib/Driver/CMakeFiles/clangDriver.dir/Compilation.cpp.obj
C:\PROGRA~2\MICROS~1.0\VC\bin\
JonasToth added a comment.
The patch does not apply clean, could you please take a look at it?
Am 12.10.2018 um 17:21 schrieb Whisperity via Phabricator:
> whisperity added a comment.
>
> @aaron.ballman Neither I nor @Charusso has commit rights, could you please
> commit this in our stead?
>
erichkeane added a comment.
@aaron.ballman or @rsmith any chance you guys could give me a hand on the
direction here? I'm growing GlobalDecl by quite a bit, so I want to make sure
this is both permissible and the right way to go. Additionally, feedback on
how to get a GlobalDecl down to getFu
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rC344373: [CodeGen] Handle extern references to OBJC_CLASS_$_*
(authored by epilk, committed by ).
Changed prior to commit:
Author: jonastoth
Date: Fri Oct 12 10:22:36 2018
New Revision: 344374
URL: http://llvm.org/viewvc/llvm-project?rev=344374&view=rev
Log:
[clang-tidy] New checker for not null-terminated result caused by strlen(),
size() or equal length
New checker called bugprone-not-null-terminated-result. This
Author: epilk
Date: Fri Oct 12 10:22:10 2018
New Revision: 344373
URL: http://llvm.org/viewvc/llvm-project?rev=344373&view=rev
Log:
[CodeGen] Handle extern references to OBJC_CLASS_$_*
Some ObjC users declare a extern variable named OBJC_CLASS_$_Foo, then use it's
address as a Class. I.e., one co
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344375: [Driver] check for exit code from SIGPIPE (authored
by nickdesaulniers, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D53001
Files:
cf
Author: nickdesaulniers
Date: Fri Oct 12 10:22:46 2018
New Revision: 344375
URL: http://llvm.org/viewvc/llvm-project?rev=344375&view=rev
Log:
[Driver] check for exit code from SIGPIPE
Summary:
D53000 adds a special exit code for SIGPIPE (writing to a closed
reader), and rather than print a fatal
sidneym added a comment.
Seems like the test cases do not consider the possibility of
CLANG_DEFAULT_LINKER being set. If CLANG_DEFAULT_LINKER was set to
"hexagon-link" these tests would probably pass.
I'm checking this out now.
Repository:
rC Clang
https://reviews.llvm.org/D53038
_
Author: jonastoth
Date: Fri Oct 12 10:36:04 2018
New Revision: 344379
URL: http://llvm.org/viewvc/llvm-project?rev=344379&view=rev
Log:
[doc] fix markup in clang-tidy bugprone-not-null-terminated-result
Modified:
clang-tools-extra/trunk/docs/clang-tidy/checks/bugprone-not-null-terminated-res
Author: jonastoth
Date: Fri Oct 12 10:44:01 2018
New Revision: 344382
URL: http://llvm.org/viewvc/llvm-project?rev=344382&view=rev
Log:
[Doc] fix BB, add code-block type
Modified:
cfe/trunk/docs/UsersManual.rst
Modified: cfe/trunk/docs/UsersManual.rst
URL:
http://llvm.org/viewvc/llvm-projec
Author: jonastoth
Date: Fri Oct 12 10:47:43 2018
New Revision: 344384
URL: http://llvm.org/viewvc/llvm-project?rev=344384&view=rev
Log:
[clangd] NFC fix semicolon warning
Modified:
clang-tools-extra/trunk/clangd/index/IndexAction.cpp
Modified: clang-tools-extra/trunk/clangd/index/IndexAction
ymandel updated this revision to Diff 169461.
ymandel marked 3 inline comments as done.
ymandel added a comment.
Adjusted reporting of warnings.
Also, addressed other comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53025
Files:
clang-tidy/readability/CMakeLists.txt
Author: jonastoth
Date: Fri Oct 12 10:57:18 2018
New Revision: 344388
URL: http://llvm.org/viewvc/llvm-project?rev=344388&view=rev
Log:
[Doc] fix second error in UsersManual
Modified:
cfe/trunk/docs/UsersManual.rst
Modified: cfe/trunk/docs/UsersManual.rst
URL:
http://llvm.org/viewvc/llvm-pr
kpn updated this revision to Diff 169463.
kpn added a comment.
Address review comments.
https://reviews.llvm.org/D52839
Files:
include/llvm/IR/IRBuilder.h
Index: include/llvm/IR/IRBuilder.h
===
--- include/llvm/IR/IRBuilder.h
++
ymandel added inline comments.
Comment at: clang-tidy/readability/ConstValueReturnCheck.cpp:25
+
+// Finds the location of the relevant "const" token in `Def`.
+llvm::Optional findConstToRemove(
JonasToth wrote:
> ymandel wrote:
> > JonasToth wrote:
> > > s/"cons
yaxunl added a comment.
This approach is trying to make OpenCL kernel and variable exceptions to
-fvisibility option. However it does not provide users with choices. What if a
user really wants to change the visibility of kernels and variables by
-fvisibility? I think is more like a hack compar
ymandel marked 5 inline comments as done.
ymandel added inline comments.
Comment at: clang-tidy/readability/ConstValueReturnCheck.cpp:60
+diag(Def->getInnerLocStart(),
+ "return type is 'const'-qualifed (possibly behind a type alias), "
+ "which hinders compil
lebedev.ri added a comment.
I think you have uploaded the wrong patch here.
https://reviews.llvm.org/D52839
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rnk
Date: Fri Oct 12 11:08:11 2018
New Revision: 344389
URL: http://llvm.org/viewvc/llvm-project?rev=344389&view=rev
Log:
Revert r344375 "[Driver] check for exit code from SIGPIPE"
This doesn't build on Windows.
Modified:
cfe/trunk/lib/Driver/Driver.cpp
Modified: cfe/trunk/lib/Drive
This patch makes a lot of posix assumptions, and that header file doesn't
exist on Windows. I reverted this to fix the build, but you might want to
reconsider how this is designed.
On Fri, Oct 12, 2018 at 10:24 AM Nick Desaulniers via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: nic
kpn updated this revision to Diff 169464.
kpn added a comment.
Upload the correct diff this time. Sorry about the confusion!
https://reviews.llvm.org/D52839
Files:
include/clang/AST/Expr.h
lib/AST/ASTImporter.cpp
lib/Analysis/BodyFarm.cpp
lib/CodeGen/CGExprScalar.cpp
lib/CodeGen/CGObj
bcraig added a comment.
You should probably add whoever the current code owner of that static analyzer
to this review. I have very little involvement with Clang these days, so a
"LGTM" from me doesn't carry much weight.
Comment at: lib/StaticAnalyzer/Checkers/PaddingChecker.
nickdesaulniers added a comment.
Thanks for the addition of the flags to the linker. Interesting note about
`-m*-endian` only being applicable for armv7. Just some minor nits left.
With the current version of the patch, I can now assemble, link, and boot in a
virtualized environment a big-endi
nickdesaulniers added inline comments.
Comment at: lib/Driver/ToolChains/Gnu.cpp:357-364
+const char* EndianFlag = "-EL";
+if (isArmBigEndian(Triple, Args)) {
+ EndianFlag = "-EB";
+ arm::appendBE8LinkFlag(Args, CmdArgs, Triple);
+}
+else if (Arch == llv
scott.linder added a comment.
The rationale is that `-fvisibility` only affects the default, and already does
not apply in many cases. For example, see the rest of the conditions above the
fvisibility check in `getLVForNamespaceScopeDecl`: when `Var->getStorageClass()
== SC_Static` the linkage
nickdesaulniers added a comment.
@rnk has reverted this due to breaking the windows build (sysexits.h) is not
available there.
Repository:
rL LLVM
https://reviews.llvm.org/D53001
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: lib/Driver/ToolChains/MinGW.cpp:383
+ Args.getLastArgValue(options::OPT_fuse_ld_EQ, CLANG_DEFAULT_LINKER)
+ .equals_lower("lld");
}
Thanks for the quick revert to keep the build green; sorry for breaking it.
Maybe we can discuss a fix in:
https://reviews.llvm.org/D53001
On Fri, Oct 12, 2018 at 11:11 AM Reid Kleckner wrote:
>
> This patch makes a lot of posix assumptions, and that header file doesn't
> exist on Windows. I reve
mstorsjo added inline comments.
Comment at: lib/Driver/ToolChains/MinGW.cpp:383
+ Args.getLastArgValue(options::OPT_fuse_ld_EQ, CLANG_DEFAULT_LINKER)
+ .equals_lower("lld");
}
rnk wrote:
> I thought we supported putting paths in this option, but I
nickdesaulniers added inline comments.
Comment at: cfe/trunk/lib/Driver/Driver.cpp:81-85
+#include
#include
#if LLVM_ON_UNIX
#include // getpid
#endif
@rnk || @majnemer thoughts on making this:
```
#if LLVM_ON_UNIX
#include // getpid
#include // EX_IOE
Charusso added a comment.
Thanks everyone for the contribution!
https://reviews.llvm.org/D45050
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
JonasToth added inline comments.
Comment at: clang-tidy/readability/ConstValueReturnCheck.cpp:25
+
+// Finds the location of the relevant "const" token in `Def`.
+llvm::Optional findConstToRemove(
ymandel wrote:
> JonasToth wrote:
> > ymandel wrote:
> > > JonasTo
JonasToth added a comment.
Committed with https://reviews.llvm.org/rCTE344374
https://reviews.llvm.org/D45050
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rksimon
Date: Fri Oct 12 11:55:36 2018
New Revision: 344398
URL: http://llvm.org/viewvc/llvm-project?rev=344398&view=rev
Log:
Consistently make llvm::opt::ArgStringList usage explicit to try and appease
MSVC 2015 buildbots. NFCI.
Modified:
cfe/trunk/include/clang/Driver/Job.h
cfe
rsmith added a comment.
In https://reviews.llvm.org/D52839#1262449, @kpn wrote:
> I forgot to address the template question. I've spend the past 18 years doing
> SystemZ backend work on multiple {,JIT} compilers. I'm not really in a
> position to answer your question about how to handle getting
yaxunl added a comment.
In https://reviews.llvm.org/D53153#1263771, @scott.linder wrote:
> The rationale is that `-fvisibility` only affects the default, and already
> does not apply in many cases. For example, see the rest of the conditions
> above the fvisibility check in `getLVForNamespaceSc
Author: rksimon
Date: Fri Oct 12 12:14:43 2018
New Revision: 344400
URL: http://llvm.org/viewvc/llvm-project?rev=344400&view=rev
Log:
Fix a clang::driver::ArgStringList usage I missed in rL344398. NFCI.
Modified:
cfe/trunk/examples/clang-interpreter/main.cpp
Modified: cfe/trunk/examples/clan
rsmith added a comment.
In https://reviews.llvm.org/D53153#1263771, @scott.linder wrote:
> The rationale is that `-fvisibility` only affects the default, and already
> does not apply in many cases. For example, see the rest of the conditions
> above the fvisibility check in `getLVForNamespaceSc
scott.linder added a comment.
That's my understanding, at least.
Take for example:
$ cat foo.c
static void foo() { }
void bar() { }
void baz() { bar(); foo(); }
$ clang -fvisibility=protected -O0 -S -emit-llvm foo.c -o -
...
; Function Attrs: noinline nounwind optnone uwtab
scott.linder added a subscriber: b-sumner.
scott.linder added a comment.
In https://reviews.llvm.org/D53153#1263804, @rsmith wrote:
> In https://reviews.llvm.org/D53153#1263771, @scott.linder wrote:
>
> > The rationale is that `-fvisibility` only affects the default, and already
> > does not app
nickdesaulniers created this revision.
nickdesaulniers added reviewers: rnk, majnemer, jfb.
Herald added a subscriber: cfe-commits.
Add preprocessor guards for UNIX.
This reverts commit c2275676c1bde4ed20c06affdeeb1a93692f29a8.
Repository:
rC Clang
https://reviews.llvm.org/D53210
Files:
l
nickdesaulniers marked an inline comment as done.
nickdesaulniers added inline comments.
Comment at: cfe/trunk/lib/Driver/Driver.cpp:81-85
+#include
#include
#if LLVM_ON_UNIX
#include // getpid
#endif
nickdesaulniers wrote:
> @rnk || @majnemer thoughts on
rsmith added a comment.
Thanks, this generally looks good, but it needs tests. For `_Alignof`,
test/Sema/align-x86.c` would be a reasonable place for the test; for C++
`alignof`, I don't see a suitable existing test file, but you could add one to
test/SemaCXX, perhaps based on test/Sema/align-x
Author: benhamilton
Date: Fri Oct 12 12:43:01 2018
New Revision: 344406
URL: http://llvm.org/viewvc/llvm-project?rev=344406&view=rev
Log:
[clang-format] Fix BraceWrapping AfterFunction for ObjC methods
Summary:
> clang-format --version
> clang-format version 7.0.0 (tags/RELEASE_700/final)
> echo
This revision was automatically updated to reflect the committed changes.
Closed by commit rC344406: [clang-format] Fix BraceWrapping AfterFunction for
ObjC methods (authored by benhamilton, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D53197
Files:
lib/Format/UnwrappedLine
benhamilton added a comment.
> @benhamilton Could you land this patch?
Done. Thanks for your contribution!
Repository:
rC Clang
https://reviews.llvm.org/D53197
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
yaxunl added a comment.
In https://reviews.llvm.org/D53153#1263810, @scott.linder wrote:
> In https://reviews.llvm.org/D53153#1263804, @rsmith wrote:
>
> > In https://reviews.llvm.org/D53153#1263771, @scott.linder wrote:
> >
> > > The rationale is that `-fvisibility` only affects the default, and
Author: rksimon
Date: Fri Oct 12 12:46:40 2018
New Revision: 344408
URL: http://llvm.org/viewvc/llvm-project?rev=344408&view=rev
Log:
Revert rL344365: [tests] Readd Python binding tests to check-all
Windows buildbots are still not happy
Now that both issues found out during the last iteration ha
scott.linder added a comment.
In https://reviews.llvm.org/D53153#1263835, @yaxunl wrote:
> In https://reviews.llvm.org/D53153#1263810, @scott.linder wrote:
>
> > In https://reviews.llvm.org/D53153#1263804, @rsmith wrote:
> >
> > > In https://reviews.llvm.org/D53153#1263771, @scott.linder wrote:
>
Author: mgorny
Date: Fri Oct 12 13:03:54 2018
New Revision: 344411
URL: http://llvm.org/viewvc/llvm-project?rev=344411&view=rev
Log:
[python] [tests] Re-add once again, this time without Windows
Modified:
cfe/trunk/bindings/python/tests/CMakeLists.txt
Modified: cfe/trunk/bindings/python/test
scott.linder added a comment.
Beyond constructors/destructors I believe an API which we implement through
access to dynamic symbols for global variable is `clGetProgramBuildInfo(...,
CL_PROGRAM_BUILD_GLOBAL_VARIABLE_TOTAL_SIZE, ...)` which is defined as "The
total amount of storage, in bytes, u
david2050 created this revision.
Herald added subscribers: cfe-commits, mgorny.
When building in an LLVM context, we should respect its LLVM_ENABLE_LIBXML2
option.
Repository:
rC Clang
https://reviews.llvm.org/D53212
Files:
CMakeLists.txt
Index: CMakeLists.txt
==
sammccall created this revision.
sammccall added a reviewer: kadircet.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric,
ilya-biryukov.
I don't bother mirroring the full capabilities struct, just parse the
bits we care about. I'll send a new patch to use this approach els
mgorny added inline comments.
Comment at: CMakeLists.txt:92
option(CLANG_ENABLE_BOOTSTRAP "Generate the clang bootstrap target" OFF)
+ option(LLVM_ENABLE_LIBXM2 "Use libxml2 if available." ON)
I suppose it will work better without typos.
Repository:
rC
david2050 updated this revision to Diff 169482.
david2050 added a comment.
fix typo
Repository:
rC Clang
https://reviews.llvm.org/D53212
Files:
CMakeLists.txt
Index: CMakeLists.txt
===
--- CMakeLists.txt
+++ CMakeLists.txt
@
rsmith added a comment.
In https://reviews.llvm.org/D53153#1263848, @scott.linder wrote:
> Beyond constructors/destructors I believe an API which we implement through
> access to dynamic symbols for global variable is `clGetProgramBuildInfo(...,
> CL_PROGRAM_BUILD_GLOBAL_VARIABLE_TOTAL_SIZE, ..
Author: mstorsjo
Date: Fri Oct 12 13:15:51 2018
New Revision: 344412
URL: http://llvm.org/viewvc/llvm-project?rev=344412&view=rev
Log:
[MinGW] Allow using LTO when lld is used as linker
Differential Revision: https://reviews.llvm.org/D53195
Added:
cfe/trunk/test/Driver/mingw-lto.c
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344412: [MinGW] Allow using LTO when lld is used as linker
(authored by mstorsjo, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D53195?vs=169
Author: abataev
Date: Fri Oct 12 13:19:59 2018
New Revision: 344413
URL: http://llvm.org/viewvc/llvm-project?rev=344413&view=rev
Log:
[OPENMP][NVPTX]Reduce memory usage in target region.
Additional reduction of the global memory usage in the target regions
without parallel regions.
Modified:
mstorsjo added a comment.
Ping @rnk or others with good ideas
Repository:
rC Clang
https://reviews.llvm.org/D53066
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk added inline comments.
Comment at: lib/Driver/Job.cpp:104-105
+ std::string Buf;
+ if (PathStyle == llvm::sys::path::Style::posix) {
+Buf = llvm::sys::path::convert_to_slash(Arg);
+Arg = Buf;
This is blindly treating every argument as if it were a p
Hello everyone,
LLVM buildmaster will be updated and restarted after 6PM Pacific time today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vmiklos created this revision.
vmiklos added reviewers: alexfh, malcolm.parsons.
Herald added a subscriber: cfe-commits.
And also enable it by default to be consistent with e.g. modernize-use-using.
This improves consistency inside the check itself as well: both checks are now
disabled in macros
sidneym created this revision.
sidneym added reviewers: bcain, davezarzycki, kparzysz, shankare.
Herald added a subscriber: cfe-commits.
Don't assume the linker is hexagon-link. https://reviews.llvm.org/D53038
removed the hard-coded name so now it is possible for the other named linkers
to be u
sidneym added a comment.
I updated the tests: https://reviews.llvm.org/D53219
Repository:
rC Clang
https://reviews.llvm.org/D53038
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
simark created this revision.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, ioeric,
ilya-biryukov.
This patch removes the possibility to change the compilation database
path at runtime using the didChangeConfiguration request. Instead, it
is suggested to use the setting on
simark added a comment.
Thanks for your input. I have opened https://reviews.llvm.org/D53220, which
removes that option.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51725
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
tekknolagi edited reviewers, added: dcoughlin; removed: malcolm.parsons.
tekknolagi added a comment.
Sorry @malcolm.parsons -- I misunderstood code owners. Should not have just
looked at a blame of the file...
Repository:
rC Clang
https://reviews.llvm.org/D53206
__
mstorsjo added inline comments.
Comment at: lib/Driver/Job.cpp:104-105
+ std::string Buf;
+ if (PathStyle == llvm::sys::path::Style::posix) {
+Buf = llvm::sys::path::convert_to_slash(Arg);
+Arg = Buf;
rnk wrote:
> This is blindly treating every argument
tekknolagi added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/PaddingChecker.cpp:167-171
}
+// How do you reorder fields if you haven't got any?
+else if (RD->field_empty())
+ return true;
+
bcraig wrote:
> I think this should just b
leonardchan updated this revision to Diff 169495.
Repository:
rC Clang
https://reviews.llvm.org/D50616
Files:
include/clang/AST/OperationKinds.def
include/clang/AST/Type.h
include/clang/Basic/DiagnosticCommonKinds.td
lib/AST/Expr.cpp
lib/AST/ExprConstant.cpp
lib/AST/Type.cpp
lib/
NoQ added a reviewer: george.karpenkov.
NoQ added a comment.
I'll take care of this review as an [analyzer]-responsible person, maybe not
immediately because i'm a bit overwhelmed right now - sorry! - and George may
want to have a look (also or instead).
Repository:
rC Clang
https://reviews
leonardchan updated this revision to Diff 169500.
leonardchan added a comment.
- Removed target hook
Repository:
rC Clang
https://reviews.llvm.org/D50616
Files:
include/clang/AST/OperationKinds.def
include/clang/AST/Type.h
include/clang/Basic/DiagnosticCommonKinds.td
lib/AST/Expr.cpp
ymandel added inline comments.
Comment at: clang-tidy/readability/ConstValueReturnCheck.cpp:64
+
+ // Fix the definition.
+ llvm::Optional Loc = findConstToRemove(Def, Result);
JonasToth wrote:
> ymandel wrote:
> > JonasToth wrote:
> > > I feel that this commen
tekknolagi updated this revision to Diff 169501.
tekknolagi added a comment.
Fix confusing & wrong if-statements, add new test suggested by @bcraig
Repository:
rC Clang
https://reviews.llvm.org/D53206
Files:
lib/StaticAnalyzer/Checkers/PaddingChecker.cpp
test/Analysis/padding_cpp.cpp
t
rnk added inline comments.
Comment at: lib/Driver/Job.cpp:104-105
+ std::string Buf;
+ if (PathStyle == llvm::sys::path::Style::posix) {
+Buf = llvm::sys::path::convert_to_slash(Arg);
+Arg = Buf;
mstorsjo wrote:
> rnk wrote:
> > This is blindly treating
ubsan updated this revision to Diff 169503.
ubsan added a comment.
add tests
fix nits
Repository:
rC Clang
https://reviews.llvm.org/D53207
Files:
include/clang/ASTMatchers/ASTMatchers.h
include/clang/Basic/LangOptions.h
include/clang/Basic/TypeTraits.h
lib/AST/ASTDumper.cpp
lib/AS
mstorsjo added inline comments.
Comment at: lib/Driver/Job.cpp:104-105
+ std::string Buf;
+ if (PathStyle == llvm::sys::path::Style::posix) {
+Buf = llvm::sys::path::convert_to_slash(Arg);
+Arg = Buf;
rnk wrote:
> mstorsjo wrote:
> > rnk wrote:
> > > Th
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
I think it's fine, just remove the git hash from the commit message and just
refer to the svn number.
Repository:
rC Clang
https://reviews.llvm.org/D53210
davezarzycki added a comment.
Tested and verified with `-DCLANG_DEFAULT_LINKER=lld`
Repository:
rC Clang
https://reviews.llvm.org/D53219
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
orivej added inline comments.
Comment at: lib/Sema/SemaInit.cpp:6034
TSInfo = S.Context.getTrivialTypeSourceInfo(Entity.getType(), Loc);
-SourceRange ParenOrBraceRange =
- (Kind.getKind() == InitializationKind::IK_DirectList)
- ? SourceRange(LBraceLoc, RBrace
leonardchan added a comment.
In https://reviews.llvm.org/D52814#1262550, @philip.pfaffe wrote:
> You're right, my bad; I missed the fact that it's EP_OptimizerLast, which has
> no equivalent in the new PM. Your implementation is actually correct here.
>
> Did you run your test in a debug build?
101 - 200 of 222 matches
Mail list logo
