rnk added inline comments.
================
Comment at: lib/Driver/Job.cpp:104-105
+ std::string Buf;
+ if (PathStyle == llvm::sys::path::Style::posix) {
+ Buf = llvm::sys::path::convert_to_slash(Arg);
+ Arg = Buf;
----------------
This is blindly treating every argument as if it were a path. I can imagine
someone wanting to define a macro to a string value containing backslashes,
such as: `-DAWESOME_MACRO="\"asdf\""`
Given that this is used for -### and crash diagnostic printing, I'm hesitant to
do this here. I think it might be better to, in a cygming environment, try to
convert all our paths to forward slashes before we add them to the command line.
Repository:
rC Clang
https://reviews.llvm.org/D53066
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
