[PATCH] D50766: Fix false positive unsequenced access and modification warning in array subscript expression.

Rakete accepted this revision. Rakete added a comment. This revision is now accepted and ready to land. Nevermind my last comment, I was tired. LGTM https://reviews.llvm.org/D50766 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D52835: [Diagnostics] Check integer to floating point number implicit conversions

xbolva00 added a comment. Any comments? Waiting for approval here to move focus on some other patches :) https://reviews.llvm.org/D52835 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[PATCH] D50901: [clang][ubsan] Split Implicit Integer Truncation Sanitizer into unsigned and signed checks

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. This looks good to me. Sounds like @filcab is intending on doing another round of review too, so it'd make sense to double-check there before committing. Comment at: docs/Un

[PATCH] D50766: Fix false positive unsequenced access and modification warning in array subscript expression.

rsmith accepted this revision. rsmith added a comment. Thanks, LGTM! Are you interested in fixing the other cases for which p0145 tightened evaluation order (`.`, `->`, `.*`, `->*`, `<<`, `>>`, callee in a function call, assignment and compound assignment) too? =) https://reviews.llvm.org/D50

[PATCH] D53115: [COFF, ARM64] Add _ReadStatusReg and_WriteStatusReg intrinsics

mgrang created this revision. mgrang added reviewers: rnk, compnerd, mstorsjo, efriedma, TomTan, haripul. Herald added a reviewer: javed.absar. Herald added subscribers: chrib, kristof.beyls. Repository: rC Clang https://reviews.llvm.org/D53115 Files: include/clang/Basic/BuiltinsAArch64.def

[PATCH] D53115: [COFF, ARM64] Add _ReadStatusReg and_WriteStatusReg intrinsics

mgrang added a comment. _ReadStatusReg and _WriteStatusReg intrinsics take ARM64_REGNO as input. These are defined in https://www.codemachine.com/downloads/win10/winnt.h. LLVM already has intrinsics to read/write status regs: __builtin_arm_rsr/__builtin_arm_wsr. But these take the string concate

[PATCH] D53115: [COFF, ARM64] Add _ReadStatusReg and_WriteStatusReg intrinsics

mgrang added inline comments. Comment at: test/CodeGen/arm64-microsoft-status-reg.cpp:1 +// RUN: %clang_cc1 -triple arm64-windows -fms-compatibility -emit-llvm -S \ +// RUN: -o - %s | FileCheck %s -check-prefix CHECK-ASM I had to create a new test file here as th

[PATCH] D52835: [Diagnostics] Check integer to floating point number implicit conversions

efriedma added a comment. Probably should have a test for something like `float x = (__uint128_t)-1;`, to make sure we print something reasonable. Comment at: lib/Sema/SemaChecking.cpp:10874 + if (Target->isSpecificBuiltinType(BuiltinType::LongDouble)) +FloatSem =

r344199 - Add a flag to remap manglings when reading profile data information.

Author: rsmith Date: Wed Oct 10 16:13:35 2018 New Revision: 344199 URL: http://llvm.org/viewvc/llvm-project?rev=344199&view=rev Log: Add a flag to remap manglings when reading profile data information. This can be used to preserve profiling information across codebase changes that have widespread

[PATCH] D53115: [COFF, ARM64] Add _ReadStatusReg and_WriteStatusReg intrinsics

efriedma added a comment. Missing Sema changes? Repository: rC Clang https://reviews.llvm.org/D53115 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50901: [clang][ubsan] Split Implicit Integer Truncation Sanitizer into unsigned and signed checks

filcab added a comment. LGTM on the clang side too. Thank you, Filipe Repository: rC Clang https://reviews.llvm.org/D50901 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r344199 - Add a flag to remap manglings when reading profile data information.

On 10/10/2018 4:13 PM, Richard Smith via cfe-commits wrote: Author: rsmith Date: Wed Oct 10 16:13:35 2018 New Revision: 344199 URL: http://llvm.org/viewvc/llvm-project?rev=344199&view=rev Log: Add a flag to remap manglings when reading profile data information. This can be used to preserve prof

Re: [PATCH] D50901: [clang][ubsan] Split Implicit Integer Truncation Sanitizer into unsigned and signed checks

LGTM on the clang side too. Thank you, Filipe On Wed, 10 Oct 2018 at 23:33, Richard Smith - zygoloid via Phabricator < revi...@reviews.llvm.org> wrote: > rsmith accepted this revision. > rsmith added a comment. > This revision is now accepted and ready to land. > > This looks good to me. Sounds

r344201 - Update documentation to indicate that profile remapping support is only

Author: rsmith Date: Wed Oct 10 16:33:18 2018 New Revision: 344201 URL: http://llvm.org/viewvc/llvm-project?rev=344201&view=rev Log: Update documentation to indicate that profile remapping support is only implemented for the new pass manager so far. Modified: cfe/trunk/docs/UsersManual.rst M

[PATCH] D53115: [COFF, ARM64] Add _ReadStatusReg and_WriteStatusReg intrinsics

mgrang updated this revision to Diff 169127. https://reviews.llvm.org/D53115 Files: include/clang/Basic/BuiltinsAArch64.def lib/CodeGen/CGBuiltin.cpp lib/Headers/intrin.h lib/Sema/SemaChecking.cpp test/CodeGen/arm64-microsoft-status-reg.cpp test/Sema/builtins-microsoft-arm64.c Index:

r344205 - [WebAssembly] Saturating float-to-int builtins

Author: tlively Date: Wed Oct 10 17:07:55 2018 New Revision: 344205 URL: http://llvm.org/viewvc/llvm-project?rev=344205&view=rev Log: [WebAssembly] Saturating float-to-int builtins Summary: Depends on D53007 and D53004. Reviewers: aheejin, dschuff Subscribers: sbc100, jgravelle-google, sunfish,

[PATCH] D53009: [WebAssembly] Saturating float-to-int builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rC344205: [WebAssembly] Saturating float-to-int builtins (authored by tlively, committed by ). Changed prior to commit: https://reviews.llvm.org/D53009?vs=168738&id=169132#toc Repository: rC Clang htt

[PATCH] D53117: [Driver] Default to `-z now` and `-z relro` on Android.

danalbert created this revision. danalbert added reviewers: srhines, pirama. RTLD_LAZY is not supported on Android (though failing to use `-z now` will work since it is assumed by the loader). RelRO is required. Repository: rC Clang https://reviews.llvm.org/D53117 Files: lib/Drive

[PATCH] D53118: [Driver] Fix --hash-style choice for Android.

danalbert created this revision. danalbert added reviewers: srhines, pirama. Android supports GNU style hashes as of Marshmallow, so we should be generating both styles for pre-M targets and GNU hashes for newer targets. Repository: rC Clang https://reviews.llvm.org/D53118 Files: lib/Drive

[PATCH] D53121: [Driver] Add defaults for Android ARM FPUs.

danalbert created this revision. danalbert added reviewers: srhines, pirama. Herald added a reviewer: javed.absar. Herald added subscribers: chrib, kristof.beyls. Android mandates that devices have at least vfpv3-d16 until Marshmallow and NEON after that. Still honor the user's decision, but raise

[PATCH] D53121: [Driver] Add defaults for Android ARM FPUs.

danalbert added a comment. Related to this but something I was less sure we should do: Android no longer supports ARMv5. Should we make `arm-linux-androideabi` targets auto pull up to armv7 if there's no `-march` flag? Repository: rC Clang https://reviews.llvm.org/D53121

[PATCH] D53115: [COFF, ARM64] Add _ReadStatusReg and_WriteStatusReg intrinsics

efriedma added inline comments. Comment at: lib/Sema/SemaChecking.cpp:1754 + // argument here. Any constant would be converted to a register of + // the form S1_2_C3_C4_5. Let the hardware throw an exception for incorrect + // registers. This matches MSVC behavior. ---

[PATCH] D53109: [Driver] Default Android toolchains to libc++.

srhines accepted this revision. srhines added a comment. This revision is now accepted and ready to land. Really cool! Thanks for making everything easier to use out-of-the-box. Repository: rC Clang https://reviews.llvm.org/D53109 ___ cfe-commits

[PATCH] D53121: [Driver] Add defaults for Android ARM FPUs.

srhines added a comment. This LGTM, but we should wait to hear from Kristof before submitting. Repository: rC Clang https://reviews.llvm.org/D53121 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

[PATCH] D52673: [HIP] Remove disabled irif library

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! https://reviews.llvm.org/D52673 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D53100: clang: Add ARCTargetInfo

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. Repository: rC Clang https://reviews.llvm.org/D53100 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.ll

[PATCH] D53125: Detect Clear Linux and apply Clear's default linker options

thiagomacieira created this revision. thiagomacieira added reviewers: mgorny, erichkeane. Herald added subscribers: cfe-commits, srhines. /usr/lib/os-release is the official path of /etc/os-release (the latter is usually a symlink to the former) Repository: rC Clang https://reviews.llvm.org/

[PATCH] D51762: First part of the calendar stuff

EricWF added a comment. Herald added a subscriber: arphaman. What's with all the XFAIL's? Comment at: test/std/utilities/time/time.cal/time.cal.ymwd/time.cal.ymwd.members/ctor.sys_days.pass.cpp:10 +// UNSUPPORTED: c++03, c++11, c++14, c++17 +// XFAIL + What?

[PATCH] D53125: Detect Clear Linux and apply Clear's default linker options

thiagomacieira updated this revision to Diff 169151. thiagomacieira added a comment. Oops, add the missing portion of the unit test (the part that actually tests). https://reviews.llvm.org/D53125 Files: include/clang/Driver/Distro.h lib/Driver/Distro.cpp lib/Driver/ToolChains/Linux.cpp

[PATCH] D53125: Detect Clear Linux and apply Clear's default linker options

thiagomacieira updated this revision to Diff 169152. https://reviews.llvm.org/D53125 Files: include/clang/Driver/Distro.h lib/Driver/Distro.cpp lib/Driver/ToolChains/Linux.cpp unittests/Driver/DistroTest.cpp Index: unittests/Driver/DistroTest.cpp =

[PATCH] D50766: Fix false positive unsequenced access and modification warning in array subscript expression.

lebedev.ri added inline comments. Comment at: test/SemaCXX/warn-unsequenced-cxx17.cpp:1 +// RUN: %clang_cc1 -fsyntax-only -verify -std=c++17 -Wno-unused %s + One last-minute thought: this is only a positive test. You don't test what happens before C++17. https:

[PATCH] D53024: [analyzer][www] Add more open projects

MTC added subscribers: teemperor, baloghadamsoftware, blitz.opensource. MTC added a comment. Herald added a subscriber: donat.nagy. In https://reviews.llvm.org/D53024#1258976, @Szelethus wrote: > Also, a lot of items on this list is outdated, but I joined the project > relatively recently, so I'

Re: r344199 - Add a flag to remap manglings when reading profile data information.

Hi Richard, This patch broke ARM bots which don't have x86_64 target available. Logs are available here: http://lab.llvm.org:8011/builders/clang-cmake-armv7-quick/builds/4326/steps/ninja%20check%201/logs/FAIL%3A%20Clang%3A%3Aprofile-remap.cpp Cheers, Yvan On Thu, 11 Oct 2018 at 01:15, Richard

[PATCH] D50901: [clang][ubsan] Split Implicit Integer Truncation Sanitizer into unsigned and signed checks

lebedev.ri added a comment. In https://reviews.llvm.org/D50901#1261203, @rsmith wrote: > This looks good to me. Sounds like @filcab is intending on doing another > round of review too, so it'd make sense to double-check there before > committing. In https://reviews.llvm.org/D50901#1261312,

<    1   2