LGTM on the clang side too. Thank you, Filipe
On Wed, 10 Oct 2018 at 23:33, Richard Smith - zygoloid via Phabricator < revi...@reviews.llvm.org> wrote: > rsmith accepted this revision. > rsmith added a comment. > This revision is now accepted and ready to land. > > This looks good to me. Sounds like @filcab is intending on doing another > round of review too, so it'd make sense to double-check there before > committing. > > > > ================ > Comment at: docs/UndefinedBehaviorSanitizer.rst:101 > + conversions - when either one, or both of the types are signed. > Issues caught by this sanitizer are not undefined behavior, > but are often unintentional. > ---------------- > this sanitizer -> these sanitizers > > > Repository: > rC Clang > > https://reviews.llvm.org/D50901 > > > >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
