craig.topper added inline comments.
Comment at: lib/Basic/Targets/X86.cpp:169
setFeatureEnabledImpl(Features, "mpx", true);
if (Kind != CK_SkylakeServer) // SKX inherits all SKL features, except SGX
setFeatureEnabledImpl(Features, "sgx", true);
l
Author: epilk
Date: Tue Oct 9 17:40:50 2018
New Revision: 344101
URL: http://llvm.org/viewvc/llvm-project?rev=344101&view=rev
Log:
[Basic] Split out -Wimplicit-int-conversion and -Wimplicit-float-conversion
from -Wconversion
These two diagnostics are noisy, so its reasonable for users to opt-ou
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344101: [Basic] Split out -Wimplicit-int-conversion and
-Wimplicit-float-conversion… (authored by epilk, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews
craig.topper requested changes to this revision.
craig.topper added a comment.
This revision now requires changes to proceed.
But there is definitely at least one test that needs to be updated.
@thiagomacieira, can update them or would you like me to?
Comment at: lib/Basic/Tar
thiagomacieira added inline comments.
Comment at: lib/Basic/Targets/X86.cpp:169
setFeatureEnabledImpl(Features, "mpx", true);
if (Kind != CK_SkylakeServer) // SKX inherits all SKL features, except SGX
setFeatureEnabledImpl(Features, "sgx", true);
rsmith added a comment.
Generally this looks good, but it needs an accompanying test.
Comment at: include/clang/AST/ASTContext.h:1129-1130
+ /// Retrieve the declaration for the type_info class type.
+ RecordDecl *getTypeInfoClassDecl() const;
+
Please indi
Author: jyknight
Date: Tue Oct 9 19:53:43 2018
New Revision: 344110
URL: http://llvm.org/viewvc/llvm-project?rev=344110&view=rev
Log:
ExprConstant: Make __builtin_object_size use EM_IgnoreSideEffects.
And, since EM_OffsetFold is now unused, remove it.
While builtin_object_size intends to ignore
This revision was automatically updated to reflect the committed changes.
Closed by commit rC344110: ExprConstant: Make __builtin_object_size use
EM_IgnoreSideEffects. (authored by jyknight, committed by ).
Herald added a subscriber: kristina.
Changed prior to commit:
https://reviews.llvm.org/D
rjmccall added a comment.
The linking does actually happen in this test case, right? Can we just do
something when linking them to unify their `Common` structures?
Repository:
rC Clang
https://reviews.llvm.org/D53046
___
cfe-commits mailing lis
rjmccall added a comment.
In https://reviews.llvm.org/D50616#1259769, @leonardchan wrote:
> @ebevhan @rjmccall Seeing that the saturation intrinsic in
> https://reviews.llvm.org/D52286 should be put on hold for now, would it be
> fine to submit this patch as is? Then if the intrinsic is finishe
thiagomacieira updated this revision to Diff 168936.
thiagomacieira added a comment.
Added test update
https://reviews.llvm.org/D53042
Files:
lib/Basic/Targets/X86.cpp
test/Preprocessor/predefined-arch-macros.c
Index: test/Preprocessor/predefined-arch-macros.c
=
erik.pilkington added a comment.
In https://reviews.llvm.org/D53046#1259933, @rjmccall wrote:
> The linking does actually happen in this test case, right? Can we just do
> something when linking them to unify their `Common` structures?
Yep, that would work too I think. We can't properly merge
rjmccall added a comment.
In https://reviews.llvm.org/D53046#1259945, @erik.pilkington wrote:
> In https://reviews.llvm.org/D53046#1259933, @rjmccall wrote:
>
> > The linking does actually happen in this test case, right? Can we just do
> > something when linking them to unify their `Common` st
jfb added a comment.
Can you add tests with arrays?
The error message doesn't really say what to do instead. What's wrong? What's
correct instead?
In C++17 and later we should suggest using `std::size` for some cases instead.
https://reviews.llvm.org/D52949
__
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D53042
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
MaskRay created this revision.
MaskRay added a reviewer: hokein.
Herald added subscribers: cfe-commits, ioeric.
The use sites are enclosed by `namespace clang`, so clang:: is not
necessary. Many unqualified names have already been used, e.g. SourceManager
SourceLocation LangOptions. This change m
erik.pilkington updated this revision to Diff 168939.
erik.pilkington added a comment.
Merge the common pointers rather than trying to use the previous one. Thanks!
https://reviews.llvm.org/D53046
Files:
clang/include/clang/AST/DeclTemplate.h
clang/lib/AST/DeclTemplate.cpp
clang/lib/Sema/
lebedev.ri added inline comments.
Comment at: lib/Basic/Targets/X86.cpp:169
setFeatureEnabledImpl(Features, "mpx", true);
if (Kind != CK_SkylakeServer) // SKX inherits all SKL features, except SGX
setFeatureEnabledImpl(Features, "sgx", true);
thi
ZaMaZaN4iK added a comment.
Herald added a subscriber: Szelethus.
What is the status of the PR?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46027
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
mwasplund added a comment.
In https://reviews.llvm.org/D52973#1259909, @rsmith wrote:
> Generally this looks good, but it needs an accompanying test.
I was looking into that and trying to read up on the documentation for adding
tests. I think I understand the crazy comment RUN test invocation,
sylvestre.ledru added a comment.
Herald added a subscriber: arphaman.
I am sorry but I am not the right reviewer for that. Sorry!
Repository:
rC Clang
https://reviews.llvm.org/D52173
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
xazax.hun added a comment.
In https://reviews.llvm.org/D52983#1258466, @NoQ wrote:
> Yay, these look useful. Is there also an attribute for methods that should
> never be called on a 'moved-from' object?
I do not know about such attribute, but once contracts are implemented and
wide-spread, a
Author: xazax
Date: Tue Oct 9 00:28:57 2018
New Revision: 344017
URL: http://llvm.org/viewvc/llvm-project?rev=344017&view=rev
Log:
[analyzer] Support Reinitializes attribute in MisusedMovedObject check
Differential Revision: https://reviews.llvm.org/D52983
Modified:
cfe/trunk/lib/StaticAnal
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344017: [analyzer] Support Reinitializes attribute in
MisusedMovedObject check (authored by xazax, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.
Szelethus added inline comments.
Comment at: www/analyzer/alpha_checks.html:450
-
-Variable Argument Alpha Checkers
-
NoQ wrote:
> I think these are missing on the available checkers list, so we should move
> rather than delete.
Indeed, I intend to update `avaib
xazax.hun added inline comments.
Comment at: www/analyzer/checker_dev_manual.html:708
+Checker Reviewer Checklist
+
NoQ wrote:
> I think we actually need two separate checklists:
> * for common bugs (careful use of non-fatal error nodes, etc. - stuff we
> chec
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
Thanks for fixing it. It looks much simpler than I thought originally.
Looks good, just a few nits.
Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:246
+
mstorsjo created this revision.
mstorsjo added reviewers: rnk, smeenai.
This assumes that the library is an import library for a system dll (named e.g.
libkernel32.a) or a static library; it won't work for import libraries for
normal user dlls named e.g. libfoo.dll.a). Since ld.bfd doesn't suppo
sylvestre.ledru created this revision.
sylvestre.ledru added a reviewer: ecbeckmann.
Herald added a subscriber: mgorny.
When building clang in stage2, when -DCMAKE_BUILD_TYPE=RelWithDebInfo is set,
the developer can expect that the stage2 clang is built using the same mode.
Especially as the perfo
kadircet created this revision.
kadircet added a reviewer: sammccall.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric,
ilya-biryukov.
Also change output of percent-encoding to use upper-case letters.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53016
Author: steveire
Date: Tue Oct 9 01:24:11 2018
New Revision: 344022
URL: http://llvm.org/viewvc/llvm-project?rev=344022&view=rev
Log:
Regenerate AST Matcher docs
Modified:
cfe/trunk/docs/LibASTMatchersReference.html
Modified: cfe/trunk/docs/LibASTMatchersReference.html
URL:
http://llvm.org
Author: steveire
Date: Tue Oct 9 01:24:18 2018
New Revision: 344023
URL: http://llvm.org/viewvc/llvm-project?rev=344023&view=rev
Log:
Remove non-existant typeloc matchers from documentation
Modified:
cfe/trunk/docs/LibASTMatchersReference.html
cfe/trunk/docs/tools/dump_ast_matchers.py
M
Author: steveire
Date: Tue Oct 9 01:24:06 2018
New Revision: 344021
URL: http://llvm.org/viewvc/llvm-project?rev=344021&view=rev
Log:
Fix indentation
Modified:
cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h
Modified: cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h
URL:
http://llvm.org
grimar added a comment.
Ping.
https://reviews.llvm.org/D52296
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ioeric
Date: Tue Oct 9 01:27:31 2018
New Revision: 344024
URL: http://llvm.org/viewvc/llvm-project?rev=344024&view=rev
Log:
[clangd] Avoid cache main file status in preamble.
Summary: Main file can certainly change when reusing preamble.
Reviewers: sammccall
Subscribers: ilya-biryukov,
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344024: [clangd] Avoid cache main file status in preamble.
(authored by ioeric, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D52991
Files:
cl
kadircet updated this revision to Diff 168762.
kadircet added a comment.
- Revert to previous heuristic with special handling of empty fixit range.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52889
Files:
clangd/Diagnostics.cpp
unittests/clangd/ClangdUnitTests.cpp
Inde
Author: kadircet
Date: Tue Oct 9 01:41:12 2018
New Revision: 344025
URL: http://llvm.org/viewvc/llvm-project?rev=344025&view=rev
Log:
[clangd] Revert back to previous heuristic for diagnostic range extraction.
Summary: Also add a few new test cases and a special case into handling of
empty fixi
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE344025: [clangd] Revert back to previous heuristic for
diagnostic range extraction. (authored by kadircet, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52889?vs=168762&id=168764#
Author: steveire
Date: Tue Oct 9 01:44:28 2018
New Revision: 344026
URL: http://llvm.org/viewvc/llvm-project?rev=344026&view=rev
Log:
[ASTMatcher] Add missing imaginaryLiteral
Modified:
cfe/trunk/lib/ASTMatchers/Dynamic/Registry.cpp
Modified: cfe/trunk/lib/ASTMatchers/Dynamic/Registry.cpp
U
Hi Jonas, Bence,
On 10/08/2018 08:22 AM, Mikael Holmén via cfe-commits wrote:
> Hi Jonas,
>
> I get the follwing warning/error when compiling this commit with clang 3.6:
>
> ../tools/clang/tools/extra/clang-tidy/modernize/DeprecatedIosBaseAliasesCheck.cpp:21:5:
> error: suggest braces around ini
xazax.hun added inline comments.
Comment at:
test/Analysis/Inputs/expected-plists/plist-macros-with-expansion.cpp.plist:6
+ clang_version
+clang version 8.0.0 (http://mainstream.inf.elte.hu/Szelethus/clang
85a6dda64587a5a18482f091cbcf020fbd3ec1dd) (https://github.com/llvm-mirro
Hi, sorry for the late response. I will look at it, currently multiple
things to do though.
Am 09.10.2018 um 11:10 schrieb Mikael Holmén via cfe-commits:
> Hi Jonas, Bence,
>
> On 10/08/2018 08:22 AM, Mikael Holmén via cfe-commits wrote:
>> Hi Jonas,
>>
>> I get the follwing warning/error when co
JonasToth added inline comments.
Comment at: clang-tidy/performance/UnnecessaryCopyInitialization.cpp:65-66
has(varDecl(hasLocalStorage(),
- hasType(matchers::isExpensiveToCopy()),
+ hasTy
JonasToth added inline comments.
Comment at: clang-tidy/readability/NumericalCostantsToMaxIntCheck.cpp:63
+ const auto *Lit = Result.Nodes.getNodeAs("Literal");
+ assert(Decl != nullptr);
+ std::string InsteadOf = "-1";
please assert `Lit` as well and add an e
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/URI.cpp:94
case '/': // '/' is only reserved when parsing.
+ case ':':
return false;
add a comment: ':' is only reserve
Anastasia added inline comments.
Comment at: lib/Sema/SemaCast.cpp:2288
+ SrcType->isPointerType()) {
+const PointerType *DestPtr = DestType->getAs();
+if (!DestPtr->isAddressSpaceOverlapping(*SrcType->getAs())) {
rjmccall wrote:
> Anastasia wrote:
>
Author: sammccall
Date: Tue Oct 9 03:02:02 2018
New Revision: 344030
URL: http://llvm.org/viewvc/llvm-project?rev=344030&view=rev
Log:
[clangd] Fix nondeterministic test
Modified:
clang-tools-extra/trunk/unittests/clangd/DexTests.cpp
Modified: clang-tools-extra/trunk/unittests/clangd/DexTes
Szelethus updated this revision to Diff 168767.
Szelethus added a comment.
Merged the two sections.
https://reviews.llvm.org/D52993
Files:
www/analyzer/checker_dev_manual.html
Index: www/analyzer/checker_dev_manual.html
===
---
Thanks! Fixed in r344030.
On Tue, Oct 9, 2018 at 12:28 AM Artem Dergachev via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hi all,
>
> Just wanted to attract attention to the clangd test failure at
> http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-expensive/12782/
>
> Buildbots wer
Author: szelethus
Date: Tue Oct 9 03:05:08 2018
New Revision: 344031
URL: http://llvm.org/viewvc/llvm-project?rev=344031&view=rev
Log:
[analyzer][www] Add more useful links
Differential Revision: https://reviews.llvm.org/D52993
Modified:
cfe/trunk/www/analyzer/checker_dev_manual.html
Modif
This revision was automatically updated to reflect the committed changes.
Closed by commit rC344031: [analyzer][www] Add more useful links (authored by
Szelethus, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D52993
Files:
www/analyzer/checker_dev_manual.html
Index: www/an
whisperity added inline comments.
Comment at:
test/Analysis/Inputs/expected-plists/plist-macros-with-expansion.cpp.plist:346
+
+
/home/eumakri/Documents/2codechecker_dev_env/llvm/tools/clang/test/Analysis/plist-macros-with-expansion.cpp
+
Same here, as @xaza
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344033: [clangd] Mark colon as a safe character when
percent-encoding. (authored by kadircet, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D5301
kadircet updated this revision to Diff 168771.
kadircet added a comment.
- Add comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53016
Files:
clangd/URI.cpp
unittests/clangd/URITests.cpp
Index: unittests/clangd/URITests.cpp
=
101 - 155 of 155 matches
Mail list logo
