craig.topper added inline comments.

================
Comment at: lib/Basic/Targets/X86.cpp:169
     setFeatureEnabledImpl(Features, "mpx", true);
     if (Kind != CK_SkylakeServer) // SKX inherits all SKL features, except SGX
       setFeatureEnabledImpl(Features, "sgx", true);
----------------
lebedev.ri wrote:
> > high-end desktop and server chips (I can't find any SKX without).
> 
> Are you sure you didn't want to move it into an else of this `if()` ?
> This commit leaves it disabled for all processors, but can be re-enabled for 
> specific builds with -mrtm.

So I think this was intended.


Repository:
  rC Clang

https://reviews.llvm.org/D53042



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to