[PATCH] D52660: [CMake][Fuchsia] Use libc++ ABIv2 for Fuchsia toolchain

kristina added a comment. LGTM. Can we formalize ABIv2 as stable and make it distinct from unstable (soon to be ABIv3) or are there are any rough corners still left before ABIv2 and unstable can split in a feature freeze? Repository: rC Clang https://reviews.llvm.org/D52660 _

[PATCH] D52320: AMDGPU: add __builtin_amdgcn_update_dpp

b-sumner added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:11313-11315 + case AMDGPU::BI__builtin_amdgcn_update_dpp: { +llvm::SmallVector Args; +for (unsigned I = 0; I != 6; ++I) arsenm wrote: > The only difference between this and mov_dpp is

[PATCH] D52248: [SEMA] ignore duplicate declaration specifiers from typeof exprs

nickdesaulniers updated this revision to Diff 167565. nickdesaulniers added a comment. Herald added a subscriber: jfb. - split duplicate_declspec into Extension and Extwarn from Extwarn. - rename ext_duplicate_declspec to be the Extension, not the Extwarn. - Fix C++ case. - Use tablegen'd Extensio

[PATCH] D52248: [SEMA] ignore duplicate declaration specifiers from typeof exprs

nickdesaulniers added a comment. Ok, I think this is ready for rereview. Comment at: test/Parser/atomic.c:5 typedef _Atomic int atomic_int; -typedef _Atomic _Atomic _Atomic(int) atomic_int; // expected-warning {{duplicate '_Atomic' declaration specifier}} N

[PATCH] D52248: [SEMA] ignore duplicate declaration specifiers from typeof exprs

nickdesaulniers added inline comments. Comment at: test/FixIt/fixit.c:50 -// CHECK: const typedef int int_t; -const typedef typedef int int_t; // expected-warning {{duplicate 'typedef'}} - Ah, this was a case I should add one last test for. I think reviewers can

Re: r343285 - [cxx2a] P0641R2: (Some) type mismatches on defaulted functions only

Hello Richard, This commit broke couple of our builders: http://lab.llvm.org:8011/builders/clang-with-thin-lto-ubuntu/builds/12924 http://lab.llvm.org:8011/builders/clang-with-lto-ubuntu/builds/10475 . . . FAILED: lib/Transforms/Instrumentation/CMakeFiles/LLVMInstrumentation.dir/DataFlowSanitizer

[PATCH] D52660: [CMake][Fuchsia] Use libc++ ABIv2 for Fuchsia toolchain

ldionne added a comment. In https://reviews.llvm.org/D52660#1249709, @kristina wrote: > LGTM. Can we formalize ABIv2 as stable and make it distinct from unstable > (soon to be ABIv3) or are there are any rough corners still left before ABIv2 > and unstable can split in a feature freeze? I'm not

Re: [PATCH] D52660: [CMake][Fuchsia] Use libc++ ABIv2 for Fuchsia toolchain

We have no such desire. I think we're fine being the test subjects for ABIv2 however. On Fri, Sep 28, 2018, 4:51 PM Louis Dionne via Phabricator < revi...@reviews.llvm.org> wrote: > ldionne added a comment. > > In https://reviews.llvm.org/D52660#1249709, @kristina wrote: > > > LGTM. Can we formal

[PATCH] D52675: [clang] Properly apply attributes on explicit instantiations of static data members

erik.pilkington added reviewers: rsmith, rjmccall. erik.pilkington added a comment. Add some reviewers. Repository: rC Clang https://reviews.llvm.org/D52675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

Buildbot numbers for the week of 9/09/2018 - 9/15/2018

Hello everyone, Below are some buildbot numbers for the week of 9/09/2018 - 9/15/2018. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed to r

Buildbot numbers for the week of 9/16/2018 - 9/22/2018

Hello everyone, Below are some buildbot numbers for the last week of 9/16/2018 - 9/22/2018. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed

[PATCH] D52675: [clang] Properly apply attributes on explicit instantiations of static data members

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. This seems reasonable to me, but I'd feel most comfortable if @rsmith also signed off on it. Repository: rC Clang https://reviews.llvm.org/D52675 _

[PATCH] D52660: [CMake][Fuchsia] Use libc++ ABIv2 for Fuchsia toolchain

kristina added a comment. My misunderstanding then, I was eventually hoping for a feature freeze of ABIv2 to a point where it's considered stable so any alterations to things like internal layout of std::string (ie. like SBO that came with ABIv2) happen in `unstable/std::__3` as this allows for

r343369 - [cxx2a] Fix warning triggered by r343285

Author: vitalybuka Date: Fri Sep 28 19:17:12 2018 New Revision: 343369 URL: http://llvm.org/viewvc/llvm-project?rev=343369&view=rev Log: [cxx2a] Fix warning triggered by r343285 Modified: cfe/trunk/include/clang/AST/DeclBase.h Modified: cfe/trunk/include/clang/AST/DeclBase.h URL: http://llv

[clang-tools-extra] r343369 - [cxx2a] Fix warning triggered by r343285

Author: vitalybuka Date: Fri Sep 28 19:17:12 2018 New Revision: 343369 URL: http://llvm.org/viewvc/llvm-project?rev=343369&view=rev Log: [cxx2a] Fix warning triggered by r343285 Modified: clang-tools-extra/trunk/clang-doc/BitcodeWriter.h Modified: clang-tools-extra/trunk/clang-doc/BitcodeWri

Re: r343285 - [cxx2a] P0641R2: (Some) type mismatches on defaulted functions only

https://reviews.llvm.org/rL343369 On Fri, Sep 28, 2018 at 4:51 PM Galina Kistanova via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hello Richard, > > This commit broke couple of our builders: > > http://lab.llvm.org:8011/builders/clang-with-thin-lto-ubuntu/builds/12924 > http://lab.llvm.or

[PATCH] D52673: [HIP] Remove disabled irif library

kristina added a comment. If you don't mind, can you please do another revision with full context (`-U9`), makes it easier to review and makes it less likely that `svn patch` screws up. Repository: rC Clang https://reviews.llvm.org/D52673 _

[PATCH] D50403: [clang-format]AlignConsecutiveAssignments

kristina added subscribers: djasper, klimek, kristina. kristina added a comment. Please upload your diffs with full context (use `-U9` when doing the diff) and update them. I don't think there is a code owner for this part but @klimek and @djasper do most reviews to do with clang-format, so

[PATCH] D51714: CMake: Deprecate using llvm-config to detect llvm installation

tstellar added a comment. In https://reviews.llvm.org/D51714#1248643, @smeenai wrote: > Is there anything holding this up? No hold up, I just wanted to address the review comment. I'll commit on Monday if there are no other comments. Repository: rC Clang https://reviews.llvm.org/D51714

[PATCH] D52401: Remove redundant null pointer check in operator delete

lichray reopened this revision. lichray added a comment. This revision is now accepted and ready to land. LGTM as well, unless @mclow.lists can tell us some history like interactions with K&R libc :) Repository: rL LLVM https://reviews.llvm.org/D52401 _

[PATCH] D44609: [Clang-Format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style)

lichray added a comment. In https://reviews.llvm.org/D44609#1059675, @Wawha wrote: > In my case, the main requirement is to be able **avoid** a lambda in one line. That doesn't work for me. I would like short lambdas still be formatted in one line, when `AllowShortFunctionsOnASingleLine` or a

<    1   2