ilya-biryukov added inline comments.
Comment at: clang-tools-extra/trunk/clangd/tool/ClangdMain.cpp:287
+StaticIdx.reset(Placeholder = new
SwapIndex(llvm::make_unique()));
+runAsync([Placeholder] {
+ if (auto Idx = loadIndex(YamlSymbolFile))
Wouldn'
ilya-biryukov added a comment.
In https://reviews.llvm.org/D50438#1224289, @hokein wrote:>
> Thanks, and sorry for the delay here, I was planning to submit it after
> https://reviews.llvm.org/D50958 is submitted (probably today?)-- because it
> requires some rebasing changes.
Thanks for the u
Author: ioeric
Date: Wed Sep 5 00:40:38 2018
New Revision: 341449
URL: http://llvm.org/viewvc/llvm-project?rev=341449&view=rev
Log:
[clangd] Tune macro quality scoring for code completion.
x0.2 seems to be too much penalty, macros might be wanted in some cases;
changing to 0.5x instead. The tuni
sammccall added a comment.
I think you're right - this isn't actually asynchronous (I didn't manage to
test that!), and if it were it'd interfere with clean shutdown.
I think both issues can be addressed by assigning the future to a variable
scoped to main. Will send a patch.
Repository:
rL
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341450: clang-format: Fix formatting C++ namespaces with
preceding 'inline' or 'export'… (authored by sammccall,
committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://re
whisperity added a subscriber: martong.
whisperity added a comment.
Make sure you use only the C++ projects like BitCoin, LLVM/Clang, ProtoBuf and
such from the Xazax CSA Test suite because this checker is not really
applicable to C projects.
Generally I like the idea (personally I've ran into
Author: sammccall
Date: Wed Sep 5 00:44:02 2018
New Revision: 341450
URL: http://llvm.org/viewvc/llvm-project?rev=341450&view=rev
Log:
clang-format: Fix formatting C++ namespaces with preceding 'inline' or 'export'
specifier
This fixes formatting namespaces with preceding 'inline' and 'export'
Author: sammccall
Date: Wed Sep 5 00:52:49 2018
New Revision: 341451
URL: http://llvm.org/viewvc/llvm-project?rev=341451&view=rev
Log:
[clangd] Fix buildbot failures on older compilers from r341375
Modified:
clang-tools-extra/trunk/clangd/RIFF.cpp
clang-tools-extra/trunk/clangd/index/Ser
Sorry! r341451 should fix this, will keep an eye on the buildbots.
On Wed, Sep 5, 2018 at 8:46 AM Mikael Holmén
wrote:
> Hi Sam,
>
> This doesn't compile for me. Both clang 3.6.0 and gcc 5.4.0 complain:
>
> [1/6] Building CXX object
>
> tools/clang/tools/extra/clangd/CMakeFiles/clangDaemon.dir/i
Author: maskray
Date: Wed Sep 5 01:01:37 2018
New Revision: 341452
URL: http://llvm.org/viewvc/llvm-project?rev=341452&view=rev
Log:
[clangd] Fix typo. NFC
Modified:
clang-tools-extra/trunk/clangd/Cancellation.h
clang-tools-extra/trunk/clangd/CodeComplete.cpp
clang-tools-extra/trunk/
sammccall created this revision.
sammccall added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ioeric.
This wasn't actually async (due to std::future destructor blocking).
If it were, we would have clean shutdown issues if main returned
an
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/Basic/VirtualFileSystem.cpp:248
+private:
+ // Make sure `CWDCache` update is thread safe in
`getCurrentWorkingDirectory`.
+ mutable std::mutex M
melver added a comment.
In https://reviews.llvm.org/D51036#1223254, @sammccall wrote:
> In https://reviews.llvm.org/D51036#1223230, @melver wrote:
>
> > Awaiting remaining reviewer acceptance.
> >
> > FYI: I do not have commit commit access -- what is the procedure to commit
> > once diff is acc
On 09/05/2018 09:56 AM, Sam McCall wrote:
Sorry! r341451 should fix this, will keep an eye on the buildbots.
Now it compiles with clang 3.6.0 but with gcc 5.4.0 it fails with
/proj/bbi_twh/wh_bbi/x86_64-Linux2/bbigcc/1.5.4.0/crosscompiler/bin/g++
-I/proj/bbi_twh/wh_bbi/x86_64-Linux2/bbilib
baloghadamsoftware updated this revision to Diff 163984.
baloghadamsoftware added a comment.
Updated according to the comments and rebased.
https://reviews.llvm.org/D32902
Files:
lib/StaticAnalyzer/Checkers/IteratorChecker.cpp
test/Analysis/Inputs/system-header-simulator-cxx.h
test/Analys
baloghadamsoftware marked an inline comment as done.
baloghadamsoftware added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:1449-1464
+const CXXRecordDecl *getCXXRecordDecl(const MemRegion *Reg) {
+ QualType Type;
+ if (const auto *TVReg = Reg->ge
ioeric updated this revision to Diff 163986.
ioeric marked an inline comment as done.
ioeric added a comment.
- s/Mutex/CWDMutex/
Repository:
rC Clang
https://reviews.llvm.org/D51641
Files:
lib/Basic/VirtualFileSystem.cpp
Index: lib/Basic/VirtualFileSystem.cpp
===
kbobyrev updated this revision to Diff 163987.
kbobyrev marked 14 inline comments as done.
kbobyrev added a comment.
- Rebase on top of master
- Address suggestions Eric wrote here
- Address suggestions from the offline discussion by reusing `Quality.cpp`
infrastructure for path proximity boostin
kbobyrev added a comment.
Ping; this one just redirects to the appropriate Wiki entry on GitHub.
https://reviews.llvm.org/D51297
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ioeric
Date: Wed Sep 5 02:45:27 2018
New Revision: 341455
URL: http://llvm.org/viewvc/llvm-project?rev=341455&view=rev
Log:
[VFS] Cache the current working directory for the real FS.
Reviewers: sammccall
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D51641
M
Szelethus updated this revision to Diff 163992.
Szelethus added a comment.
Fixed an assertation failure where a lambda field's this capture was undefined.
https://reviews.llvm.org/D51057
Files:
lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h
lib/StaticAnalyzer/Checkers
This revision was automatically updated to reflect the committed changes.
Closed by commit rC341455: [VFS] Cache the current working directory for the
real FS. (authored by ioeric, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D51641?vs=163986&id=163994#toc
Repository:
rC
ioeric created this revision.
ioeric added a reviewer: sammccall.
Herald added a subscriber: cfe-commits.
This provides information about the macro definition. For example, it
can be used to compute macro USRs.
Repository:
rC Clang
https://reviews.llvm.org/D51675
Files:
include/clang/Sema/
Szelethus added inline comments.
Comment at:
lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedPointee.cpp:126-127
if (V.isUndef()) {
+assert(!FR->getDecl()->getType()->isReferenceType() &&
+ "References must be initialized!");
return addFieldToU
kbobyrev created this revision.
kbobyrev added reviewers: ioeric, ilya-biryukov, sammccall.
kbobyrev added a project: clang-tools-extra.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay.
Quality.cpp defines a structure for convenient storage of Top N items, it
should be used instead
sammccall updated this revision to Diff 164004.
sammccall added a comment.
Finish tests, fix TestTU::index() to include occurrences.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50958
Files:
clangd/XRefs.cpp
clangd/XRefs.h
unittests/clangd/TestTU.cpp
unittests/clangd/
ioeric added inline comments.
Comment at: clang-tools-extra/clangd/index/dex/DexIndex.cpp:59
LookupTable[Sym->ID] = Sym;
-SymbolQuality[Sym] = quality(*Sym);
+SymbolAndScores[I] = {Sym, static_cast(quality(*Sym))};
}
ioeric wrote:
> ioeric wrote:
Author: sammccall
Date: Wed Sep 5 03:33:36 2018
New Revision: 341458
URL: http://llvm.org/viewvc/llvm-project?rev=341458&view=rev
Log:
[clangd] Implement findReferences function
clangd will use findReferences to provide LSP's reference feature.
Modified:
clang-tools-extra/trunk/clangd/XRefs
Author: sammccall
Date: Wed Sep 5 03:39:58 2018
New Revision: 341459
URL: http://llvm.org/viewvc/llvm-project?rev=341459&view=rev
Log:
[clangd] Avoid enum class+enumValN to avoid GCC bug(?), and use consistent
style.
Modified:
clang-tools-extra/trunk/clangd/global-symbol-builder/GlobalSymb
Author: rksimon
Date: Wed Sep 5 03:44:03 2018
New Revision: 341460
URL: http://llvm.org/viewvc/llvm-project?rev=341460&view=rev
Log:
Fix -Wdocumentation warning. NFCI.
Modified:
cfe/trunk/lib/Sema/SemaType.cpp
Modified: cfe/trunk/lib/Sema/SemaType.cpp
URL:
http://llvm.org/viewvc/llvm-proje
martong added a comment.
From this little information I have hear are my thoughts:
> match callExpr(allOf (callee(functionDecl(hasName("std::sort"))),
> hasArgument(0,
> hasDescendant(declRefExpr(to(fieldDecl(hasName("value_type"))
I think this is a good direction, but keep
baloghadamsoftware updated this revision to Diff 164006.
baloghadamsoftware added a comment.
Herald added subscribers: Szelethus, mikhail.ramalho.
Rebased.
https://reviews.llvm.org/D32904
Files:
lib/StaticAnalyzer/Checkers/IteratorChecker.cpp
test/Analysis/Inputs/system-header-simulator-cxx
sammccall added inline comments.
Comment at: clangd/XRefs.cpp:328
+ : AST(AST) {
+for (const Decl *D : TargetDecls)
+ Targets.insert(D);
hokein wrote:
> nit: we can initialize TargetDecls like `Targets(TargetDecls.begin(),
> TargetDecls.end())`.
In
sammccall closed this revision.
sammccall added a comment.
Oops, I forgot to associate my patch with this review. It landed as
https://reviews.llvm.org/rL341458.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50958
___
cfe-commits
Szelethus added a comment.
Polite ping ^-^
Repository:
rC Clang
https://reviews.llvm.org/D51417
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Szelethus created this revision.
Szelethus added reviewers: george.karpenkov, NoQ, xazax.hun, rnkovacs.
Herald added subscribers: cfe-commits, mikhail.ramalho, a.sidorin, szepet,
whisperity.
Since I plan to add a number of new flags, it made sense to encapsulate them in
a new struct, in order no
sammccall commandeered this revision.
sammccall added a reviewer: hokein.
sammccall added a comment.
Herald added a subscriber: kadircet.
(Taking this as @hokein is on leave and the dependency has landed in
https://reviews.llvm.org/D50958)
Repository:
rCTE Clang Tools Extra
https://reviews.l
sammccall updated this revision to Diff 164010.
sammccall added a comment.
Updated based on findReferences implementation which has now landed.
Removed ReferenceContext support for now, implementation has no options.
references->findReferences in ClangdServer (more consistent with other methods)
A
Hello all,
Is there a way to see how the patch looked like after my commit and
before the revert from the git mirror ?
I cannot reproduce the test failure from the bots in my local build,
(which is based on the the git mirror). but I noticed that a similar
behavior however occurs when the test
sammccall marked 4 inline comments as done.
sammccall added a comment.
PTAL
Comment at: clangd/ClangdServer.h:158
+ /// Retrieve locations for symbol references.
+ void references(PathRef File, Position Pos, bool includeDeclaration,
+ Callback> CB);
-
sammccall updated this revision to Diff 164012.
sammccall added a comment.
Don't load index asynchronously if -run-synchronously is passed.
Nothing needs this today, but it's less surprising behavior.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51674
Files:
clangd/tool/Cl
hokein updated this revision to Diff 164013.
hokein added a comment.
Rebase to master.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50438
Files:
clangd/XRefs.cpp
unittests/clangd/XRefsTests.cpp
Index: unittests/clangd/XRefsTests.cpp
==
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
Thanks, LGTM, ship it!
Comment at: clangd/Protocol.h:881
+struct ReferenceParams : public TextDocumentPositionParams {};
+bool fromJSON(const llvm::json::Value &, Reference
Szelethus created this revision.
Szelethus added reviewers: george.karpenkov, NoQ, rnkovacs, xazax.hun.
Herald added subscribers: cfe-commits, mikhail.ramalho, a.sidorin, szepet,
whisperity.
Based on a suggestion from @george.karpenkov.
In some cases, structs are used as unions with a help of a
hokein updated this revision to Diff 164014.
hokein added a comment.
Fix code style.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50438
Files:
clangd/XRefs.cpp
unittests/clangd/XRefsTests.cpp
Index: unittests/clangd/XRefsTests.cpp
Author: sammccall
Date: Wed Sep 5 04:53:07 2018
New Revision: 341462
URL: http://llvm.org/viewvc/llvm-project?rev=341462&view=rev
Log:
[clangd] Add xrefs LSP boilerplate implementation.
Reviewers: ilya-biryukov, ioeric
Subscribers: MaskRay, jkorous, arphaman, cfe-commits
Differential Revision:
This revision was automatically updated to reflect the committed changes.
sammccall marked 3 inline comments as done.
Closed by commit rCTE341462: [clangd] Add xrefs LSP boilerplate implementation.
(authored by sammccall, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50896?
Author: hokein
Date: Wed Sep 5 05:00:15 2018
New Revision: 341463
URL: http://llvm.org/viewvc/llvm-project?rev=341463&view=rev
Log:
[clangd] Sort GoToDefinition results.
Summary:
GoToDefinition returns all declaration results (implicit/explicit) that are
in the same location, and the results are
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341463: [clangd] Sort GoToDefinition results. (authored by
hokein, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D50438
Files:
clang-tools-ext
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE341463: [clangd] Sort GoToDefinition results. (authored by
hokein, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50438?vs=164014&id=164017#toc
Repository:
rL LLVM
https://revi
On 09/05/2018 12:41 PM, Sam McCall wrote:
Thanks. Unclear to me whether it's the enum class or the anonymous
namespace that's triggering this (I believe) compiler bug, but r341459
may help...
Still doesn't work.
In file included from
../tools/clang/include/clang/Frontend/CommandLineSourceL
kbobyrev updated this revision to Diff 164023.
kbobyrev marked 5 inline comments as done.
kbobyrev added a comment.
Address another round of comments.
https://reviews.llvm.org/D51481
Files:
clang-tools-extra/clangd/CMakeLists.txt
clang-tools-extra/clangd/FileDistance.h
clang-tools-extra/c
kbobyrev updated this revision to Diff 164024.
kbobyrev added a comment.
Keep 2 minor refactorings out of the scope of this patch.
https://reviews.llvm.org/D51481
Files:
clang-tools-extra/clangd/CMakeLists.txt
clang-tools-extra/clangd/FileDistance.h
clang-tools-extra/clangd/index/SymbolYA
Author: sammccall
Date: Wed Sep 5 06:17:51 2018
New Revision: 341466
URL: http://llvm.org/viewvc/llvm-project?rev=341466&view=rev
Log:
[clangd] Fix references.test assertions
Modified:
clang-tools-extra/trunk/test/clangd/references.test
Modified: clang-tools-extra/trunk/test/clangd/referenc
Author: sammccall
Date: Wed Sep 5 06:17:47 2018
New Revision: 341465
URL: http://llvm.org/viewvc/llvm-project?rev=341465&view=rev
Log:
[clangd] make zlib compression optional for binary format
Modified:
clang-tools-extra/trunk/clangd/index/Serialization.cpp
Modified: clang-tools-extra/trunk
Author: sammccall
Date: Wed Sep 5 06:22:11 2018
New Revision: 341467
URL: http://llvm.org/viewvc/llvm-project?rev=341467&view=rev
Log:
[clangd] Fix type/variable name conflict on some compilers
Modified:
clang-tools-extra/trunk/clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp
Modif
elsteveogrande added a comment.
Hi @rsmith ! Thanks for taking a look at this. I'd much prefer to fix the
underlying problem and not swat at these symptoms, so thanks for the analysis
of what's actually going on here. :) Let me take a stab at fixing the real
problem in the manner you descri
Dear LLVM and compiler interested people,
next Thursday, 19:00, we will have two exciting tech-talks at the LLVM compiler
social!
# The Lean Theorem Prover
Lean is a new theorem prover using dependent type theory (DTT). Lean 3 gained
support for meta programming, employing dependent types not
Anastasia added a comment.
In https://reviews.llvm.org/D51411#1217477, @yaxunl wrote:
> Is this a feature requested by users?
>
> I can understand that this may be useful to pinpoint some conversions which
> are potentially harmful to performance. However such conversions can often be
> elimina
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: include/clang/Sema/CodeCompleteConsumer.h:847
+ /// If the result is RK_Macro, this can store the information about the macro
+ /// definition.
baloghadamsoftware added inline comments.
Herald added subscribers: Szelethus, mikhail.ramalho.
Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:1584-1588
+ auto stateFound = state->BindExpr(CE, LCtx, RetVal);
+ auto stateNotFound = state->BindExpr(CE, LCtx, SecondPa
yaxunl added a comment.
In https://reviews.llvm.org/D51411#1224615, @Anastasia wrote:
> In https://reviews.llvm.org/D51411#1217477, @yaxunl wrote:
>
> > Is this a feature requested by users?
> >
> > I can understand that this may be useful to pinpoint some conversions which
> > are potentially h
dnsampaio created this revision.
dnsampaio added reviewers: pbarrio, SjoerdMeijer.
Herald added a reviewer: javed.absar.
Herald added subscribers: cfe-commits, chrib, kristof.beyls.
The **inline** attribute is not valid for C standard 89. Replace the argument
in the generation of header files wit
Understood, The test worked for me because I have both 64 bit and 32 bit libs
installed on my default sysroot. Otherwise might fail indeed.
Will amend the test with an explicit sysroot,
> -Original Message-
> From: Tim Shen via Phabricator [mailto:revi...@reviews.llvm.org]
> Sent: Wedn
ioeric requested changes to this revision.
ioeric added a comment.
This revision now requires changes to proceed.
This should be the last round! ;)
Comment at: clang-tools-extra/clangd/index/dex/DexIndex.cpp:45
+std::vector>
+createPathIterators(llvm::ArrayRef ProximityPaths,
+
patricklyster updated this revision to Diff 164037.
patricklyster added a comment.
Previous implementation only supported immediately nested declare targets such
as below:
#pragma omp declare target
#pragma omp declare target
int foo();
#pragma omp end declare target
int bar(
t.p.northover accepted this revision.
t.p.northover added a comment.
This revision is now accepted and ready to land.
Looks good to me.
Repository:
rC Clang
https://reviews.llvm.org/D51683
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
Author: labath
Date: Wed Sep 5 07:38:44 2018
New Revision: 341472
URL: http://llvm.org/viewvc/llvm-project?rev=341472&view=rev
Log:
Enable DWARF accelerator tables by default when tuning for lldb (-glldb =>
-gpubnames)
Summary:
DWARF v5 accelerator tables provide a considerable performance
impr
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341472: Enable DWARF accelerator tables by default when
tuning for lldb (-glldb =>… (authored by labath, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llv
Anastasia added inline comments.
Comment at: include/clang/Basic/OpenCLExtensionTypes.def:1
+//===-- OpenCLExtensionTypes.def - Metadata about BuiltinTypes --*- C++
-*-===//
+//
I am confused about the purpose of this file. Is it supposed to contain intel
e
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341475: Fix arm_neon.h and arm_fp16.h generation for
compiling with std=c89 (authored by dnsampaio, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm
ioeric updated this revision to Diff 164044.
ioeric added a comment.
- update comment about missing MacroInfo.
Repository:
rC Clang
https://reviews.llvm.org/D51675
Files:
include/clang/Sema/CodeCompleteConsumer.h
lib/Sema/SemaCodeComplete.cpp
tools/libclang/CXCursor.cpp
Index: tools/
ioeric added inline comments.
Comment at: include/clang/Sema/CodeCompleteConsumer.h:847
+ /// If the result is RK_Macro, this can store the information about the macro
+ /// definition.
sammccall wrote:
> Let's not make this maybe/optional: `If the result is
Author: dnsampaio
Date: Wed Sep 5 07:56:21 2018
New Revision: 341475
URL: http://llvm.org/viewvc/llvm-project?rev=341475&view=rev
Log:
Fix arm_neon.h and arm_fp16.h generation for compiling with std=c89
Summary:
The inline attribute is not valid for C standard 89. Replace the argument in
the g
Author: ioeric
Date: Wed Sep 5 07:59:17 2018
New Revision: 341476
URL: http://llvm.org/viewvc/llvm-project?rev=341476&view=rev
Log:
[Sema] Store MacroInfo in CodeCompletionResult for macro results.
Summary:
This provides information about the macro definition. For example, it
can be used to comp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341476: [Sema] Store MacroInfo in CodeCompletionResult for
macro results. (authored by ioeric, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D516
Anastasia added a comment.
It seems generally good to partition this big header but I am trying to
understand what problem is it trying to solve now? The unsupported declarations
are guarded out by `#if defined(ext_name)` and therefore won't be parsed and
put into PCH is extensions are not supp
Hahnfeld created this revision.
Hahnfeld added reviewers: gtbercea, ABataev.
Herald added subscribers: cfe-commits, guansong.
When looking for the bclib Clang considered the default library
path first while it preferred directories in LIBRARY_PATH when
constructing the invocation of nvlink. The la
joerg added inline comments.
Comment at: cfe/trunk/utils/TableGen/NeonEmitter.cpp:2412
- OS << "#define __ai static inline __attribute__((__always_inline__, "
+ OS << "#define __ai static __inline __attribute__((__always_inline__, "
"__nodebug__))\n\n";
-
Szelethus updated this revision to Diff 164050.
Szelethus added a comment.
Added doc to `www/analyzer/alpha_checks.html`.
https://reviews.llvm.org/D51680
Files:
lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h
lib/StaticAnalyzer/Checkers/UninitializedObject/Uninitialize
asavonic added a comment.
In https://reviews.llvm.org/D51544#1224730, @Anastasia wrote:
> It seems generally good to partition this big header but I am trying to
> understand what problem is it trying to solve now?
Main motivation is to reduce memory footprint by factoring out everything that
lebedev.ri added a comment.
Ping.
Repository:
rC Clang
https://reviews.llvm.org/D50250
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
lebedev.ri added a comment.
Ping.
Repository:
rC Clang
https://reviews.llvm.org/D50901
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
benhamilton requested changes to this revision.
benhamilton added a comment.
This revision now requires changes to proceed.
Thanks for this! Let's consolidate this with the property name checker (either
simplify the logic there and allow `arBiTRAryCapSAnYWHere` or apply the same
registered acron
twoh added a comment.
Herald added subscribers: llvm-commits, jfb.
Hello, I observed a case where atomic builtin generates libcall when the
corresponding sync builtin generates an atomic instruction
(https://bugs.llvm.org/show_bug.cgi?id=38846). It seems that the alignment
checking for __atomic
ioeric created this revision.
ioeric added a reviewer: sammccall.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ilya-biryukov.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51688
Files:
clangd/AST.cpp
clangd/AST.h
clangd/CodeComplete.cpp
c
elsteveogrande added inline comments.
Comment at: lib/Serialization/ASTReaderDecl.cpp:1766
+
+// FIXME: handle serialized lambdas
assert(!DD.IsLambda && !MergeDD.IsLambda && "faked up lambda definition?");
rsmith wrote:
> Did you mean to add this FIXME?
ioeric updated this revision to Diff 164055.
ioeric added a comment.
- Set name for the test symbol.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51688
Files:
clangd/AST.cpp
clangd/AST.h
clangd/CodeComplete.cpp
clangd/index/SymbolCollector.cpp
unittests/clangd/CodeC
sammccall created this revision.
sammccall added a reviewer: kbobyrev.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ioeric, ilya-biryukov.
This uses a bitmap representation instead of a list if the density of
the list is high enough (at least 1 in 32, which is the
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/AST.h:41
+/// Gets the symbol ID for a macro, if possible.
+llvm::Optional getSymbolID(const IdentifierInfo &II,
+
Author: abataev
Date: Wed Sep 5 10:10:30 2018
New Revision: 341483
URL: http://llvm.org/viewvc/llvm-project?rev=341483&view=rev
Log:
[OPENMP][NVPTX] Disable runtime-type info for CUDA devices.
RTTI is not supported by the NVPTX target.
Added:
cfe/trunk/test/OpenMP/nvptx_target_rtti_messages
ABataev accepted this revision.
ABataev added a comment.
LG
https://reviews.llvm.org/D51378
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kbobyrev updated this revision to Diff 164062.
kbobyrev marked 18 inline comments as done.
kbobyrev added a comment.
Address a round of comments
https://reviews.llvm.org/D51481
Files:
clang-tools-extra/clangd/FileDistance.h
clang-tools-extra/clangd/URI.cpp
clang-tools-extra/clangd/URI.h
Author: erichkeane
Date: Wed Sep 5 10:14:21 2018
New Revision: 341484
URL: http://llvm.org/viewvc/llvm-project?rev=341484&view=rev
Log:
Test Commit for git-svn-cleanup comment.
Removes the class name for the Expr class, which isn't necessary.
Modified:
cfe/trunk/include/clang/AST/Expr.h
Mo
erik.pilkington updated this revision to Diff 164064.
erik.pilkington added a comment.
Ping! In the new patch:
- Uncomment __cpp_lib_node_extract, reverting r340544
- Rebase/Clean up the diff a bit
https://reviews.llvm.org/D48896
Files:
libcxx/include/__hash_table
libcxx/include/__node_han
ABataev added a comment.
In https://reviews.llvm.org/D51554#1224049, @echristo wrote:
> The change in name here from "line tables" to "directives only" feels a bit
> confusing. "Limited" seems to be a bit more clear, or even remaining line
> tables only. Can you explain where you were going wi
kbobyrev created this revision.
kbobyrev added reviewers: ioeric, ilya-biryukov, sammccall.
kbobyrev added a project: clang-tools-extra.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay.
Code health: prevent implicit conversions to user-defined types.
https://reviews.llvm.org/D5169
kbobyrev created this revision.
kbobyrev added reviewers: sammccall, ioeric, ilya-biryukov.
kbobyrev added a project: clang-tools-extra.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay.
`URIDistance` constructor should mention that `Sources` must contain *absolute
paths*, not URIs.
ahatanak added inline comments.
Comment at: include/clang/AST/Decl.h:977
+
+unsigned EscapingByref : 1;
};
rjmccall wrote:
> This doesn't actually seem to be initialized anywhere.
VarDecl's constructor in Decl.cpp initializes it to false.
```
AllBits =
ahatanak updated this revision to Diff 164069.
ahatanak marked 11 inline comments as done.
ahatanak added a comment.
Address review comments. Fix bugs in the handling of `__block` variables that
have reference types.
Repository:
rC Clang
https://reviews.llvm.org/D51564
Files:
include/clan
1 - 100 of 152 matches
Mail list logo
