[PATCH] D51507: Allow all supportable attributes to be used with #pragma clang attribute.

rsmith updated this revision to Diff 163584. rsmith added a comment. Don't add #pragma clang attribute support for 'mode' and 'ext_vector_type'. Repository: rC Clang https://reviews.llvm.org/D51507 Files: include/clang/Basic/Attr.td test/Misc/pragma-attribute-supported-attributes-list.te

r341251 - [X86] Add k-mask conversion and load/store instrinsics to match gcc and icc.

Author: ctopper Date: Fri Aug 31 13:41:06 2018 New Revision: 341251 URL: http://llvm.org/viewvc/llvm-project?rev=341251&view=rev Log: [X86] Add k-mask conversion and load/store instrinsics to match gcc and icc. This adds: _cvtmask8_u32, _cvtmask16_u32, _cvtmask32_u32, _cvtmask64_u64 _cvtu32_mask8

[PATCH] D51448: [WebAssembly] clang-format (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rC341254: [WebAssembly] clang-format (NFC) (authored by aheejin, committed by ). Changed prior to commit: https://reviews.llvm.org/D51448?vs=163152&id=163590#toc Repository: rL LLVM https://reviews.ll

[PATCH] D51448: [WebAssembly] clang-format (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rL341254: [WebAssembly] clang-format (NFC) (authored by aheejin, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D51448 Files: cfe/trunk/lib/Drive

r341254 - [WebAssembly] clang-format (NFC)

Author: aheejin Date: Fri Aug 31 13:57:00 2018 New Revision: 341254 URL: http://llvm.org/viewvc/llvm-project?rev=341254&view=rev Log: [WebAssembly] clang-format (NFC) Summary: This patch runs clang-format on all wasm-only files. Subscribers: dschuff, sbc100, jgravelle-google, sunfish, jfb, cfe-c

[PATCH] D51554: [CUDA][OPENMP][NVPTX]Improve logic of the debug info support.

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Nice. So, in effect, for optimized builds we'll generate pre-DWARF line info only, unless --cuda-noopt-device-debug is specified. Will this deal with the warnings about back-end being unable to handl

r341265 - [X86] Add ktest intrinsics to match gcc and icc.

Author: ctopper Date: Fri Aug 31 15:29:56 2018 New Revision: 341265 URL: http://llvm.org/viewvc/llvm-project?rev=341265&view=rev Log: [X86] Add ktest intrinsics to match gcc and icc. These aren't documented in the Intel Intrinsics Guide, but are supported by gcc and icc. Includes these intrinsi

[PATCH] D51333: Diagnose likely typos in include statements

rsmith added a comment. In https://reviews.llvm.org/D51333#1220878, @christylee wrote: > In https://reviews.llvm.org/D51333#1219938, @rsmith wrote: > > > Instead of guessing whether the corrected filename would be valid, why not > > strip off the leading and trailing non-alphanumeric characters,

[PATCH] D51329: [Attribute/Diagnostics] Print macro instead of whole attribute for address_space

leonardchan updated this revision to Diff 163604. leonardchan marked 8 inline comments as done. leonardchan added a comment. - Removed default value for `getAttributedType` and added any macro identifier necessary as a fourth argument to `getAttributedType` - Added tracking for `LateAttr`s to kee

[PATCH] D51329: [Attribute/Diagnostics] Print macro instead of whole attribute for address_space

leonardchan added inline comments. Comment at: lib/AST/TypePrinter.cpp:1370 + +// Remove the underlying address space so it won't be printed. +SplitQualType SplitTy = T->getModifiedType().split(); rsmith wrote: > leonardchan wrote: > > rsmith wrote: > > >

[PATCH] D45898: [SemaCXX] Mark destructor as referenced

ahatanak updated this revision to Diff 163612. ahatanak marked 3 inline comments as done. ahatanak added a comment. Move the call that checks the element's destructor into InitListChecker::CheckStructUnionTypes. Repository: rC Clang https://reviews.llvm.org/D45898 Files: lib/Sema/SemaInit

[PATCH] D51564: Distinguish `__block` variables that are captured by escaping blocks from those that aren't

ahatanak created this revision. ahatanak added a reviewer: rjmccall. Herald added a subscriber: dexonsmith. This patch changes the way `__block` variables that aren't captured by escaping blocks are handled: - Since non-escaping blocks on the stack never get copied to the heap (see https://revi

[PATCH] D45898: [SemaCXX] Mark destructor as referenced

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: lib/Sema/SemaInit.cpp:1827-1829 + if (SemaRef.DiagnoseUseOfDecl(Destructor, Loc)) +return false; + return true; Usual Clang convention

[PATCH] D51510: Move AESNI generation to Skylake and Goldmont

thiagomacieira added a comment. Sure. Hadn't seen that file. Repository: rC Clang https://reviews.llvm.org/D51510 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51510: Move AESNI generation to Skylake and Goldmont

thiagomacieira added a comment. See https://reviews.llvm.org/D51565 Repository: rC Clang https://reviews.llvm.org/D51510 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51539: [clangd] Add symbol slab size to index memory consumption estimates

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/dex/DexIndex.cpp:184 + size_t Bytes = PairedSlabSize; + Bytes += LookupTable.size() * sizeof(std::pair); Bytes += SymbolQuality.size() * sizeof(std::pair); Why not use `LookupTable.ge

[PATCH] D51539: [clangd] Add symbol slab size to index memory consumption estimates

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:91 + for (const auto &P : FileToSlabs) +Result += P.second->size(); + return Result; Why not `bytes` here as well? https://reviews.llvm.org/D51539

[PATCH] D51567: CMake: Consolidate gtest detection code

tstellar created this revision. tstellar added reviewers: chandlerc, beanz. Herald added a subscriber: mgorny. This makes it possible to build the unittests with only the gtest sources and without a full LLVM source tree. Repository: rC Clang https://reviews.llvm.org/D51567 Files: CMakeLis

[PATCH] D51084: Implement -Watomic-implicit-seq-cst

rjmccall added inline comments. Comment at: lib/Sema/SemaChecking.cpp:4924 +<< Callee->getSourceRange(); + } + rjmccall wrote: > Why is the diagnostic at the end location? And why are you separately > checking whether it's ignored at the begin location

[PATCH] D51564: Distinguish `__block` variables that are captured by escaping blocks from those that aren't

rjmccall added inline comments. Comment at: include/clang/AST/Decl.h:977 + +unsigned EscapingByref : 1; }; This doesn't actually seem to be initialized anywhere. Comment at: include/clang/AST/Decl.h:1422 + + bool isNonEscapingByref() co

<    1   2