r340082 - test commit: add a comment

Author: mikerice Date: Fri Aug 17 14:16:21 2018 New Revision: 340082 URL: http://llvm.org/viewvc/llvm-project?rev=340082&view=rev Log: test commit: add a comment Modified: cfe/trunk/test/PCH/pch-through3c.cpp Modified: cfe/trunk/test/PCH/pch-through3c.cpp URL: http://llvm.org/viewvc/llvm-pr

[PATCH] D50740: [SourceManager] isPointWithin: avoid using isBeforeInTranslationUnit, compare buffer offsets directly for lexical correctness

arphaman added a comment. Hmm, after more analysis I realized that this is not the right solution for the rename problem. It would be correct to map one file:line:column location to a set of `SourceLocation`s, and to use the old `isPointWithin` on a set of such locations. I opened https://revie

[PATCH] D50509: [analyzer][UninitializedObjectChecker] Refactoring p6.: Move dereferencing to a function

Szelethus added inline comments. Comment at: lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedPointee.cpp:223 + // int*). + while (auto Tmp = V.getAs()) { +// We can't reason about symbolic regions, assume its initialized. NoQ wrote: > Szelethu

[PATCH] D50926: [SourceManager] Extract 'findFileIDsForFile' from 'translateFile' to allow mapping from one file entry to multiple FileIDs

arphaman created this revision. arphaman added reviewers: jkorous, ioeric. Herald added a subscriber: dexonsmith. This patch extracts the code that searches for a file id from `translateFile` to `findFileIDsForFile` to allow the users to map from one file entry to multiple FileIDs. Will be used

[PATCH] D50814: [clangd] transfer the fixits with the notes instead of adding them to the main diagnostic if request by the client

arphaman added a comment. Our client has a presentation layer with a Clang-based hierarchical model for diagnostics, so we need the original notes. This is a hard requirement in that sense. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50814 ___

[PATCH] D50927: [Sema] Remove location from implicit capture init expr

vsk created this revision. vsk added reviewers: rsmith, rtrieu, erichkeane. A lambda's closure is initialized when the lambda is declared. For implicit captures, the initialization code emitted from EmitLambdaExpr references source locations *within the lambda body* in the function containing the

r340093 - [analyzer] [NFC] Split up summary generation in RetainCountChecker in two methods

Author: george.karpenkov Date: Fri Aug 17 14:41:37 2018 New Revision: 340093 URL: http://llvm.org/viewvc/llvm-project?rev=340093&view=rev Log: [analyzer] [NFC] Split up summary generation in RetainCountChecker in two methods Differential Revision: https://reviews.llvm.org/D50830 Modified:

[PATCH] D50830: [analyzer] [NFC] Split up summary generation in RetainCountChecker in two methods

This revision was automatically updated to reflect the committed changes. Closed by commit rC340093: [analyzer] [NFC] Split up summary generation in RetainCountChecker in two… (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https:/

[PATCH] D50863: [analyzer] [NFC] Move canEval function from RetainCountChecker to RetainCountSummaries

This revision was automatically updated to reflect the committed changes. Closed by commit rC340094: [analyzer] [NFC] Move canEval function from RetainCountChecker to… (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews

r340094 - [analyzer] [NFC] Move canEval function from RetainCountChecker to RetainCountSummaries

Author: george.karpenkov Date: Fri Aug 17 14:42:05 2018 New Revision: 340094 URL: http://llvm.org/viewvc/llvm-project?rev=340094&view=rev Log: [analyzer] [NFC] Move canEval function from RetainCountChecker to RetainCountSummaries Differential Revision: https://reviews.llvm.org/D50863 Modified:

r340096 - [analyzer] [NFC] Move ObjCRetainCount to include/Analysis

Author: george.karpenkov Date: Fri Aug 17 14:42:32 2018 New Revision: 340096 URL: http://llvm.org/viewvc/llvm-project?rev=340096&view=rev Log: [analyzer] [NFC] Move ObjCRetainCount to include/Analysis Differential Revision: https://reviews.llvm.org/D50869 Added: cfe/trunk/include/clang/Analy

[PATCH] D50869: [analyzer] [NFC] Move ObjCRetainCount to include/Analysis

This revision was automatically updated to reflect the committed changes. Closed by commit rC340096: [analyzer] [NFC] Move ObjCRetainCount to include/Analysis (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org

r340098 - [analyzer] [NFC] Minor refactoring of ISL-specific code in RetainCountChecker

Author: george.karpenkov Date: Fri Aug 17 14:43:27 2018 New Revision: 340098 URL: http://llvm.org/viewvc/llvm-project?rev=340098&view=rev Log: [analyzer] [NFC] Minor refactoring of ISL-specific code in RetainCountChecker Differential Revision: https://reviews.llvm.org/D50879 Modified: cfe/t

[PATCH] D50879: [analyzer] [NFC] Minor refactoring of ISL-specific code in RetainCountChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rC340098: [analyzer] [NFC] Minor refactoring of ISL-specific code in RetainCountChecker (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: http

[PATCH] D50259: [OpenCL] Disallow negative attribute arguments

yaxunl accepted this revision. yaxunl added a comment. LGTM. Thanks. Repository: rC Clang https://reviews.llvm.org/D50259 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50805: Don't warn on returning the address of a label from a statement expression

nickdesaulniers added a comment. Thank you for this! https://reviews.llvm.org/D50805 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41217: [Concepts] Concept Specialization Expressions

saar.raz updated this revision to Diff 161343. saar.raz added a comment. - Fix bad ArgsAsWritten assertion, add missing null initializer in ConceptSpecializationExpr. Repository: rC Clang https://reviews.llvm.org/D41217 Files: include/clang/AST/DeclTemplate.h include/clang/AST/ExprCXX.h

[PATCH] D50928: [ASTImporter] Test for importing condition variable from a ForStmt

teemperor created this revision. Herald added a subscriber: martong. Herald added a reviewer: a.sidorin. Repository: rC Clang https://reviews.llvm.org/D50928 Files: test/Import/for-stmt/Inputs/F.cpp test/Import/for-stmt/test.cpp Index: test/Import/for-stmt/test.cpp ==

r340101 - Don't warn on returning the address of a label from a statement expression

Author: rnk Date: Fri Aug 17 15:11:31 2018 New Revision: 340101 URL: http://llvm.org/viewvc/llvm-project?rev=340101&view=rev Log: Don't warn on returning the address of a label from a statement expression Summary: There isn't anything inherently wrong with returning a label from a statement expre

[PATCH] D50805: Don't warn on returning the address of a label from a statement expression

This revision was automatically updated to reflect the committed changes. Closed by commit rC340101: Don't warn on returning the address of a label from a statement expression (authored by rnk, committed by ). Changed prior to commit: https://reviews.llvm.org/D50805?vs=161148&id=161344#toc Rep

[PATCH] D41284: [Concepts] Associated constraints infrastructure.

saar.raz updated this revision to Diff 161345. saar.raz added a comment. - Fix bad reference to getRequiresClause on TemplateDecl in assertion Repository: rC Clang https://reviews.llvm.org/D41284 Files: include/clang/AST/DeclTemplate.h include/clang/AST/RecursiveASTVisitor.h include/cl

r340102 - [ObjC] Error out when using forward-declared protocol in a @protocol

Author: arphaman Date: Fri Aug 17 15:18:08 2018 New Revision: 340102 URL: http://llvm.org/viewvc/llvm-project?rev=340102&view=rev Log: [ObjC] Error out when using forward-declared protocol in a @protocol expression Clang emits invalid protocol metadata when a @protocol expression is used with a f

[PATCH] D49462: [ObjC] Error out when using forward-declared protocol in a @protocol expression

This revision was automatically updated to reflect the committed changes. Closed by commit rL340102: [ObjC] Error out when using forward-declared protocol in a @protocol (authored by arphaman, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm

[PATCH] D50924: [CodeGen] add rotate builtins

spatel updated this revision to Diff 161346. spatel added a comment. Patch updated: Update the existing Microsoft rotate builtins to also use the LLVM funnel shift intrinsics. https://reviews.llvm.org/D50924 Files: docs/LanguageExtensions.rst include/clang/Basic/Builtins.def lib/CodeGen/

[PATCH] D41569: [Concepts] Constraint enforcement and diagnostics

saar.raz updated this revision to Diff 161348. saar.raz added a comment. - Adjusted to new CodeSynthesisContexts, added tests for them. Repository: rC Clang https://reviews.llvm.org/D41569 Files: include/clang/AST/ExprCXX.h include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/

[PATCH] D47757: [Sema] Produce diagnostics when unavailable aligned allocation/deallocation functions are called

tra added a comment. Talked to @ahatanak over IRC. It appears that this patch may have exposed a preexisting bug. Apparently `delete t;` in test/SemaCUDA/call-host-fn-from-device.cu does actually end up calling `__host__ operator delete`. It should've picked `__device__ operator delete`, but i

[PATCH] D50924: [CodeGen] add rotate builtins

lebedev.ri added a comment. Looks ok to me. https://reviews.llvm.org/D50924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41284: [Concepts] Associated constraints infrastructure.

Quuxplusone added inline comments. Comment at: test/CXX/concepts-ts/temp/temp.constr/temp.constr.decl/var-template-decl.cpp:10 + +template requires bool(U()) +int B::A = int(U()); For my own edification, could you explain whether, given #define BOOL bool

[PATCH] D50924: [CodeGen] add rotate builtins

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Thanks, looks good! https://reviews.llvm.org/D50924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D50932: [ASTImporter] Add test for C++ casts and fix broken const_cast importing.

teemperor created this revision. Herald added a subscriber: martong. Herald added a reviewer: a.sidorin. Repository: rC Clang https://reviews.llvm.org/D50932 Files: lib/AST/ASTImporter.cpp test/Import/cxx-casts/Inputs/F.cpp test/Import/cxx-casts/test.cpp tools/clang-import-test/clang-i

[PATCH] D40925: Add option -fkeep-static-consts

rnk added inline comments. Comment at: include/clang/Basic/LangOptions.def:311 +BENIGN_LANGOPT(KeepStaticConsts , 1, 0, "keep static const variables even if unused") + Let's make this a CodeGenOption, since only CodeGen needs to look at it. https://revi

r340109 - [index] For an ObjC message call, also record as receivers the protocols if they are present in the ObjC type

Author: akirtzidis Date: Fri Aug 17 16:50:59 2018 New Revision: 340109 URL: http://llvm.org/viewvc/llvm-project?rev=340109&view=rev Log: [index] For an ObjC message call, also record as receivers the protocols if they are present in the ObjC type Modified: cfe/trunk/lib/Index/IndexBody.cpp

r340110 - Quickfix for failing tests.

Author: george.karpenkov Date: Fri Aug 17 16:54:00 2018 New Revision: 340110 URL: http://llvm.org/viewvc/llvm-project?rev=340110&view=rev Log: Quickfix for failing tests. Modified: cfe/trunk/test/ARCMT/objcmt-arc-cf-annotations.m.result Modified: cfe/trunk/test/ARCMT/objcmt-arc-cf-annotation

[PATCH] D50703: [clangd] NFC: Mark Workspace Symbol feature complete in the documentation

malaperle added a comment. Herald added a subscriber: kadircet. I hadn't marked it as done because without symbols in main files I found it quite lacking. Repository: rL LLVM https://reviews.llvm.org/D50703 ___ cfe-commits mailing list cfe-commi

[PATCH] D50870: Close FileEntries of cached files in ModuleManager::addModule().

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Thanks for working on this Adrian, LGTM. > When we last discussed this my plan was to avoid the stat() in > lookupModuleFile() for files that were just added to the PCMCache by > WriteAST() ent

[PATCH] D41217: [Concepts] Concept Specialization Expressions

rsmith added inline comments. Comment at: include/clang/AST/ExprCXX.h:4420 + /// \brief The concept named. + ConceptDecl *NamedConcept; + saar.raz wrote: > rsmith wrote: > > You should also track the `FoundDecl` and the optional > > `NestedNameSpecifierLoc` (j

r340117 - Revert "[analyzer] [NFC] Split up RetainSummaryManager from RetainCountChecker"

Author: bruno Date: Fri Aug 17 20:22:11 2018 New Revision: 340117 URL: http://llvm.org/viewvc/llvm-project?rev=340117&view=rev Log: Revert "[analyzer] [NFC] Split up RetainSummaryManager from RetainCountChecker" This reverts commit a786521fa66c72edd308baff0c08961b6d964fb1. Bots haven't caught up

Re: r340114 - [analyzer] [NFC] Split up RetainSummaryManager from RetainCountChecker

Hi George, This broke the modules build, reverted in r340117 for now. I can help you figure out any module map change if necessary next week. Thanks, On Fri, Aug 17, 2018 at 6:46 PM George Karpenkov via cfe-commits wrote: > > Author: george.karpenkov > Date: Fri Aug 17 18:45:50 2018 > New Revisi

[PATCH] D42043: c-index: CXString: fix MSAN read-past-end bug

elsteveogrande updated this revision to Diff 161370. elsteveogrande added a comment. Rebase + fix conflicts for very old diff. Works again. `ninja check-clang` with MSAN-enabled build: Before: Failing Tests (2): Clang :: CodeGen/signed_metadata.cpp Clang :: Index/comment-to-html-

<    1   2   3