Author: hans
Date: Fri Aug 17 00:19:32 2018
New Revision: 339987
URL: http://llvm.org/viewvc/llvm-project?rev=339987&view=rev
Log:
Merging r339675:
r339675 | ldionne | 2018-08-14 15:29:17 +0200 (Tue, 14 Aug 2018) | 15 lines
Author: hans
Date: Fri Aug 17 00:20:04 2018
New Revision: 339988
URL: http://llvm.org/viewvc/llvm-project?rev=339988&view=rev
Log:
Merging r339702:
r339702 | ldionne | 2018-08-14 20:16:56 +0200 (Tue, 14 Aug 2018) | 11 lines
Author: hans
Date: Fri Aug 17 00:20:30 2018
New Revision: 339989
URL: http://llvm.org/viewvc/llvm-project?rev=339989&view=rev
Log:
Merging r339741:
r339741 | ldionne | 2018-08-15 02:16:41 +0200 (Wed, 15 Aug 2018) | 12 lines
Author: hans
Date: Fri Aug 17 00:20:52 2018
New Revision: 339990
URL: http://llvm.org/viewvc/llvm-project?rev=339990&view=rev
Log:
Merging r339742:
r339742 | ldionne | 2018-08-15 02:18:01 +0200 (Wed, 15 Aug 2018) | 11 lines
Author: hans
Date: Fri Aug 17 00:21:26 2018
New Revision: 339991
URL: http://llvm.org/viewvc/llvm-project?rev=339991&view=rev
Log:
Merging r339804:
r339804 | marshall | 2018-08-15 21:27:53 +0200 (Wed, 15 Aug 2018) | 1 line
M
Author: hans
Date: Fri Aug 17 00:22:08 2018
New Revision: 339992
URL: http://llvm.org/viewvc/llvm-project?rev=339992&view=rev
Log:
Merging r339816:
r339816 | marshall | 2018-08-15 23:19:08 +0200 (Wed, 15 Aug 2018) | 1 line
S
JonasToth added inline comments.
Comment at: test/clang-tidy/abseil-auto-make-unique.cpp:73
+ // Different type. No change.
+ std::unique_ptr z = make_unique();
+ std::unique_ptr z2(make_unique());
JonasToth wrote:
> lets consider a 3 level class hierarchy.
>
JonasToth added a comment.
In https://reviews.llvm.org/D49851#1202764, @Abpostelnicu wrote:
> Strangely I haven't had those kind of issues but since you propose those
> modifications I would do one more modification, let's output everything to
> stdout and not stderr by doing:
>
> if err:
>
Author: lebedevri
Date: Fri Aug 17 00:33:25 2018
New Revision: 339995
URL: http://llvm.org/viewvc/llvm-project?rev=339995&view=rev
Log:
[NFC] Some small test updates for Implicit Conversion sanitizer.
Split off from D50250.
Added:
cfe/trunk/test/CodeGen/catch-implicit-integer-conversions-bas
JonasToth added inline comments.
Comment at: clang-tidy/abseil/NoInternalDepsCheck.cpp:21
+bool IsInAbseilFile(const SourceManager& manager, SourceLocation loc){
+ if (loc.isInvalid()) {
+return false;
You can elide the braces for single stmt ifs
=
JonasToth added a comment.
I am suprised that this does not automatically follow from the general rules.
At the end, smartpointers cant do anything else then 'normal' classes.
The `operator+/->` were not handled before? The mutation of `SmartPtr x;
x->mf();` should already be catched, not?
Re
ebevhan added a comment.
In https://reviews.llvm.org/D50616#1203446, @leonardchan wrote:
> Sorry I forgot to address this also. Just to make sure I understand this
> correctly since I haven't used these before: target hooks are essentially for
> emitting target specific code for some operations
hokein updated this revision to Diff 161176.
hokein marked an inline comment as done.
hokein added a comment.
Remove ASSERT_TRUE(bool(Preamble)).
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50627
Files:
unittests/clangd/TUSchedulerTests.cpp
Index: unittests/clangd/TUSche
Author: hokein
Date: Fri Aug 17 01:15:22 2018
New Revision: 340001
URL: http://llvm.org/viewvc/llvm-project?rev=340001&view=rev
Log:
[clangd] Always use the latest preamble
Summary:
Fix an inconsistent behavior of using `LastBuiltPreamble`/`NewPreamble`
in TUScheduler (see the test for details),
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE340001: [clangd] Always use the latest preamble (authored
by hokein, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50695?vs=160983&id=161177#toc
Repository:
rCTE Clang Tools Ex
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: clangd/CodeCompletionStrings.cpp:52
// get this declaration, so we don't show documentation in that case.
if (Result.Kind != CodeCompletionResult::RK_D
rjmccall added a comment.
In https://reviews.llvm.org/D50616#1203692, @ebevhan wrote:
> In https://reviews.llvm.org/D50616#1203446, @leonardchan wrote:
>
> > Sorry I forgot to address this also. Just to make sure I understand this
> > correctly since I haven't used these before: target hooks are
ilya-biryukov updated this revision to Diff 161187.
ilya-biryukov marked 2 inline comments as done.
ilya-biryukov added a comment.
- Turn ifs to ternary ops
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50726
Files:
clangd/CodeComplete.cpp
clangd/CodeCompletionStrings.cpp
ilya-biryukov added inline comments.
Comment at: clangd/CodeCompletionStrings.cpp:52
// get this declaration, so we don't show documentation in that case.
if (Result.Kind != CodeCompletionResult::RK_Declaration)
return "";
ioeric wrote:
> `RK_Pattern`
ioeric added inline comments.
Comment at: clangd/CodeCompletionStrings.cpp:52
// get this declaration, so we don't show documentation in that case.
if (Result.Kind != CodeCompletionResult::RK_Declaration)
return "";
ilya-biryukov wrote:
> ioeric wrote:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL340004: [clangd] Show function documentation in signature
help (authored by ibiryukov, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D50726
File
Author: ibiryukov
Date: Fri Aug 17 02:29:38 2018
New Revision: 340004
URL: http://llvm.org/viewvc/llvm-project?rev=340004&view=rev
Log:
[clangd] Show function documentation in signature help
Summary:
Previously, clangd was trying to show documentation for the active
parameter instead, which is wr
Author: ibiryukov
Date: Fri Aug 17 02:32:30 2018
New Revision: 340005
URL: http://llvm.org/viewvc/llvm-project?rev=340005&view=rev
Log:
[clangd] Fetch documentation from the Index during signature help
Summary:
Sema can only be used for documentation in the current file, other doc
comments should
lebedev.ri added a comment.
In https://reviews.llvm.org/D50616#1203751, @rjmccall wrote:
> In https://reviews.llvm.org/D50616#1203692, @ebevhan wrote:
>
> >
>
>
> Has anyone actually asked LLVM whether they would accept fixed-point types
> into IR? I'm just a frontend guy, but it seems to me th
This revision was automatically updated to reflect the committed changes.
Closed by commit rL340005: [clangd] Fetch documentation from the Index during
signature help (authored by ibiryukov, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.o
ilya-biryukov added a comment.
In https://reviews.llvm.org/D50847#1202658, @ioeric wrote:
> > Dynamic index misses important information from the body of the file, e.g.
> > locations of definitions
> > XRefs cannot be collected at all, since we can only obtain full
> > information for the curr
Quuxplusone updated this revision to Diff 161190.
Quuxplusone added a comment.
A type with no move-constructor, and some non-defaulted copy-constructors (even
if it *also* has some defaulted copy-constructors) should not be considered
naturally trivially relocatable. The paper already said this,
kbobyrev updated this revision to Diff 161191.
kbobyrev marked 4 inline comments as done.
kbobyrev added a comment.
Upload version which is IMO readable.
https://reviews.llvm.org/D50839
Files:
llvm/include/llvm/Support/YAMLTraits.h
llvm/tools/llvm-yaml-numeric-parser-fuzzer/CMakeLists.txt
kbobyrev added inline comments.
Comment at: llvm/include/llvm/Support/YAMLTraits.h:454
+inline bool isNumeric(StringRef S) {
+ if (S.empty())
+return false;
zturner wrote:
> What would happen if we re-wrote this entire function as:
>
> ```
> inline bool isN
kbobyrev updated this revision to Diff 161192.
kbobyrev added a comment.
I tried to rewrite the loop, but IMO it looks even worse now.
https://reviews.llvm.org/D50839
Files:
llvm/include/llvm/Support/YAMLTraits.h
llvm/tools/llvm-yaml-numeric-parser-fuzzer/CMakeLists.txt
llvm/tools/llvm-ya
This revision was automatically updated to reflect the committed changes.
Closed by commit rL340007: [clangd] NFC: Mark Workspace Symbol feature complete
in the documentation (authored by omtcyfz, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.
Author: omtcyfz
Date: Fri Aug 17 03:14:31 2018
New Revision: 340007
URL: http://llvm.org/viewvc/llvm-project?rev=340007&view=rev
Log:
[clangd] NFC: Mark Workspace Symbol feature complete in the documentation
Workspace Symbol implementation was introduced in D44882 and should be
complete now.
Rev
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE340007: [clangd] NFC: Mark Workspace Symbol feature
complete in the documentation (authored by omtcyfz, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50703?vs=160566&id=161196#toc
ilya-biryukov created this revision.
ilya-biryukov added reviewers: hokein, ioeric.
Herald added subscribers: arphaman, jkorous, MaskRay.
It was previously only indexing the preamble decls. The new
implementation will index both the preamble and the main AST and
report both sets of symbols, prefer
ilya-biryukov added a comment.
@ioeric, specifically, see https://reviews.llvm.org/D50889 for an updated
FileIndex
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50847
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
ilya-biryukov added a comment.
This is still WIP, but wanted to share anyway the progress anyway.
Need to fix the FIXMEs currently added to the code and add tests.
Comment at: clangd/index/FileIndex.cpp:81
if (!Slab)
FileToSlabs.erase(Path);
else
We
Just a heads up that this broke the Chromium build on Mac:
https://crbug.com/874997
Apparently we have some target that explicitly targets 10.5. I don't
know if that's really necessary, but the fact that we ran into this at
all suggests others will too, so maybe this change warrants a release
note
Author: rksimon
Date: Fri Aug 17 03:40:05 2018
New Revision: 340009
URL: http://llvm.org/viewvc/llvm-project?rev=340009&view=rev
Log:
Fix clangd tests on older compilers
Old versions of gcc struggle with raw string literals inside macros.
Modified:
clang-tools-extra/trunk/unittests/clangd/Co
kbobyrev updated this revision to Diff 161202.
kbobyrev marked 6 inline comments as done.
kbobyrev added a comment.
Address a round of comments.
https://reviews.llvm.org/D50337
Files:
clang-tools-extra/clangd/CMakeLists.txt
clang-tools-extra/clangd/index/dex/DexIndex.cpp
clang-tools-extra
kbobyrev updated this revision to Diff 161204.
kbobyrev added a comment.
Add couple tests, fix formatting issues, use `__builtin_trap()` instead of
`assert` in fuzzer so that it's more transparent.
Also, fuzzing this unreadable version for a couple of hours suggests that it is
valid.
https://
avt77 added a comment.
In https://reviews.llvm.org/D47196#1202805, @efriedma wrote:
> > :start: means the timer was started
>
> In some cases, the ChildTime is already non-zero at the "start" point; what
> does that mean?
It means there was recursive call and this child time should be removed
Szelethus added a comment.
I think testcases for non-class iterator objects would be valuable.
Comment at: lib/StaticAnalyzer/Checkers/PointerSortingChecker.cpp:72-76
+ auto IteratesPointerKeysM = hasType(cxxRecordDecl(has(
+fieldDecl(hasType(ha
Szelethus updated this revision to Diff 161209.
Szelethus edited the summary of this revision.
https://reviews.llvm.org/D50509
Files:
lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObjectChecker.cpp
lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedPointee.cpp
Index:
Oh, and maybe the driver should diagnose if -mmacosx-version-min= is
set too low?
On Fri, Aug 17, 2018 at 12:38 PM, Hans Wennborg wrote:
> Just a heads up that this broke the Chromium build on Mac:
> https://crbug.com/874997
>
> Apparently we have some target that explicitly targets 10.5. I don't
ilya-biryukov planned changes to this revision.
ilya-biryukov added a comment.
As discussed offline, we could instead have a two-layer scheme for dynamic
index. A top layer will contain main file symbols, second layer will contain
preamble symbols.
Repository:
rCTE Clang Tools Extra
https:/
hokein added a comment.
Thanks for adding it.
Comment at: clangd/TUScheduler.cpp:406
// We only need to build the AST if diagnostics were requested.
if (WantDiags == WantDiagnostics::No)
return;
The AST might not get built if `WantDiags::No`, a
Szelethus created this revision.
Szelethus added reviewers: george.karpenkov, NoQ, xazax.hun, rnkovacs.
Herald added subscribers: cfe-commits, mikhail.ramalho, a.sidorin, szepet,
whisperity.
Repository:
rC Clang
https://reviews.llvm.org/D50892
Files:
lib/StaticAnalyzer/Checkers/Uninitialize
Szelethus added inline comments.
Comment at: test/Analysis/cxx-uninitialized-object-inheritance.cpp:787
// TODO: we'd expect the note: {{uninitialized field 'this->x'}}
int x; // no-note
};
The checker should be able to catch this one -- for some reason it
Dmitry.Kozhevnikov added a comment.
In https://reviews.llvm.org/D50462#1203038, @vsapsai wrote:
> Have you checked that produced AST is of sufficient quality to be used?
> Because, for example, for invalid code error recovery tries to keep going but
> the end result isn't always good.
> In the
MTC updated this revision to Diff 161217.
MTC added a comment.
- rebase
- Since we have enhanced the ability of `CallDescription`, remove the helper
method `isCalledOnStringObject()`.
https://reviews.llvm.org/D48027
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h
lib/Sta
olista01 accepted this revision.
olista01 added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
https://reviews.llvm.org/D49793
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
MTC added a comment.
In https://reviews.llvm.org/D48027#1201248, @xazax.hun wrote:
> Generally looks good, I only wonder if this works well with inline
> namespaces. Could you test? Probably it will.
Thank you for reminding me! Yea, this can handle inline namespaces.
However this approach has
This revision was automatically updated to reflect the committed changes.
Closed by commit rL340018: [AArch64] - Generate pointer authentication
instructions (authored by LukeCheeseman, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D4
Hahnfeld added a comment.
In https://reviews.llvm.org/D50845#1202973, @ABataev wrote:
> > So ideally I think Clang should determine which functions are really
> > `declare target` (either explicit or implicit) and only run semantical
> > analysis on them. If a function is then found to be "brok
Author: lukecheeseman
Date: Fri Aug 17 05:55:05 2018
New Revision: 340019
URL: http://llvm.org/viewvc/llvm-project?rev=340019&view=rev
Log:
[AArch64] - return address signing
- Add a command line options -msign-return-address to enable return address
signing
- Armv8.3a added instructions to sig
ABataev added a comment.
In https://reviews.llvm.org/D50845#1203961, @Hahnfeld wrote:
> In https://reviews.llvm.org/D50845#1202973, @ABataev wrote:
>
> > > So ideally I think Clang should determine which functions are really
> > > `declare target` (either explicit or implicit) and only run seman
Author: tejohnson
Date: Fri Aug 17 06:19:36 2018
New Revision: 340021
URL: http://llvm.org/viewvc/llvm-project?rev=340021&view=rev
Log:
[ThinLTO] Correct documentation on default number of threads
Summary:
The number of threads used for ThinLTO backend parallelism was
dropped to the number of cor
This revision was automatically updated to reflect the committed changes.
Closed by commit rC340021: [ThinLTO] Correct documentation on default number of
threads (authored by tejohnson, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50882?vs=161161&id=161223#toc
Repository:
Hahnfeld added a comment.
In https://reviews.llvm.org/D50845#1203967, @ABataev wrote:
> In https://reviews.llvm.org/D50845#1203961, @Hahnfeld wrote:
>
> > In https://reviews.llvm.org/D50845#1202973, @ABataev wrote:
> >
> > > > So ideally I think Clang should determine which functions are really
ioeric added inline comments.
Comment at: clang-tools-extra/clangd/index/dex/DexIndex.cpp:86
+ const auto TrigramTokens = generateIdentifierTrigrams(Req.Query);
+ TopLevelChildren.push_back(createAnd(createTrigramIterators(TrigramTokens)));
+
`createTrigramIter
ABataev added a comment.
In https://reviews.llvm.org/D50845#1203973, @Hahnfeld wrote:
> In https://reviews.llvm.org/D50845#1203967, @ABataev wrote:
>
> > In https://reviews.llvm.org/D50845#1203961, @Hahnfeld wrote:
> >
> > > In https://reviews.llvm.org/D50845#1202973, @ABataev wrote:
> > >
> > >
Author: hans
Date: Fri Aug 17 06:37:57 2018
New Revision: 340023
URL: http://llvm.org/viewvc/llvm-project?rev=340023&view=rev
Log:
clang-cl: Expose -fno-crash-diagnostics (PR38574)
Modified:
cfe/trunk/include/clang/Driver/Options.td
cfe/trunk/test/Driver/cl-options.c
Modified: cfe/trunk/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL340025: Fix for bug 38508 - Don't do PCH processing
when only generating preprocessor… (authored by erichkeane, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://
Author: erichkeane
Date: Fri Aug 17 06:43:39 2018
New Revision: 340025
URL: http://llvm.org/viewvc/llvm-project?rev=340025&view=rev
Log:
Fix for bug 38508 - Don't do PCH processing when only generating preprocessor
output
This clang-cl driver change removes the PCH options when we are only gener
ilya-biryukov added inline comments.
Comment at: clangd/CodeComplete.h:85
+
+ /// Enables cursor to be moved around according to completions needs even
when
+ /// snippets are disabled. For example selecting a function with parameters
as
kadircet wrote:
> ioe
ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.
LGTM with the `__clz` you missed.
Comment at: include/bit:61
+inline _LIBCPP_INLINE_VISIBILITY
+int __popcount(unsigned __x) { return __builtin_popcount (__x); }
lebedev.ri added inline comments.
Comment at: include/bit:117
+ unsigned long __where;
// Search from LSB to MSB for first set bit.
// Returns zero if no set bit is found.
Like i commented in the original review, this should probably be
```
// Search from
ilya-biryukov added a comment.
Why do we want an alternative mode for transferring fix-its and notes? Any
reason why our current model is bad?
One thing that comes to mind is inconsistency between clang and our model, but
I wonder where would it affect the user experience in a bad way?
Reposit
smaksimovic updated this revision to Diff 161233.
smaksimovic added a comment.
Added test cases.
https://reviews.llvm.org/D50557
Files:
include/clang/Basic/DiagnosticCommonKinds.td
lib/Basic/Targets/Mips.cpp
lib/Basic/Targets/Mips.h
test/Preprocessor/init.c
Index: test/Preprocessor/ini
hokein created this revision.
hokein added reviewers: ilya-biryukov, ioeric.
Herald added subscribers: arphaman, jkorous, MaskRay.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50896
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/ClangdServer.cpp
clang
ioeric added inline comments.
Comment at: clangd/CodeComplete.cpp:1377
+ // Check whether function has any parameters or not.
+ LSP.textEdit->newText += SnippetSuffix.size() > 2 ? "(${0})" : "()";
+else
There seems to be no guarantee on whether the
kbobyrev updated this revision to Diff 161235.
kbobyrev marked 7 inline comments as done.
kbobyrev added a comment.
Address another round of comments.
https://reviews.llvm.org/D50337
Files:
clang-tools-extra/clangd/CMakeLists.txt
clang-tools-extra/clangd/index/dex/DexIndex.cpp
clang-tools
smaksimovic added inline comments.
Comment at: lib/Basic/Targets/Mips.cpp:62
+unsigned MipsTargetInfo::getISARev(const std::string& CPU) const {
+ return llvm::StringSwitch(getCPU())
atanasyan wrote:
> The CPU argument looks unused. We can either remove it or
hokein added a subscriber: sbenza.
hokein added a comment.
Thanks for porting the check to upstream (context: the check was developed
internally, and has been run on our codebase for a while, it is pretty stable).
Could you please update the patch message to indicate this is a porting change,
a
ioeric added a comment.
Almost LG! Just a few more nits.
Comment at: clang-tools-extra/clangd/index/dex/DexIndex.cpp:87
+ std::vector SymbolDocIDs;
+ std::priority_queue> Top;
+
nit: move `SymbolDocIDs` and `Top` closer to where they're used.
==
kbobyrev created this revision.
kbobyrev added reviewers: ioeric, ilya-biryukov.
kbobyrev added a project: clang-tools-extra.
Herald added subscribers: arphaman, jkorous, MaskRay.
This patch adds hidden Clangd flag which replaces (currently) default
`MemIndex` with `DexIndex` for the static index
kbobyrev updated this revision to Diff 161239.
kbobyrev added a comment.
Fix anonymous namespace beginning placement in Clangd driver.
https://reviews.llvm.org/D50897
Files:
clang-tools-extra/clangd/index/Index.h
clang-tools-extra/clangd/index/MemIndex.cpp
clang-tools-extra/clangd/index/M
ilya-biryukov added a comment.
Mostly NITs, but please take a look at the `CancelParams` handling problem. I
believe there might be a potential bug hiding there :-)
Comment at: clangd/Cancellation.h:87
+/// Enables async tasks to check for cancellation signal, contains a read
kadircet created this revision.
kadircet added reviewers: ilya-biryukov, hokein, ioeric.
Herald added subscribers: cfe-commits, arphaman, jkorous.
Whenever a code-completion is triggered within a class/struct/union looks at
base classes and figures out non-overriden virtual functions. Than suggest
Author: hokein
Date: Fri Aug 17 07:25:10 2018
New Revision: 340029
URL: http://llvm.org/viewvc/llvm-project?rev=340029&view=rev
Log:
[Preamble] Empty preamble is not an error.
Summary:
Empty preamble is valid for source file which doesn't have any
preprocessor and #includes.
This patch makes cla
This revision was automatically updated to reflect the committed changes.
Closed by commit rC340029: [Preamble] Empty preamble is not an error. (authored
by hokein, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50628?vs=160319&id=161241#toc
Repository:
rC Clang
https://
kadircet updated this revision to Diff 161243.
kadircet added a comment.
- Change option name.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50835
Files:
clangd/CodeComplete.cpp
clangd/CodeComplete.h
unittests/clangd/CodeCompleteTests.cpp
Index: unittests/clangd/CodeCo
kadircet marked 3 inline comments as done.
kadircet added inline comments.
Comment at: clangd/CodeComplete.cpp:1377
+ // Check whether function has any parameters or not.
+ LSP.textEdit->newText += SnippetSuffix.size() > 2 ? "(${0})" : "()";
+else
i
ilya-biryukov added inline comments.
Comment at: clangd/XRefs.cpp:665
+std::vector references(ParsedAST &AST, Position Pos,
+ bool IncludeDeclaration,
+ const SymbolIndex *Index) {
Are we going to su
hokein added inline comments.
Comment at: clang-tidy/abseil/NoInternalDepsCheck.cpp:20
+
+bool IsInAbseilFile(const SourceManager& manager, SourceLocation loc){
+ if (loc.isInvalid()) {
I think we can make it as an ASTMatcher instead of a function like:
```
AST
mclow.lists added inline comments.
Comment at: include/bit:117
+ unsigned long __where;
// Search from LSB to MSB for first set bit.
// Returns zero if no set bit is found.
lebedev.ri wrote:
> Like i commented in the original review, this should probably b
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rC Clang
https://reviews.llvm.org/D50259
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
hokein added inline comments.
Comment at: clangd/XRefs.cpp:665
+std::vector references(ParsedAST &AST, Position Pos,
+ bool IncludeDeclaration,
+ const SymbolIndex *Index) {
ilya-biryukov wrote:
> Ar
Author: hokein
Date: Fri Aug 17 07:55:57 2018
New Revision: 340035
URL: http://llvm.org/viewvc/llvm-project?rev=340035&view=rev
Log:
[clangd] Add a testcase for empty preamble.
Summary: This is a patch of add a testcase for https://reviews.llvm.org/D50628.
Reviewers: ilya-biryukov
Subscribers:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL340035: [clangd] Add a testcase for empty preamble.
(authored by hokein, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D50627
Files:
clang-too
kbobyrev updated this revision to Diff 161252.
kbobyrev marked 9 inline comments as done.
kbobyrev added a comment.
Address another round of comments.
https://reviews.llvm.org/D50337
Files:
clang-tools-extra/clangd/CMakeLists.txt
clang-tools-extra/clangd/index/dex/DexIndex.cpp
clang-tools
mclow.lists added inline comments.
Comment at: include/bit:61
+inline _LIBCPP_INLINE_VISIBILITY
+int __popcount(unsigned __x) { return __builtin_popcount (__x); }
+
ldionne wrote:
> Funny spacing between `__builtin_popcount` and `(__x)`
It's actually t
Hahnfeld added a comment.
In https://reviews.llvm.org/D50845#1203991, @ABataev wrote:
> In https://reviews.llvm.org/D50845#1203973, @Hahnfeld wrote:
>
> > In https://reviews.llvm.org/D50845#1203967, @ABataev wrote:
> >
> > > I thought about this approach already. But it won't work in general. The
lebedev.ri created this revision.
lebedev.ri added reviewers: rsmith, vsk, Sanitizers.
lebedev.ri added projects: Sanitizers, clang.
As per IRC disscussion, it seems we really want to have more fine-grained
`-fsanitize=implicit-integer-truncation`:
- A check when both of the types are unsigned.
bader accepted this revision.
bader added a comment.
LGTM.
Please, remove "Change-Id: I910b5c077f5f29e02a1572d9202f0fdbea5280fd" from the
log message - it not relevant to the project.
Repository:
rC Clang
https://reviews.llvm.org/D50259
___
cfe-
ABataev added a comment.
> Right, warning wasn't a good thought. We really want strict checking and
> would have to error out when we find a function that wasn't implicitly
> `declare target` on the host.
> I meant to ask how common that would be? If that's only some known functions
> we could
ioeric added inline comments.
Comment at: clangd/CodeComplete.cpp:1377
+ // Check whether function has any parameters or not.
+ LSP.textEdit->newText += SnippetSuffix.size() > 2 ? "(${0})" : "()";
+else
kadircet wrote:
> ioeric wrote:
> > There seem
Hahnfeld added a comment.
In https://reviews.llvm.org/D50845#1204210, @ABataev wrote:
> > Right, warning wasn't a good thought. We really want strict checking and
> > would have to error out when we find a function that wasn't implicitly
> > `declare target` on the host.
> > I meant to ask how
kadircet updated this revision to Diff 161256.
kadircet added a comment.
- Only append to snippets of type function or method.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50835
Files:
clangd/CodeComplete.cpp
clangd/CodeComplete.h
unittests/clangd/CodeCompleteTests.cpp
ioeric added inline comments.
Comment at: clang-tools-extra/clangd/index/dex/DexIndex.cpp:97
+}
+// FIXME(kbobyrev): Add True iterator as soon as it's implemented
otherwise.
+// If TopLevelChildren vector will be empty it will trigger an assertion.
A
1 - 100 of 239 matches
Mail list logo
