arsenm created this revision.
arsenm added reviewers: yaxunl, kzhuravl.
Herald added subscribers: t-tye, tpr, dstuttard, nhaehnle, wdng.
Avoids regressions in future commit when the device name is round tripped
through the table
https://reviews.llvm.org/D50843
Files:
lib/Basic/Targets/AMDGPU
kbobyrev updated this revision to Diff 161027.
kbobyrev marked 2 inline comments as done.
kbobyrev added a subscriber: lebedev.ri.
kbobyrev added a comment.
Herald added a subscriber: mgorny.
Very good point by @lebedev.ri! I have added a very simple fuzzer for the
parser. So far, there were no i
Author: hans
Date: Thu Aug 16 07:49:38 2018
New Revision: 339881
URL: http://llvm.org/viewvc/llvm-project?rev=339881&view=rev
Log:
Merging r339865:
r339865 | yroux | 2018-08-16 13:38:09 +0200 (Thu, 16 Aug 2018) | 7 lines
[li
Merged to 7.0 in r339881.
On Thu, Aug 16, 2018 at 1:38 PM, Yvan Roux via cfe-commits
wrote:
> Author: yroux
> Date: Thu Aug 16 04:38:09 2018
> New Revision: 339865
>
> URL: http://llvm.org/viewvc/llvm-project?rev=339865&view=rev
> Log:
> [libcxxabi] Fix test_exception_address_alignment test for A
phosek updated this revision to Diff 161031.
Repository:
rC Clang
https://reviews.llvm.org/D50547
Files:
clang/include/clang/Driver/ToolChain.h
clang/lib/Driver/ToolChain.cpp
Index: clang/lib/Driver/ToolChain.cpp
===
--- cla
phosek added a comment.
In https://reviews.llvm.org/D50547#1198218, @rnk wrote:
> Would it be to much to check both the normalized and non-normalized?
Done, currently I'm only checking the provided target triple followed by the
normalized one, I'm not checking the effective triple but it'd be
ioeric added inline comments.
Comment at: clang-tools-extra/clangd/index/dex/DexIndex.cpp:25
+ std::vector> &Scores) {
+ // First, sort retrieved symbols by the cumulative score to apply callbacks
+ // in the order of descending score.
Why is th
Author: hans
Date: Thu Aug 16 07:54:37 2018
New Revision: 339882
URL: http://llvm.org/viewvc/llvm-project?rev=339882&view=rev
Log:
Merging r339874:
r339874 | ldionne | 2018-08-16 14:44:28 +0200 (Thu, 16 Aug 2018) | 25 lines
hans added a comment.
Thanks! Merged to 7.0 in r339882.
Repository:
rL LLVM
https://reviews.llvm.org/D50652
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Merged to 7.0 in r339882.
On Thu, Aug 16, 2018 at 2:44 PM, Louis Dionne via cfe-commits
wrote:
> Author: ldionne
> Date: Thu Aug 16 05:44:28 2018
> New Revision: 339874
>
> URL: http://llvm.org/viewvc/llvm-project?rev=339874&view=rev
> Log:
> [libcxx] By default, do not use internal_linkage to hi
Hahnfeld created this revision.
Hahnfeld added reviewers: tra, gtbercea, hfinkel.
Herald added subscribers: cfe-commits, guansong.
When compiling CUDA or OpenMP device code Clang parses header files
that expect certain predefined macros from the host architecture. To
make this work the compiler pa
Hahnfeld added inline comments.
Comment at: test/SemaCUDA/builtins.cu:15-17
+#if !defined(__x86_64__)
+#error "Expected to see preprocessor macros from the host."
#endif
@tra I'm not sure here: Do we want `__PTX__` to be defined during host
compilation? I can't
kbobyrev updated this revision to Diff 161033.
kbobyrev added a comment.
Use consistent `Regex` matchers naming: don't append "Matcher" at the end.
https://reviews.llvm.org/D50839
Files:
llvm/include/llvm/Support/YAMLTraits.h
llvm/tools/llvm-yaml-numeric-parser-fuzzer/CMakeLists.txt
llvm/
ABataev added a comment.
Maybe for device compilation we also should define `__NO_MATH_INLINES` and
`__NO_STRING_INLINES` macros to disable inline assembly in glibc?
Repository:
rC Clang
https://reviews.llvm.org/D50845
___
cfe-commits mailing li
hokein added inline comments.
Comment at: test/clang-tidy/hicpp-exception-baseclass.cpp:191
+void templated_thrower() { throw T{}(); }
+// CHECK-MESSAGES: [[@LINE-1]]:34: warning: throwing an exception whose type
'int' is not derived from 'std::exception'
+
Jona
Hahnfeld added a comment.
In https://reviews.llvm.org/D50845#1202540, @ABataev wrote:
> Maybe for device compilation we also should define `__NO_MATH_INLINES` and
> `__NO_STRING_INLINES` macros to disable inline assembly in glibc?
The problem is that `__NO_MATH_INLINES` doesn't even avoid all
ABataev added a comment.
In https://reviews.llvm.org/D50845#1202550, @Hahnfeld wrote:
> In https://reviews.llvm.org/D50845#1202540, @ABataev wrote:
>
> > Maybe for device compilation we also should define `__NO_MATH_INLINES` and
> > `__NO_STRING_INLINES` macros to disable inline assembly in glib
mattd added a comment.
In https://reviews.llvm.org/D50410#1201206, @acoomans wrote:
> @mattd @Sunil_Srivastava if you have access to the PS4 SDK, could you tell if
> the `-debug-info-macro` command line clang option is available? Thank you
Hi @acoomans,
The ps4 buildbot should be running with
Meinersbur added a comment.
In https://reviews.llvm.org/D50805#1201956, @Quuxplusone wrote:
> If you added a new option `-Wret-addr-label` as suggested above (for a total
> patch of +2 lines), then is it accurate to say:
>
> - if `-Wret-addr-label` was enabled by default, we know of at least one
acoomans added a comment.
@mattd thanks for confirming. I tried `clang -cc1as -target x86_64-scei-ps4
-debug-info-macros` and got suggestions.
@modocache @mattd Should we try to first land https://reviews.llvm.org/D50515
to see if it fails again?
Repository:
rC Clang
https://reviews.llvm.o
ilya-biryukov created this revision.
ilya-biryukov added a reviewer: hokein.
Herald added subscribers: arphaman, jkorous, MaskRay, ioeric, javed.absar.
Will be used for updating the dynamic index on updates to the open files.
Currently we collect only information coming from the preamble
AST. This
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50695
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM, but note the comment: we don't need `ASSERT_TRUE(bool(Preamble))`.
Comment at: unittests/clangd/TUSchedulerTests.cpp:333
+ // We expe
lebedev.ri requested changes to this revision.
lebedev.ri added a comment.
This revision now requires changes to proceed.
In https://reviews.llvm.org/D50805#1202578, @Meinersbur wrote:
> In https://reviews.llvm.org/D50805#1201956, @Quuxplusone wrote:
>
> > If you added a new option `-Wret-addr-la
ioeric added a comment.
> Dynamic index misses important information from the body of the file, e.g.
> locations of definitions
> XRefs cannot be collected at all, since we can only obtain full information
> for the current file (preamble is parsed with skipped function bodies,
> therefore not
joerg added inline comments.
Comment at:
llvm/tools/llvm-yaml-numeric-parser-fuzzer/yaml-numeric-parser-fuzzer.cpp:16
+
+llvm::Regex Inifnity("^[-+]?(\\.inf|\\.Inf|\\.INF)$");
+llvm::Regex Base8("^0o[0-7]+$");
Spelling?
https://reviews.llvm.org/D50839
_
lebedev.ri added inline comments.
Comment at: llvm/unittests/Support/YAMLIOTest.cpp:2626
+ //
+ // * Sexagecimal numbers
+ // * Decimal numbers with comma s the delimiter
Spelling
Comment at: llvm/unittests/Support/YAMLIOTest.cpp:2627
+ //
mattd added a comment.
In https://reviews.llvm.org/D50410#1202597, @acoomans wrote:
> @mattd thanks for confirming. I tried `clang -cc1as -target x86_64-scei-ps4
> -debug-info-macros` and got suggestions.
>
> @modocache @mattd Should we try to first land https://reviews.llvm.org/D50515
> to see
Author: rupprecht
Date: Thu Aug 16 09:55:07 2018
New Revision: 339899
URL: http://llvm.org/viewvc/llvm-project?rev=339899&view=rev
Log:
NFC: Test commit access
Testing commit access from a new machine, so using this as an opportunity to
revert my old test access commit (r336006) that I never cle
wzssyqa created this revision.
wzssyqa added reviewers: rsmith, atanasyan.
Herald added subscribers: cfe-commits, jrtc27, arichardson, sdardis, srhines.
Debian uses different triples for MIPS r6 and paths.
These new triples include:
mipsisa32r6-linux-gnu
mipsisa32r6el-linux-gnu
mipsisa64r6-linux
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
This LGTM. Do you want me to commit it for you?
Repository:
rCXX libc++
https://reviews.llvm.org/D50736
___
cfe-commits mailing list
zturner added inline comments.
Comment at: llvm/include/llvm/Support/YAMLTraits.h:454
+inline bool isNumeric(StringRef S) {
+ if (S.empty())
+return false;
What would happen if we re-wrote this entire function as:
```
inline bool isNumeric(StringRef S) {
R2RT reopened this revision.
R2RT added a comment.
This revision is now accepted and ready to land.
Hey, all, as for me it seems that this commit introduced a few problems with
Python3 (at least 3.7)
sys.stdout.write(' '.join(invocation) + '\n' + output + '\n')
TypeError: can only concatenat
hugoeg created this revision.
hugoeg added reviewers: alexfh, hokein.
hugoeg added a project: clang-tools-extra.
Herald added a subscriber: mgorny.
warns to use 'auto' to avoid repeating the type name and fixes the issue
Replace:
std::unique_ptr x = make_unique(...);
with:
auto x = make_uniqu
I can commit sometime today; thanks.
-- HT
On Thu, Aug 16, 2018 at 1:24 PM, Marshall Clow via Phabricator <
revi...@reviews.llvm.org> wrote:
> mclow.lists accepted this revision.
> mclow.lists added a comment.
> This revision is now accepted and ready to land.
>
> This LGTM. Do you want me to co
Abpostelnicu added a comment.
Strangely I haven't had those kind of issues but since you propose those
modifications I would do one more modification, let's output everything to
stdout and not stderr by doing:
if err:
sys.stdout.write(str(err) + '\n')
Repository:
rL LLVM
https://revi
lebedev.ri added a comment.
1. Please always upload all patches with full context.
2. There already is `modernize-use-auto`. Does it handle this case? Then this
should be just an alias to that check. Else, i think it would be best to extend
that one, and still alias.
https://reviews.llvm.org/D
hugoeg added a comment.
what do you mean by "with full context"?
https://reviews.llvm.org/D50852
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
lebedev.ri added a comment.
In https://reviews.llvm.org/D50852#1202781, @hugoeg wrote:
> what do you mean by "with full context"?
`-U9` when generating the diff.
https://reviews.llvm.org/D50852
___
cfe-commits mailing list
cfe-commits@lists.l
efriedma added a comment.
> :start: means the timer was started
In some cases, the ChildTime is already non-zero at the "start" point; what
does that mean?
> ActOnFunctionDeclarator:start:._exception:
That's weird... DeclarationName::print should generally return something ASCII;
do you k
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rC Clang
https://reviews.llvm.org/D50547
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
tra added a subscriber: pcc.
tra added a comment.
In https://reviews.llvm.org/D50845#1202551, @ABataev wrote:
> In https://reviews.llvm.org/D50845#1202550, @Hahnfeld wrote:
>
> > In https://reviews.llvm.org/D50845#1202540, @ABataev wrote:
> >
> > > Maybe for device compilation we also should defi
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet,
rnkovacs.
Herald added subscribers: cfe-commits, Szelethus, mikhail.ramalho,
baloghadamsoftware.
Despite the effort to eliminate the need for
`skipRValueSubobjectAdjustments()`, we still e
Author: teemperor
Date: Thu Aug 16 11:19:21 2018
New Revision: 339915
URL: http://llvm.org/viewvc/llvm-project?rev=339915&view=rev
Log:
[ASTImporter] Add test for IndirectGotoStmt
Reviewers: a.sidorin, martong
Reviewed By: martong
Subscribers: rnkovacs, martong, cfe-commits
Differential Revisi
This revision was automatically updated to reflect the committed changes.
Closed by commit rC339915: [ASTImporter] Add test for IndirectGotoStmt
(authored by teemperor, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D50813
Files:
test/Import/indirect-goto/Inputs/F.cpp
test/
Author: teemperor
Date: Thu Aug 16 11:20:05 2018
New Revision: 339916
URL: http://llvm.org/viewvc/llvm-project?rev=339916&view=rev
Log:
[ASTImporter] Add test for WhileStmt
Reviewers: a.sidorin, martong
Reviewed By: martong
Subscribers: rnkovacs, martong, cfe-commits
Differential Revision: htt
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339916: [ASTImporter] Add test for WhileStmt (authored by
teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D50811?vs=160919&id=161074
Author: teemperor
Date: Thu Aug 16 11:20:52 2018
New Revision: 339917
URL: http://llvm.org/viewvc/llvm-project?rev=339917&view=rev
Log:
[ASTImporter] Add test for DoStmt
Reviewers: a.sidorin, martong
Reviewed By: martong
Subscribers: rnkovacs, martong, cfe-commits
Differential Revision: https:
NoQ updated this revision to Diff 161073.
NoQ added a comment.
Add comments for optional arguments.
The reason why i chose an out-parameter rather than returning a std::pair is
because most callers //presumably// don't need this feature.
https://reviews.llvm.org/D50855
Files:
include/clang/
Author: teemperor
Date: Thu Aug 16 11:21:33 2018
New Revision: 339918
URL: http://llvm.org/viewvc/llvm-project?rev=339918&view=rev
Log:
[ASTImporter] Add test for importing CompoundAssignOperators
Reviewers: a.sidorin, martong
Reviewed By: martong
Subscribers: rnkovacs, cfe-commits, martong
Di
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339917: [ASTImporter] Add test for DoStmt (authored by
teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D50810?vs=160918&id=161075#to
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339918: [ASTImporter] Add test for importing
CompoundAssignOperators (authored by teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D5
Author: teemperor
Date: Thu Aug 16 11:22:21 2018
New Revision: 339919
URL: http://llvm.org/viewvc/llvm-project?rev=339919&view=rev
Log:
[ASTImporter] Add test for member pointer types.
Reviewers: a.sidorin, martong
Reviewed By: martong
Subscribers: rnkovacs, martong, cfe-commits
Differential R
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339919: [ASTImporter] Add test for member pointer types.
(authored by teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D50792?vs=1608
emmettneyman updated this revision to Diff 161080.
emmettneyman added a comment.
Added to README
Repository:
rC Clang
https://reviews.llvm.org/D50829
Files:
clang/tools/clang-fuzzer/Dockerfile
clang/tools/clang-fuzzer/README.txt
Index: clang/tools/clang-fuzzer/README.txt
==
CaseyCarter created this revision.
CaseyCarter added reviewers: mclow.lists, EricWF.
Drive-by:
- Fix potential race between check and update of `throw_one` in operator new
- Fix latent bug in operator delete, which shouldn't decrement
`outstanding_new` when passed a null pointer
- Specifically c
NoQ added a comment.
> which is of course a bad thing to do because we should not bind `Loc`s to
> `prvalue` expressions
... of non-pointer type. On the other hand, binding `NonLoc`s to glvalue
expressions is always a bad thing to do; but, for the reference, adding this as
an assertion current
Hahnfeld added a comment.
In https://reviews.llvm.org/D50845#1202838, @tra wrote:
> In https://reviews.llvm.org/D50845#1202551, @ABataev wrote:
>
> > In https://reviews.llvm.org/D50845#1202550, @Hahnfeld wrote:
> >
> > > In https://reviews.llvm.org/D50845#1202540, @ABataev wrote:
> > >
> > > > Ma
leonardchan updated this revision to Diff 161087.
leonardchan marked 6 inline comments as done.
leonardchan added a comment.
- Added separate case for conversions to a non-saturated type
Repository:
rC Clang
https://reviews.llvm.org/D50616
Files:
include/clang/AST/OperationKinds.def
incl
leonardchan added inline comments.
Comment at: lib/CodeGen/CGExprScalar.cpp:331
+ SourceLocation Loc);
+
/// Emit a conversion from the specified complex type to the specified
ebevhan wrote:
> What's the plan for the other conv
hfinkel added a comment.
> Another option would be to implement some sort of attribute-based
> overloading. Then OpenMP can provide its own version of the device-side
> library function without clashing with system headers.
I'm thinking about what the desired behavior is here. So, if we have a
Hahnfeld added a comment.
In https://reviews.llvm.org/D50845#1202963, @hfinkel wrote:
> As a result, we should really have a separate header that has those
> actually-available functions. When targeting NVPTX, why don't we have the
> included math.h be CUDA's math.h? In the end, those are the f
ABataev added a comment.
>> If I understand it correctly, the root cause of this exercise is that we
>> want to compile for GPU using plain C. CUDA avoids this issue by separating
>> device and host code via target attributes and clang has few special cases
>> to ignore inline assembly errors i
NoQ added a comment.
...and adding the aforementioned assertion for prvalues increases the number
of crashes on tests to 196. It seems that the analyzer assigns values of
improper loc-less very often, but then immediately overwrites them :/ I wonder
how much performance could be gained by fixi
hfinkel added a comment.
In https://reviews.llvm.org/D50845#1202965, @Hahnfeld wrote:
> In https://reviews.llvm.org/D50845#1202963, @hfinkel wrote:
>
> > As a result, we should really have a separate header that has those
> > actually-available functions. When targeting NVPTX, why don't we have
gtbercea added a comment.
In https://reviews.llvm.org/D50845#1202973, @ABataev wrote:
> >> If I understand it correctly, the root cause of this exercise is that we
> >> want to compile for GPU using plain C. CUDA avoids this issue by
> >> separating device and host code via target attributes an
rsmith added a comment.
In https://reviews.llvm.org/D50805#1201910, @rnk wrote:
> I think the state machine use case is real, though, something like:
>
> void *f(void *startlabel) {
> common_work();
> goto *startlabel;
> state1:
> return &&state2;
> state2:
> return &&state3
hugoeg added a comment.
In https://reviews.llvm.org/D50852#1202774, @lebedev.ri wrote:
> 1. Please always upload all patches with full context.
> 2. There already is `modernize-use-auto`. Does it handle this case? Then this
> should be just an alias to that check. Else, i think it would be best
lebedev.ri added reviewers: aaron.ballman, zinovy.nis.
lebedev.ri added a comment.
In https://reviews.llvm.org/D50852#1203009, @hugoeg wrote:
> In https://reviews.llvm.org/D50852#1202774, @lebedev.ri wrote:
>
> > 1. Please always upload all patches with full context.
> > 2. There already is `mode
kzhuravl accepted this revision.
kzhuravl added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D50843
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
rnk added a comment.
Sounds good. I think, in the meantime, we all agree we can stop emitting this
warning in the statement expression case. I'll upload a patch for that.
Repository:
rC Clang
https://reviews.llvm.org/D50805
___
cfe-commits maili
gtbercea added a comment.
In https://reviews.llvm.org/D50845#1202991, @hfinkel wrote:
> In https://reviews.llvm.org/D50845#1202965, @Hahnfeld wrote:
>
> > In https://reviews.llvm.org/D50845#1202963, @hfinkel wrote:
> >
> > > As a result, we should really have a separate header that has those
> >
emmettneyman updated this revision to Diff 161093.
emmettneyman added a comment.
Rebased and ready to land
Repository:
rC Clang
https://reviews.llvm.org/D50829
Files:
clang/tools/clang-fuzzer/Dockerfile
clang/tools/clang-fuzzer/README.txt
Index: clang/tools/clang-fuzzer/README.txt
vsapsai added a comment.
Have you checked that produced AST is of sufficient quality to be used?
Because, for example, for invalid code error recovery tries to keep going but
the end result isn't always good.
In the test you verify that you can ignore bogus includes. Is this the
real-world use
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339933: Update README and Dockerfile to include
llvm-proto-fuzzer (authored by emmettneyman, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50829?vs=161093&id=161095#toc
Repository:
Author: emmettneyman
Date: Thu Aug 16 13:13:40 2018
New Revision: 339933
URL: http://llvm.org/viewvc/llvm-project?rev=339933&view=rev
Log:
Update README and Dockerfile to include llvm-proto-fuzzer
Summary: Added commands to Dockerfile to build llvm-proto-fuzzer and the other
related tools. Also
rnk updated this revision to Diff 161096.
rnk added a comment.
- keep the warning, suppress stmt expr case
https://reviews.llvm.org/D50805
Files:
clang/lib/Sema/SemaInit.cpp
clang/test/Sema/statements.c
Index: clang/test/Sema/statements.c
==
JonasToth added inline comments.
Comment at: test/clang-tidy/hicpp-exception-baseclass.cpp:191
+void templated_thrower() { throw T{}(); }
+// CHECK-MESSAGES: [[@LINE-1]]:34: warning: throwing an exception whose type
'int' is not derived from 'std::exception'
+
h
rnk updated this revision to Diff 161098.
rnk added a comment.
- fix it right
https://reviews.llvm.org/D50805
Files:
clang/lib/Sema/SemaInit.cpp
clang/test/Sema/statements.c
Index: clang/test/Sema/statements.c
===
--- clang/t
arsenm closed this revision.
arsenm added a comment.
r339934
https://reviews.llvm.org/D50843
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: arsenm
Date: Thu Aug 16 13:19:47 2018
New Revision: 339934
URL: http://llvm.org/viewvc/llvm-project?rev=339934&view=rev
Log:
AMDGPU: Correct errors in device table
Modified:
cfe/trunk/lib/Basic/Targets/AMDGPU.h
Modified: cfe/trunk/lib/Basic/Targets/AMDGPU.h
URL:
http://llvm.org/view
deannagarcia created this revision.
deannagarcia added reviewers: hokein, alexfh.
deannagarcia added a project: clang-tools-extra.
Herald added subscribers: xazax.hun, mgorny.
This check is an abseil specific check that checks for code using single
character string literals as delimiters and tran
JonasToth added a comment.
In https://reviews.llvm.org/D50852#1202774, @lebedev.ri wrote:
> 1. Please always upload all patches with full context.
> 2. There already is `modernize-use-auto`. Does it handle this case? Then this
> should be just an alias to that check. Else, i think it would be be
JonasToth added inline comments.
Comment at: clang-tidy/abseil/AutoMakeUniqueCheck.cpp:21
+void AutoMakeUniqueCheck::registerMatchers(MatchFinder* finder) {
+ if (!getLangOpts().CPlusPlus) return;
+
Please clang-format, `return` on next line.
tra added a comment.
In https://reviews.llvm.org/D50845#1203031, @gtbercea wrote:
> In https://reviews.llvm.org/D50845#1202991, @hfinkel wrote:
>
> > In https://reviews.llvm.org/D50845#1202965, @Hahnfeld wrote:
> >
> > > In https://reviews.llvm.org/D50845#1202963, @hfinkel wrote:
> > >
> > > > As
arphaman added a comment.
In https://reviews.llvm.org/D50740#1202248, @jkorous wrote:
> Hi Alex, nice work!
>
> I am just wondering if it would be beneficial to assert Loc and End are in
> the same file. It might help to catch bugs.
I don't see the value in that unless I'm misunderstanding som
JonasToth added inline comments.
Comment at: clang-tidy/abseil/FasterStrsplitDelimiterCheck.cpp:24
+
+ast_matchers::internal::Matcher
+constructExprWithArg(llvm::StringRef ClassName,
you dont need the `ast_matchers` namespace as there is a `using namespace
ast_m
Author: dblaikie
Date: Thu Aug 16 14:30:24 2018
New Revision: 339941
URL: http://llvm.org/viewvc/llvm-project?rev=339941&view=rev
Log:
Update for LLVM API change
Modified:
cfe/trunk/lib/CodeGen/CGDebugInfo.cpp
Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp
URL:
http://llvm.org/viewvc/llvm-
shuaiwang added a comment.
In https://reviews.llvm.org/D50619#1202135, @JonasToth wrote:
> @shuaiwang i tried to apply this and check the clang-tidy part again, but it
> does not compile (log attached).
> I update clang to master, did you add a matcher or something like this?
>
> F6950472: erro
Author: marshall
Date: Thu Aug 16 14:35:38 2018
New Revision: 339943
URL: http://llvm.org/viewvc/llvm-project?rev=339943&view=rev
Log:
Establish the header. NFC yet. Reviewed as https://reviews.llvm.org/D50815
Added:
libcxx/trunk/include/bit
Modified:
libcxx/trunk/include/algorithm
l
NoQ created this revision.
NoQ added reviewers: dcoughlin, george.karpenkov.
Herald added subscribers: cfe-commits, Szelethus, mikhail.ramalho, a.sidorin,
szepet, baloghadamsoftware, xazax.hun.
CFRetainReleaseChecker is a tiny checker that verifies that arguments of
CoreFoundation retain/release
mclow.lists closed this revision.
mclow.lists added a comment.
landed as revision 339943
https://reviews.llvm.org/D50815
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mikerice updated this revision to Diff 161116.
mikerice marked an inline comment as done.
mikerice added a comment.
Added a -verify test to ensure no warnings on successful PCH use.
https://reviews.llvm.org/D50640
Files:
lib/Driver/Driver.cpp
test/Driver/cl-pch.cpp
test/PCH/Inputs/pch-thr
mikerice added a comment.
In https://reviews.llvm.org/D50640#1201216, @thakis wrote:
> How does the gcc driver codepath handle this?
Interestingly I'd say. So the gcc PCH model uses -include pch.h to use a PCH.
In the driver, -include pch.h is handled by locating a matching pch file (say
pc
NoQ added inline comments.
Herald added subscribers: Szelethus, mikhail.ramalho.
Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:1477-1530
+bool isPushBackCall(const FunctionDecl *Func) {
+ const auto *IdInfo = Func->getIdentifier();
+ if (!IdInfo)
+return false
Author: juliehockett
Date: Thu Aug 16 14:54:34 2018
New Revision: 339948
URL: http://llvm.org/viewvc/llvm-project?rev=339948&view=rev
Log:
Implement a (simple) Markdown generator
Implementing a simple Markdown generator from the emitted bitcode
summary of declarations. Very primitive at this poin
This revision was automatically updated to reflect the committed changes.
juliehockett marked an inline comment as done.
Closed by commit rCTE339948: Implement a (simple) Markdown generator (authored
by juliehockett, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D43424?vs=15
aprantl created this revision.
aprantl added reviewers: bruno, rsmith, teemperor.
Herald added a subscriber: llvm-commits.
Close FileEntries of cached files in ModuleManager::addModule().
While investigating why LLDB (which can build hundreds of clang
modules during one debug session) was getting
Author: rsmith
Date: Thu Aug 16 15:04:36 2018
New Revision: 339952
URL: http://llvm.org/viewvc/llvm-project?rev=339952&view=rev
Log:
Factor Node creation out of the demangler. No functionality change intended.
(This is a port of llvm r339944 to libcxxabi.)
Modified:
libcxxabi/trunk/src/cxa_d
aprantl added a comment.
@bruno: When we last discussed this my plan was to avoid the stat() in
lookupModuleFile() for files that were just added to the PCMCache by WriteAST()
entirely, but ModuleManager::Modules is a DenseMap and
lookupModuleFile() is the easiest way to create a new FileEntry.
101 - 200 of 250 matches
Mail list logo
