rjmccall added a comment.
Herald added a subscriber: jfb.
Hey, still working on this?
Repository:
rC Clang
https://reviews.llvm.org/D44539
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
Author: theraven
Date: Thu Aug 9 01:02:42 2018
New Revision: 339317
URL: http://llvm.org/viewvc/llvm-project?rev=339317&view=rev
Log:
Correctly initialise global blocks on Windows.
Summary:
Windows does not allow globals to be initialised to point to globals in
another DLL. Exported globals may
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339317: Correctly initialise global blocks on Windows.
(authored by theraven, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D50436
Files:
cfe/
theraven updated this revision to Diff 159868.
theraven added a comment.
- Address rjmcall's review comments.
- Revert blocks part of the patch to put in a separate review.
Repository:
rC Clang
https://reviews.llvm.org/D50144
Files:
include/clang/Driver/Options.td
lib/AST/MicrosoftMangle
ilya-biryukov added a comment.
The new behavior looks reasonable for interactive tools like clangd, but I'm a
bit worried that clang may emit too many irrelevant errors, because it may not
cope nicely with those fatal errors, i.e. wasn't tested that thoroughly in that
mode.
Nevertheless, I thin
hokein added a comment.
Sorry for the delay. I thought there was a dependent patch of this patch, but
it seems resolved, right?
A rough round of review.
> New version. I tried to share the code between this and SymbolCollector, but
> didn't find a good clean way. Do you have concrete suggestio
avt77 added a comment.
In https://reviews.llvm.org/D45619#1192803, @craig.topper wrote:
> I'm unclear why the we would want to assign clang's FrontendTimesIsEnabled
> from inside CodeGenAction. If I'm understanding the intentions here, the goal
> was to add more timing infrastructure to clang.
ilya-biryukov added inline comments.
Comment at: clangd/ClangdLSPServer.cpp:441
const clangd::CodeCompleteOptions &CCOpts,
+ const ClangdDiagnosticOptions &DiagOpts,
llvm::Optional
devnexen added a comment.
ping but will be for 8.0 :)
https://reviews.llvm.org/D49722
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
Comment at: clangd/TUScheduler.h:145
};
+
} // namespace clangd
NIT: accidental whitespace change?
Repository:
rCTE Clang T
HsiangKai added a comment.
Hi @vext01,
It should be fixed in https://reviews.llvm.org/D50495.
Please help me to confirm it in your environment. Thanks so much. :)
Repository:
rL LLVM
https://reviews.llvm.org/D45045
___
cfe-commits mailing list
c
Author: ioeric
Date: Thu Aug 9 02:05:45 2018
New Revision: 339320
URL: http://llvm.org/viewvc/llvm-project?rev=339320&view=rev
Log:
[clangd] Record the file being processed in a TUScheduler thread in context.
Summary:
This allows implementations like different symbol indexes to know what
the cur
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339320: [clangd] Record the file being processed in a
TUScheduler thread in context. (authored by ioeric, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.ll
Author: ioeric
Date: Thu Aug 9 02:25:26 2018
New Revision: 339322
URL: http://llvm.org/viewvc/llvm-project?rev=339322&view=rev
Log:
[clangd] Try to fix buildbot after r339320.
http://lab.llvm.org:8011/builders/clang-cmake-armv8-quick/builds/5487
Modified:
clang-tools-extra/trunk/clangd/TUSc
hokein added a comment.
In https://reviews.llvm.org/D50385#1191914, @ioeric wrote:
> 2 high-level questions:
>
> 1. What's the reason for having a separate `SymbolOccurrenceSlab`? Could
> store occurrences as extra payload of `Symbol`?
Storing occurrences in `Symbol` structure is easy to misus
kbobyrev created this revision.
kbobyrev added reviewers: ioeric, ilya-biryukov.
kbobyrev added a project: clang-tools-extra.
Herald added subscribers: arphaman, jkorous, MaskRay.
This patch modifies `consume` function to allow retrieval of limited number of
symbols. This is the "cheap" implement
ioeric added a comment.
In https://reviews.llvm.org/D50385#1193545, @hokein wrote:
> In https://reviews.llvm.org/D50385#1191914, @ioeric wrote:
>
> > 2 high-level questions:
> >
> > 1. What's the reason for having a separate `SymbolOccurrenceSlab`? Could
> > store occurrences as extra payload of
theraven updated this revision to Diff 159887.
theraven added a comment.
- Address Dustin's review comments.
- Fix an issue in protocol generation.
- Fix failing test.
- Address rjmcall's review comments.
- Add some missing comments and factor out SEH check.
Repository:
rC Clang
https://revie
theraven marked an inline comment as done.
theraven added a comment.
I believe that this is now ready to land.
Comment at: lib/CodeGen/CGObjCGNU.cpp:915
+return name;
+ }
/// The GCC ABI superclass message lookup function. Takes a pointer to a
rjmccall
kadircet created this revision.
kadircet added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, jfb, arphaman, jkorous, MaskRay, ioeric,
mgorny.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50502
Files:
clangd/CMakeLists.txt
clangd/Cancellation.cpp
clang
Szelethus created this revision.
Szelethus added reviewers: NoQ, xazax.hun, rnkovacs, george.karpenkov.
Herald added subscribers: cfe-commits, mikhail.ramalho, a.sidorin, szepet,
whisperity.
This diff is the first part of a series of patches to refactor
`UninitializedObjectChecker`. The goal of
Szelethus created this revision.
Szelethus added reviewers: george.karpenkov, NoQ, xazax.hun, rnkovacs.
Herald added subscribers: cfe-commits, mikhail.ramalho, a.sidorin, szepet,
whisperity, mgorny.
In this patch, the following classes and functions have been moved to a header
file:
- `FieldCha
Szelethus created this revision.
Szelethus added reviewers: xazax.hun, george.karpenkov, NoQ, rnkovacs.
Herald added subscribers: cfe-commits, mikhail.ramalho, a.sidorin, szepet,
whisperity.
Szelethus added a dependency: D50504: [analyzer][UninitializedObjectChecker]
Refactoring p2.: Moving point
Szelethus created this revision.
Szelethus added reviewers: xazax.hun, rnkovacs, NoQ, george.karpenkov.
Herald added subscribers: cfe-commits, mikhail.ramalho, a.sidorin, szepet,
whisperity.
This patch is the bread and butter of the refactoring effort.
Currently on trunk, `FieldChainInfo` is a s
miyuki created this revision.
miyuki added reviewers: eli.friedman, olista01, SjoerdMeijer.
Herald added a reviewer: javed.absar.
Herald added subscribers: chrib, kristof.beyls.
On targets that do not support FP16 natively LLVM currently legalizes
vectors of FP16 values by scalarizing them and pro
ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D47400
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
Author: martong
Date: Thu Aug 9 05:18:07 2018
New Revision: 339334
URL: http://llvm.org/viewvc/llvm-project?rev=339334&view=rev
Log:
Add support for importing imaginary literals
Reviewers: a_sidorin, r.stahl, xazax.hun
Subscribers: rnkovacs, dkrupp, cfe-commits
Differential Revision: https://r
Szelethus created this revision.
Szelethus added reviewers: NoQ, george.karpenkov, rnkovacs, xazax.hun.
Herald added subscribers: cfe-commits, mikhail.ramalho, a.sidorin, szepet,
whisperity.
A class named `FindUninitializedFields` shouldn't care about whether the
checker will outright ignore all
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339334: Add support for importing imaginary literals
(authored by martong, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D50428?vs=159662&id=
ldionne updated this revision to Diff 159903.
ldionne marked an inline comment as done.
ldionne added a comment.
Address vsapsai's comments
Repository:
rCXX libc++
https://reviews.llvm.org/D50344
Files:
libcxx/include/__config
libcxx/include/new
libcxx/test/libcxx/memory/aligned_alloca
ldionne added inline comments.
Comment at: libcxx/include/new:111-116
#if !__has_builtin(__builtin_operator_new) || \
__has_builtin(__builtin_operator_new) < 201802L || \
defined(_LIBCPP_HAS_NO_ALIGNED_ALLOCATION) || \
!defined(__cpp_aligned_new) || __cpp_aligned_new
ldionne marked an inline comment as done.
ldionne added inline comments.
Comment at: libcxx/test/libcxx/memory/aligned_allocation_macro.pass.cpp:11
+// UNSUPPORTED: c++98, c++03, c++11, c++14
+// XFAIL: with_system_cxx_lib=macosx10.12
+// XFAIL: with_system_cxx_lib=macosx10.11
--
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339336: Fix structural inequivalency of forward EnumDecl
(authored by martong, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D50444?vs=159697
Author: martong
Date: Thu Aug 9 05:36:25 2018
New Revision: 339336
URL: http://llvm.org/viewvc/llvm-project?rev=339336&view=rev
Log:
Fix structural inequivalency of forward EnumDecl
Summary:
Currently we consider one forward declared RecordDecl and another with a
definition equal. We have to do
Merged to 7.0 in r339339.
On Thu, Aug 9, 2018 at 10:02 AM, David Chisnall via cfe-commits
wrote:
> Author: theraven
> Date: Thu Aug 9 01:02:42 2018
> New Revision: 339317
>
> URL: http://llvm.org/viewvc/llvm-project?rev=339317&view=rev
> Log:
> Correctly initialise global blocks on Windows.
>
>
Merged to 7.0 in r339341.
On Wed, Aug 8, 2018 at 9:14 PM, Craig Topper via cfe-commits
wrote:
> Author: ctopper
> Date: Wed Aug 8 12:14:23 2018
> New Revision: 339281
>
> URL: http://llvm.org/viewvc/llvm-project?rev=339281&view=rev
> Log:
> [CodeGen][Timers] Enable llvm::TimePassesIsEnabled when
erichkeane abandoned this revision.
erichkeane added a comment.
After talking to Aaron, we're going to try to use the lexical names for ALL
cases. This requires a bunch of of accessory work (in order to get the
Identifier from the SourceRange), so it'll be split up into a couple of commits
and
kbobyrev updated this revision to Diff 159908.
kbobyrev marked 15 inline comments as done.
kbobyrev added a comment.
Address a round of comments. Also put `FIXME`s where appropriate for the future
changes.
https://reviews.llvm.org/D50337
Files:
clang-tools-extra/clangd/CMakeLists.txt
clang
olista01 added inline comments.
Comment at: test/Driver/aarch64-cpus.c:10
+// GENERIC: "-cc1"{{.*}} "-triple" "aarch64"{{.*}} "-target-cpu" "generic"
+// GENERIC-LE: "-cc1"{{.*}} "-triple" "aarch64--"{{.*}} "-target-cpu" "generic"
SjoerdMeijer wrote:
> olista01
Author: erichkeane
Date: Thu Aug 9 06:21:32 2018
New Revision: 339344
URL: http://llvm.org/viewvc/llvm-project?rev=339344&view=rev
Log:
Implement diagnostic stream operator for ParsedAttr.
As a part of attempting to clean up the way attributes are
printed, this patch adds an operator << to the
Szelethus created this revision.
Szelethus added reviewers: george.karpenkov, NoQ, xazax.hun, rnkovacs.
Herald added subscribers: cfe-commits, mikhail.ramalho, a.sidorin, szepet,
whisperity.
Now that it has it's own file, it makes little sense for
`isPointerOrReferenceUninit` to be this large, s
ioeric added a comment.
Could you add test? ;)
Comment at: clang-tools-extra/clangd/index/dex/Iterator.cpp:223
std::vector Result;
- for (; !It.reachedEnd(); It.advance())
+ for (size_t Retreived = 0; !It.reachedEnd() && Retreived < Limit;
+ It.advance())
---
SjoerdMeijer added inline comments.
Comment at: test/Driver/aarch64-cpus.c:10
+// GENERIC: "-cc1"{{.*}} "-triple" "aarch64"{{.*}} "-target-cpu" "generic"
+// GENERIC-LE: "-cc1"{{.*}} "-triple" "aarch64--"{{.*}} "-target-cpu" "generic"
olista01 wrote:
> SjoerdMe
SjoerdMeijer updated this revision to Diff 159915.
SjoerdMeijer added a comment.
Addressed comments.
https://reviews.llvm.org/D50175
Files:
test/Driver/aarch64-cpus.c
Index: test/Driver/aarch64-cpus.c
===
--- test/Driver/aarch64
Szelethus updated this revision to Diff 159916.
Szelethus added a comment.
Fixed a comment.
https://reviews.llvm.org/D50509
Files:
lib/StaticAnalyzer/Checkers/UninitializedPointee.cpp
Index: lib/StaticAnalyzer/Checkers/UninitializedPointee.cpp
olista01 accepted this revision.
olista01 added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
https://reviews.llvm.org/D50175
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
hokein updated this revision to Diff 159919.
hokein marked an inline comment as done.
hokein added a comment.
Adress review comment - ignore the case in the check.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50447
Files:
clang-tidy/performance/ForRangeCopyCheck.cpp
test/
hokein added inline comments.
Comment at: clang-tidy/performance/ForRangeCopyCheck.cpp:39
+ auto WhitelistClassMatcher =
+ cxxRecordDecl(hasAnyName(SmallVector(
+ WhitelistClasses.begin(), WhitelistClasses.end(;
JonasToth wrote:
> I have seens
Szelethus updated this revision to Diff 159918.
Szelethus added a comment.
The solution now relies on the refactored version of the checker. Note that it
modifies roughly 75% less code ;).
https://reviews.llvm.org/D49228
Files:
lib/StaticAnalyzer/Checkers/UninitializedPointee.cpp
test/Anal
Author: sjoerdmeijer
Date: Thu Aug 9 07:07:27 2018
New Revision: 339347
URL: http://llvm.org/viewvc/llvm-project?rev=339347&view=rev
Log:
[AArch64][NFC] better matching of AArch64 target in aarch64-cpus.c tests
Differential Revision: https://reviews.llvm.org/D50175
Modified:
cfe/trunk/test/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339347: [AArch64][NFC] better matching of AArch64 target in
aarch64-cpus.c tests (authored by SjoerdMeijer, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://revi
ahatanak updated this revision to Diff 159926.
ahatanak marked 2 inline comments as done.
ahatanak added a comment.
Address review comments.
Repository:
rC Clang
https://reviews.llvm.org/D50152
Files:
include/clang/AST/ASTContext.h
lib/AST/ASTContext.cpp
lib/CodeGen/CGBlocks.cpp
lib/
ahatanak added inline comments.
Comment at: lib/CodeGen/CGBlocks.cpp:1682
+ if (IsCopyHelper && Ctx.getBlockVarCopyInits(Var).CanThrow)
+Name += "c";
+}
rjmccall wrote:
> ahatanak wrote:
> > rjmccall wrote:
> > > I don't think you nee
hans created this revision.
hans added reviewers: rnk, thakis.
This extension emits the guard cf table without inserting the instrumentation.
Currently that's what clang-cl does with /guard:cf anyway, but this allows a
user to request that explicitly.
https://reviews.llvm.org/D50513
Files:
hans added inline comments.
Comment at: lib/CodeGen/CodeGenModule.cpp:463
// We want function ID tables for Control Flow Guard.
-getModule().addModuleFlag(llvm::Module::Warning, "cfguard", 1);
+getModule().addModuleFlag(llvm::Module::Warning, "cfguardtable", 1);
}
acoomans added a comment.
Ping
Repository:
rC Clang
https://reviews.llvm.org/D49549
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
Looks good, thanks!
PS: I don't think it hurts, but it's sufficient to add cfe-commits as a
subscriber. I believe it's an automation account (so it won't be able to accept
on phab
philip.pfaffe added a comment.
Ping.
https://reviews.llvm.org/D49486
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
acoomans added a comment.
@JDevlieghere Thanks! subscribers -> makes sense, will do
Repository:
rC Clang
https://reviews.llvm.org/D49549
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
SjoerdMeijer added inline comments.
Comment at: lib/Driver/ToolChains/Arch/ARM.cpp:430
+ if (ArchName.find_lower("+noaes") == StringRef::npos)
+Features.push_back("+aes");
+} else if (ArchName.find_lower("-crypto") != StringRef::npos) {
efriedma
acoomans created this revision.
acoomans added a reviewer: cfe-commits.
Original changeset (https://reviews.llvm.org/D46776) by @modocache. It was
reverted after the PS4 bot failed.
The issue has been determined to be with the way the PS4 SDK handles this
particular option. https://reviews.llvm
balazske created this revision.
Herald added subscribers: cfe-commits, martong.
Herald added a reviewer: a.sidorin.
When importing a friend class template declaration,
this declaration should not be merged with any other existing declaration
for the same type. Otherwise the getFriendDecl of the Fr
kbobyrev created this revision.
kbobyrev added reviewers: ioeric, ilya-biryukov.
Herald added subscribers: arphaman, jkorous, MaskRay.
https://reviews.llvm.org/D50517
Files:
clang-tools-extra/clangd/index/dex/Trigram.cpp
clang-tools-extra/clangd/index/dex/Trigram.h
clang-tools-extra/unittes
beanz added a comment.
I’m not opposed to this patch, but is there a real need for this? Have you
considered just running clang with the `-print-resource-dir` flag?
https://reviews.llvm.org/D49486
___
cfe-commits mailing list
cfe-commits@lists.llvm
JonasToth added a comment.
LGTM, but alex or aaron should allow the commit ;)
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50447
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
kbobyrev planned changes to this revision.
kbobyrev added a comment.
This patch is in preview mode and can be useful for the discussion. It's not
functional yet, but this will be changed in the future.
The upcoming changes would allow handling short queries introduced in
https://reviews.llvm.or
kbobyrev planned changes to this revision.
kbobyrev added a comment.
Oops, I thought I pushed "Plan Changes" for this one.
https://reviews.llvm.org/D50500
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
ahatanak added a comment.
ping
Repository:
rC Clang
https://reviews.llvm.org/D47757
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
philip.pfaffe added a comment.
I had not, but it should work just as well!
https://reviews.llvm.org/D49486
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kzhuravl accepted this revision.
kzhuravl added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D50493
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
ilya-biryukov added inline comments.
Comment at: clangd/CodeComplete.cpp:289
}
+ std::stable_sort(Completion.FixIts.begin(), Completion.FixIts.end(),
+ [](const TextEdit &X, const TextEdit &Y) {
We shouldn't have duplicate/overla
beanz added a comment.
Please check and see if that works for you. In general I prefer to avoid adding
new features that aren't used in-tree unless it is unavoidable or would be
difficult to work around out-of-tree. This one seems pretty straightforward to
me.
https://reviews.llvm.org/D49486
kbobyrev updated this revision to Diff 159959.
kbobyrev marked 3 inline comments as done.
kbobyrev added a comment.
Fix the implementation and add test coverage.
https://reviews.llvm.org/D50500
Files:
clang-tools-extra/clangd/index/dex/Iterator.cpp
clang-tools-extra/clangd/index/dex/Iterato
Author: bviyer
Date: Mon Aug 6 17:31:44 2018
New Revision: 339085
URL: http://llvm.org/viewvc/llvm-project?rev=339085&view=rev
Log:
Performing a test commmit as requested by Chris Lattner.
-This line, and those below, will be ignored--
MTemplateBase.h
Modified:
cfe/trunk/include/clang/A
This has also shown up in a game engine middleware codebase, so it may be a
broader issue - people seem to assume size_t is one of the int*_t types.
On Wed, Aug 8, 2018 at 10:55 AM, Sam Clegg via Phabricator <
revi...@reviews.llvm.org> wrote:
> sbc100 added a comment.
>
> In https://reviews.llvm.
Author: kadircet
Date: Wed Aug 8 01:59:29 2018
New Revision: 339224
URL: http://llvm.org/viewvc/llvm-project?rev=339224&view=rev
Log:
Added functionality to suggest FixIts for conversion of '->' to '.' and vice
versa.
Summary: Added functionality to suggest FixIts for conversion of '->' to '.'
vsapsai accepted this revision.
vsapsai added inline comments.
This revision is now accepted and ready to land.
Comment at: libcxx/include/new:111-116
#if !__has_builtin(__builtin_operator_new) || \
__has_builtin(__builtin_operator_new) < 201802L || \
defined(_LIBCPP_HAS
ldionne added inline comments.
Comment at:
libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.array/new_size_align.fail.cpp:15
// UNSUPPORTED: c++98, c++03, c++11, c++14, c++17
// UNSUPPORTED: clang-3.3, clang-3.4, clang-3.5, clang-3.6, clang-3.7,
clang-
Author: george.karpenkov
Date: Thu Aug 9 12:03:12 2018
New Revision: 339369
URL: http://llvm.org/viewvc/llvm-project?rev=339369&view=rev
Log:
[analyzer] Fix the bug in UninitializedObjectChecker caused by not handling
block pointers
Differential Revision: https://reviews.llvm.org/D50523
Added:
This revision was automatically updated to reflect the committed changes.
Closed by commit rC339369: [analyzer] Fix the bug in UninitializedObjectChecker
caused by not handling… (authored by george.karpenkov, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https
simark marked 3 inline comments as done.
simark added a comment.
In https://reviews.llvm.org/D48687#1193470, @hokein wrote:
> Sorry for the delay. I thought there was a dependent patch of this patch, but
> it seems resolved, right?
>
> A rough round of review.
Right, the patch this one depends
simark updated this revision to Diff 159972.
simark marked an inline comment as done.
simark added a comment.
Replace
RelPathPrefix == StringRef()
with
RelPathPrefix.empty()
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48687
Files:
clangd/FindSymbols.cpp
clangd/Sou
efriedma added inline comments.
Comment at: lib/Driver/ToolChains/Arch/AArch64.cpp:266
+ const bool HasV83a = (std::find(ItBegin, ItEnd, "+v8.3a") != ItEnd);
+ const bool HasV84a = (std::find(ItBegin, ItEnd, "+v8.4a") != ItEnd);
+ const bool HasV85a = (std::find(It
rsmith created this revision.
rsmith added a reviewer: aaron.ballman.
rsmith added a project: clang.
Specifically, `AttributedType` now tracks a regular `attr::Kind` rather than
having its own parallel `Kind` enumeration, and `AttributedTypeLoc` now holds
an `Attr*` instead of holding an ad-hoc
dannygr664 added a comment.
Are there any updates on this revision? The team at my company is interested in
using this linting rule in C++ code.
https://reviews.llvm.org/D33029
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM with a small bugfix.
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:1122
+for (Decl *D : MemberGet) {
+ if (FunctionTemplateDecl *FTD = dyn_cast(D)) {
+Temp
erik.pilkington created this revision.
erik.pilkington added reviewers: rjmccall, arphaman.
Herald added a subscriber: dexonsmith.
This fixes rdar://30741878
Thanks!
Erik
Repository:
rC Clang
https://reviews.llvm.org/D50527
Files:
clang/lib/Parse/ParseExpr.cpp
clang/test/Parser/message-
emmettneyman created this revision.
emmettneyman added reviewers: morehouse, kcc.
Herald added a subscriber: cfe-commits.
Edited `loop_proto_to_llvm` to emit metadata at the end of the generated IR.
This metadata will increase the vector width when the IR is optimized.
Repository:
rC Clang
h
SjoerdMeijer updated this revision to Diff 159979.
SjoerdMeijer added a comment.
fixed typo
https://reviews.llvm.org/D50179
Files:
lib/Driver/ToolChains/Arch/AArch64.cpp
lib/Driver/ToolChains/Arch/ARM.cpp
test/Driver/arm-features.c
test/Preprocessor/aarch64-target-features.c
Index: tes
rsmith added a comment.
One comment, but otherwise the code change looks mechanically correct. Not
accepting only because I don't know whether this is the intended language rule
for Objective-C++ or not (please get someone else to sign off on that).
Comment at: clang/lib/Pars
erichkeane created this revision.
erichkeane added reviewers: rjmccall, riccibruno, aaron.ballman.
ParsedAttr is using a hand-rolled trailing-objects
implementation that gets cleaned up quite a bit by
just using llvm::TrailingObjects. This is a large
TrailingObjects list, but most things are leng
morehouse added inline comments.
Comment at: clang/tools/clang-fuzzer/proto-to-llvm/loop_proto_to_llvm.cpp:141
+<< "!1 = !{!\"llvm.loop.vectorize.enable\", i1 true}\n"
+<< "!2 = !{!\"llvm.loop.vectorize.width\", i32 " << kArraySize
+<< "}\n";
-
Author: steveire
Date: Thu Aug 9 13:05:03 2018
New Revision: 339372
URL: http://llvm.org/viewvc/llvm-project?rev=339372&view=rev
Log:
Add getBeginLoc API to replace getLocStart
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D50346
Modified:
cfe/trunk/include/clang
Author: steveire
Date: Thu Aug 9 13:05:18 2018
New Revision: 339373
URL: http://llvm.org/viewvc/llvm-project?rev=339373&view=rev
Log:
Add getBeginLoc API to replace getStartLoc
Reviewers: teemperor!
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D50347
Modified:
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339372: Add getBeginLoc API to replace getLocStart (authored
by steveire, committed by ).
Herald added a subscriber: llvm-
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rC339372: Add getBeginLoc API to replace getLocStart (authored
by steveire, committed by ).
Changed prior to commit:
http
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rC339373: Add getBeginLoc API to replace getStartLoc (authored
by steveire, committed by ).
Changed prior to commit:
http
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339373: Add getBeginLoc API to replace getStartLoc (authored
by steveire, committed by ).
Herald added a subscriber: llvm-
Author: steveire
Date: Thu Aug 9 13:05:47 2018
New Revision: 339374
URL: http://llvm.org/viewvc/llvm-project?rev=339374&view=rev
Log:
Add getEndLoc API to replace getLocEnd
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D50348
Modified:
cfe/trunk/include/clang/AST
erichkeane added inline comments.
Comment at: include/clang/Sema/ParsedAttr.h:80
+struct TypeTagForDatatypeData {
+ ParsedType *MatchingCType;
Because all of these became part of the TYPE of ParsedAttr now, they need to be
defined outside of ParsedAttr. Addi
1 - 100 of 194 matches
Mail list logo
