efriedma added inline comments.
================
Comment at: lib/Driver/ToolChains/Arch/AArch64.cpp:266
+ const bool HasV83a = (std::find(ItBegin, ItEnd, "+v8.3a") != ItEnd);
+ const bool HasV84a = (std::find(ItBegin, ItEnd, "+v8.4a") != ItEnd);
+ const bool HasV85a = (std::find(ItBegin, ItEnd, "+v8.5a") != ItEnd);
----------------
HasV84a is always false; you checked it a few lines earlier. And I think that
implies HasV85a is also false? Not sure.
================
Comment at: lib/Driver/ToolChains/Arch/ARM.cpp:430
+ if (ArchName.find_lower("+noaes") == StringRef::npos)
+ Features.push_back("+aes");
+ } else if (ArchName.find_lower("-crypto") != StringRef::npos) {
----------------
SjoerdMeijer wrote:
> efriedma wrote:
> > The ARM backend doesn't support features named "sha2" and "aes" at the
> > moment.
> These ARM target features were introduced in rL335953.
Hmm, I missed that somehow; okay.
https://reviews.llvm.org/D50179
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
