krasimir created this revision.
krasimir added a reviewer: djasper.
Herald added subscribers: cfe-commits, acoomans.
Adds 2 functions taking a text proto argument.
Repository:
rC Clang
https://reviews.llvm.org/D50132
Files:
lib/Format/Format.cpp
Index: lib/Format/Format.cpp
=
SjoerdMeijer added inline comments.
Comment at: test/Driver/aarch64-cpus.c:9
// RUN: %clang -target aarch64_be -mlittle-endian -mcpu=generic -### -c %s
2>&1 | FileCheck -check-prefix=GENERIC %s
// GENERIC: "-cc1"{{.*}} "-triple" "aarch64{{.*}}" "-target-cpu" "generic"
--
baloghadamsoftware updated this revision to Diff 158479.
baloghadamsoftware added a comment.
Pre-statement check of `CXXOperatorCallExpr` merged into pre-call check.
https://reviews.llvm.org/D32747
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/Iterator
baloghadamsoftware added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:605
+ if (Pos && !Pos->isValid()) {
+// If I do not put a tag here, some invalidation tests will fail
+static CheckerProgramPointTag Tag("InvalidatedIteratorChecker",
--
Hahnfeld added a comment.
In https://reviews.llvm.org/D47849#1183150, @hfinkel wrote:
> Hrmm. Doesn't that make it so that whatever functions are implemented using
> that inline assembly will not be callable from target code (or, perhaps
> worse, will crash the backend if called)?
You are rig
djasper added a comment.
I don't have very strong opinions here and I agree that we will need to improve
the conditional formatting, especially as this kind of ternary-chaining is
becoming more popular because of constexpr.
My personal opinion(s):
- I think this is a no-brainer for BreakBefore
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
Thanks! LGTM
https://reviews.llvm.org/D49758
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM with a small nit. Thanks for the change!
Comment at: clangd/ClangdLSPServer.cpp:419
+DidChangeConfigurationParams &Params) {
+ ClangdConfigurationPara
a.elovikov updated this revision to Diff 158483.
a.elovikov added a comment.
- Address Erich's comment + clang-format.
https://reviews.llvm.org/D50056
Files:
clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp
Index: clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp
Typz added a comment.
Ping!
This has been stale for a while now. Last comment indicate this is not the
right approach, but some prototyping has been done a more generic approach,
with no timeline.
I understand this, but in the meantime the problem is still there, with no
solution at the moment
Author: rksimon
Date: Wed Aug 1 02:45:21 2018
New Revision: 338502
URL: http://llvm.org/viewvc/llvm-project?rev=338502&view=rev
Log:
Fix "not all control paths return a value" MSVC warning.
Modified:
cfe/trunk/include/clang/Analysis/ConstructionContext.h
Modified: cfe/trunk/include/clang/An
Author: yamaguchi
Date: Wed Aug 1 02:50:02 2018
New Revision: 338503
URL: http://llvm.org/viewvc/llvm-project?rev=338503&view=rev
Log:
[Modules] Do not emit relocation error when -fno-validate-pch is set
Summary:
Clang emits error when implicit modules was relocated from the
first build director
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338503: [Modules] Do not emit relocation error when
-fno-validate-pch is set (authored by yamaguchi, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llv
klimek added a comment.
Yea, if we go down this route I'd go with this by default:
some ? thing :
else ? otherthing :
unrelated ? but :
finally;
Theoretically we could even use:
some ? thing :
else;
by default ;)
Repository:
rC Clang
https://reviews.llvm.org/D50078
klimek added a comment.
The problem here is that we have different opinions on how the formatting on
namespace macros should behave in the first place- I think they should behave
like namespaces, you want them to be formatted differently.
Given that you want full control over the formatting of t
AlexeySotkin added a comment.
In https://reviews.llvm.org/D49725#1183316, @aaron.ballman wrote:
> FYI: @asavonic, the email address you have associated with your commit id is
> `AlexeySotkin@/etc/mailname` which is getting stuck in the moderation queue
> as not being signed up to the mailing li
Author: rksimon
Date: Wed Aug 1 03:26:04 2018
New Revision: 338508
URL: http://llvm.org/viewvc/llvm-project?rev=338508&view=rev
Log:
Replace 'FALL-THROUGH' comment with LLVM_FALLTHROUGH to silence warning. NFCI.
Modified:
cfe/trunk/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp
Modified: cfe/tru
Author: rksimon
Date: Wed Aug 1 03:34:13 2018
New Revision: 338510
URL: http://llvm.org/viewvc/llvm-project?rev=338510&view=rev
Log:
Add missing semicolon.
Modified:
cfe/trunk/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp
Modified: cfe/trunk/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp
URL:
http:
lolgear added a comment.
Herald added subscribers: llvm-commits, dexonsmith.
Well, deprecated category only shows "Implementing deprecated category" message.
However, I would like to tell users that all methods of this category are
deprecated.
For that I need to add deprecated attribute for each
LukeCheeseman updated this revision to Diff 158491.
LukeCheeseman added a comment.
Move -msign-return-address argument handling into AArch64TargetArgs
https://reviews.llvm.org/D49793
Files:
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
include/clang/Frontend/Co
mstorsjo created this revision.
mstorsjo added reviewers: phosek, beanz, compnerd, smeenai.
Herald added subscribers: chrib, mgorny.
This is the same as libcxxabi/libcxx do.
Repository:
rUNW libunwind
https://reviews.llvm.org/D50135
Files:
CMakeLists.txt
Index: CMakeLists.txt
===
hokein added a comment.
Mostly good. A few nits.
Comment at: clang-tidy/performance/UnnecessaryValueParamCheck.cpp:103
// Do not trigger on non-const value parameters when they are not only used
as
// const.
This comment needs to be updated.
krasimir created this revision.
krasimir added a reviewer: mprobst.
Herald added subscribers: cfe-commits, acoomans.
Repository:
rC Clang
https://reviews.llvm.org/D50138
Files:
lib/Format/BreakableToken.cpp
Index: lib/Format/BreakableToken.cpp
==
bricci updated this revision to Diff 158498.
bricci added a comment.
rebased after the great whitespace trimming
Repository:
rC Clang
https://reviews.llvm.org/D49729
Files:
include/clang/AST/Decl.h
include/clang/AST/DeclBase.h
lib/AST/Decl.cpp
lib/AST/DeclBase.cpp
lib/AST/DeclCXX.c
bricci updated this revision to Diff 158499.
bricci added a comment.
rebased after the great whitespace trimming
Repository:
rC Clang
https://reviews.llvm.org/D49734
Files:
include/clang/AST/DeclObjC.h
lib/AST/DeclObjC.cpp
lib/Sema/SemaDeclObjC.cpp
lib/Serialization/ASTReaderDecl.cpp
bricci updated this revision to Diff 158500.
bricci added a comment.
rebased after the great whitespace trimming
Repository:
rC Clang
https://reviews.llvm.org/D49733
Files:
include/clang/AST/Decl.h
include/clang/AST/DeclCXX.h
include/clang/AST/DeclOpenMP.h
lib/AST/Decl.cpp
lib/AST/
hokein marked an inline comment as done.
hokein added inline comments.
Comment at: clangd/index/Index.h:45
- operator bool() const { return !FileURI.empty(); }
+ explicit operator bool() const { return !FileURI.empty(); }
+ bool operator==(const SymbolLocation& Loc) const {
Author: hokein
Date: Wed Aug 1 04:24:50 2018
New Revision: 338517
URL: http://llvm.org/viewvc/llvm-project?rev=338517&view=rev
Log:
[clangd] Make SymbolLocation => bool conversion explicitly.
Summary:
The implicit bool conversion could happen superisingly, e.g. when
checking `if (Loc1 == Loc2)`,
This revision was automatically updated to reflect the committed changes.
hokein marked an inline comment as done.
Closed by commit rCTE338517: [clangd] Make SymbolLocation => bool conversion
explicitly. (authored by hokein, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D496
bricci updated this revision to Diff 158501.
bricci added a comment.
rebased after the great whitespace trimming
Repository:
rC Clang
https://reviews.llvm.org/D49732
Files:
include/clang/AST/Decl.h
include/clang/AST/DeclCXX.h
lib/AST/Decl.cpp
lib/AST/DeclCXX.cpp
lib/Serialization/A
Author: simark
Date: Wed Aug 1 04:28:49 2018
New Revision: 338518
URL: http://llvm.org/viewvc/llvm-project?rev=338518&view=rev
Log:
[clangd] Receive compilationDatabasePath in 'initialize' request
Summary:
That way, as soon as the "initialize" is received by the server, it can start
parsing/inde
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338518: [clangd] Receive compilationDatabasePath in
'initialize' request (authored by simark, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D
simark marked 2 inline comments as done.
simark added a comment.
Thanks, done.
Repository:
rL LLVM
https://reviews.llvm.org/D49833
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jasonl220 added a comment.
Can you commit this for me, I don't have access. Thanks
Repository:
rCXX libc++
https://reviews.llvm.org/D49997
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
krasimir added a comment.
Could you clarify how each piece is supposed to be aligned in these examples?
This is what makes me happy:
// column limit V
int a = condition1 ? result1
: conditio2 ? result2
: loocondition
? result2
: dition
Author: krasimir
Date: Wed Aug 1 04:48:04 2018
New Revision: 338519
URL: http://llvm.org/viewvc/llvm-project?rev=338519&view=rev
Log:
[clang-format] Add @private to the list of jsdoc annotations
Reviewers: mprobst
Reviewed By: mprobst
Subscribers: acoomans, cfe-commits
Differential Revision:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338519: [clang-format] Add @private to the list of jsdoc
annotations (authored by krasimir, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D50138
KP added inline comments.
Comment at: unittests/Format/FormatTest.cpp:7878
+" int const i = 1;\n"
+" int **j = 2, ***k;\n"
+" int &k = i;\n"
djasper wrote:
> This looks wrong to me. Wouldn't you want to align
Author: nico
Date: Wed Aug 1 04:56:20 2018
New Revision: 338520
URL: http://llvm.org/viewvc/llvm-project?rev=338520&view=rev
Log:
wrap to 80 cols, no behavior change
Modified:
cfe/trunk/lib/AST/MicrosoftMangle.cpp
Modified: cfe/trunk/lib/AST/MicrosoftMangle.cpp
URL:
http://llvm.org/viewvc/
hokein updated this revision to Diff 158507.
hokein marked 4 inline comments as done.
hokein added a comment.
Scope the patch to interfaces only.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49658
Files:
clangd/index/FileIndex.cpp
clangd/index/FileIndex.h
clangd/index/I
hokein added a comment.
In https://reviews.llvm.org/D49658#1171410, @sammccall wrote:
> Mostly LG.
>
> I think we can simplify in a couple of places, and you should decide if this
> patch is *implementing* the new index operation or not. (Currently it
> implements it for 1/3 implementations, wh
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
Repository:
rC Clang
https://reviews.llvm.org/D50132
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338524: [clang-format] Add some text proto functions to
Google style (authored by krasimir, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D50132
Author: krasimir
Date: Wed Aug 1 05:35:23 2018
New Revision: 338524
URL: http://llvm.org/viewvc/llvm-project?rev=338524&view=rev
Log:
[clang-format] Add some text proto functions to Google style
Summary: Adds 2 functions taking a text proto argument.
Reviewers: djasper, klimek
Reviewed By: dja
Author: sjoerdmeijer
Date: Wed Aug 1 05:41:10 2018
New Revision: 338525
URL: http://llvm.org/viewvc/llvm-project?rev=338525&view=rev
Log:
[AArch64][ARM] Add Armv8.4-A tests
This adds tests for Armv8.4-A, and also some v8.2 and v8.3 tests that were
missing.
Differential Revision: https://reviews
This revision was automatically updated to reflect the committed changes.
Closed by commit rC338525: [AArch64][ARM] Add Armv8.4-A tests (authored by
SjoerdMeijer, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D50068
Files:
lib/Basic/Targets/ARM.cpp
test/Driver/aarch64-cpus
Author: hokein
Date: Wed Aug 1 05:50:44 2018
New Revision: 338526
URL: http://llvm.org/viewvc/llvm-project?rev=338526&view=rev
Log:
[clangd] Correct the namespace of ParsedAST forward declaration, NFC.
Modified:
clang-tools-extra/trunk/clangd/FindSymbols.h
Modified: clang-tools-extra/trunk/
Author: hans
Date: Wed Aug 1 05:58:57 2018
New Revision: 338528
URL: http://llvm.org/viewvc/llvm-project?rev=338528&view=rev
Log:
UserManual: Update with the latest clang-cl flags
Modified:
cfe/trunk/docs/UsersManual.rst
Modified: cfe/trunk/docs/UsersManual.rst
URL:
http://llvm.org/viewvc/
erichkeane accepted this revision.
erichkeane added a comment.
LMK if you need someone to commit this for you.
https://reviews.llvm.org/D50056
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
Author: ldionne
Date: Wed Aug 1 06:13:14 2018
New Revision: 338531
URL: http://llvm.org/viewvc/llvm-project?rev=338531&view=rev
Log:
[libc++] Fix GCC 7.2.0 macro redefinition warning
The warning happens when LIBCXX_ENABLE_EXCEPTIONS cmake option is not set,
and it fires every time __config is in
ldionne closed this revision.
ldionne added a comment.
Committed as r32f108a0736
Repository:
rCXX libc++
https://reviews.llvm.org/D49997
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
Author: hans
Date: Wed Aug 1 06:19:14 2018
New Revision: 338534
URL: http://llvm.org/viewvc/llvm-project?rev=338534&view=rev
Log:
Make test/Frontend/clang-abi-compat.cpp pass when the version goes to 8
Modified:
cfe/trunk/test/Frontend/clang-abi-compat.cpp
Modified: cfe/trunk/test/Frontend/
Author: hans
Date: Wed Aug 1 06:30:36 2018
New Revision: 338542
URL: http://llvm.org/viewvc/llvm-project?rev=338542&view=rev
Log:
Creating release_70 branch off revision 338536
Added:
libcxx/branches/release_70/ (props changed)
- copied from r338536, libcxx/trunk/
Propchange: libcxx
Author: hans
Date: Wed Aug 1 06:30:41 2018
New Revision: 338543
URL: http://llvm.org/viewvc/llvm-project?rev=338543&view=rev
Log:
Creating release_70 branch off revision 338536
Added:
libcxxabi/branches/release_70/
- copied from r338536, libcxxabi/trunk/
__
Author: hans
Date: Wed Aug 1 06:31:22 2018
New Revision: 338549
URL: http://llvm.org/viewvc/llvm-project?rev=338549&view=rev
Log:
Creating release_70 branch off revision 338536
Added:
libunwind/branches/release_70/
- copied from r338536, libunwind/trunk/
__
Author: a.elovikov
Date: Wed Aug 1 06:34:18 2018
New Revision: 338551
URL: http://llvm.org/viewvc/llvm-project?rev=338551&view=rev
Log:
[NFC] Silence warning about ptr-to-func to ptr-to-obj cast in
clang-fuzzer/handle-llvm/handle_llvm.cpp.
Summary:
I don't have the whole list of GCC binaries av
Author: filcab
Date: Wed Aug 1 06:41:11 2018
New Revision: 338552
URL: http://llvm.org/viewvc/llvm-project?rev=338552&view=rev
Log:
Add REQUIRES: native to a test that assumes it
Modified:
cfe/trunk/test/Driver/darwin-infer-simulator-sdkroot.c
Modified: cfe/trunk/test/Driver/darwin-infer-si
Author: filcab
Date: Wed Aug 1 06:41:42 2018
New Revision: 338553
URL: http://llvm.org/viewvc/llvm-project?rev=338553&view=rev
Log:
Use a dummy target so the test passes when default target is for a toolchain
implements useIntegratedAs() -> true
Modified:
cfe/trunk/test/Driver/integrated-as
This revision was automatically updated to reflect the committed changes.
Closed by commit rC338551: [NFC] Silence warning about ptr-to-func to
ptr-to-obj cast in clang… (authored by a.elovikov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50056?vs=158483&id=158527#toc
Re
Author: hans
Date: Wed Aug 1 06:54:28 2018
New Revision: 338555
URL: http://llvm.org/viewvc/llvm-project?rev=338555&view=rev
Log:
Update version to 8.0.0svn: cmake, includes files and docs
Modified:
libcxx/trunk/CMakeLists.txt
libcxx/trunk/docs/conf.py
libcxx/trunk/include/__config
scott.linder updated this revision to Diff 158532.
scott.linder added a comment.
Add comments to explain OpenCL case
https://reviews.llvm.org/D50099
Files:
lib/CodeGen/CGDebugInfo.cpp
lib/CodeGen/CGDebugInfo.h
test/CodeGenOpenCL/blocks.cl
Index: test/CodeGenOpenCL/blocks.cl
=
Typz added a comment.
In https://reviews.llvm.org/D50078#1184015, @djasper wrote:
> - I'd be ok with the suggestion for BreakBeforeTernaryOperators=true
Just to be clear, which suggestion would you be ok with?
int fooo = ? 0
: ? 1
: ;
or:
ilya-biryukov added a comment.
Picking it up since @sammccall is OOO.
> Implementing all index operations in the patch would be end up with a large
> patch, I intend to split the patch as small as possible. Let's scope this
> patch to interface only.
LG as interface-only patch. just a few nits
Author: hans
Date: Wed Aug 1 07:01:27 2018
New Revision: 338557
URL: http://llvm.org/viewvc/llvm-project?rev=338557&view=rev
Log:
Update docs version and clear release notes after 8.0.0 version bump
Modified:
cfe/trunk/docs/ReleaseNotes.rst
cfe/trunk/docs/conf.py
Modified: cfe/trunk/doc
Author: hans
Date: Wed Aug 1 07:09:00 2018
New Revision: 338559
URL: http://llvm.org/viewvc/llvm-project?rev=338559&view=rev
Log:
Update docs version and clear release notes after 8.0.0 version bump
Modified:
clang-tools-extra/trunk/docs/ReleaseNotes.rst
clang-tools-extra/trunk/docs/conf
Author: hans
Date: Wed Aug 1 07:14:09 2018
New Revision: 338561
URL: http://llvm.org/viewvc/llvm-project?rev=338561&view=rev
Log:
Update docs version and clear release notes after 8.0.0 version bump
Modified:
libunwind/trunk/docs/conf.py
Modified: libunwind/trunk/docs/conf.py
URL:
http://l
vext01 added a comment.
Looks like this was backed out (reverted) yesterday.
I'm really interested in inserting DILabels from LLVM in my research project,
so I hope it can be recovered.
Repository:
rL LLVM
https://reviews.llvm.org/D45045
___
cf
Typz added a comment.
In https://reviews.llvm.org/D50078#1184159, @krasimir wrote:
> Could you clarify how each piece is supposed to be aligned in these examples?
> This is what makes me happy:
>
> // column limit V
> int a = condition1 ? result1
> : conditio2 ? result2
Author: hans
Date: Wed Aug 1 07:25:03 2018
New Revision: 338564
URL: http://llvm.org/viewvc/llvm-project?rev=338564&view=rev
Log:
Update version to 8.0.0svn
Modified:
libcxxabi/trunk/CMakeLists.txt
Modified: libcxxabi/trunk/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-project/libcxxabi/
a_sidorin added inline comments.
Comment at: lib/AST/ASTStructuralEquivalence.cpp:958
+ if (D1->isTemplated() != D2->isTemplated())
+return false;
I think we can move the changes for both RecordDecl and FunctionDecl into
`Finish()` and use `Decl::getDescr
aprantl added inline comments.
Comment at: test/SemaCXX/lambda-init-capture-vardefine.cpp:3
+// RUN: %clang_cc1 -std=c++17 -fsyntax-only -verify %s
+// expected-no-diagnostics
+
These kinds of tests that don't check for any output are a bit dangerous,
because t
Author: dmgreen
Date: Wed Aug 1 07:36:12 2018
New Revision: 338566
URL: http://llvm.org/viewvc/llvm-project?rev=338566&view=rev
Log:
[UnrollAndJam] Add unroll_and_jam pragma handling
This adds support for the unroll_and_jam pragma, to go with the recently
added unroll and jam pass. The name of t
This revision was automatically updated to reflect the committed changes.
Closed by commit rC338566: [UnrollAndJam] Add unroll_and_jam pragma handling
(authored by dmgreen, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D47267?vs=158219&id=158537#toc
Repository:
rC Clang
dmgreen added a comment.
Thanks.
Repository:
rC Clang
https://reviews.llvm.org/D47267
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
a_sidorin accepted this revision.
a_sidorin added a comment.
This revision is now accepted and ready to land.
LGTM. Thank you!
Repository:
rC Clang
https://reviews.llvm.org/D49792
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
balazske added inline comments.
Comment at: lib/AST/ASTStructuralEquivalence.cpp:958
+ if (D1->isTemplated() != D2->isTemplated())
+return false;
a_sidorin wrote:
> I think we can move the changes for both RecordDecl and FunctionDecl into
> `Finish()` and
ank added a comment.
Herald added a subscriber: acoomans.
Ping!
it would be awesome to get some help getting this merged since I do not have
merge rights
Repository:
rC Clang
https://reviews.llvm.org/D45719
___
cfe-commits mailing list
cfe-comm
HsiangKai added a comment.
In https://reviews.llvm.org/D45045#1184313, @vext01 wrote:
> Looks like this was backed out (reverted) yesterday.
>
> I'm really interested in inserting DILabels from LLVM in my research project,
> so I hope it can be recovered.
You could apply it locally. In most ca
avt77 updated this revision to Diff 158542.
avt77 added a comment.
efriedma, I removed redundant RAII objects but I still have the following:
1.0800 (271) _ZSt7declvalv (*)
1.0840 (273) _ZSt7declvalv (*)
1.0880 (269) _ZSt7declvalv (*)
1.1000 (276) _ZSt7declvalv (*)
1.1200 (282) _ZSt7declvalv
vext01 added a comment.
Hi HsiangKai,
Thanks for the response.
Indeed, I've just rolled back to just before the revert for now to experiment,
but I do hope this change hits LLVM-7.
Wishing you the best of luck with getting it merged!
Repository:
rL LLVM
https://reviews.llvm.org/D45045
Author: hans
Date: Wed Aug 1 08:22:27 2018
New Revision: 338570
URL: http://llvm.org/viewvc/llvm-project?rev=338570&view=rev
Log:
Bump version number to 8.0.0svn
Modified:
libunwind/trunk/CMakeLists.txt
Modified: libunwind/trunk/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-project/libun
Author: hans
Date: Wed Aug 1 08:23:47 2018
New Revision: 338571
URL: http://llvm.org/viewvc/llvm-project?rev=338571&view=rev
Log:
Drop 'svn' suffix from the version number.
Modified:
libcxx/branches/release_70/CMakeLists.txt
Modified: libcxx/branches/release_70/CMakeLists.txt
URL:
http://l
Author: hans
Date: Wed Aug 1 08:24:06 2018
New Revision: 338572
URL: http://llvm.org/viewvc/llvm-project?rev=338572&view=rev
Log:
Drop 'svn' suffix from the version number.
Modified:
libunwind/branches/release_70/CMakeLists.txt
Modified: libunwind/branches/release_70/CMakeLists.txt
URL:
ht
It's pretty easy to make this crash
$ cat memcpy.c
void foo() {
int a[1], b;
memcpy((char*)a, (const char*)&b, (unsigned long)4);
}
$ clang memcpy.c
llvm/include/llvm/ADT/SmallVector.h:178: const_reference
llvm::SmallVectorTemplateCommon::back() const [T = clang::APValue::LValue
PathEntry]: A
scott.linder updated this revision to Diff 158545.
scott.linder added a comment.
Address feedback; I hope I understood correctly what debug info to check for.
I don't see where in CreateMemTemp and friends EmitLifetimeStart gets called,
and I don't see any lifetime intrinsics in the IR even at -
hfinkel added a comment.
In https://reviews.llvm.org/D47849#1183996, @Hahnfeld wrote:
> In https://reviews.llvm.org/D47849#1183150, @hfinkel wrote:
>
> > Hrmm. Doesn't that make it so that whatever functions are implemented using
> > that inline assembly will not be callable from target code (or
Author: ibiryukov
Date: Wed Aug 1 08:32:56 2018
New Revision: 338578
URL: http://llvm.org/viewvc/llvm-project?rev=338578&view=rev
Log:
[Format] Fix for bug 35641
Summary:
Bug was caused due to comments at the start of scope. For a code like:
```
int func() { //
int b;
int c;
}
```
the commen
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338578: [Format] Fix for bug 35641 (authored by ibiryukov,
committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D43303?vs=134830&id=158546#toc
Repo
klimek added a comment.
Sorry that I lost track of that, but feel free to ping once / week -
unfortunately the patch doesn't apply cleanly, can you rebase?
Repository:
rC Clang
https://reviews.llvm.org/D45719
___
cfe-commits mailing list
cfe-com
Hahnfeld added a comment.
In https://reviews.llvm.org/D47849#1184367, @hfinkel wrote:
> The problem is that the inline assembly might actually be for the target,
> instead of the host, because we also have target preprocessor macros defined,
> and it's going to be hard to tell. I'm not sure tha
danilaml added inline comments.
Comment at: lib/Format/FormatToken.h:323
+ bool closesScopeAfterBlock() const {
+if(BlockKind == BK_Block)
+ return true;
Looks like all other `if`s in this file have space before `(`.
Repository:
rC Clang
https://re
theraven created this revision.
theraven added reviewers: rjmccall, DHowett-MSFT.
Herald added a subscriber: cfe-commits.
Introduces funclet-based unwinding for Objective-C and fixes an issue
where global blocks can't have their isa pointers initialised on
Windows.
After discussion with Dustin, t
hfinkel added a comment.
In https://reviews.llvm.org/D47849#1184388, @Hahnfeld wrote:
> In https://reviews.llvm.org/D47849#1184367, @hfinkel wrote:
>
> > The problem is that the inline assembly might actually be for the target,
> > instead of the host, because we also have target preprocessor ma
aheejin updated this revision to Diff 158555.
aheejin added a comment.
- wake -> notify
Repository:
rC Clang
https://reviews.llvm.org/D49396
Files:
include/clang/Basic/BuiltinsWebAssembly.def
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/builtins-wasm.c
Index: test/CodeGen/builtins-wasm.c
=
Typz created this revision.
Typz added reviewers: krasimir, djasper, klimek.
Herald added a subscriber: acoomans.
This patch allows defining external styles, which can be used exactly
like the embedded styles (llvm, google, mozilla...).
These styles are clang-format files installed either systemw
Rakete added a comment.
- There's a bug in your implementation:
struct X {
X &operator=(X &&);
};
static_assert(__is_trivially_relocatable(X)); // oops, fires!
`X` has a move constructor and a destructor, so it is trivially relocatable.
- Please run your code through clang-format.
svenvh added a comment.
You'll probably also need to update
`test/CodeGenOpenCL/cl20-device-side-enqueue.cl`; please verify with make/ninja
`check-clang`.
https://reviews.llvm.org/D50104
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
joerg added a comment.
There are two different considerations here:
(1) Create less target code
(2) Create less IR
If this code can significantly reduce the amount of IR, it can be useful in
general. That's why the existing memset logic is helpful.
Repository:
rL LLVM
https://reviews.llvm.o
Is there a particular reason why this commit didn't have a corresponding
test included?
Cheers,
Alex
On 1 August 2018 at 04:28, Simon Marchi via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: simark
> Date: Wed Aug 1 04:28:49 2018
> New Revision: 338518
>
> URL: http://llvm.org/viewv
On Tue, 31 Jul 2018, 23:06 Roman Lebedev via cfe-commits, <
cfe-commits@lists.llvm.org> wrote:
> Author: lebedevri
> Date: Tue Jul 31 23:06:16 2018
> New Revision: 338489
>
> URL: http://llvm.org/viewvc/llvm-project?rev=338489&view=rev
> Log:
> [AST] CastExpr: BasePathSize is not large enough.
>
>
1 - 100 of 195 matches
Mail list logo
