balazske added inline comments.
================ Comment at: lib/AST/ASTStructuralEquivalence.cpp:958 + if (D1->isTemplated() != D2->isTemplated()) + return false; ---------------- a_sidorin wrote: > I think we can move the changes for both RecordDecl and FunctionDecl into > `Finish()` and use `Decl::getDescribedTemplate()`. This will both simplify > the patch and give us the support for templated VarDecls and TypeAliasDecls > for free. What do you think? Yes it can be good to check with `getDescribedClassTemplate` in `Finish`. (Similarly, there can be more things that are common to check with all `Decl` or `NamedDecl` objects in `Finish`, specifically the name is checked. Or in some cases the name does not matter, but in others yes?) Repository: rC Clang https://reviews.llvm.org/D49223 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
