xbolva00 added a comment.
In https://reviews.llvm.org/D46822#1183007, @efriedma wrote:
> Please don't commit patches on behalf of someone else if the author hasn't
> specifically requested it. There might be some issue which the author forgot
> to note on the review.
Oh, ok.
Repository:
kpn updated this revision to Diff 158351.
kpn added a comment.
This includes the change to pass the annotation token when FENV_ACCESS is
turned off.
https://reviews.llvm.org/D49865
Files:
include/clang/AST/Expr.h
include/clang/Basic/LangOptions.h
include/clang/Basic/TokenKinds.def
incl
Author: hahnfeld
Date: Tue Jul 31 11:47:48 2018
New Revision: 338414
URL: http://llvm.org/viewvc/llvm-project?rev=338414&view=rev
Log:
Fix riscv32-toolchain.c with CLANG_DEFAULT_CXX_STDLIB
This configuration was (again) broken after r338385 because Clang
might be configured to always use libc++.
rnk added subscribers: hans, thakis, samsonov, rnk.
rnk added a comment.
+@thakis @hans
I think this broke Chromium's distributed Mac ASan build.
I personally found the error message confusing for the reasons that @samsonov
mentioned back in 2015. It's not that ASan wasn't supported on the plat
george.karpenkov added a comment.
@aaron.ballman @alexfh @shuaiwang Would it be possible to move that code into a
matcher, or into a something which could be used from Clang? We would also like
to use similar functionality, but can't include stuff from clang-tidy.
Repository:
rCTE Clang Tool
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:605
+ if (Pos && !Pos->isValid()) {
+// If I do not put a tag here, some invalidation tests will fail
+static CheckerProgramPointTag Tag("InvalidatedIteratorChecker",
george.karpenkov added a comment.
@rnk could you clarify how did it break the distributed asanified build? If the
slave compiler supports asan it should have this runtime, right?
Repository:
rL LLVM
https://reviews.llvm.org/D15225
___
cfe-commit
Hahnfeld added a comment.
In https://reviews.llvm.org/D47849#1124861, @hfinkel wrote:
> In https://reviews.llvm.org/D47849#1124638, @Hahnfeld wrote:
>
> > 2. Incidentally I ran into a closely related problem: I can't `#include
> > ` in translation units compiled for offloading, Clang complains
george.karpenkov added a comment.
@rnk Regarding the error message, would it be possible to compromise on
something like "sanitizer runtime not available"?
I understand that the exact error message would be very useful for you, but
it's just confusing for a user getting a toolchain with Xcode, s
efriedma added a comment.
I think there's something weird happening with your timers if they're showing
half a second spent parsing or instantiating std::declval: it doesn't have a
definition, anywhere (it's just a placeholder for template metaprogramming
tricks).
Comment at
Author: marshall
Date: Tue Jul 31 12:25:00 2018
New Revision: 338419
URL: http://llvm.org/viewvc/llvm-project?rev=338419&view=rev
Log:
import timespec and timespec_get into namespace std if we're under c++17 or
later AND the underlying C library has them. Fixes PR#38220, but doesn't
implement al
erik.pilkington added a comment.
Ping!
https://reviews.llvm.org/D46845
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: dergachev
Date: Tue Jul 31 12:26:34 2018
New Revision: 338420
URL: http://llvm.org/viewvc/llvm-project?rev=338420&view=rev
Log:
[analyzer] Don't try to simplify mixed Loc/NonLoc expressions.
This fix is similar to r337769 and addresses a regression caused by r337167.
When an operation be
NoQ closed this revision.
NoQ marked an inline comment as done.
NoQ added a comment.
Committed in https://reviews.llvm.org/rC338420 but i accidentally screwed the
revision link.
Repository:
rC Clang
https://reviews.llvm.org/D49749
___
cfe-commit
hfinkel added a comment.
In https://reviews.llvm.org/D47849#1183134, @Hahnfeld wrote:
> In https://reviews.llvm.org/D47849#1124861, @hfinkel wrote:
>
> > In https://reviews.llvm.org/D47849#1124638, @Hahnfeld wrote:
> >
> > > 2. Incidentally I ran into a closely related problem: I can't `#include
Author: dergachev
Date: Tue Jul 31 12:29:25 2018
New Revision: 338422
URL: http://llvm.org/viewvc/llvm-project?rev=338422&view=rev
Log:
[analyzer] Reuse some code in simplifySVal().
No functional change intended.
Differential Revision: https://reviews.llvm.org/D49826
Modified:
cfe/trunk/lib
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338422: [analyzer] Reuse some code in simplifySVal().
(authored by dergachev, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D49826?vs=157389&
aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.
Comment at: apple-accel.cpp:11
+__attribute__((section("1,__text_foo"))) void foo() {}
int main (int argc, char const *argv[]) { return argc; }
A co
Author: dergachev
Date: Tue Jul 31 12:39:37 2018
New Revision: 338425
URL: http://llvm.org/viewvc/llvm-project?rev=338425&view=rev
Log:
[CFG] [analyzer] Add stubs for constructor and message argument constructors.
CFG now correctly identifies construction context for temporaries constructed
for t
sfantao added inline comments.
Comment at: include/clang/Driver/Compilation.h:312
+ /// \param skipBundler - bool value set once by the driver.
+ void setSkipOffloadBundler(bool skipBundler);
+
gtbercea wrote:
> sfantao wrote:
> > gtbercea wrote:
> > > sfantao
NoQ added a comment.
Uhm, sry, https://reviews.llvm.org/rC338425 is not relevant, i screwed up the
revision link again.
Repository:
rL LLVM
https://reviews.llvm.org/D49826
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
NoQ closed this revision.
NoQ added a comment.
Committed in https://reviews.llvm.org/rC338425 but i accidentally screwed up
the revision link.
https://reviews.llvm.org/D48249
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
scott.linder created this revision.
scott.linder added reviewers: echristo, Anastasia, yaxunl.
Herald added subscribers: cfe-commits, JDevlieghere, aprantl.
Refactor collection of member debug info into helper functions and add separate
debug-info tests.
The reason for `-debug-info-kind=limited`
Author: dergachev
Date: Tue Jul 31 12:46:14 2018
New Revision: 338426
URL: http://llvm.org/viewvc/llvm-project?rev=338426&view=rev
Log:
[CFG] [analyzer] Add construction contexts for returning C++ objects in ObjC++.
Like any normal funciton, Objective-C message can return a C++ object
in Objectiv
This revision was automatically updated to reflect the committed changes.
Closed by commit rC338426: [CFG] [analyzer] Add construction contexts for
returning C++ objects in ObjC++. (authored by dergachev, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D48608
Files:
include/cl
This revision was automatically updated to reflect the committed changes.
Closed by commit rC338427: [OpenCL] Check for invalid kernel arguments in array
types (authored by AlexeySotkin, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D49723?vs=157688&id=158365#toc
Repository
Author: AlexeySotkin
Date: Tue Jul 31 12:47:19 2018
New Revision: 338427
URL: http://llvm.org/viewvc/llvm-project?rev=338427&view=rev
Log:
[OpenCL] Check for invalid kernel arguments in array types
Summary:
OpenCL specification forbids use of several types as kernel arguments.
This patch improves
ab accepted this revision.
ab added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Comment at: test/Driver/aarch64-cpus.c:9
// RUN: %clang -target aarch64_be -mlittle-endian -mcpu=generic -### -c %s
2>&1 | FileCheck -check-prefix=GENERIC %s
// GENE
shuaiwang added a comment.
In https://reviews.llvm.org/D45679#1183116, @george.karpenkov wrote:
> @aaron.ballman @alexfh @shuaiwang Would it be possible to move that code into
> a matcher, or into a something which could be used from Clang? We would also
> like to use similar functionality, but
simark updated this revision to Diff 158366.
simark added a comment.
Address Ilya's comment (add an indirection for initializationOptions).
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49833
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/Protocol.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338432: [OpenCL] Forbid size dependent types used as kernel
arguments (authored by AlexeySotkin, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D4
Author: rkovacs
Date: Tue Jul 31 13:27:11 2018
New Revision: 338433
URL: http://llvm.org/viewvc/llvm-project?rev=338433&view=rev
Log:
[analyzer] Move InnerPointerChecker out of alpha.
Differential Revision: https://reviews.llvm.org/D49058
Modified:
cfe/trunk/include/clang/StaticAnalyzer/Chec
JonasToth added a comment.
I think `clang/lib/Analysis` is a good place.
> I think it should in theory be possible, though I need some advice about
> where exactly is the best place in clang.
>
> Repository:
>
> rCTE Clang Tools Extra
>
> https://reviews.llvm.org/D45679
Repository:
rCTE
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338433: [analyzer] Move InnerPointerChecker out of alpha.
(authored by rkovacs, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D49058?vs=15798
bobsayshilol created this revision.
bobsayshilol added reviewers: mclow.lists, EricWF.
Herald added subscribers: cfe-commits, ldionne.
This allows a user replaced operator delete to modify or reuse returned memory
in the case where the size and capacity of a vector do not match upon
destruction
arphaman updated this revision to Diff 158376.
arphaman marked 3 inline comments as done.
arphaman added a comment.
Updated to address review comments.
https://reviews.llvm.org/D49758
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/GlobalCompilationDatabase.cpp
clangd/
arphaman added inline comments.
Comment at: test/clangd/did-change-configuration-params.test:43
+#
+# ERR: Updating file /clangd-test/foo.c with command [/clangd-test2] clang -c
foo.c -Wall -Werror
+# Don't reparse the second file:
ilya-biryukov wrote:
> Matchin
rnk added a comment.
In https://reviews.llvm.org/D15225#1183132, @george.karpenkov wrote:
> @rnk could you clarify how did it break the distributed asanified build? If
> the slave compiler supports asan it should have this runtime, right?
Most open source distributed build systems wrap only co
george.karpenkov added a comment.
> it's just that the runtime library didn't happen to exist on the system
> performing compilation
But then conceptually, the compiler toolchain on the system performing
compilation is not fully supporting asan, right?
It works for producing asanified object fi
george.karpenkov added a comment.
@rnk OK I see, we've accidentally posted comments nearly simultaneously.
Repository:
rL LLVM
https://reviews.llvm.org/D15225
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
aaron.ballman added subscribers: llvm-commits, cfe-commits.
aaron.ballman added a comment.
In https://reviews.llvm.org/D50055#1183277, @probinson wrote:
> I think you forgot to subscribe llvm-commits to this review?
Oh shoot, good catch! I've added llvm-commits and cfe-commits both. Thank you
aaron.ballman added a comment.
FYI: @asavonic, the email address you have associated with your commit id is
`AlexeySotkin@/etc/mailname` which is getting stuck in the moderation queue as
not being signed up to the mailing list. You may want to correct your svn
information as I am not certain wh
Author: AlexeySotkin
Date: Tue Jul 31 13:26:43 2018
New Revision: 338432
URL: http://llvm.org/viewvc/llvm-project?rev=338432&view=rev
Log:
[OpenCL] Forbid size dependent types used as kernel arguments
Summary:
Size_t, intptr_t, uintptr_t and ptrdiff_t cannot be used as kernel
arguments, according
Author: dergachev
Date: Tue Jul 31 13:45:53 2018
New Revision: 338436
URL: http://llvm.org/viewvc/llvm-project?rev=338436&view=rev
Log:
[CFG] [analyzer] Implement function argument construction contexts.
In r330377 and r338425 we have already identified what constitutes function
argument construc
george.karpenkov added a comment.
@rnk changing subjects: will you be at the LLVM social on Thursday? Could we
discuss it there?
Repository:
rL LLVM
https://reviews.llvm.org/D15225
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
probinson accepted this revision.
probinson added a comment.
This revision is now accepted and ready to land.
Using `%t` with suffixes instead of `%T` is the preferred idiom, glad you
worked that out.
The more elaborate test depends on a set of Posix-y calls, but that's fine. If
there are more
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338437: [DWARF] Do not create a .debug_ranges section when
no ranges are needed. (authored by wolfgangp, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50089?vs=158328&id=158378#toc
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, though I raised a few questions. If you want to handle them as part of
this patch, I'm happy to do another round of review. If you want to handle them
in a follow-up patch,
Author: rsmith
Date: Tue Jul 31 14:01:53 2018
New Revision: 338438
URL: http://llvm.org/viewvc/llvm-project?rev=338438&view=rev
Log:
[serialization] PR34728: Don't assume that only a suffix of template
parameters can have default arguments.
At least for function templates and class template parti
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: include/clang/AST/Expr.h:2791
+public:
+ using BasePathSizeTy = unsigned short;
+ static_assert(std::numeric_limits::max() >= 16384,
rnk added a comment.
In https://reviews.llvm.org/D15225#1183318, @george.karpenkov wrote:
> @rnk changing subjects: will you be at the LLVM social on Thursday? Could we
> discuss it there?
Yes, we can and should, but I'd like update chromium's copy of clang before
then.
Repository:
rL LLV
gtbercea added inline comments.
Comment at: include/clang/Driver/Compilation.h:312
+ /// \param skipBundler - bool value set once by the driver.
+ void setSkipOffloadBundler(bool skipBundler);
+
sfantao wrote:
> gtbercea wrote:
> > sfantao wrote:
> > > gtbercea
lebedev.ri updated this revision to Diff 158379.
lebedev.ri added a comment.
Drop pointless cast of zero.
Repository:
rC Clang
https://reviews.llvm.org/D50050
Files:
include/clang/AST/Expr.h
include/clang/AST/ExprCXX.h
include/clang/AST/ExprObjC.h
include/clang/AST/Stmt.h
lib/AST/E
shuaiwang created this revision.
Herald added a reviewer: george.karpenkov.
Herald added subscribers: cfe-commits, a.sidorin.
This yields better recall as ExprMutationAnalyzer is more accurate.
One common pattern this check is now able to catch is:
void foo(std::vector v) {
for (const auto
george.karpenkov added a comment.
@rnk OK it's fine with me to revert it now and then we see what can be done.
Repository:
rL LLVM
https://reviews.llvm.org/D15225
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
lebedev.ri added a comment.
It is great when the test cases are included :)
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50102
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
Author: dergachev
Date: Tue Jul 31 14:12:42 2018
New Revision: 338439
URL: http://llvm.org/viewvc/llvm-project?rev=338439&view=rev
Log:
[CFG] [analyzer] NFC: Enumerate construction context layer kinds.
This is a refactoring patch; no functional change intended.
The common part of ConstructionCon
Author: dergachev
Date: Tue Jul 31 14:17:40 2018
New Revision: 338441
URL: http://llvm.org/viewvc/llvm-project?rev=338441&view=rev
Log:
[analyzer] Fix eliding the same destructor twice due to buggy default arguments.
Because of incomplete support for CXXDefaultArgExpr, we cannot yet commit to
ass
This revision was automatically updated to reflect the committed changes.
Closed by commit rC338441: [analyzer] Fix eliding the same destructor twice due
to buggy default arguments. (authored by dergachev, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D49213
Files:
lib/Stati
jfb added a comment.
In https://reviews.llvm.org/D49771#1181008, @mehdi_amini wrote:
> I'm curious: isn't the kind of optimization we should expect LLVM to provide?
Maybe? It seems obvious to do here since we know we'll probably want to be
doing it, and I have another patch I'm working on whic
scott.linder created this revision.
scott.linder added reviewers: yaxunl, Anastasia, arsenm.
Herald added subscribers: cfe-commits, wdng.
Ensures the statically sized alloca is not converted to DYNAMIC_STACKALLOC
later because it is not in the entry block.
I believe it is valid to insert the all
NoQ added a comment.
In https://reviews.llvm.org/D49627#1176326, @baloghadamsoftware wrote:
> How much different is a correct `this`-argument construction context from
> real argument construction contexts?
It's identified in a similar manner; this patch pretty much already shows how
to ident
chandlerc added inline comments.
Comment at: docs/DeveloperPolicy.rst:395-408
+Commits with No Functional Change
+-
+
+It may be permissible to commit changes without prior review when the changes
+have no semantic impact on the code if the changes
ldionne created this revision.
ldionne added reviewers: EricWF, mclow.lists.
Herald added subscribers: cfe-commits, dexonsmith, christof.
The implementation of operator= for tuple currently diverges from the way
the Standard specifies them, which leads to subtle cases where the behavior
is not as
mclow.lists added a comment.
One more thing -
When you add a new header file, you need to update `include/module.modulemap`,
`test/libcxx/double_include.sh.cpp`, and `include/CMakeLists.txt`.
Take a look at https://reviews.llvm.org/D49338 for an example.
https://reviews.llvm.org/D46845
NoQ closed this revision.
NoQ added a comment.
Committed as https://reviews.llvm.org/rC338439 but Phabricator didn't pick it
up because i put a `.` after the phabricator link.
https://reviews.llvm.org/D49210
___
cfe-commits mailing list
cfe-commits
NoQ closed this revision.
NoQ added a comment.
Committed as https://reviews.llvm.org/rC338436 but Phabricator didn't pick it
up because i put a `.` after the phabricator link.
https://reviews.llvm.org/D48681
___
cfe-commits mailing list
cfe-commits
bviyer updated this revision to Diff 158391.
bviyer added a comment.
Fixed code as suggested by John McCall.
Repository:
rC Clang
https://reviews.llvm.org/D49952
Files:
lib/CodeGen/CGExprConstant.cpp
test/CodeGenCXX/empty-struct-init-list.cpp
Index: test/CodeGenCXX/empty-struct-init-li
yaxunl added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:3342
auto *AT = llvm::ArrayType::get(SizeTy, NumArgs - First);
+ // Always insert the alloca in the entry block so it remains static in
+ // the SelectionDAG.
+ BasicBlock *Begin = nullptr;
lebedev.ri added a comment.
In https://reviews.llvm.org/D50050#1183341, @rjmccall wrote:
> LGTM.
Thank you for the review.
I'll land in ~+9 hours or so, since i did not hear from @erichkeane back yet..
Repository:
rC Clang
https://reviews.llvm.org/D50050
Author: rnk
Date: Tue Jul 31 14:57:35 2018
New Revision: 338444
URL: http://llvm.org/viewvc/llvm-project?rev=338444&view=rev
Log:
Revert r337635 "[Driver] Sanitizer support based on runtime library presence"
This change causes issues with distributed build systems, which may only
have compiler bi
bviyer updated this revision to Diff 158392.
bviyer added a comment.
Forgot to pass the -emit-llvm to the test case.
https://reviews.llvm.org/D49952
Files:
lib/CodeGen/CGExprConstant.cpp
test/CodeGenCXX/empty-struct-init-list.cpp
Index: test/CodeGenCXX/empty-struct-init-list.cpp
=
erik.pilkington added a comment.
In https://reviews.llvm.org/D46845#1183435, @mclow.lists wrote:
> One more thing -
> When you add a new header file, you need to update
> `include/module.modulemap`, `test/libcxx/double_include.sh.cpp`, and
> `include/CMakeLists.txt`.
> Take a look at https:/
I'm probably missing something, from looking here:
FieldOffset = 0;
if (CGM.getLangOpts().OpenCL) {
FType = CGM.getContext().IntTy;
EltTys.push_back(CreateMemberType(Unit, FType, "__size", &FieldOffset));
EltTys.push_back(CreateMemberType(Unit, FType, "__align",
&FieldOffset));
}
aaronpuchert created this revision.
aaronpuchert added reviewers: aaron.ballman, delesley.
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D50110
Files:
lib/Analysis/ThreadSafety.cpp
test/SemaCXX/warn-thread-safety-analysis.cpp
Index: test/SemaCXX/wa
pirama created this revision.
pirama added a reviewer: rsmith.
Android's memory allocators also guarantee 8-byte alignment for 32-bit
architectures and 16-byte alignment for 64-bit.
Repository:
rC Clang
https://reviews.llvm.org/D50112
Files:
lib/Basic/TargetInfo.cpp
test/Preprocessor/ini
lichray updated this revision to Diff 158404.
lichray added a comment.
Dropping a lambda
Repository:
rCXX libc++
https://reviews.llvm.org/D41458
Files:
include/CMakeLists.txt
include/charconv
include/module.modulemap
src/charconv.cpp
test/libcxx/double_include.sh.cpp
test/std/uti
leonardchan updated this revision to Diff 158407.
leonardchan marked 6 inline comments as done.
leonardchan added a comment.
- Added tests for checking that `noderef` can only be used for C style pointers
and arrays (not usable for references or ObjC pointers)
- Added warnings for dereferencing a
shuaiwang updated this revision to Diff 158408.
shuaiwang added a comment.
Add test case
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50102
Files:
clang-tidy/performance/UnnecessaryValueParamCheck.cpp
test/clang-tidy/performance-unnecessary-value-param.cpp
Index: test/cl
leonardchan added a comment.
> You shouldn't be adding your own `ExpressionEvaluationContextRecord`s. What I
> was suggesting is that you store a list of pending `noderef` expressions on
> the record, and diagnose them when the record is popped (if they've not been
> removed since).
This is
mehdi_amini added a comment.
In https://reviews.llvm.org/D49771#1183380, @jfb wrote:
> In https://reviews.llvm.org/D49771#1181008, @mehdi_amini wrote:
>
> > I'm curious: isn't the kind of optimization we should expect LLVM to
> > provide?
>
>
> Maybe? It seems obvious to do here since we know we
What might be missing is the impl of CreateMemberType:
llvm::DIType *CGDebugInfo::CreateMemberType(llvm::DIFile *Unit, QualType
FType,
StringRef Name, uint64_t
*Offset) {
llvm::DIType *FieldTy = CGDebugInfo::getOrCreateType(FType, Unit);
uint64_t
jfb added a comment.
In https://reviews.llvm.org/D49771#1183562, @mehdi_amini wrote:
> In https://reviews.llvm.org/D49771#1183380, @jfb wrote:
>
> > In https://reviews.llvm.org/D49771#1181008, @mehdi_amini wrote:
> >
> > > I'm curious: isn't the kind of optimization we should expect LLVM to
> >
mclow.lists accepted this revision.
mclow.lists added a comment.
In https://reviews.llvm.org/D46845#1183462, @erik.pilkington wrote:
> In https://reviews.llvm.org/D46845#1183435, @mclow.lists wrote:
>
> > One more thing -
> > When you add a new header file, you need to update
> > `include/modu
leonardchan added a comment.
> Your current counter-based approach doesn't work very well in the case where
> we switch to another context while processing an expression (for example,
> during template instantiation): you'll defer all the diagnostics for the
> inner construct until the outer co
On Tue, Jul 31, 2018 at 3:59 PM wrote:
> What might be missing is the impl of CreateMemberType:
>
> llvm::DIType *CGDebugInfo::CreateMemberType(llvm::DIFile *Unit, QualType
> FType,
> StringRef Name, uint64_t
> *Offset) {
>llvm::DIType *FieldTy = C
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
Repository:
rCXX libc++
https://reviews.llvm.org/D41458
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
rsmith added inline comments.
Comment at: lib/Serialization/ASTReaderDecl.cpp:3448-3456
if (!inheritDefaultTemplateArgument(Context, FTTP, ToParam))
break;
} else if (auto *FNTTP = dyn_cast(FromParam)) {
if (!inheritDefaultTemplateArgument(Context, FNT
Author: marshall
Date: Tue Jul 31 16:29:06 2018
New Revision: 338454
URL: http://llvm.org/viewvc/llvm-project?rev=338454&view=rev
Log:
Test for the presence of a bunch of new macros for c++17. These macros come
from C11. Part of P0063
Modified:
libcxx/trunk/include/cfloat
libcxx/trunk/in
Author: rsmith
Date: Tue Jul 31 16:35:09 2018
New Revision: 338455
URL: http://llvm.org/viewvc/llvm-project?rev=338455&view=rev
Log:
[constexpr] Support for constant evaluation of __builtin_memcpy and
__builtin_memmove (in non-type-punning cases).
This is intended to permit libc++ to make std::co
dschuff added inline comments.
Comment at: include/clang/Basic/BuiltinsWebAssembly.def:38
+// Atomic wait and wake.
+BUILTIN(__builtin_wasm_atomic_wait_i32, "Uii*iLLi", "n")
+BUILTIN(__builtin_wasm_atomic_wait_i64, "UiLLi*LLiLLi", "n")
So this means that the sign
This revision was automatically updated to reflect the committed changes.
mattd marked an inline comment as done.
Closed by commit rCRT338456: [compiler-rt] Add a routine to specify the mode
used when creating profile dirs. (authored by mattd, committed by ).
Herald added subscribers: Sanitizers,
Author: marshall
Date: Tue Jul 31 16:39:12 2018
New Revision: 338457
URL: http://llvm.org/viewvc/llvm-project?rev=338457&view=rev
Log:
Final bit of P0063 - make sure that aligned_alloc is available when the
underlying C library supports it
Modified:
libcxx/trunk/test/std/depr/depr.c.headers/
vsapsai created this revision.
vsapsai added reviewers: bruno, benlangmuir.
Herald added a subscriber: dexonsmith.
First and subsequent iteration steps are similar, capture this similarity.
https://reviews.llvm.org/D50118
Files:
clang/lib/Basic/VirtualFileSystem.cpp
Index: clang/lib/Basic/V
mehdi_amini added a comment.
> I'm worried, however, about generating a bunch more code than needed from
> clang in the hopes that the compiler will clean it up later.
Isn't a strong design component of clang/LLVM? Clang does not try to generate
"smart" code and leave it up to LLVM to clean it
leonardchan updated this revision to Diff 158423.
leonardchan added a comment.
- Moved the counter and set into `ExpressionEvaluationContextRecord`
Repository:
rC Clang
https://reviews.llvm.org/D49511
Files:
include/clang/AST/Type.h
include/clang/Basic/Attr.td
include/clang/Basic/AttrD
0x8000- updated this revision to Diff 158425.
0x8000- added a comment.
Add tests to show that we can detect, report and ignore floating point numbers
represented using hexadecimal notation
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49114
Files:
clang-tidy/cppcore
Quuxplusone created this revision.
Quuxplusone added a reviewer: rsmith.
Quuxplusone added a project: clang.
Herald added a subscriber: cfe-commits.
This is the compiler half of C++ proposal 1144 "Object relocation in terms of
move plus destroy," as seen on https://godbolt.org/g/zUUAVW and
https
juliehockett added inline comments.
Comment at: clang-tools-extra/clang-doc/Representation.h:246
+
+ std::vector ChildNamespaces;
+ std::vector ChildRecords;
ioeric wrote:
> Would a record ever have namespace children? Maybe we should assert that this
> doesn'
Author: rsmith
Date: Tue Jul 31 17:33:25 2018
New Revision: 338464
URL: http://llvm.org/viewvc/llvm-project?rev=338464&view=rev
Log:
[P0936R0] add [[clang::lifetimebound]] attribute
This patch adds support for a new attribute, [[clang::lifetimebound]], that
indicates that the lifetime of a functi
101 - 200 of 236 matches
Mail list logo
