arphaman added inline comments.
================
Comment at: test/clangd/did-change-configuration-params.test:43
+#
+# ERR: Updating file /clangd-test/foo.c with command [/clangd-test2] clang -c
foo.c -Wall -Werror
+# Don't reparse the second file:
----------------
ilya-biryukov wrote:
> Matching the stderr output seems fragile, but that's the only way to inspect
> the actual compile command that's used, so that's probably fine here.
> However, the paths on windows will probably differ (notice the regexp matches
> for file uris), so we might need to do the regexp match here as well,
> e.g.`Updating file {{.*}}foo.c with command ...` to keep the Windows
> buildbots happy.
Good point.
I also realized that I have to make this a UNIX-specific test as the
compilation database updates require a path, which will obviously be different
on Windows.
https://reviews.llvm.org/D49758
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
