mgehre added a comment.
Does it also work with lambdas (being implicitly auto) that return pointers? A
test case for that would be nice.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43745
___
cfe-commits mailing list
cfe-commits@
ldionne added a comment.
Just to make sure I understand properly: this means we will use newlib's
implementation of `iswcntrl_l` & friends instead of our own emulation (which is
an ODR violation currently going unnoticed)? And this is OK because newlib
provides `iswcntrl_l` & friends starting a
ABataev added a comment.
Eric accepted the patch offline.
Repository:
rC Clang
https://reviews.llvm.org/D49148
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
scott.linder created this revision.
scott.linder added reviewers: Anastasia, echristo.
Herald added subscribers: cfe-commits, JDevlieghere, aprantl, yaxunl.
OpenCL block literal structs have different fields which are now correctly
identified in the debug info.
Repository:
rC Clang
https://r
jyknight accepted this revision.
jyknight added a comment.
This revision is now accepted and ready to land.
Typo in commit message? They were added to 2.5, not 2.4 (the code is right,
just the comment is wrong).
Repository:
rCXX libc++
https://reviews.llvm.org/D49927
_
rupprecht added a comment.
In https://reviews.llvm.org/D49927#1178659, @ldionne wrote:
> Just to make sure I understand properly: this means we will use newlib's
> implementation of `iswcntrl_l` & friends instead of our own emulation (which
> is an ODR violation currently going unnoticed)? And
yaxunl created this revision.
yaxunl added reviewers: tra, rjmccall.
CUDA 8.0 E.3.9.4 says: Within the body of a __device__ or __global__
function, only __shared__ variables or variables without any device
memory qualifiers may be declared with static storage class.
It is unclear how a function-s
yaxunl updated this revision to Diff 157740.
yaxunl edited the summary of this revision.
yaxunl added a comment.
update diagnostic message.
https://reviews.llvm.org/D49931
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/CodeGen/CodeGenModule.cpp
lib/Sema/SemaDecl.cpp
test/CodeGenC
Author: abataev
Date: Fri Jul 27 12:45:14 2018
New Revision: 338155
URL: http://llvm.org/viewvc/llvm-project?rev=338155&view=rev
Log:
[DEBUGINFO] Disable unsupported debug info options for NVPTX target.
Summary:
Some targets support only default set of the debug options and do not
support additio
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rC338155: [DEBUGINFO] Disable unsupported debug info options
for NVPTX target. (authored by ABataev, committed by ).
Change
ldionne added a comment.
It would be nice if all the TMP required to determine whether to call
`__move_construct_forward(..., true_type)` or `__move_construct_forward(...,
false_type)` was done in `__move_construct_forward` itself (or a helper). This
way, callers wouldn't have to do it themselv
Author: rupprecht
Date: Fri Jul 27 13:02:58 2018
New Revision: 338157
URL: http://llvm.org/viewvc/llvm-project?rev=338157&view=rev
Log:
[libc++] Exclude posix_l/strtonum fallback inclusion for newlib > 2.4
Summary:
[libc++] Exclude posix_l/strtonum fallback inclusion for newlib > 2.4
r338122 cha
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338157: [libc++] Exclude posix_l/strtonum fallback inclusion
for newlib > 2.4 (authored by rupprecht, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.o
tra added a comment.
> This patch also allows function-scope static const variable without device
> memory qualifier and emits it as a global variable in constant address space.
What does NVCC do with local static const variables?
https://reviews.llvm.org/D49931
Author: abataev
Date: Fri Jul 27 13:16:44 2018
New Revision: 338158
URL: http://llvm.org/viewvc/llvm-project?rev=338158&view=rev
Log:
[DEBUG_INFO] Fix tests, NFC.
Modified:
cfe/trunk/test/Driver/cuda-unsupported-debug-options.cu
cfe/trunk/test/Driver/openmp-unsupported-debug-options.c
Mo
timshen added inline comments.
Comment at: libcxx/include/experimental/simd:726
+#if defined(_LIBCPP_COMPILER_CLANG)
+#define _SPECIALIZE_VEC_EXT(_TYPE, _NUM_ELEMENT)
\
+ template <>
timshen updated this revision to Diff 157751.
timshen marked 6 inline comments as done.
timshen added a comment.
Update based on the comments.
https://reviews.llvm.org/D41376
Files:
libcxx/include/__config
libcxx/include/experimental/__config
libcxx/include/experimental/simd
libcxx/test
timshen added a comment.
I'm not going to rebase all the succeeding patches immediately onto this one,
as it is painful and spamming emails. Rather, I'll only rebase the next patch
in the line. So if you review more than one patch ahead (as you already did),
you may see some stale patch context
timshen added inline comments.
Comment at: libcxx/include/experimental/simd:1341
// [simd.class]
// TODO: implement simd
template
timshen wrote:
> mclow.lists wrote:
> > Is this TODO still necessary?
> I think so, as some operations are still not implemented,
Quuxplusone marked an inline comment as done.
Quuxplusone added inline comments.
Comment at: include/vector:296
+_LIBCPP_INLINE_VISIBILITY
+inline void
+__copy_construct_forward(_Alloc& __a, _Iter __begin1, _Iter __end1,
ldionne wrote:
> Do you really need `inlin
rsmith added a comment.
Thanks, I like this approach a lot more.
Comment at: include/clang/Parse/Parser.h:1658
+CastExpr,// Also allow '(' type-name ')'
+FoldExpr // Also allow fold-expression
};
This should be reordered up nearer t
ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: include/vector:296
+_LIBCPP_INLINE_VISIBILITY
+inline void
+__copy_construct_forward(_Alloc& __a, _Iter __begin1, _Iter __end1,
Quuxpluson
Quuxplusone added a comment.
@ldionne: I don't know if your "LGTM" is necessarily sufficient to commit this
or not; but either way, I don't have commit privs, so could I ask you (or
someone else) to commit this on my behalf? Thanks!
Repository:
rCXX libc++
https://reviews.llvm.org/D49317
ldionne added a comment.
In https://reviews.llvm.org/D49317#1178767, @Quuxplusone wrote:
> @ldionne: I don't know if your "LGTM" is necessarily sufficient to commit
> this or not; but either way, I don't have commit privs, so could I ask you
> (or someone else) to commit this on my behalf? Than
yaxunl added a comment.
In https://reviews.llvm.org/D49931#1178720, @tra wrote:
> > This patch also allows function-scope static const variable without device
> > memory qualifier and emits it as a global variable in constant address
> > space.
>
> What does NVCC do with local static const vari
greened added a comment.
In https://reviews.llvm.org/D49899#1178545, @ruiu wrote:
> > The Fuchsia driver relies on lld so invoke clang with -fuse-ld=lld. This
> > gets the test passing when the clang default linker is something other than
> > lld.
>
> Does it work if lld is not installed at all
Rakete updated this revision to Diff 157759.
Rakete added a comment.
Addressed review comments :)
Repository:
rC Clang
https://reviews.llvm.org/D49848
Files:
include/clang/Parse/Parser.h
lib/Parse/ParseExpr.cpp
test/Parser/cxx1z-fold-expressions.cpp
Index: test/Parser/cxx1z-fo
jfb updated this revision to Diff 157761.
jfb added a comment.
- Add constant AS pointer test.
Repository:
rC Clang
https://reviews.llvm.org/D47618
Files:
lib/Sema/SemaChecking.cpp
test/Sema/atomic-ops.c
test/SemaOpenCL/atomic-ops.cl
Index: test/SemaOpenCL/atomic-ops.cl
=
jfb marked an inline comment as done.
jfb added a comment.
Give the comments, I think this is ready to commit.
Repository:
rC Clang
https://reviews.llvm.org/D47618
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
jvesely abandoned this revision.
jvesely added a comment.
In https://reviews.llvm.org/D49650#1177323, @jvesely wrote:
> In https://reviews.llvm.org/D49650#1176336, @arsenm wrote:
>
> > In https://reviews.llvm.org/D49650#1175461, @jvesely wrote:
> >
> > > In https://reviews.llvm.org/D49650#1175438
arphaman updated this revision to Diff 157762.
arphaman marked 2 inline comments as done.
arphaman added a comment.
Updated patch to address review comments:
- The compilation database updated are used only when
'-in-memory-compile-commands' flag is used.
- It's now possible to set the working d
Author: epilk
Date: Fri Jul 27 14:23:48 2018
New Revision: 338165
URL: http://llvm.org/viewvc/llvm-project?rev=338165&view=rev
Log:
[Sema] Use a TreeTransform to extract deduction guide parameter types
Previously, we just canonicalized the type, but this lead to crashes with
parameter types that
This revision was automatically updated to reflect the committed changes.
Closed by commit rC338165: [Sema] Use a TreeTransform to extract deduction
guide parameter types (authored by epilk, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D49439?vs=157309&id=157767#toc
Reposi
tra added a comment.
Looks OK overall except for the huge `if` below.
Comment at: lib/Sema/SemaDecl.cpp:11923-11930
+ if (getLangOpts().CUDA &&
+ !(VD->hasAttr() ||
+(VD->getType().isConstQualified() &&
+ !VD->hasAttr() &&
+ !VD
yaxunl marked an inline comment as done.
yaxunl added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:11923-11930
+ if (getLangOpts().CUDA &&
+ !(VD->hasAttr() ||
+(VD->getType().isConstQualified() &&
+ !VD->hasAttr() &&
+ !VD-
Author: rakete
Date: Fri Jul 27 14:55:12 2018
New Revision: 338170
URL: http://llvm.org/viewvc/llvm-project?rev=338170&view=rev
Log:
Parse a possible trailing postfix expression suffix after a fold expression
Summary:
This patch allows the parsing of a postfix expression involving a fold
exp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338170: Parse a possible trailing postfix expression suffix
after a fold expression (authored by Rakete, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews
yaxunl updated this revision to Diff 157778.
yaxunl marked an inline comment as done.
yaxunl added a comment.
Revised by Artem's comments.
https://reviews.llvm.org/D49931
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/CodeGen/CodeGenModule.cpp
lib/Sema/SemaDecl.cpp
test/CodeGenCU
az created this revision.
az added a reviewer: SjoerdMeijer.
Herald added a reviewer: javed.absar.
Herald added subscribers: cfe-commits, chrib, kristof.beyls.
This patch adds the fp16 scalar intrinsic for ARM as described in the ARM ACLE
document. Only the frontend work is done here and some wor
vsapsai accepted this revision.
vsapsai added a comment.
This revision is now accepted and ready to land.
Looks good to me. Any further improvements are up to you.
Repository:
rC Clang
https://reviews.llvm.org/D49119
___
cfe-commits mailing list
NoQ updated this revision to Diff 157789.
NoQ added a comment.
A better `ConstructedObjectKey::print()`.
https://reviews.llvm.org/D49210
Files:
include/clang/Analysis/ConstructionContext.h
include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h
lib/Analysis/CFG.cpp
lib/Analysis/Con
leonardchan created this revision.
leonardchan added reviewers: phosek, mcgrathr, jakehehrlich, ebevhan, rjmccall.
leonardchan added a project: clang.
Herald added a subscriber: mgorny.
- Print negative numbers correctly
- Handle APInts of different sizes
- Add formal unit tests for FixedPointValu
ahatanak added a comment.
Thanks, I'll update the patch and commit it today.
In https://reviews.llvm.org/D49119#1176139, @vsapsai wrote:
> In https://reviews.llvm.org/D49119#1176047, @ahatanak wrote:
>
> > In https://reviews.llvm.org/D49119#1164285, @vsapsai wrote:
> >
> > > Also I had a few ide
mcgrathr added a comment.
I think this wants to be a hard error rather than a warning. Though since we
use -Werror anyway if others feel strongly contrary I won't object.
Repository:
rC Clang
https://reviews.llvm.org/D49511
___
cfe-commits mail
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D46013
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rC Clang
https://reviews.llvm.org/D49466
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
rnkovacs updated this revision to Diff 157809.
rnkovacs marked an inline comment as done.
https://reviews.llvm.org/D49656
Files:
lib/StaticAnalyzer/Checkers/InnerPointerChecker.cpp
lib/StaticAnalyzer/Checkers/MallocChecker.cpp
test/Analysis/inner-pointer.cpp
Index: test/Analysis/inner-poin
rnkovacs added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/InnerPointerChecker.cpp:192
- if (Call.isCalled(CStrFn) || Call.isCalled(DataFn)) {
-SVal RawPtr = Call.getReturnValue();
-if (SymbolRef Sym = RawPtr.getAsSymbol(/*IncludeBaseRegions=*/true)) {
-
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/InnerPointerChecker.cpp:192
- if (Call.isCalled(CStrFn) || Call.isCalled(DataFn)) {
-SVal RawPtr = Call.getReturnValue();
-if (SymbolRef Sym = RawPtr.getAsSymbol(/*IncludeBaseRegions=*/true)) {
- /
ahatanak updated this revision to Diff 157815.
ahatanak added a comment.
- Produce a note that tells users where the class extension conforming to the
protocol containing the non-escaping method is declared.
- Add a class method that has the same name as the instance method and check
that no spu
arphaman requested changes to this revision.
arphaman added a comment.
FYI, this patch can't be applied because of the broken file paths (some diffs
include /clangd prefix, some don't, while the test diffs are missing '/test').
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D495
efriedma added inline comments.
Comment at: lib/Sema/SemaLambda.cpp:1447
+getFrontendFunctionTimeCtx()->startFrontendTimer(
+{LSI.CallOperator, 0.0});
+ }
This seems sort of late? You're starting the timer after the body has already
been parsed.
Hello Erik,
This commit broke build step on one of our builders:
http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/11300
. . .
FAILED: tools/clang/lib/Sema/CMakeFiles/clangSema.dir/SemaTemplate.cpp.obj
C:\PROGRA~2\MICROS~1.0\VC\bin\amd64\cl.exe /nologo /TP -DEXPENSI
Author: maskray
Date: Fri Jul 27 17:48:05 2018
New Revision: 338183
URL: http://llvm.org/viewvc/llvm-project?rev=338183&view=rev
Log:
[CFG] Remove duplicate function/class names at the beginning of comments
Some functions/classes have renamed while the comments still use the old names.
Delete th
bviyer created this revision.
bviyer added reviewers: arphaman, dexonsmith, ahatanak, rjmccall.
While emitting Array Constant, if the destination type is null-pointer, it will
cause an assert. This patch will check if the destination type is null, and if
so then it will just return nullptr as th
Author: epilk
Date: Fri Jul 27 18:29:31 2018
New Revision: 338186
URL: http://llvm.org/viewvc/llvm-project?rev=338186&view=rev
Log:
Compile SemaTemplate.cpp with /bigobj on MSVC
This should fix some bot failures introduced by r338165.
Modified:
cfe/trunk/lib/Sema/CMakeLists.txt
Modified: cf
This should be fixed by r338186. I'll keep an eye on this bot to make
sure that this is the case.
Thanks!
Erik
On 2018-07-27 5:46 PM, Galina Kistanova wrote:
C:\ps4-buildslave2\llvm-clang-x86_64-expensive-checks-win\llvm\tools\clang\lib\Sema\SemaTemplate.cpp
: fatal error C1128: number of secti
xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D49656
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
rjmccall added a comment.
I think the right fix here is to ensure that `DestType` is non-null at a higher
level. Older branches of the compiler seem to be able to correctly emit this,
probably because the initializer generated for this field ends up having type
`a[0]`. Maybe we've just done s
Author: george.karpenkov
Date: Fri Jul 27 19:16:13 2018
New Revision: 338187
URL: http://llvm.org/viewvc/llvm-project?rev=338187&view=rev
Log:
[AST] Add a convenient getter from QualType to RecordDecl
Differential Revision: https://reviews.llvm.org/D49951
Modified:
cfe/trunk/include/clang/AS
Okay, the bot can now compile this file, but it looks like somebody else
broke it again in the meantime...
FAIL: LLVM :: CodeGen/AArch64/arm64-opt-remarks-lazy-bfi.ll (17518 of
39837) TEST 'LLVM ::
CodeGen/AArch64/arm64-opt-remarks-lazy-bfi.ll' FAILED
***
erik.pilkington added inline comments.
Comment at: test/CodeGenCXX/empty-struct-init-list.cpp:1-4
+// RUN: %clang_cc1 -std=c++11 %s
+// RUN: %clang_cc1 -std=c++14 %s
+// RUN: %clang_cc1 -std=c++17 %s
+// expected-no-diagnostics
You should add -emit-llvm, or el
Author: yaxunl
Date: Fri Jul 27 20:05:25 2018
New Revision: 338188
URL: http://llvm.org/viewvc/llvm-project?rev=338188&view=rev
Log:
[CUDA][HIP] Allow function-scope static const variable
CUDA 8.0 E.3.9.4 says: Within the body of a __device__ or __global__
function, only __shared__ variables or v
This revision was automatically updated to reflect the committed changes.
Closed by commit rC338188: [CUDA][HIP] Allow function-scope static const
variable (authored by yaxunl, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D49931
Files:
include/clang/Basic/DiagnosticSemaKind
yaxunl accepted this revision.
yaxunl added a comment.
LGTM. Thanks.
Repository:
rC Clang
https://reviews.llvm.org/D49723
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mattd created this revision.
mattd added a reviewer: void.
Herald added a subscriber: dberris.
This patch introduces `llvm_profile_set_dir_mode` and
`llvm_profile_get_dir_mode` to
the compiler-rt profile API.
Originally, profile data was placed into a directory that was created with a
hard-code
yaxunl added a comment.
LGTM. Thanks.
Repository:
rC Clang
https://reviews.llvm.org/D49930
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rC338189: [Sema][ObjC] Warn when a method declared in a
protocol takes a (authored by ahatanak, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D49119
Files:
include/clang/Basic/Diagnost
Author: epilk
Date: Fri Jul 27 21:06:30 2018
New Revision: 338190
URL: http://llvm.org/viewvc/llvm-project?rev=338190&view=rev
Log:
[demangler] Fix an oss-fuzz bug from r338138
Stack overflow on invalid. While collapsing references, we were skipping over a
cycle check in ForwardTemplateReference
Author: ahatanak
Date: Fri Jul 27 21:06:13 2018
New Revision: 338189
URL: http://llvm.org/viewvc/llvm-project?rev=338189&view=rev
Log:
[Sema][ObjC] Warn when a method declared in a protocol takes a
non-escaping parameter but the implementation's method takes an escaping
parameter.
rdar://problem/
Thank you Erik!
Thanks
Galina
On Fri, Jul 27, 2018 at 7:35 PM, Erik Pilkington
wrote:
> Okay, the bot can now compile this file, but it looks like somebody else
> broke it again in the meantime...
>
>
> FAIL: LLVM :: CodeGen/AArch64/arm64-opt-remarks-lazy-bfi.ll (17518 of 39837)
>
mprobst added inline comments.
Comment at: lib/Format/Format.cpp:814
+// by qualified identifiers.
+GoogleStyle.CommentPragmas = "(taze:|^/[
\t]*<|@see|@exports|@module|@mods)";
GoogleStyle.MaxEmptyLinesToKeep = 3;
krasimir wrote:
> mprobst wrote:
>
101 - 172 of 172 matches
Mail list logo
