hokein created this revision.
hokein added a reviewer: sammccall.
Herald added subscribers: arphaman, jkorous, MaskRay, ioeric, ilya-biryukov.
This is the first step of implementing Xrefs in clangd:
- add index interfaces, and related data structures.
- implement a naive in-memory index for symbo
ikudrin added a comment.
Did you consider dividing the patch into two separate changes to solve the two
described issues independently?
Repository:
rC Clang
https://reviews.llvm.org/D49589
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ilya-biryukov accepted this revision.
ilya-biryukov added a reviewer: ilya-biryukov.
ilya-biryukov added a comment.
Herald added a subscriber: arphaman.
LGTM
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49253
___
cfe-commits maili
ilya-biryukov added a comment.
Herald added a subscriber: arphaman.
Thanks for putting up this change! It can be really annoying that clangd does
not pick up the compile commands that got updated.
A few things of the top of my head on why we might want to punt on using the
LSP watches:
- File
ilya-biryukov added a subscriber: simark.
ilya-biryukov added a comment.
Herald added a subscriber: arphaman.
A recent change (https://reviews.llvm.org/D49267) is another indication that
caching might be doing more wrong than good. I assume the caching does not give
us much performance-wise, we
ilya-biryukov added a comment.
JSON is a subset of YAML, do we really need both outputs? I've noticed the
schema for the output is actually different between YAML and JSON, wouldn't
that be confusing?
> Should be compatible with the current index format accepted by clangd
Do we really want th
sammccall added a comment.
In https://reviews.llvm.org/D48071#1171289, @ilya-biryukov wrote:
> A recent change (https://reviews.llvm.org/D49267) is another indication that
> caching might be doing more wrong than good. I assume the caching does not
> give us much performance-wise, we only reque
kosarev added a comment.
Ping.
https://reviews.llvm.org/D49375
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kosarev added a comment.
Ping.
https://reviews.llvm.org/D49376
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kbobyrev updated this revision to Diff 156725.
kbobyrev added a comment.
Herald added a subscriber: mgrang.
- Implemented convenient dumping via `llvm::raw_ostream
&operator<<(llvm::raw_ostream &OS, QueryIterator &Iterator)`, which dumps
iterator tree in human-readable format, e.g. `(&& [1, 2, 3
kosarev added a comment.
Ping.
https://reviews.llvm.org/D49075
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kosarev added a comment.
Ping.
https://reviews.llvm.org/D48829
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: include/clang/Basic/arm_neon.td:1419
// Vector rounding
- def FRINTZH : SInst<"vrnd", "dd", "hQh">;
- def FRINTNH : SInst<"vrndn"
SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: include/clang/Basic/arm_neon.td:1466
def VMINH : SInst<"vmin", "ddd", "hQh">;
- def FMAXNMH : SInst<"vmaxnm", "ddd", "hQh">;
-
sepavloff added a comment.
In https://reviews.llvm.org/D49589#1171279, @ikudrin wrote:
> Did you consider dividing the patch into two separate changes to solve the
> two described issues independently?
The both tow issues have the same cause: the check is genereated too late. Now
it is genera
SjoerdMeijer added a comment.
Now that they are conditionally defined, do we need negative tests (in
test/Sema/arm-no-fp16.c?) to check that they are not available when fp16 is not
enabled?
https://reviews.llvm.org/D49075
___
cfe-commits mailing l
SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D48829
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
On 2018-07-19 20:55, Hal Finkel wrote:
On 07/19/2018 09:01 AM, Jonas Hahnfeld wrote:
On 2018-07-19 15:43, Hal Finkel wrote:
On 07/16/2018 01:19 PM, Jonas Hahnfeld wrote:
[ Moving discussion from https://reviews.llvm.org/D49386 to the
relevant comment on cfe-commits, CC'ing Hal who commented on
djasper added a comment.
Could you explain what problem this is fixing?
https://reviews.llvm.org/D49580
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sammccall added a comment.
A few more comments about the bits I understand, but waiting mostly on the
documentation.
Comment at: clang-tools-extra/clangd/index/dex/QueryIterator.cpp:155
+ llvm::raw_ostream &dump(llvm::raw_ostream &OS) const override {
+OS << "(&& ";
+
Author: baloghadamsoftware
Date: Mon Jul 23 03:50:20 2018
New Revision: 337678
URL: http://llvm.org/viewvc/llvm-project?rev=337678&view=rev
Log:
[Analyzer] Quick Fix for exponential execution time when simpilifying complex
additive expressions
Patch https://reviews.llvm.org/rC329780 not only rea
sammccall added a comment.
Mostly LG.
I think we can simplify in a couple of places, and you should decide if this
patch is *implementing* the new index operation or not. (Currently it
implements it for 1/3 implementations, which doesn't seem that useful).
Comment at: clangd
This revision was automatically updated to reflect the committed changes.
Closed by commit rL337678: [Analyzer] Quick Fix for exponential execution time
when simpilifying complex… (authored by baloghadamsoftware, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
Author: baloghadamsoftware
Date: Mon Jul 23 03:53:02 2018
New Revision: 337679
URL: http://llvm.org/viewvc/llvm-project?rev=337679&view=rev
Log:
Fix for last commit: adding new test file forgotten.
Added:
cfe/trunk/test/Analysis/PR38208.c
Added: cfe/trunk/test/Analysis/PR38208.c
URL:
http:
ioeric updated this revision to Diff 156738.
ioeric marked 4 inline comments as done.
ioeric added a comment.
- addressed review comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49543
Files:
clangd/CodeComplete.cpp
clangd/CodeComplete.h
clangd/Quality.cpp
clangd
Author: ioeric
Date: Mon Jul 23 03:56:37 2018
New Revision: 337681
URL: http://llvm.org/viewvc/llvm-project?rev=337681&view=rev
Log:
[clangd] Penalize non-instance members when accessed via class instances.
Summary:
The following are metrics for explicit member access completions. There is no
not
This revision was automatically updated to reflect the committed changes.
Closed by commit rL337681: [clangd] Penalize non-instance members when accessed
via class instances. (authored by ioeric, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.
Author: sammccall
Date: Mon Jul 23 04:25:25 2018
New Revision: 337682
URL: http://llvm.org/viewvc/llvm-project?rev=337682&view=rev
Log:
[Tooling] Use UniqueStringSaver. NFC
Modified:
cfe/trunk/include/clang/Tooling/Execution.h
cfe/trunk/lib/Tooling/Execution.cpp
Modified: cfe/trunk/inclu
ioeric added inline comments.
Comment at: clangd/Quality.cpp:146
+return false;
+ if (const auto *CM = dyn_cast(ND))
+return !CM->isStatic();
sammccall wrote:
> I think we also have to consider template functions too?
> And ideally I think we want to exc
aaronpuchert added a comment.
Ping? The functional changes should be minimal.
Comment at: test/SemaCXX/warn-thread-safety-analysis.cpp:38-39
#endif
+#define EXCLUSIVE_UNLOCK_FUNCTION(...)
__attribute__((release_capability(__VA_ARGS__)))
+#define SHARED_UNLOCK_FUNCTION(...)
Author: ericwf
Date: Mon Jul 23 04:46:47 2018
New Revision: 337684
URL: http://llvm.org/viewvc/llvm-project?rev=337684&view=rev
Log:
Cleanup name qualification in the filesystem internals.
In most cases there is no reason why the filesystem internals
use the qualifier std:: or _VSTD::. This patch
ilya-biryukov added a comment.
The extensions itself seems like a reasonable way to provide compile commands
for the individual files. In case didChangeConfiguration does not work for you
for some reason, happy to take a look at this change too.
One drawback of using didChangeConfiguration for c
vsk added inline comments.
Comment at: docs/UndefinedBehaviorSanitizer.rst:159
- ``-fsanitize=undefined``: All of the checks listed above other than
``unsigned-integer-overflow`` and the ``nullability-*`` checks.
- ``-fsanitize=undefined-trap``: Deprecated alias of
On Sat, Jul 21, 2018 at 4:40 PM, Arthur O'Dwyer via cfe-commits
wrote:
> In this case Clang is complaining about
>
> memset(complicated-expr, 0, 0);
>
> which means that transposing the last two arguments would not "fix"
> anything. Clang ought to not complain in this case.
+1
~Aaron
> It d
lebedev.ri added inline comments.
Comment at: lib/CodeGen/CodeGenFunction.h:383
+ // This stack is used/maintained exclusively by the implicit cast sanitizer.
+ llvm::SmallVector CastExprStack;
+
vsk wrote:
> lebedev.ri wrote:
> > vsk wrote:
> > > Why not 0 ins
vsk added inline comments.
Comment at: lib/CodeGen/CodeGenFunction.h:383
+ // This stack is used/maintained exclusively by the implicit cast sanitizer.
+ llvm::SmallVector CastExprStack;
+
lebedev.ri wrote:
> vsk wrote:
> > lebedev.ri wrote:
> > > vsk wrote:
>
Author: ericwf
Date: Mon Jul 23 04:55:13 2018
New Revision: 337685
URL: http://llvm.org/viewvc/llvm-project?rev=337685&view=rev
Log:
Cleanup unnecessary conversions in filesystem.
Modified:
libcxx/trunk/src/experimental/filesystem/operations.cpp
Modified: libcxx/trunk/src/experimental/filesy
lebedev.ri added inline comments.
Comment at: lib/CodeGen/CodeGenFunction.h:383
+ // This stack is used/maintained exclusively by the implicit cast sanitizer.
+ llvm::SmallVector CastExprStack;
+
vsk wrote:
> lebedev.ri wrote:
> > vsk wrote:
> > > lebedev.ri wr
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
Scary
Definitely LGTM!
Comment at: clangd/index/Index.h:45
- operator bool() const { return !FileURI.empty(); }
+ explicit operator bool() const { retur
lebedev.ri updated this revision to Diff 156583.
lebedev.ri marked 11 inline comments as done.
lebedev.ri added a comment.
Address @vsk's review notes.
Repository:
rC Clang
https://reviews.llvm.org/D48958
Files:
docs/ReleaseNotes.rst
docs/UndefinedBehaviorSanitizer.rst
include/clang/Ba
Or make operator bool explicit
On Mon, Jul 23, 2018, 13:55 Ilya Biryukov via Phabricator <
revi...@reviews.llvm.org> wrote:
> ilya-biryukov accepted this revision.
> ilya-biryukov added a comment.
> This revision is now accepted and ready to land.
>
> Scary
> Definitely LGTM!
>
>
>
>
sammccall added a subscriber: hokein.
sammccall added a comment.
Or make operator bool explicit
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49657
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lg
Repository:
rC Clang
https://reviews.llvm.org/D48873
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49618
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rC Clang
https://reviews.llvm.org/D48759
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
ilya-biryukov added a subscriber: sammccall.
ilya-biryukov added a comment.
@sammccall pointed out that I've been looking at a different layer of caching.
Clangd does per-directory (to avoid reloading compilation database multiple
times) and per-file (to avoid calling into compilation database mu
ioeric created this revision.
ioeric added a reviewer: sammccall.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay,
ilya-biryukov.
Currently, class constructors have the same score as the class types, and they
are often ranked before class types. This is often not desireable and
ilya-biryukov added a comment.
Just a drive-by comment.
Comment at: clangd/Quality.cpp:211
+ case Constructor:
+Score *= 1.0f; // Rank class constructors after class types.
+break;
NIT: This does not seem to change the score, right? Maybe just the assi
ioeric added inline comments.
Comment at: clangd/Quality.cpp:211
+ case Constructor:
+Score *= 1.0f; // Rank class constructors after class types.
+break;
ilya-biryukov wrote:
> NIT: This does not seem to change the score, right? Maybe just the assignmen
Author: d0k
Date: Mon Jul 23 05:45:24 2018
New Revision: 337688
URL: http://llvm.org/viewvc/llvm-project?rev=337688&view=rev
Log:
[AST] Use llvm::TrailingObjects in CXXTryStmt
1. Use llvm::TrailingObjects in CXXTryStmt instead of manually doing the
reinterpret_casts + pointer arithmetic. This is
This revision was automatically updated to reflect the committed changes.
Closed by commit rL337688: [AST] Use llvm::TrailingObjects in CXXTryStmt
(authored by d0k, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D48873?vs=155564&id=156
This revision was automatically updated to reflect the committed changes.
Closed by commit rC337688: [AST] Use llvm::TrailingObjects in CXXTryStmt
(authored by d0k, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48873?vs=155564&id=156759#toc
Repository:
rL LLVM
https://r
aaron.ballman added a comment.
I'm going to let @delesley give the final sign off on this as he is more
familiar with this part of the analysis, but I think this looks reasonable.
Repository:
rC Clang
https://reviews.llvm.org/D49355
___
cfe-comm
Author: kosarev
Date: Mon Jul 23 06:26:37 2018
New Revision: 337690
URL: http://llvm.org/viewvc/llvm-project?rev=337690&view=rev
Log:
[NEON] Fix support for vrndi_f32(), vrndiq_f32() and vrndns_f32() intrinsics
This patch adds support for vrndi_f32() and vrndiq_f32()
intrinsics in AArch32 mode an
This revision was automatically updated to reflect the committed changes.
Closed by commit rC337690: [NEON] Fix support for vrndi_f32(), vrndiq_f32() and
vrndns_f32() intrinsics (authored by kosarev, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D48829
Files:
include/clang/B
kosarev added a comment.
Thanks for reviewing!
Comment at: include/clang/Basic/arm_neon.td:1466
def VMINH : SInst<"vmin", "ddd", "hQh">;
- def FMAXNMH : SInst<"vmaxnm", "ddd", "hQh">;
- def FMINNMH : SInst<"vminnm", "ddd", "hQh">;
+ let ArchGuard = "__
kosarev added inline comments.
Comment at: include/clang/Basic/arm_neon.td:1419
// Vector rounding
- def FRINTZH : SInst<"vrnd", "dd", "hQh">;
- def FRINTNH : SInst<"vrndn", "dd", "hQh">;
- def FRINTAH : SInst<"vrnda", "dd", "hQh">;
- def FRINTPH : SIn
SjoerdMeijer added inline comments.
Comment at: include/clang/Basic/arm_neon.td:1466
def VMINH : SInst<"vmin", "ddd", "hQh">;
- def FMAXNMH : SInst<"vmaxnm", "ddd", "hQh">;
- def FMINNMH : SInst<"vminnm", "ddd", "hQh">;
+ let ArchGuard = "__ARM_ARCH >= 8
SjoerdMeijer added inline comments.
Comment at: include/clang/Basic/arm_neon.td:1419
// Vector rounding
- def FRINTZH : SInst<"vrnd", "dd", "hQh">;
- def FRINTNH : SInst<"vrndn", "dd", "hQh">;
- def FRINTAH : SInst<"vrnda", "dd", "hQh">;
- def FRINTPH
aaron.ballman added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:3426
+ let Content = [{
+The ``noderef`` attribute causes clang to throw a warning whenever a pointer
marked with
+this attribute is dereferenced. This is ideally used with pointers that point
to
kbobyrev updated this revision to Diff 156772.
kbobyrev marked 19 inline comments as done.
kbobyrev added a reviewer: ilya-biryukov.
kbobyrev removed a subscriber: ilya-biryukov.
kbobyrev added a comment.
Address all comments from the last iteration.
Latest changes:
- Trigram generation algorith
kbobyrev updated this revision to Diff 156774.
kbobyrev added a comment.
Wrong diff, should be correct now.
https://reviews.llvm.org/D49591
Files:
clang-tools-extra/clangd/CMakeLists.txt
clang-tools-extra/clangd/index/dex/Token.cpp
clang-tools-extra/clangd/index/dex/Token.h
clang-tools-
probinson added a reviewer: probinson.
probinson added a comment.
Needs a test.
Repository:
rC Clang
https://reviews.llvm.org/D49652
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
probinson added a comment.
Also, please document the option in clang/docs/UsersManual.rst. It should have
been added when the option was first added, but certainly with right-to-left
behavior it needs a mention. Nearly all options work left-to-right, so even
though it's the same as gcc, not e
keith.walker.arm added a comment.
This change fixed a failing build here, so it looks correct to me.
Repository:
rCXX libc++
https://reviews.llvm.org/D49629
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
Author: simark
Date: Mon Jul 23 07:32:12 2018
New Revision: 337697
URL: http://llvm.org/viewvc/llvm-project?rev=337697&view=rev
Log:
[clangd] Fix category in clangd-vscode's package.json
Summary:
When opening package.json, vscode shows:
Use 'Programming Languages' instead
Replacing "Language
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL337697: [clangd] Fix category in clangd-vscode's
package.json (authored by simark, committed by ).
Herald added a subscrib
Author: kosarev
Date: Mon Jul 23 07:53:44 2018
New Revision: 337699
URL: http://llvm.org/viewvc/llvm-project?rev=337699&view=rev
Log:
[NEON] Define half-precision vrnd intrinsics only when available
Differential Revision: https://reviews.llvm.org/D49376
Modified:
cfe/trunk/include/clang/Basi
This revision was automatically updated to reflect the committed changes.
Closed by commit rC337699: [NEON] Define half-precision vrnd intrinsics only
when available (authored by kosarev, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D49376
Files:
include/clang/Basic/arm_neo
alxu planned changes to this revision.
alxu added a comment.
The test syntax looked complicated, and I assumed that the documentation was
terrible, like wine's, but it's actually pretty good, so I'll give it a go. I
think the order is not really surprising though. It is run from right to left,
alxu added a comment.
Also, is it right to use SmallVector in one place and vector in the other? I
just assumed based on the surrounding declarations, but I really have no idea.
Repository:
rC Clang
https://reviews.llvm.org/D49652
___
cfe-commit
yaxunl added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:3368-3374
} else if (Form != Load && Form != LoadCopy) {
if (ValType.isConstQualified()) {
Diag(DRE->getLocStart(), diag::err_atomic_op_needs_non_const_pointer)
<< Ptr->getType() << Ptr->g
dmgreen created this revision.
dmgreen added reviewers: t.p.northover, olista01, john.brawn.
Herald added a reviewer: javed.absar.
Herald added a subscriber: kristof.beyls.
Adds a tiny code model as a Clang side of https://reviews.llvm.org/D49673.
https://reviews.llvm.org/D49674
Files:
includ
ldionne added a comment.
Can't you simply set `LIBCXX_ENABLE_SHARED=OFF` when you don't want to
build/install the shared library and `LIBCXX_ENABLE_STATIC=OFF` for the static
library?
Repository:
rL LLVM
https://reviews.llvm.org/D49573
___
cfe-
JonasToth updated this revision to Diff 156800.
JonasToth added a comment.
- rebase to master
Repository:
rC Clang
https://reviews.llvm.org/D48759
Files:
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/ASTMatchersInternal.cpp
lib/ASTMatchers/Dynamic/Registry.cpp
unittests/AST
Author: jonastoth
Date: Mon Jul 23 08:59:27 2018
New Revision: 337703
URL: http://llvm.org/viewvc/llvm-project?rev=337703&view=rev
Log:
[ASTMatchers] add matcher for decltypeType and its underlyingType
Summary:
This patch introduces a new matcher for `DecltypeType` and its underlying type
in orde
This revision was automatically updated to reflect the committed changes.
Closed by commit rL337703: [ASTMatchers] add matcher for decltypeType and its
underlyingType (authored by JonasToth, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D
xazax.hun requested changes to this revision.
xazax.hun added a comment.
This revision now requires changes to proceed.
Some comments, mostly nits inline.
Comment at: lib/StaticAnalyzer/Checkers/InnerPointerChecker.cpp:149
+C.addTransition(State);
return;
+ }
Author: kosarev
Date: Mon Jul 23 09:01:35 2018
New Revision: 337704
URL: http://llvm.org/viewvc/llvm-project?rev=337704&view=rev
Log:
[NEON] Define half-precision vmaxnm intrinsics only when available
Differential Revision: https://reviews.llvm.org/D49375
Modified:
cfe/trunk/include/clang/Ba
This revision was automatically updated to reflect the committed changes.
Closed by commit rC337704: [NEON] Define half-precision vmaxnm intrinsics only
when available (authored by kosarev, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D49375?vs=155675&id=156802#toc
Reposit
sammccall added a comment.
Looks really nice! Only major issue is the query trigrams don't look right.
Otherwise, some style nits and fixes that seem to have gotten lost.
Comment at: clang-tools-extra/clangd/index/dex/Token.cpp:28
+
+llvm::StringRef Token::data() const { return
Author: epilk
Date: Mon Jul 23 09:24:14 2018
New Revision: 337706
URL: http://llvm.org/viewvc/llvm-project?rev=337706&view=rev
Log:
[Sema] Don't emit -Wmemset-transposed-args for memset(p,0,0)
Thanks to Arthur O'Dwyer for the suggestion!
Modified:
cfe/trunk/lib/Sema/SemaChecking.cpp
cfe/
JonasToth updated this revision to Diff 156805.
JonasToth added a comment.
- rebase to master
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49618
Files:
clang-tidy/fuchsia/TrailingReturnCheck.cpp
Index: clang-tidy/fuchsia/TrailingReturnCheck.cpp
===
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
No opinion on the boost style thing.
Comment at: unittests/clangd/QualityTests.cpp:198
EXPECT_LT(Macro.evaluate(), Default.evaluate());
+ EXPECT_LT(Macro.evaluate()
Sure, that seems pretty reasonable. r337706. Thanks for the suggestion!
On 7/21/18 1:40 PM, Arthur O'Dwyer wrote:
In this case Clang is complaining about
memset(complicated-expr, 0, 0);
which means that transposing the last two arguments would not "fix"
anything. Clang ought to not compl
Author: jonastoth
Date: Mon Jul 23 09:30:13 2018
New Revision: 337707
URL: http://llvm.org/viewvc/llvm-project?rev=337707&view=rev
Log:
[clang-tidy] remove private decltypeType in TrailingReturnType
Summary:
This patch removes a private matcher in fuchsia/TrailingReturnType check because
the matc
This revision was automatically updated to reflect the committed changes.
Closed by commit rL337707: [clang-tidy] remove private decltypeType in
TrailingReturnType (authored by JonasToth, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D496
JonasToth marked 2 inline comments as done.
JonasToth added a comment.
The tests do run now with decltype too.
Still ready to land?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48717
___
cfe-commits mailing list
cfe-commits@lists
aaron.ballman accepted this revision.
aaron.ballman added a comment.
Yes, this looks good to me. Thanks!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48717
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
NoQ added a comment.
I've just one thing to add.
Comment at: lib/StaticAnalyzer/Checkers/InnerPointerChecker.cpp:149
+C.addTransition(State);
return;
+ }
xazax.hun wrote:
> Nit: This return is redundant.
Because of how easy it is to accidentally split
hamzasood updated this revision to Diff 156808.
hamzasood added a comment.
- Added a missing visibility attribute.
- Added a simple test that type-checks the expected public interface.
Testing whether it's actually hooked up correctly is quite problematic; it
isn't meant to be instantiable. What
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rCXXA libc++abi
https://reviews.llvm.org/D49638
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
xazax.hun added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/InnerPointerChecker.cpp:207
- if (mayInvalidateBuffer(Call)) {
-if (const PtrSet *PS = State->get(ObjRegion)) {
- // Mark all pointer symbols associated with the deleted object released.
- c
acoomans added a comment.
@djasper I updated the description of the diff.
This fixes the issue of `clang-format -lines=x:x` not returning the same
results as `clang-format`, while keeping the current behavior as default.
https://reviews.llvm.org/D49580
__
acoomans added a comment.
Also ping @jolesiak since he initially filed the report
https://reviews.llvm.org/D49580
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
djasper added a comment.
In my opinion, this only addresses one edge case where clang-format -lines
output is not identical with a full reformatting. I believe they cannot all
usefully be avoided. As such, I am unsure that this option carries its weight
of making the implementation more complex
mclow.lists added a comment.
> Testing whether it's actually hooked up correctly is quite problematic; it
> isn't meant to be instantiable. What's the best way to proceed with this?
The compiler is supposed to create these - right?
Does clang currently do this?
- If not, we should wait for them
olga.chupina added a comment.
Hello,
Since the structure field which is a function pointer appears in the assignment
statement, it messes up the type analysis.
If it would really be a pointer to a structure then the corresponding
assignment could be treated as bad type casting and potentially l
JonasToth updated this revision to Diff 156812.
JonasToth added a comment.
rebase to master
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48717
Files:
test/clang-tidy/cppcoreguidelines-pro-bounds-pointer-arithmetic.cpp
Index: test/clang-tidy/cppcoreguidelines-pro-bounds-po
acoomans added a comment.
I don't know; I just picked a random bug from the Bugzilla to get myself
familiarized with the LLVM codebase :)
@jolesiak?
https://reviews.llvm.org/D49580
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
1 - 100 of 246 matches
Mail list logo
