ioeric added inline comments.
================ Comment at: clangd/Quality.cpp:211 + case Constructor: + Score *= 1.0f; // Rank class constructors after class types. + break; ---------------- ilya-biryukov wrote: > NIT: This does not seem to change the score, right? Maybe just the assignment > or merge with the `Unknown` case? Previously, constructors are treated as `Function` and got 1.1 boost. Now it doesn't get a boost. Merging with `Unknown` might make sense too, but I wonder if we want to be more explicit. Happy to change. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49667 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
