[PATCH] D49074: [Analyzer] [WIP] Basic support for multiplication and division in the constraint manager

baloghadamsoftware added a comment. In https://reviews.llvm.org/D49074#1156110, @george.karpenkov wrote: > @baloghadamsoftware @dkrupp @xazax.hun Interesting. What do you think about > instead using Z3 cross-check functionality recently added, to solve this and > all other similar problems inst

[PATCH] D48903: [VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name

ilya-biryukov added a comment. In https://reviews.llvm.org/D48903#1157600, @simark wrote: > Thanks. I have seen no failures in `check-clang` and `check-clang-tools`, so > I will push it. LG! We can always revert the change is anything breaks... Repository: rC Clang https://reviews.llvm.o

[PATCH] D49074: [Analyzer] [WIP] Basic support for multiplication and division in the constraint manager

baloghadamsoftware added a comment. In https://reviews.llvm.org/D49074#1156609, @george.karpenkov wrote: > The overall point is that writing this kind of code is *extremely* > error-prone. Every modifications on the core is extremely error-prone. That is why we must cross check it and only ap

[PATCH] D33537: [clang-tidy] Exception Escape Checker

baloghadamsoftware added a comment. Any news regarding this? https://reviews.llvm.org/D33537 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49158: [clang-tidy] Fixing segfault when there's no IdentifierInfo

JonasToth added inline comments. Comment at: clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.cpp:44 bool &isInterface) const { - StringRef Name = Node->getIdentifier()->getName(); - llvm::StringMapConstIterator Pa

[PATCH] D49158: [clang-tidy] Fixing segfault when there's no IdentifierInfo

JonasToth added a comment. Is there a way to add a test, that would trigger the old segfault and show that it does not happen anymore with this fix? https://reviews.llvm.org/D49158 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://list

[PATCH] D46190: For a used declaration, mark any associated usings as referenced.

CarlosAlbertoEnciso added a comment. @rsmith Is there anything I can add to this patch? The review https://reviews.llvm.org/D44826 is already approved and it is dependent on this patch being reviewed. Thanks very much https://reviews.llvm.org/D46190 ___

[PATCH] D49074: [Analyzer] [WIP] Basic support for multiplication and division in the constraint manager

baloghadamsoftware added a comment. In https://reviews.llvm.org/D49074#1156110, @george.karpenkov wrote: > @baloghadamsoftware @dkrupp @xazax.hun Interesting. What do you think about > instead using Z3 cross-check functionality recently added, to solve this and > all other similar problems inst

r336776 - [AST] Structural equivalence of methods

Author: balazske Date: Wed Jul 11 02:37:24 2018 New Revision: 336776 URL: http://llvm.org/viewvc/llvm-project?rev=336776&view=rev Log: [AST] Structural equivalence of methods Summary: Added structural equivalence check for C++ methods. Improved structural equivalence tests. Added related ASTImpor

[PATCH] D48628: [AST] Structural equivalence of methods

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL336776: [AST] Structural equivalence of methods (authored by balazske, committed by ). Herald added a subscriber: llvm-com

[PATCH] D47946: [ASTImporter] Fix infinite recursion on function import with struct definition in parameters

a.sidorin accepted this revision. a.sidorin added a comment. Hello Zoltán, Sorry for the delay. I think the patch is fine, just some minor nits inline. Comment at: unittests/AST/ASTImporterTest.cpp:234 +assert(ToAST); +createVirtualFileIfNeeded(ToAST.get(), It->FileNam

[PATCH] D49012: [clangd] Uprank delcarations when "using q::name" is present in the main file

omtcyfz updated this revision to Diff 154956. omtcyfz marked 3 inline comments as done. omtcyfz added a comment. Address few comments, add test for macro definition, slightly reformat `QualityTests.cpp` https://reviews.llvm.org/D49012 Files: clang-tools-extra/clangd/Quality.cpp clang-tools

[PATCH] D49008: [clangd] Upgrade logging facilities with levels and formatv.

sammccall updated this revision to Diff 154959. sammccall added a comment. Add workaround for formatv+error issues. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49008 Files: clangd/ClangdLSPServer.cpp clangd/ClangdServer.cpp clangd/ClangdUnit.cpp clangd/CodeComplete.c

[clang-tools-extra] r336785 - [clangd] Upgrade logging facilities with levels and formatv.

Author: sammccall Date: Wed Jul 11 03:35:11 2018 New Revision: 336785 URL: http://llvm.org/viewvc/llvm-project?rev=336785&view=rev Log: [clangd] Upgrade logging facilities with levels and formatv. Summary: log() is split into four functions: - elog()/log()/vlog() have different severity levels,

[PATCH] D49008: [clangd] Upgrade logging facilities with levels and formatv.

This revision was automatically updated to reflect the committed changes. Closed by commit rL336785: [clangd] Upgrade logging facilities with levels and formatv. (authored by sammccall, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D4

[PATCH] D46940: [ASTImporter] make sure that ACtx::getParents still works

r.stahl added a comment. @rsmith Yes, this should generally better be handled outside of the ASTContext. That would be out of scope of this patch. Is it fine to proceed with this one for now? For my usage scenario it actually is convenient this way. In my checker I use getParents, but if I wou

[PATCH] D49012: [clangd] Uprank delcarations when "using q::name" is present in the main file

omtcyfz updated this revision to Diff 154969. omtcyfz added a comment. Slightly refactor code by making lambda only used once anonymous. https://reviews.llvm.org/D49012 Files: clang-tools-extra/clangd/Quality.cpp clang-tools-extra/unittests/clangd/QualityTests.cpp clang/include/clang/Sema

[PATCH] D49175: [clangd] Ignore sema code complete callback with recovery context.

ioeric created this revision. ioeric added reviewers: sammccall, ilya-biryukov. Herald added subscribers: cfe-commits, jkorous, MaskRay. Sema code complete in the recovery mode is generally useless. For many cases, sema first completes in recovery context and then recovers to more useful context,

[PATCH] D49175: [clangd] Ignore sema code complete callback with recovery context.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. I like this idea, of course hard to know how it will affect all practical cases. Is it easy to get have internal stats on how many wins/losses this has? Comment at: cl

r336798 - [mips] Add '-mvirt', '-mno-virt', '-mginv', '-mno-ginv' options

Author: vstefanovic Date: Wed Jul 11 05:45:25 2018 New Revision: 336798 URL: http://llvm.org/viewvc/llvm-project?rev=336798&view=rev Log: [mips] Add '-mvirt', '-mno-virt', '-mginv', '-mno-ginv' options '-mvirt'/'-mno-virt' enables/disables Virtualization ASE. '-mginv'/'-mno-ginv' enables/disables

[PATCH] D48982: [mips] Add '-mvirt', '-mno-virt', '-mginv', '-mno-ginv' options

This revision was automatically updated to reflect the committed changes. Closed by commit rC336798: [mips] Add '-mvirt', '-mno-virt', '-mginv', '-mno-ginv' options (authored by vstefanovic, committed by ). Repository: rC Clang https://reviews.llvm.org/D48982 Files: include/clang/Driver/Op

[PATCH] D49175: [clangd] Ignore sema code complete callback with recovery context.

ioeric updated this revision to Diff 154979. ioeric marked 2 inline comments as done. ioeric added a comment. - Addressed review comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49175 Files: clangd/CodeComplete.cpp unittests/clangd/CodeCompleteTests.cpp Index: uni

[PATCH] D49175: [clangd] Ignore sema code complete callback with recovery context.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. Thanks! That's a simple fix that makes things better overall! LGTM with a NIT about the comment in the test. Comment at: unittests/clangd/CodeCompleteTests.cpp:797 #if 0 + // In recorvery mode, "param_in_fo

[PATCH] D49175: [clangd] Ignore sema code complete callback with recovery context.

ioeric added a comment. In https://reviews.llvm.org/D49175#1158562, @sammccall wrote: > I like this idea, of course hard to know how it will affect all practical > cases. > > Is it easy to get have internal stats on how many wins/losses this has? This would fix bad completion results when sema

[clang-tools-extra] r336801 - [clangd] Ignore sema code complete callback with recovery context.

Author: ioeric Date: Wed Jul 11 06:15:31 2018 New Revision: 336801 URL: http://llvm.org/viewvc/llvm-project?rev=336801&view=rev Log: [clangd] Ignore sema code complete callback with recovery context. Summary: Sema code complete in the recovery mode is generally useless. For many cases, sema first

[PATCH] D49175: [clangd] Ignore sema code complete callback with recovery context.

This revision was automatically updated to reflect the committed changes. Closed by commit rL336801: [clangd] Ignore sema code complete callback with recovery context. (authored by ioeric, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D49

Re: [PATCH] D49175: [clangd] Ignore sema code complete callback with recovery context.

On Wed, Jul 11, 2018, 15:18 Eric Liu via Phabricator < revi...@reviews.llvm.org> wrote: > ioeric added a comment. > > In https://reviews.llvm.org/D49175#1158562, @sammccall wrote: > > > I like this idea, of course hard to know how it will affect all > practical cases. > > > > Is it easy to get hav

[PATCH] D47946: [ASTImporter] Fix infinite recursion on function import with struct definition in parameters

gerazo marked 2 inline comments as done. gerazo added inline comments. Comment at: unittests/AST/ASTImporterTest.cpp:234 +assert(ToAST); +createVirtualFileIfNeeded(ToAST.get(), It->FileName, It->Code); +return &*It; a.sidorin wrote: > Can we move the

[PATCH] D47946: [ASTImporter] Fix infinite recursion on function import with struct definition in parameters

gerazo updated this revision to Diff 154991. gerazo marked an inline comment as done. gerazo added a comment. Minor fixes for Aleksei's comments. https://reviews.llvm.org/D47946 Files: lib/AST/ASTImporter.cpp unittests/AST/ASTImporterTest.cpp Index: unittests/AST/ASTImporterTest.cpp ==

r336807 - [VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name

Author: simark Date: Wed Jul 11 07:08:17 2018 New Revision: 336807 URL: http://llvm.org/viewvc/llvm-project?rev=336807&view=rev Log: [VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name Summary: InMemoryFileSystem::status behaves differently than RealFileSystem

[PATCH] D48903: [VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name

This revision was automatically updated to reflect the committed changes. Closed by commit rC336807: [VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the… (authored by simark, committed by ). Changed prior to commit: https://reviews.llvm.org/D48903?vs=154835&id=154995#toc R

Re: [PATCH] D49175: [clangd] Ignore sema code complete callback with recovery context.

Sounds good. Thanks for the suggestion! On Wed, Jul 11, 2018 at 3:45 PM Sam McCall wrote: > > > On Wed, Jul 11, 2018, 15:18 Eric Liu via Phabricator < > revi...@reviews.llvm.org> wrote: > >> ioeric added a comment. >> >> In https://reviews.llvm.org/D49175#1158562, @sammccall wrote: >> >> > I lik

[PATCH] D49120: [libc++] P0898R3 2 of 12: Implement header

CaseyCarter added inline comments. Comment at: include/concepts:175 +template +_LIBCPP_CONCEPT_DECL Same = __same_impl<_Tp, _Up> && __same_impl<_Up, _Tp>; + Quuxplusone wrote: > CaseyCarter wrote: > > Quuxplusone wrote: > > > Peanut gallery asks: From lines 166-

r336810 - [clangd] Uprank delcarations when "using q::name" is present in the main file

Author: omtcyfz Date: Wed Jul 11 07:49:49 2018 New Revision: 336810 URL: http://llvm.org/viewvc/llvm-project?rev=336810&view=rev Log: [clangd] Uprank delcarations when "using q::name" is present in the main file Having `using qualified::name;` for some symbol is an important signal for clangd cod

[clang-tools-extra] r336810 - [clangd] Uprank delcarations when "using q::name" is present in the main file

Author: omtcyfz Date: Wed Jul 11 07:49:49 2018 New Revision: 336810 URL: http://llvm.org/viewvc/llvm-project?rev=336810&view=rev Log: [clangd] Uprank delcarations when "using q::name" is present in the main file Having `using qualified::name;` for some symbol is an important signal for clangd cod

[PATCH] D49188: [OpenMP] Initialize data sharing for SPMD case

gtbercea created this revision. gtbercea added reviewers: ABataev, carlo.bertolli, caomhin. Herald added subscribers: cfe-commits, guansong, jholewinski. In the SPMD case, we need to initialize the data sharing and globalization infrastructure. This covers the case when an SPMD region calls a fun

[PATCH] D49012: [clangd] Uprank delcarations when "using q::name" is present in the main file

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE336810: [clangd] Uprank delcarations when "using q::name" is present in the main file (authored by omtcyfz, committed by ). Changed prior to commit: https://reviews.llvm.org/D49012?vs=154969&id=155001

[PATCH] D49188: [OpenMP] Initialize data sharing stack for SPMD case

ABataev added a comment. Tests? Repository: rC Clang https://reviews.llvm.org/D49188 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49188: [OpenMP] Initialize data sharing stack for SPMD case

ABataev added a comment. What about the check for the new function call? Repository: rC Clang https://reviews.llvm.org/D49188 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49188: [OpenMP] Initialize data sharing stack for SPMD case

gtbercea updated this revision to Diff 155002. gtbercea added a comment. Fix test. Repository: rC Clang https://reviews.llvm.org/D49188 Files: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp test/OpenMP/nvptx_data_sharing.cpp Index: test/OpenMP/nvptx_data_sharing.cpp =

[PATCH] D49190: [clang-tidy/ObjC] Add SQL to list of acronyms

benhamilton created this revision. benhamilton added reviewers: Wizard, hokein. Herald added a subscriber: cfe-commits. SQL is a common acronym. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49190 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp Index: clang-tidy/objc/P

[PATCH] D49188: [OpenMP] Initialize data sharing stack for SPMD case

Hahnfeld added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:84-85 OMPRTL_NVPTX__kmpc_data_sharing_init_stack, + /// Call to void __kmpc_data_sharing_init_stack_spmd(); + OMPRTL_NVPTX__kmpc_data_sharing_init_stack_spmd, /// Call to void* __kmpc_data_sh

[PATCH] D49112: [Sema] Implement -Wmemset-transposed-args

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. lgtm assuming you ran this on some large code base to make sure it doesn't have false positives. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:659 +def warn_s

r336817 - [AST] Fix for structural equivalence tests in rL336776.

Author: balazske Date: Wed Jul 11 08:26:26 2018 New Revision: 336817 URL: http://llvm.org/viewvc/llvm-project?rev=336817&view=rev Log: [AST] Fix for structural equivalence tests in rL336776. Modified: cfe/trunk/unittests/AST/StructuralEquivalenceTest.cpp Modified: cfe/trunk/unittests/AST/Str

[PATCH] D47894: [clang]: Add support for "-fno-delete-null-pointer-checks"

manojgupta added a comment. @efriedma @jyknight Does the change match your expectations where warnings are still generated but codeGen does not emit nonnull attribute? Comment at: test/Sema/nonnull.c:2 // RUN: %clang_cc1 -fsyntax-only -verify %s +// RUN: %clang_cc1 -fsyntax-o

[PATCH] D48559: [clangd] refactoring for XPC transport layer [NFCI]

jkorous added a comment. Ping. Added reviewers suggestion. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D48559 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36892: [clang-tidy] check_clang_tidy.py: support CHECK-NOTES prefix

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. As per the previous comment: I have no concerns as long as the documentation is updated and at least one existing test is changed to use this feature (see the list in the previous co

[PATCH] D48395: Added PublicOnly flag

juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. Remember to mark comments as done when they are. Otherwise, LGTM unless @ioeric has any concerns. https://reviews.llvm.org/D48395 __

[PATCH] D33537: [clang-tidy] Exception Escape Checker

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good with one comment. Comment at: test/clang-tidy/bugprone-exception-escape.cpp:178 +void indirect_implicit() noexcept { + // CHECK-MESSAGES: :[[@LINE-1]]:6: warning:

[PATCH] D42682: [clang-tidy] Add io-functions-misused checker

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. (removing from my dashboard) Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42682 ___ cfe-commits mailing list cfe-com

[PATCH] D49197: FileManager: Try to compute RealPathName in getVirtualFile

simark created this revision. Herald added a subscriber: cfe-commits. I noticed that when getVirtualFile is called for a file, subsequent calls to getFile will return a FileEntry without the RealPathName computed: const FileEntry *VFE = Mgr->getVirtualFile("/foo/../bar", ...); const FileEntry

[PATCH] D49197: FileManager: Try to compute RealPathName in getVirtualFile

simark updated this revision to Diff 155027. simark added a comment. Update commit message. Repository: rC Clang https://reviews.llvm.org/D49197 Files: lib/Basic/FileManager.cpp unittests/Basic/FileManagerTest.cpp Index: unittests/Basic/FileManagerTest.cpp =

[PATCH] D49197: FileManager: Try to compute RealPathName in getVirtualFile

simark added a comment. I'm not sure who should review this patch, please add anybody you think is qualified/responsible. Repository: rC Clang https://reviews.llvm.org/D49197 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D49197: FileManager: Try to compute RealPathName in getVirtualFile

simark added a comment. Background: I'm trying to fix the cases why we receive a FileEntry without a real path computed in clangd, so we can avoid having to compute it ourselves. Repository: rC Clang https://reviews.llvm.org/D49197 ___ cfe-comm

[PATCH] D49190: [clang-tidy/ObjC] Add SQL to list of acronyms

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49190 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D48903: [VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name

ioeric added a comment. In https://reviews.llvm.org/D48903#1155403, @ilya-biryukov wrote: > In https://reviews.llvm.org/D48903#1154846, @simark wrote: > > > With the `InMemoryFileSystem`, this now returns a non-real path. The > > result is that we fill `RealPathName` with that non-real path. I

Re: r336776 - [AST] Structural equivalence of methods

Hello Balazs, This commit broke at least one of our builders: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/10897 . . . Failing Tests (1): Clang-Unit :: AST/./ASTTests.exe/StructuralEquivalenceRecordTest.Name Please have a look? It is not good idea to keep t

[PATCH] D48903: [VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name

ioeric added a comment. In https://reviews.llvm.org/D48903#1159023, @ioeric wrote: > In https://reviews.llvm.org/D48903#1155403, @ilya-biryukov wrote: > > > In https://reviews.llvm.org/D48903#1154846, @simark wrote: > > > > > With the `InMemoryFileSystem`, this now returns a non-real path. The

Re: r336807 - [VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name

Hello Simon, This commit added broken tests to one of our builders: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/18386/steps/test/logs/stdio . . . Failing Tests (4): Clang :: PCH/case-insensitive-include.c Clang-Unit :: Basic/./BasicTests.exe/In

[PATCH] D49188: [OpenMP] Initialize data sharing stack for SPMD case

gtbercea updated this revision to Diff 155037. gtbercea added a comment. Add test for spmd stack init function. Repository: rC Clang https://reviews.llvm.org/D49188 Files: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp test/OpenMP/nvptx_data_sharing.cpp test/OpenMP/nvptx_data_sharing_spmd.cpp

[PATCH] D48903: [VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name

simark added a comment. In https://reviews.llvm.org/D48903#1159023, @ioeric wrote: > Would you mind reverting this patch for now so that we can come up with a > solution to address those use cases? > > Sorry again about missing the discussion earlier! Of course, feel free to revert if needed (

[PATCH] D48903: [VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name

ioeric added a comment. In https://reviews.llvm.org/D48903#1159046, @simark wrote: > In https://reviews.llvm.org/D48903#1159023, @ioeric wrote: > > > Would you mind reverting this patch for now so that we can come up with a > > solution to address those use cases? > > > > Sorry again about missi

[PATCH] D49197: FileManager: Try to compute RealPathName in getVirtualFile

ioeric added inline comments. Comment at: lib/Basic/FileManager.cpp:395 + SmallString<128> RealPathName; + if (!FS->getRealPath(InterndFileName, RealPathName)) +UFE->RealPathName = RealPathName.str(); It seems that at this point, we have failed to find `Fil

[PATCH] D47946: [ASTImporter] Fix infinite recursion on function import with struct definition in parameters

martong added a comment. @gerazo, Do you have commit rights, or should I help with the commit? https://reviews.llvm.org/D47946 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49188: [OpenMP] Initialize data sharing stack for SPMD case

gtbercea marked 2 inline comments as done. gtbercea added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:84-85 OMPRTL_NVPTX__kmpc_data_sharing_init_stack, + /// Call to void __kmpc_data_sharing_init_stack_spmd(); + OMPRTL_NVPTX__kmpc_data_sharing_init_stac

[PATCH] D47632: [ASTImporter] Refactor Decl creation

martong added a comment. Hi Aleksei, could you pleas take an other quick look, there were only minor changes since your last comments. Thanks! Repository: rC Clang https://reviews.llvm.org/D47632 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D44493: [libunwind] Add a cmake option for disabling the use of the dynamic linker

mstorsjo abandoned this revision. mstorsjo added a comment. Herald added a subscriber: chrib. I choose not to commit this one after all, I managed to work around the issue with Windows Store apps in a much simpler way by providing a Windows Store compatible version of EnumProcessModules, see ht

[PATCH] D44494: [libunwind] Support __register_frame with a full .eh_frame section

mstorsjo abandoned this revision. mstorsjo added a comment. Herald added a subscriber: chrib. FWIW, I'm not going to put any more effort into this one at the moment, I managed to fix my use case in a much simpler way by providing a Windows Store compatible version of EnumProcessModules, see htt

r336831 - Revert "[VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name"

Author: ioeric Date: Wed Jul 11 11:43:07 2018 New Revision: 336831 URL: http://llvm.org/viewvc/llvm-project?rev=336831&view=rev Log: Revert "[VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name" This reverts commit r336807. This breaks users of ClangTool::mapVi

[PATCH] D49199: [analyzer][UninitializedObjectChecker] Pointer/reference objects are dereferenced according to dynamic type

Szelethus created this revision. Szelethus added reviewers: NoQ, george.karpenkov, xazax.hun, rnkovacs. Herald added subscribers: cfe-commits, mikhail.ramalho, a.sidorin, szepet, whisperity. This diff fixes a long debated issues with pointers/references not being dereferenced according to their

Re: r336776 - [AST] Structural equivalence of methods

Hi, I am aware of the problem, there should be already a commit to (hopefully) correct the failure. Balázs Kéri Galina Kistanova ezt írta (időpont: 2018. júl. 11., Sze, 20:01): > Hello Balazs, > > This commit broke at least one of our builders: > > http://lab.llvm.org:8011/builders/llvm-clang-x

[PATCH] D49074: [Analyzer] [WIP] Basic support for multiplication and division in the constraint manager

george.karpenkov added a comment. > What issues could it cause since it is guarded by an option? I've meant the rearrangement. Actually, I would like to apologize for that point, I thought it was causing some issues, but it wasn't, we've just checked it yesterday. > As far as I know the purpos

Re: r336807 - [VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name

fyi, I've reverted this commit with r336831 due to some other issues. On Wed, Jul 11, 2018 at 8:23 PM Galina Kistanova via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hello Simon, > > This commit added broken tests to one of our builders: > > http://lab.llvm.org:8011/builders/llvm-clang-ll

[PATCH] D48845: [Sema] Add fixit for unused lambda captures

arphaman added a comment. Thanks for working on this! Please upload the patch with the full context (git diff -U9). It helps the reviewers :) In https://reviews.llvm.org/D48845#1158103, @alexshap wrote: > I'm kind of interested in this fixit, but one thought which i have - probably > it sh

[PATCH] D49197: FileManager: Try to compute RealPathName in getVirtualFile

simark added inline comments. Comment at: lib/Basic/FileManager.cpp:395 + SmallString<128> RealPathName; + if (!FS->getRealPath(InterndFileName, RealPathName)) +UFE->RealPathName = RealPathName.str(); ioeric wrote: > It seems that at this point, we have fai

r336835 - [analyzer] Track multiple raw pointer symbols in DanglingInternalBufferChecker.

Author: rkovacs Date: Wed Jul 11 12:08:02 2018 New Revision: 336835 URL: http://llvm.org/viewvc/llvm-project?rev=336835&view=rev Log: [analyzer] Track multiple raw pointer symbols in DanglingInternalBufferChecker. Previously, the checker only tracked one raw pointer symbol for each container obje

[PATCH] D49057: [analyzer] Track multiple raw pointer symbols in DanglingInternalBufferChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rC336835: [analyzer] Track multiple raw pointer symbols in DanglingInternalBufferChecker. (authored by rkovacs, committed by ). Repository: rC Clang https://reviews.llvm.org/D49057 Files: lib/StaticAn

r336836 - [NFC] Replace usage of QualType.getTypePtr()-> with operator->

Author: erichkeane Date: Wed Jul 11 12:09:21 2018 New Revision: 336836 URL: http://llvm.org/viewvc/llvm-project?rev=336836&view=rev Log: [NFC] Replace usage of QualType.getTypePtr()-> with operator-> Modified: cfe/trunk/lib/Sema/SemaDecl.cpp Modified: cfe/trunk/lib/Sema/SemaDecl.cpp URL: ht

[PATCH] D49074: [Analyzer] [WIP] Basic support for multiplication and division in the constraint manager

xazax.hun added a comment. In https://reviews.llvm.org/D49074#1159095, @george.karpenkov wrote: > > This may remove false-positives (like the example above), but we surely > > cannot find new errors where multiplicative operations are used. > > Do you have examples of those? In my understanding,

[PATCH] D49199: [analyzer][UninitializedObjectChecker] Pointer/reference objects are dereferenced according to dynamic type

Szelethus added inline comments. Comment at: lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp:591-609 +// TODO: This function constructs an incorrect string if a void pointer is a +// part of the chain: +// +// struct B { int x; } +// +// struct A { +// void *vp

[PATCH] D48845: [Sema] Add fixit for unused lambda captures

alexshap added a comment. > Are you talking about a more conservative warning or a more conservative > fixit? If it doesn't make sense for us to have a fixit for a particular > capture, does it make sense for us to have a warning for that >capture in the > first place? to be honest i'm more co

r336840 - [NFC] typo

Author: jfb Date: Wed Jul 11 12:51:40 2018 New Revision: 336840 URL: http://llvm.org/viewvc/llvm-project?rev=336840&view=rev Log: [NFC] typo Modified: cfe/trunk/lib/CodeGen/ConstantEmitter.h Modified: cfe/trunk/lib/CodeGen/ConstantEmitter.h URL: http://llvm.org/viewvc/llvm-project/cfe/trunk

[PATCH] D48958: [clang][ubsan] Implicit Cast Sanitizer - integer truncation - clang part

vsk added inline comments. Comment at: lib/CodeGen/CGExprScalar.cpp:1694 // handle things like function to ptr-to-function decay etc. Value *ScalarExprEmitter::VisitCastExpr(CastExpr *CE) { Expr *E = CE->getSubExpr(); lebedev.ri wrote: > vsk wrote: > > I thi

r336842 - Fix setting of empty implicit-section-name attribute

Author: petr.pavlu Date: Wed Jul 11 13:17:54 2018 New Revision: 336842 URL: http://llvm.org/viewvc/llvm-project?rev=336842&view=rev Log: Fix setting of empty implicit-section-name attribute Code in `CodeGenModule::SetFunctionAttributes()` could set an empty attribute `implicit-section-name` on a

[PATCH] D48916: Fix setting of empty implicit-section-name attribute for functions affected by '#pragma clang section'

This revision was automatically updated to reflect the committed changes. Closed by commit rC336842: Fix setting of empty implicit-section-name attribute (authored by petr.pavlu, committed by ). Repository: rC Clang https://reviews.llvm.org/D48916 Files: lib/CodeGen/CodeGenModule.cpp test

[PATCH] D49114: [clang-tidy] Add a check for "magic numbers"

Eugene.Zelenko added a comment. C++ Core Guidelines contains ES.45: Avoid "magic constants"; use symbolic constants , so I think check should be moved into cppcoreguidelines module. Repository: rCTE Clan

[PATCH] D48687: [clangd] Avoid duplicates in findDefinitions response

simark updated this revision to Diff 155057. simark added a comment. This is an update of my work in progress. I haven't done any sharing with SymbolCollector, as it's not clear to me how to proceed with that. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D48687 Files: clang

[clang-tools-extra] r336849 - [Documentation] Link format and order of Clang-tidy changes in Release Notes

Author: eugenezelenko Date: Wed Jul 11 13:41:16 2018 New Revision: 336849 URL: http://llvm.org/viewvc/llvm-project?rev=336849&view=rev Log: [Documentation] Link format and order of Clang-tidy changes in Release Notes Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified: clang-too

[PATCH] D49114: [clang-tidy] Add a check for "magic numbers"

Quuxplusone added inline comments. Comment at: docs/clang-tidy/checks/readability-magic-numbers.rst:11 + + double circleArea = 3.1415926535 * radius * radius; + 0x8000- wrote: > Eugene.Zelenko wrote: > > JonasToth wrote: > > > This example is good, but righ

[clang-tools-extra] r336850 - [Documentation] Fix incorrect documentation references, new checks order in Release Notes

Author: eugenezelenko Date: Wed Jul 11 13:56:26 2018 New Revision: 336850 URL: http://llvm.org/viewvc/llvm-project?rev=336850&view=rev Log: [Documentation] Fix incorrect documentation references, new checks order in Release Notes Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modif

[PATCH] D46845: [libcxx][c++17] P0083R5: Splicing Maps and Sets

ldionne requested changes to this revision. ldionne added a comment. This revision now requires changes to proceed. Generally looks pretty good, but I have a couple questions/suggestions. Comment at: libcxx/include/__hash_table:2165 +#if _LIBCPP_STD_VER > 14 +template +templat

r336852 - Fix determination of whether one set of cvr-qualifiers is compatible

Author: rsmith Date: Wed Jul 11 14:07:04 2018 New Revision: 336852 URL: http://llvm.org/viewvc/llvm-project?rev=336852&view=rev Log: Fix determination of whether one set of cvr-qualifiers is compatible with another in template argument deduction. We happened to typically get away with getting thi

[PATCH] D48958: [clang][ubsan] Implicit Cast Sanitizer - integer truncation - clang part

lebedev.ri added inline comments. Comment at: lib/CodeGen/CGExprScalar.cpp:1694 // handle things like function to ptr-to-function decay etc. Value *ScalarExprEmitter::VisitCastExpr(CastExpr *CE) { Expr *E = CE->getSubExpr(); vsk wrote: > lebedev.ri wrote: >

[PATCH] D48958: [clang][ubsan] Implicit Cast Sanitizer - integer truncation - clang part

lebedev.ri updated this revision to Diff 155064. lebedev.ri added a comment. Add some more tricky tests where maintaining just the `CastExpr` part of AST stack would break them. Repository: rC Clang https://reviews.llvm.org/D48958 Files: docs/ReleaseNotes.rst docs/UndefinedBehaviorSanit

[PATCH] D49074: [Analyzer] [WIP] Basic support for multiplication and division in the constraint manager

george.karpenkov added a comment. > The imprecision in the built in solver might result in failure to constrain a > value to zero while the Z3 might be able to do that. Ah right, that's a good point, we only throw a null-pointer deref/division by zero when the pointer/value is definitely zero.

[libcxx] r336855 - Fix a test #ifdef that was reversed. NFC to the library.

Author: marshall Date: Wed Jul 11 14:20:42 2018 New Revision: 336855 URL: http://llvm.org/viewvc/llvm-project?rev=336855&view=rev Log: Fix a test #ifdef that was reversed. NFC to the library. Modified: libcxx/trunk/test/std/strings/string.view/string.view.cons/assign.pass.cpp Modified: lib

[libcxx] r336856 - Same reversed ifdef happened twice. Test fix only, NFC to the library.

Author: marshall Date: Wed Jul 11 14:22:13 2018 New Revision: 336856 URL: http://llvm.org/viewvc/llvm-project?rev=336856&view=rev Log: Same reversed ifdef happened twice. Test fix only, NFC to the library. Modified: libcxx/trunk/test/std/strings/string.view/string.view.cons/assign.pass.cpp

[PATCH] D45898: [SemaCXX] Mark destructor as referenced

ahatanak added a comment. ping Repository: rC Clang https://reviews.llvm.org/D45898 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46845: [libcxx][c++17] P0083R5: Splicing Maps and Sets

ldionne added a comment. I forgot to mention it in my initial review, but it also seems like you forgot to update all the synopsis in the comments at the beginning of headers. https://reviews.llvm.org/D46845 ___ cfe-commits mailing list cfe-commits

[PATCH] D48903: [VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name

ioeric added a comment. After looking at a few more use cases of the in-memory file system, I think a problem we need to address is the consistency of file paths you get from clang when using in-mem vfs. The clang-move tests that you have mitigated in https://reviews.llvm.org/D48951 could be a

  1   2   >