klimek added a comment.
In https://reviews.llvm.org/D28462#1147019, @enyquist wrote:
> @klimek fair point. To be honest, I've pretty much lost interest / momentum
> on this feature, I very much doubt I will ever go back and re-implement from
> scratch as you suggest.
> Not meaning to sound rud
klimek added a reviewer: rsmith.
klimek added inline comments.
Comment at: clangd/XRefs.cpp:559
+ //- auto& i = 1;
+ bool VisitDeclaratorDecl(DeclaratorDecl *D) {
+if (!D->getTypeSourceInfo() ||
malaperle wrote:
> klimek wrote:
> > sammccall wrote:
> > > ma
JonasToth updated this revision to Diff 153457.
JonasToth added a comment.
This revision is now accepted and ready to land.
- fix decltype deduction with new matcher
I had to introduce a new matcher in clang for `DecltypeType` to reach its
underlying type. It would be better to have `hasType` res
JonasToth created this revision.
JonasToth added reviewers: aaron.ballman, alexfh, NoQ, dcoughlin.
Herald added a subscriber: cfe-commits.
This patch introduces a new matcher for `DecltypeType` and its underlying type
in order to fix a bug in clang-tidy, see https://reviews.llvm.org/D48717 for
mo
krasimir created this revision.
Herald added a subscriber: cfe-commits.
This adds a few more common function names expecting a text proto argument.
Repository:
rC Clang
https://reviews.llvm.org/D48760
Files:
lib/Format/Format.cpp
Index: lib/Format/Format.cpp
=
Author: martong
Date: Fri Jun 29 03:25:19 2018
New Revision: 335959
URL: http://llvm.org/viewvc/llvm-project?rev=335959&view=rev
Log:
[ASTImporter] Eliminated some unittest warnings.
Summary:
When running the ASTTests test, warnings produced by the compiler can be
distracting when looking for tes
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335959: [ASTImporter] Eliminated some unittest warnings.
(authored by martong, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D47459
Files:
cfe
sammccall created this revision.
sammccall added a reviewer: ioeric.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
LSP has some presentational fields with limited semantics (e.g. 'detail') and
doesn't provide a good place to return information like namespace.
Some places where mo
sammccall added a comment.
@jkorous FYI: this may be interesting from an XPC perspective - it'd be easy to
serialize the LSP-style struct, or the more detailed one if that's useful.
LSP will be more stable of course :-)
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48762
__
baloghadamsoftware created this revision.
baloghadamsoftware added reviewers: NoQ, mikhail.ramalho.
Herald added subscribers: a.sidorin, dkrupp, rnkovacs, szepet, xazax.hun,
whisperity.
Herald added a reviewer: george.karpenkov.
Marking a symbolic expression as live is not recursive. In our check
mike.dvoretsky updated this revision to Diff 153471.
mike.dvoretsky marked 2 inline comments as done.
mike.dvoretsky added a comment.
Updated per comments. Typedefs for intermediate short vectors moved into the
bodies of the functions using them.
https://reviews.llvm.org/D48712
Files:
clang/
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335964: [analyzer][UninitializedObjectChecker] Added a
NotesAsWarnings flag (authored by Szelethus, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D48285
Files:
lib/StaticAnalyzer/Che
Author: szelethus
Date: Fri Jun 29 04:25:24 2018
New Revision: 335964
URL: http://llvm.org/viewvc/llvm-project?rev=335964&view=rev
Log:
[analyzer][UninitializedObjectChecker] Added a NotesAsWarnings flag
In order to better support consumers of the plist output that don't
parse note entries just y
Szelethus added a comment.
In https://reviews.llvm.org/D45532#1145512, @sylvestre.ledru wrote:
> If you are interested, I executed this checker on Firefox code. Results can
> be found here
> http://sylvestre.ledru.info/reports/fx-scan-build/
Absolutely, thank you! :)
> Andi reported this bug
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
This looks good to me.
Comment at: include/clang/Driver/CC1Options.td:604
+ HelpText<"When creating a pch stop at this file. When using a pch start "
+ "after this fi
ebevhan added a comment.
I also think it would be good with some unit tests for this class once the
functionality and interface is nailed down.
Comment at: include/clang/Basic/FixedPoint.h:31
+ SatNoPadding,
+};
+
rjmccall wrote:
> I figured you'd want this t
alexfh added a comment.
Please add a test.
Repository:
rC Clang
https://reviews.llvm.org/D48759
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: martong
Date: Fri Jun 29 05:17:34 2018
New Revision: 335968
URL: http://llvm.org/viewvc/llvm-project?rev=335968&view=rev
Log:
[ASTImporter] Added import of CXXStdInitializerListExpr
Reviewers: a.sidorin
Reviewed By: a.sidorin
Subscribers: martong, cfe-commits
Differential Revision: htt
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335968: [ASTImporter] Added import of
CXXStdInitializerListExpr (authored by martong, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D48631
Files
baloghadamsoftware updated this revision to Diff 153481.
baloghadamsoftware added a comment.
Previous rebase was wrong, this is the correct one.
https://reviews.llvm.org/D32845
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/IteratorChecker.cpp
test/An
baloghadamsoftware updated this revision to Diff 153482.
baloghadamsoftware added a comment.
Herald added a subscriber: mikhail.ramalho.
Rebased to https://reviews.llvm.org/rL335835.
https://reviews.llvm.org/D32859
Files:
lib/StaticAnalyzer/Checkers/IteratorChecker.cpp
test/Analysis/mismatc
aaron.ballman added inline comments.
Comment at: lib/Sema/SemaDeclAttr.cpp:5305
+
+ if (hasFunctionProto(D) && getFunctionOrMethodNumParams(D) != 0) {
+S.Diag(D->getLocation(), diag::warn_riscv_interrupt_attribute) << 0;
I would have assumed this would be: `
RKSimon added inline comments.
Comment at: clang/lib/Headers/avx512vlbwintrin.h:1501
+ (__v8qi){0, 0, 0, 0, 0, 0, 0, 0}, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11,
+ 12, 13, 14, 15);
}
Are we happy with using illegal types like this? What about flipping the
aaron.ballman added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:5523
+ StringLiteralCheckType CommonResult;
+ for (const FormatArgAttr *FA : ND->specific_attrs()) {
const Expr *Arg = CE->getArg(FA->getFormatIdx().getASTIndex());
You
ioeric added a comment.
Looks great! Mostly nits.
Comment at: clangd/CodeComplete.cpp:259
+ : ASTCtx(ASTCtx), ExtractDocumentation(Opts.IncludeComments) {
+if (C.SemaResult) {
+ Completion.Name = llvm::StringRef(SemaCCS->getTypedText());
nit: shal
aaron.ballman added a comment.
Once this goes in, you can also update TrailingReturnTypeCheck.cpp to remove
its local instance of this type matcher.
Comment at: lib/ASTMatchers/Dynamic/Registry.cpp:137
REGISTER_MATCHER(autoType);
+ REGISTER_MATCHER(decltypeType);
REGIST
aaron.ballman added a comment.
In https://reviews.llvm.org/D48717#1147644, @JonasToth wrote:
> - fix decltype deduction with new matcher
>
> I had to introduce a new matcher in clang for `DecltypeType` to reach its
> underlying type. It would be better to have `hasType` resolve all these
> is
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335972: [clangd] Improve output of --help and --version.
NFC. (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D48634
Files
Author: sammccall
Date: Fri Jun 29 06:24:20 2018
New Revision: 335972
URL: http://llvm.org/viewvc/llvm-project?rev=335972&view=rev
Log:
[clangd] Improve output of --help and --version. NFC.
Reviewers: ilya-biryukov
Subscribers: ioeric, MaskRay, jkorous, cfe-commits
Differential Revision: https:
ebevhan added inline comments.
Comment at: lib/Basic/FixedPoint.cpp:53
+// We can overflow here
+unsigned ShiftAmt = DstScale - Scale;
+if (Val < 0 && Val.countLeadingOnes() >= ShiftAmt)
ebevhan wrote:
> I think saturation can be modeled a bit better.
krasimir accepted this revision.
krasimir added a comment.
This revision is now accepted and ready to land.
Checked with both python 2 and python 3 as suggested. Works like a charm! Thank
you!
https://reviews.llvm.org/D48098
___
cfe-commits mailing
Author: krasimir
Date: Fri Jun 29 07:25:25 2018
New Revision: 335978
URL: http://llvm.org/viewvc/llvm-project?rev=335978&view=rev
Log:
[clang-format] Support additional common functions for text proto formatting
Summary: This adds a few more common function names expecting a text proto
argument.
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335978: [clang-format] Support additional common functions
for text proto formatting (authored by krasimir, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48760?vs=153459&id=153491#t
sammccall updated this revision to Diff 153493.
sammccall marked 11 inline comments as done.
sammccall added a comment.
Address review comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48762
Files:
clangd/ClangdServer.cpp
clangd/CodeComplete.cpp
clangd/CodeComplete
sammccall added inline comments.
Comment at: clangd/CodeComplete.cpp:259
+ : ASTCtx(ASTCtx), ExtractDocumentation(Opts.IncludeComments) {
+if (C.SemaResult) {
+ Completion.Name = llvm::StringRef(SemaCCS->getTypedText());
ioeric wrote:
> nit: shall w
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48762
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
Author: sammccall
Date: Fri Jun 29 07:47:57 2018
New Revision: 335980
URL: http://llvm.org/viewvc/llvm-project?rev=335980&view=rev
Log:
[clangd] codeComplete returns more structured completion items, LSP. NFC.
Summary:
LSP has some presentational fields with limited semantics (e.g. 'detail') and
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE335980: [clangd] codeComplete returns more structured
completion items, LSP. NFC. (authored by sammccall, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48762?vs=153493&id=153495#t
martong created this revision.
martong added reviewers: a.sidorin, balazske, r.stahl.
Herald added subscribers: cfe-commits, dkrupp, rnkovacs.
Currently, anonymous types are merged into the same redecl chain even if they
are structurally inequivalent. This results that global objects are not
impor
Author: benhamilton
Date: Fri Jun 29 08:26:37 2018
New Revision: 335983
URL: http://llvm.org/viewvc/llvm-project?rev=335983&view=rev
Log:
[clang-format/ObjC] Fix NS_SWIFT_NAME(foo(bar:baz:)) after ObjC method decl
Summary:
In D44638, I partially fixed `NS_SWIFT_NAME(foo(bar:baz:))`-style
annotati
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335983: [clang-format/ObjC] Fix NS_SWIFT_NAME(foo(bar:baz:))
after ObjC method decl (authored by benhamilton, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://review
deepak2427 added a comment.
Do I need to add specific reviewers?
Repository:
rC Clang
https://reviews.llvm.org/D48721
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
martong added a comment.
I realized that, this patch brakes 3 lldb tests ATM:
- `TestTopLevelExprs.py`. If https://reviews.llvm.org/D48722 was merged then
this test would not be broken.
- `TestPersistentTypes.py` If https://reviews.llvm.org/D48773 was merged then
this test would not be broken.
sammccall updated this revision to Diff 153504.
sammccall marked 2 inline comments as done.
sammccall added a comment.
Address review comments. Most notably: limit the up-traversals from some
sources.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48441
Files:
clangd/CMakeLi
mike.dvoretsky added inline comments.
Comment at: clang/lib/Headers/avx512vlbwintrin.h:1501
+ (__v8qi){0, 0, 0, 0, 0, 0, 0, 0}, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11,
+ 12, 13, 14, 15);
}
RKSimon wrote:
> Are we happy with using illegal types like this?
paulsemel updated this revision to Diff 153511.
paulsemel added a comment.
Fixed version problem. Now building.
Repository:
rC Clang
https://reviews.llvm.org/D47953
Files:
lib/CodeGen/CGBuiltin.cpp
Index: lib/CodeGen/CGBuiltin.cpp
=
paulsemel added a comment.
In https://reviews.llvm.org/D47953#1143044, @dblaikie wrote:
> This doesn't seem to build for me - so hard to debug/probe it:
>
> llvm/src/tools/clang/lib/CodeGen/CGBuiltin.cpp:1264:65: error: no viable
> conversion from 'clang::QualType' to 'llvm::Type *'
>
> CGF.CG
bruno added a comment.
Herald added a subscriber: dexonsmith.
Ping!
Repository:
rC Clang
https://reviews.llvm.org/D47297
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: leonardchan
Date: Fri Jun 29 10:08:19 2018
New Revision: 335993
URL: http://llvm.org/viewvc/llvm-project?rev=335993&view=rev
Log:
[Fixed Point Arithmetic] Rename `-fsame-fbits` flag
- Rename the `-fsame-fbits` flag to `-fpadding-on-unsigned-fixed-point`
- Move the flag from a driver optio
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335993: [Fixed Point Arithmetic] Rename `-fsame-fbits` flag
(authored by leonardchan, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D48727
Files:
include/clang/Basic/LangOptions.def
RKSimon added a comment.
Please can you create a llvm side parallel patch that updates the relevant
fast-isel tests
Comment at: clang/lib/Headers/avx512vlbwintrin.h:1501
+ (__v8qi){0, 0, 0, 0, 0, 0, 0, 0}, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11,
+ 12, 13, 14, 15);
}
-
arphaman added inline comments.
Comment at: lib/Sema/SemaDeclObjC.cpp:1208
+// serialize something meaningful.
+if (getLangOpts().Modules)
+ PushOnScopeChains(PDecl, TUScope);
Is this a problem only for modules or does this show up in PCHs too? What
NoQ added a comment.
That's right. You only need to mark "atomic" symbols (`SymbolData`) as live,
and expressions that contain them would automatically become live. So i think
you should just iterate through a `symbol_iterator` and mark all `SymbolData`
symbols you encounter as live.
Is this a
chh updated this revision to Diff 153532.
chh retitled this revision from "Make __gcov_flush visible outside a shared
library" to "Add llvm_gcov_flush to be called outside a shared library".
chh edited the summary of this revision.
chh added a comment.
Now keep __gcov_flush hidden as libgcov; add
thakis created this revision.
thakis added a reviewer: majnemer.
MSVC limits char16_t and char32_t string literal names to 32 bytes of character
data, not to 32 characters. wchar_t string literal names on the other hand can
get up to 64 bytes of character data.
https://reviews.llvm.org/D48781
thakis added a comment.
For your convenience: https://godbolt.org/g/KXxbKb
https://reviews.llvm.org/D48781
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
apazos added inline comments.
Comment at: lib/Sema/SemaDeclAttr.cpp:5305
+
+ if (hasFunctionProto(D) && getFunctionOrMethodNumParams(D) != 0) {
+S.Diag(D->getLocation(), diag::warn_riscv_interrupt_attribute) << 0;
aaron.ballman wrote:
> I would have assumed
srhines added a comment.
Thanks for picking this up again and updating the change to add
llvm_gcov_flush().
Comment at: test/profile/Inputs/instrprof-dlopen-dlclose-main.c:20
+ void (*gcov_flush)() = (void (*)())dlsym(f1_handle, "__gcov_flush");
+ if (gcov_flush != NULL) {
+
apazos updated this revision to Diff 153544.
https://reviews.llvm.org/D48412
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Basic/DiagnosticSemaKinds.td
lib/CodeGen/TargetInfo.cpp
lib/Sema/SemaDeclAttr.cpp
test/Sema/riscv-interrupt-attr.c
test/Sema/
marco-c added a comment.
Why keeping a __gcov_flush which is incompatible with GCC and previous versions
of LLVM and adding a __llvm_gcov_flush which is compatible? I feel the other
way around (or even just having an unhidden "__gcov_flush" and not introducing
"__llvm_gcov_flush") would be mor
Author: paquette
Date: Fri Jun 29 11:06:10 2018
New Revision: 336001
URL: http://llvm.org/viewvc/llvm-project?rev=336001&view=rev
Log:
[MachineOutliner] Make -mno-outline use -enable-machine-outliner=never
This updates -mno-outline so that it passes -enable-machine-outliner=never
instead of nothi
Author: mramalho
Date: Fri Jun 29 11:11:43 2018
New Revision: 336002
URL: http://llvm.org/viewvc/llvm-project?rev=336002&view=rev
Log:
[analyzer] Replace the vector of ConstraintSets by a single ConstraintSet and a
function to merge ConstraintSets
Now, instead of adding the constraints when they
This revision was automatically updated to reflect the committed changes.
Closed by commit rC336002: [analyzer] Replace the vector of ConstraintSets by a
single ConstraintSet and a… (authored by mramalho, committed by ).
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://revi
Hello Richard,
This commit broke tests at one of our builders:
http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/10599
Failing Tests (1):
Clang :: CXX/conv/conv.prom/p5.cpp
Please have a look?
Thanks
Galina
On Thu, Jun 28, 2018 at 2:17 PM, Richard Smith via c
davidxl added a comment.
With the current gcov_flush implementation in LLVM, making gcov_flush's
visibility to be default will simply lead to wrong behavior. GCC libgcov's
implementation is more elaborate -- it allows gcov_flush to dump gcda data for
all dynamic objects while making sure gcov
Yeah, doesn't look like this code handles a value crossing the boundary of
the size of the bitfield type (it's reading only the low bit).
I suspect looking at the code that generates bitfield accesses would be
useful - and/or maybe actually calling into that very code, rather than
reimplementing i
dblaikie added a subscriber: paulsemel.
dblaikie added a comment.
Yeah, doesn't look like this code handles a value crossing the boundary of
the size of the bitfield type (it's reading only the low bit).
I suspect looking at the code that generates bitfield accesses would be
useful - and/or maybe
bruno added inline comments.
Comment at: lib/Sema/SemaDeclObjC.cpp:1208
+// serialize something meaningful.
+if (getLangOpts().Modules)
+ PushOnScopeChains(PDecl, TUScope);
arphaman wrote:
> Is this a problem only for modules or does this show up in
chh added a comment.
Marco, latest patch does not change __gcov_flush, which is also hidden in
libgcov.
Android coverage test programs have depended on an earlier compiler-rt that did
not hide __gcov_flush.
If that's the only use case broken by recent change of compiler-rt, which hide
__gcov_fl
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
Thanks for explaining! LGTM
Repository:
rC Clang
https://reviews.llvm.org/D47297
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
aaron.ballman added inline comments.
Comment at: lib/Sema/SemaDeclAttr.cpp:5305
+
+ if (hasFunctionProto(D) && getFunctionOrMethodNumParams(D) != 0) {
+S.Diag(D->getLocation(), diag::warn_riscv_interrupt_attribute) << 0;
apazos wrote:
> aaron.ballman wrote:
rupprecht created this revision.
Herald added subscribers: cfe-commits, christof.
Repository:
rUNW libunwind
https://reviews.llvm.org/D48785
Files:
docs/README.txt
Index: docs/README.txt
===
--- docs/README.txt
+++ docs/README
This revision was automatically updated to reflect the committed changes.
Closed by commit rC336004: [mips][ias] Enable IAS by default for OpenBSD /
FreeBSD mips64/mips64el. (authored by brad, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48515?vs=152580&id=153550#toc
Repo
Author: brad
Date: Fri Jun 29 12:03:03 2018
New Revision: 336004
URL: http://llvm.org/viewvc/llvm-project?rev=336004&view=rev
Log:
[mips][ias] Enable IAS by default for OpenBSD / FreeBSD mips64/mips64el.
Reviewers: atanasyan
Differential Revision: https://reviews.llvm.org/D48515
Modified:
c
Author: rupprecht
Date: Fri Jun 29 12:05:21 2018
New Revision: 336006
URL: http://llvm.org/viewvc/llvm-project?rev=336006&view=rev
Log:
Add a blank line to docs/README.txt test commit access
Subscribers: christof, cfe-commits
Differential Revision: https://reviews.llvm.org/D48785
Modified:
Author: rupprecht
Date: Fri Jun 29 12:05:20 2018
New Revision: 336005
URL: http://llvm.org/viewvc/llvm-project?rev=336005&view=rev
Log:
Revert "Support for multiarch runtimes layout"
This reverts commit 0c7cea3c0c6338b99e30c13201365a3dd4edc6f4.
Modified:
libunwind/trunk/CMakeLists.txt
Modif
This revision was automatically updated to reflect the committed changes.
Closed by commit rL336006: Add a blank line to docs/README.txt test commit
access (authored by rupprecht, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D48785
File
vsapsai created this revision.
vsapsai added reviewers: bruno, rsmith.
Herald added a subscriber: dexonsmith.
Fixes a problem when we have multiple inclusion cycles and try to
enumerate all possible ways to reach the max inclusion depth.
rdar://problem/38871876
https://reviews.llvm.org/D48786
Author: dim
Date: Fri Jun 29 12:18:17 2018
New Revision: 336008
URL: http://llvm.org/viewvc/llvm-project?rev=336008&view=rev
Log:
Request init/fini array on FreeBSD 12 and later
Summary:
It seems a bad idea to change the default in the middle of a release
branch due to possible changes in global
This revision was automatically updated to reflect the committed changes.
Closed by commit rL336008: Request init/fini array on FreeBSD 12 and later
(authored by dim, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D24867?vs=72282&id=15
benhamilton accepted this revision.
benhamilton added a comment.
This revision is now accepted and ready to land.
Nice improvement!
Repository:
rC Clang
https://reviews.llvm.org/D48719
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
OK! Sounds good to me to keep it hidden until
https://reviews.llvm.org/D48538 is done (I'm going to try to finish it
soon).
Il 29/06/2018 19:34, David Li via Phabricator ha scritto:
> davidxl added a comment.
>
> With the current gcov_flush implementation in LLVM, making gcov_flush's
> visibilit
marco-c added a comment.
OK! Sounds good to me to keep it hidden until
https://reviews.llvm.org/D48538 is done (I'm going to try to finish it
soon).
Il 29/06/2018 19:34, David Li via Phabricator ha scritto:
> davidxl added a comment.
>
> With the current gcov_flush implementation in LLVM, makin
rupprecht created this revision.
Herald added subscribers: cfe-commits, christof, mgorny.
Repository:
rUNW libunwind
https://reviews.llvm.org/D48787
Files:
CMakeLists.txt
Index: CMakeLists.txt
===
--- CMakeLists.txt
+++ CMakeL
erik.pilkington added a comment.
Herald added a subscriber: dexonsmith.
Ping!
Repository:
rC Clang
https://reviews.llvm.org/D48322
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
benhamilton accepted this revision.
benhamilton added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/Format/ContinuationIndenter.cpp:1411
+ // line).
+ if (Current.MatchingParen && Current.MatchingParen->Previous) {
+const FormatToken &Cur
rsmith added a comment.
Hmm, so this will mean that we can have internal linkage declarations marked
`Used` for which there is no definition, and we need to not warn on that.
I think it might be better to avoid marking things used in this case (even
though they're still technically odr-used).
malaperle added inline comments.
Comment at: clangd/FindSymbols.cpp:181
+/// Finds document symbols in the main file of the AST.
+class DocumentSymbolsConsumer : public index::IndexDataConsumer {
+ ASTContext &AST;
sammccall wrote:
> I guess the alternative here
Author: echristo
Date: Fri Jun 29 13:27:40 2018
New Revision: 336012
URL: http://llvm.org/viewvc/llvm-project?rev=336012&view=rev
Log:
Revert "Revert "Support for multiarch runtimes layout""
This reverts commit r336005 that was accidentally committed.
Modified:
libunwind/trunk/CMakeLists.txt
ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D48616
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
Author: rsmith
Date: Fri Jun 29 13:41:23 2018
New Revision: 336013
URL: http://llvm.org/viewvc/llvm-project?rev=336013&view=rev
Log:
Specify an explicit underlying type for this enum to fix Windows
buildbots.
On Windows targets, enums always get an underlying type of 'int', even
if they have wide
Author: rupprecht
Date: Fri Jun 29 13:41:50 2018
New Revision: 336014
URL: http://llvm.org/viewvc/llvm-project?rev=336014&view=rev
Log:
Introduce a separate preprocessor macro, _LIBUNWIND_USE_DLADDR, for directly
controlling a dependency on dladdr(). This will allow us to use libunwind
without a
This revision was automatically updated to reflect the committed changes.
Closed by commit rL336014: Introduce a separate preprocessor macro,
_LIBUNWIND_USE_DLADDR, for directly… (authored by rupprecht, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://review
Should be fixed in r336013. Thanks for pointing this out.
On Fri, 29 Jun 2018 at 11:24, Galina Kistanova via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hello Richard,
>
> This commit broke tests at one of our builders:
>
> http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-chec
Author: rsmith
Date: Fri Jun 29 13:46:25 2018
New Revision: 336016
URL: http://llvm.org/viewvc/llvm-project?rev=336016&view=rev
Log:
[modules] Emit the type of the TypeSourceInfo for a DeclaratorDecl (but
not the corresponding location information) earlier.
We need the type as written in order to
chh updated this revision to Diff 153569.
chh marked an inline comment as done.
chh added a comment.
Added calls to dlerror() before other dl* functions.
https://reviews.llvm.org/D45454
Files:
lib/profile/GCDAProfiling.c
test/profile/Inputs/instrprof-dlopen-dlclose-main.c
Index: test/prof
davidxl added inline comments.
Comment at: lib/profile/GCDAProfiling.c:546
+// find and call. In that case, it dumps profile data of a .so file.
+// If it is called directly inside a .so file, the unified copy of
+// llvm_gcov_flush might dump data of other .so file or the main m
chh updated this revision to Diff 153573.
chh added a comment.
check dlerror() where it shouldn't be NULL
https://reviews.llvm.org/D45454
Files:
lib/profile/GCDAProfiling.c
test/profile/Inputs/instrprof-dlopen-dlclose-main.c
Index: test/profile/Inputs/instrprof-dlopen-dlclose-main.c
=
chh added inline comments.
Comment at: test/profile/Inputs/instrprof-dlopen-dlclose-main.c:20
+ void (*gcov_flush)() = (void (*)())dlsym(f1_handle, "__gcov_flush");
+ if (gcov_flush != NULL) {
+fprintf(stderr, "__gcov_flush should not be visible in func.shared'\n");
---
srhines added a comment.
LGTM. Thanks for making the checking more clear. This should help bridge the
gap for now, so that we can resume getting per-library profile data in Android.
https://reviews.llvm.org/D45454
___
cfe-commits mailing list
cfe-c
1 - 100 of 136 matches
Mail list logo
