kosarev added a comment.
Ping.
https://reviews.llvm.org/D48440
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
klimek added inline comments.
Comment at: unittests/Format/FormatTest.cpp:4449-4450
+ " })\n"
+ "
.foo(\"aaa\"\n"
+ " \"bb\");\n"
+
ebevhan added a comment.
Herald added a subscriber: mikhail.ramalho.
Ping.
https://reviews.llvm.org/D46944
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ebevhan added inline comments.
Comment at: lib/AST/ExprConstant.cpp:9501
+ return false;
+return Success(Result.getInt() >> Scale, E);
+ }
ebevhan wrote:
> The shift here will not produce the correct rounding behavior for fixed-point
> to integer conve
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
Repository:
rC Clang
https://reviews.llvm.org/D48363
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
rogfer01 added inline comments.
Comment at: include/clang/CodeGen/CGFunctionInfo.h:475
+static_assert(std::is_trivially_copyable::value,
+"ABIArgInfo must be trivially copyable as it is embedded as trailing "
I think this is the right trait here. I spent to
rogfer01 created this revision.
rogfer01 added a reviewer: rjmccall.
This is WIP and it is motivated by the suggestions in
http://lists.llvm.org/pipermail/cfe-dev/2018-June/058263.html
First attempt, piggybacking the extend information in a structure where the
bit-width of the integer represent
a.sidorin added a comment.
Hi Gabor!
I like the change but there are also some questions.
Comment at: lib/AST/ASTImporter.cpp:1659
+ AccessSpecDecl *ToD;
+ std::tie(ToD, AlreadyImported) = CreateDecl(
+ D, Importer.getToContext(), D->getAccess(), DC, Loc, ColonLoc);
---
a.sidorin accepted this revision.
a.sidorin added a comment.
This revision is now accepted and ready to land.
Thank you!
When committing, please change the commit message (the current review
description is out-of-date) and mention the reformatting done.
Repository:
rC Clang
https://reviews.
a.sidorin accepted this revision.
a.sidorin added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rC Clang
https://reviews.llvm.org/D47450
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
MarcoFalke updated this revision to Diff 152867.
MarcoFalke added a comment.
Keep python2 by default for now
https://reviews.llvm.org/D48098
Files:
tools/clang-format/clang-format-diff.py
Index: tools/clang-format/clang-format-diff.py
ank added inline comments.
Comment at: unittests/Format/FormatTest.cpp:4449-4450
+ " })\n"
+ "
.foo(\"aaa\"\n"
+ " \"bb\");\n"
+
atanasyan added inline comments.
Comment at: lib/Driver/ToolChains/FreeBSD.cpp:197
+CmdArgs.push_back("-m");
+CmdArgs.push_back("elf64ltsmip_fbsd");
+break;
Does it make a sense to handle N32 ABI case here?
Repository:
rC Clang
https://reviews.ll
ank updated this revision to Diff 152870.
Repository:
rC Clang
https://reviews.llvm.org/D45719
Files:
lib/Format/ContinuationIndenter.cpp
lib/Format/FormatToken.h
unittests/Format/FormatTest.cpp
Index: unittests/Format/FormatTest.cpp
atanasyan added a comment.
LGTM, but before commit please add a test case into the freebsd.c.
Repository:
rC Clang
https://reviews.llvm.org/D48515
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
a.sidorin accepted this revision.
a.sidorin added a comment.
This revision is now accepted and ready to land.
Hi Bevin,
The patch looks good to me. But let's wait for maintainers to approve it. @NoQ
, could you take a look?
https://reviews.llvm.org/D46944
___
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
LG.
Repository:
rC Clang
https://reviews.llvm.org/D45719
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
Author: krasimir
Date: Tue Jun 26 05:00:14 2018
New Revision: 335595
URL: http://llvm.org/viewvc/llvm-project?rev=335595&view=rev
Log:
[clang-format] Enable text proto formatting in common functions
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D48363
Modified:
cf
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335595: [clang-format] Enable text proto formatting in
common functions (authored by krasimir, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D483
yamaguchi updated this revision to Diff 152875.
yamaguchi added a comment.
Add #import test and add branch AllowExtraModuleMapSearch when ModuleName was
from @import
https://reviews.llvm.org/D48367
Files:
clang/include/clang/Lex/HeaderSearch.h
clang/lib/Frontend/CompilerInstance.cpp
clan
yamaguchi added inline comments.
Comment at: clang/lib/Lex/HeaderSearch.cpp:285
// directory.
-loadSubdirectoryModuleMaps(SearchDirs[Idx]);
+if (ModMap.getLangOpts().ObjC1 || ModMap.getLangOpts().ObjC2)
+ loadSubdirectoryModuleMaps(SearchDirs[Idx]);
yamaguchi updated this revision to Diff 152876.
yamaguchi added a comment.
Delete a.out)
https://reviews.llvm.org/D48367
Files:
clang/include/clang/Lex/HeaderSearch.h
clang/lib/Frontend/CompilerInstance.cpp
clang/lib/Lex/HeaderSearch.cpp
clang/lib/Serialization/ASTReader.cpp
clang/tes
Author: ioeric
Date: Tue Jun 26 05:49:09 2018
New Revision: 335598
URL: http://llvm.org/viewvc/llvm-project?rev=335598&view=rev
Log:
[clangd] Use default clang-format styles.
Modified:
clang-tools-extra/trunk/clangd/ClangdServer.cpp
clang-tools-extra/trunk/clangd/CodeComplete.cpp
Modifie
Thank you for your reproducer. I debugged it and found the issue.
ngettext is defined as follows.
extern char *ngettext (const char *__msgid1, const char *__msgid2,
unsigned long int __n)
throw () __attribute__ ((__format_arg__ (1))) __attribute__
((__format_arg__ (2)));
Indeed, two
hans added a comment.
This looks reasonable to me as far as I can tell. Thanks!
I think the expert on the driver side for this stuff is Nico, so hopefully he
can take a look as well.
Comment at: include/clang/Basic/DiagnosticLexKinds.td:412
+ "%select{create|use}1 precompile
atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D48499
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
Author: martong
Date: Tue Jun 26 06:44:24 2018
New Revision: 335600
URL: http://llvm.org/viewvc/llvm-project?rev=335600&view=rev
Log:
[ASTImporter] Use InjectedClassNameType at import of templated record.
Summary:
At import of a record describing a template set its type to
InjectedClassNameType (
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335600: [ASTImporter] Use InjectedClassNameType at import of
templated record. (authored by martong, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D47450?vs=152634&id=152880#toc
Rep
r.stahl added a comment.
@rsmith do you have a chance to take a look or assign someone else?
https://reviews.llvm.org/D46940
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
JDevlieghere added a comment.
I tested this patch on the LLDB test suite and all tests passed.
What I did was:
- I removed the DWARF version check in clang so this was always generated.
- I commented out the code that reads the .apple_objc accelerator tables in
DWARFASTParserClang.cpp (which as
JDevlieghere updated this revision to Diff 152883.
JDevlieghere added a comment.
- Update diff to version I used for testing (modulo the removed DWARF version
check)
https://reviews.llvm.org/D48241
Files:
lib/CodeGen/CGDebugInfo.cpp
lib/CodeGen/CGDebugInfo.h
Index: lib/CodeGen/CGDebugInf
erik.pilkington added a comment.
Hi Volodymyr, thanks for working on this!
Comment at: libcxx/include/memory:1479
+struct __has_construct_missing
+: false_type
+{
Shouldn't this be true_type?
Comment at: libcxx/include/memory:1673-1677
+
tejohnson added a comment.
ping (assuming this is ok, but since I sent for review...)
Repository:
rC Clang
https://reviews.llvm.org/D47906
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
jkorous added inline comments.
Comment at: xpc/test-client/ClangdXPCTestClient.cpp:51
+ dlHandle, "clangd_xpc_get_bundle_identifier");
+ xpc_connection_t conn =
+ xpc_connection_create(clangd_xpc_get_bundle_identifier(), NULL);
arphaman wrote:
> We
jkorous updated this revision to Diff 152888.
jkorous added a comment.
Two changes in test client based on internal review by XPC folks:
- Removed cleanup code at the end of main() as dispatch_main() never returns.
- Removed check for conn as xpc_connection_create() is guaranteed to succeed.
ht
Author: rksimon
Date: Tue Jun 26 08:20:20 2018
New Revision: 335614
URL: http://llvm.org/viewvc/llvm-project?rev=335614&view=rev
Log:
Avoid spurious 'comma operator within array index expression' MSVC warning.
NFCI.
Split the braces list initialization from the [] map operator to keep MSVC
happ
dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rC Clang
https://reviews.llvm.org/D47906
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
JDevlieghere updated this revision to Diff 152896.
JDevlieghere added a comment.
- Re-add test case (forgot to stage it for last patch)
https://reviews.llvm.org/D48241
Files:
lib/CodeGen/CGDebugInfo.cpp
lib/CodeGen/CGDebugInfo.h
test/CodeGenObjC/debug-info-category.m
Index: test/CodeGenO
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335618: [ThinLTO] Add testing of summary index parsing to a
couple CFI tests (authored by tejohnson, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D47906?vs=150402&id=152899#toc
Rep
Author: tejohnson
Date: Tue Jun 26 08:50:34 2018
New Revision: 335618
URL: http://llvm.org/viewvc/llvm-project?rev=335618&view=rev
Log:
[ThinLTO] Add testing of summary index parsing to a couple CFI tests
Summary:
Changes to some clang side tests to go with the summary parsing patch.
Depends on
aprantl added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:4246
+ if (it == TypeCache.end())
+continue;
+
What does it mean that a type is not being found in the cache here?
Comment at: lib/CodeGen/CGDebugInfo.h:102
+
Szelethus added a comment.
Polite ping :)
https://reviews.llvm.org/D48325
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bsdjhb added inline comments.
Comment at: lib/Driver/ToolChains/FreeBSD.cpp:197
+CmdArgs.push_back("-m");
+CmdArgs.push_back("elf64ltsmip_fbsd");
+break;
atanasyan wrote:
> Does it make a sense to handle N32 ABI case here?
For whatever reason, FreeBSD
atanasyan accepted this revision.
atanasyan added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/Driver/ToolChains/FreeBSD.cpp:197
+CmdArgs.push_back("-m");
+CmdArgs.push_back("elf64ltsmip_fbsd");
+break;
bsdjhb wrot
cryptoad updated this revision to Diff 152900.
cryptoad added a comment.
Rebasing.
Repository:
rC Clang
https://reviews.llvm.org/D48570
Files:
lib/Driver/ToolChains/CommonArgs.cpp
test/Driver/sanitizer-ld.c
Index: test/Driver/sanitizer-ld.c
=
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335620: [Driver] Do not add -lpthread & -lrt with
-static-libsan on Android (authored by cryptoad, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48570?vs=152900&id=152901#toc
Repos
Author: cryptoad
Date: Tue Jun 26 09:14:35 2018
New Revision: 335620
URL: http://llvm.org/viewvc/llvm-project?rev=335620&view=rev
Log:
[Driver] Do not add -lpthread & -lrt with -static-libsan on Android
Summary:
I am not sure anyone has tried to compile an application with sanitizers on
Android w
martong added inline comments.
Comment at: lib/AST/ASTImporter.cpp:1659
+ AccessSpecDecl *ToD;
+ std::tie(ToD, AlreadyImported) = CreateDecl(
+ D, Importer.getToContext(), D->getAccess(), DC, Loc, ColonLoc);
a.sidorin wrote:
> As I see, all usage samples r
dexonsmith added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:3355
+ QualType QTy(ID->getTypeForDecl(), 0);
+ auto it = TypeCache.find(QTy.getAsOpaquePtr());
+ if (it != TypeCache.end()) {
LLVM style rules suggest UpperCamelCase or INIT
malaperle accepted this revision.
malaperle added a comment.
This revision is now accepted and ready to land.
Self-approving because this is pretty inconsequential.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47847
___
cfe-commit
Author: malaperle
Date: Tue Jun 26 09:57:44 2018
New Revision: 335624
URL: http://llvm.org/viewvc/llvm-project?rev=335624&view=rev
Log:
[clangd] Simplify matches in FindSymbols tests
Summary:
Instead of checking symbol name and container (scope) separately, check the
qualified name instead. This
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335624: [clangd] Simplify matches in FindSymbols tests
(authored by malaperle, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D47847
Files:
cla
JDevlieghere updated this revision to Diff 152910.
JDevlieghere marked 6 inline comments as done.
JDevlieghere added a comment.
- Feedback Adrian & Duncan
https://reviews.llvm.org/D48241
Files:
lib/CodeGen/CGDebugInfo.cpp
lib/CodeGen/CGDebugInfo.h
test/CodeGenObjC/debug-info-category.m
I
JDevlieghere added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:4239
+// Add methods to interface.
+for (auto p : ObjCMethodCache) {
+ if (p.second.empty())
dexonsmith wrote:
> Some comment for "p" here.
Fixed; I'll update the rest of the
Author: rksimon
Date: Tue Jun 26 10:00:43 2018
New Revision: 335626
URL: http://llvm.org/viewvc/llvm-project?rev=335626&view=rev
Log:
Fix -Wdocumentation warning. NFCI.
Modified:
clang-tools-extra/trunk/clangd/Headers.h
Modified: clang-tools-extra/trunk/clangd/Headers.h
URL:
http://llvm.org
Author: thegameg
Date: Tue Jun 26 10:05:01 2018
New Revision: 335628
URL: http://llvm.org/viewvc/llvm-project?rev=335628&view=rev
Log:
Revert "[CMake][Darwin] Match cxx-headers -> cxx_headers libcxx target rename."
This reverts commit r334550. Try to fix the stage2 build failing on
Green Dragon f
Author: aaronenyeshi
Date: Tue Jun 26 10:12:29 2018
New Revision: 335630
URL: http://llvm.org/viewvc/llvm-project?rev=335630&view=rev
Log:
[Test] Initial test commit access
Modified:
cfe/trunk/lib/Driver/ToolChains/HIP.cpp
Modified: cfe/trunk/lib/Driver/ToolChains/HIP.cpp
URL:
http://llvm.o
Author: abataev
Date: Tue Jun 26 10:24:03 2018
New Revision: 335632
URL: http://llvm.org/viewvc/llvm-project?rev=335632&view=rev
Log:
[OPENMP, NVPTX] Reduce the number of the globalized variables.
Patch tries to make better analysis of the variables that should be
globalized. From now, instead of
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335634: [HIP] Remove hip/hc.amdgcn.bc from HIP Toolchains
(authored by aaronenyeshi, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D48455?vs=
aprantl added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:4239
+// Add methods to interface.
+for (auto p : ObjCMethodCache) {
+ if (p.second.empty())
JDevlieghere wrote:
> dexonsmith wrote:
> > Some comment for "p" here.
> Fixed; I'll u
Author: aaronenyeshi
Date: Tue Jun 26 10:40:36 2018
New Revision: 335634
URL: http://llvm.org/viewvc/llvm-project?rev=335634&view=rev
Log:
[HIP] Remove hip/hc.amdgcn.bc from HIP Toolchains
Summary:
The hc.amdgcn.bc and hip.amdgcn.bc are removed in VDI build and no longer
needed.
Reviewers: yaxu
Author: pcc
Date: Tue Jun 26 10:45:26 2018
New Revision: 335636
URL: http://llvm.org/viewvc/llvm-project?rev=335636&view=rev
Log:
Compile CodeGenModule.cpp with /bigobj.
Apparently we're now hitting an object file section limit on this
file with expensive checks enabled.
Modified:
cfe/trunk/
Author: vsapsai
Date: Tue Jun 26 10:56:48 2018
New Revision: 335638
URL: http://llvm.org/viewvc/llvm-project?rev=335638&view=rev
Log:
[Sema] Fix infinite typo correction loop.
NumTypos guard value ~0U doesn't prevent from creating new delayed typos. When
you create new delayed typos during typo c
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335638: [Sema] Fix infinite typo correction loop. (authored
by vsapsai, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D47341?vs=148841&id=152924#toc
Repository:
rC Clang
https://
vsapsai added a comment.
Thanks for the review, Richard.
Repository:
rC Clang
https://reviews.llvm.org/D47341
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
george.karpenkov accepted this revision.
george.karpenkov added a comment.
This revision is now accepted and ready to land.
> My fear of using file IDs is that I don't know whether they are stable
IIRC they are currently stable, but that's relying on implementation details.
Still better than not
vsapsai planned changes to this revision.
vsapsai added inline comments.
Comment at: libcxx/include/memory:1479
+struct __has_construct_missing
+: false_type
+{
erik.pilkington wrote:
> Shouldn't this be true_type?
I see this is confusing and I'm still strugg
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335641: [Hexagon] Add a "generic" cpu (authored by
bcahoon, committed by ).
Herald added a subscriber: llvm-commits.
Chan
j10kay created this revision.
j10kay added reviewers: hans, inglorion, rnk.
Herald added subscribers: llvm-commits, hiraditya.
New flag causes crash reports to be written in the specified directory
rather than the temp directory.
Repository:
rL LLVM
https://reviews.llvm.org/D48601
Files:
c
dblaikie added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:4239
+// Add methods to interface.
+for (auto p : ObjCMethodCache) {
+ if (p.second.empty())
aprantl wrote:
> JDevlieghere wrote:
> > dexonsmith wrote:
> > > Some comment for "p"
rjmccall added inline comments.
Comment at: include/clang/CodeGen/CGFunctionInfo.h:90
union {
-unsigned DirectOffset; // isDirect() || isExtend()
-unsigned IndirectAlign;// isIndirect()
-unsigned AllocaFieldIndex; // isInAlloca()
+llvm::StructType *Exte
Wawha marked 2 inline comments as done.
Wawha added a comment.
Hello,
after my last modification (require by previous comment), I do not see any
feedback or validation for this patch.
Is their something special to do in order to go forward on this patch?
Lambda are more an more used in modern
zturner added inline comments.
Comment at: clang/lib/Driver/Driver.cpp:4043-4044
+if (CCGenDiagnostics && A) {
+ SmallString<128> CrashDirectory;
+ CrashDirectory = A->getValue();
+ llvm::sys::path::append(CrashDirectory, Split.first);
Maybe yo
kparzysz reopened this revision.
kparzysz added a comment.
This needs to be restored to the original form. A mistake in a commit message
closed this review by accident.
Repository:
rL LLVM
https://reviews.llvm.org/D48571
___
cfe-commits mailing
arsenm added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:3500
+if (auto *PtrTy = dyn_cast(PTy)) {
+ if (PtrTy->getAddressSpace() !=
+ ArgValue->getType()->getPointerAddressSpace()) {
Anastasia wrote:
> arsenm wrote:
> > An
Author: jhb
Date: Tue Jun 26 12:48:05 2018
New Revision: 335653
URL: http://llvm.org/viewvc/llvm-project?rev=335653&view=rev
Log:
[mips] Use more conservative default CPUs for MIPS on FreeBSD.
FreeBSD defaults to mips3 for all MIPS ABIs with GCC as that is the
minimum MIPS architecture FreeBSD su
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335653: [mips] Use more conservative default CPUs for MIPS
on FreeBSD. (authored by jhb, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48499?vs=152522&id=152944#toc
Repository:
r
kparzysz updated this revision to Diff 152946.
kparzysz added a comment.
Restored the original patch.
Repository:
rL LLVM
https://reviews.llvm.org/D48571
Files:
include/clang/Basic/BitmaskEnum.h
include/clang/Parse/Parser.h
include/clang/Parse/RAIIObjectsForParser.h
include/clang/Sem
kparzysz added a comment.
Please take over, I commandeered to restore the patch.
Repository:
rL LLVM
https://reviews.llvm.org/D48571
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
rjmccall added inline comments.
Comment at: include/clang/AST/ASTContext.h:1954
+ llvm::APInt getFixedPointMin(QualType Ty) const;
+ llvm::APInt getFixedPointOne(QualType Ty) const;
ebevhan wrote:
> rjmccall wrote:
> > Are these opaque bit-patterns? I think
Author: modocache
Date: Tue Jun 26 13:05:18 2018
New Revision: 335655
URL: http://llvm.org/viewvc/llvm-project?rev=335655&view=rev
Log:
[AST] Fix typo in LazyOffsetPtr::get docs (NFC)
Modified:
cfe/trunk/include/clang/AST/ExternalASTSource.h
Modified: cfe/trunk/include/clang/AST/ExternalAST
malaperle updated this revision to Diff 152953.
malaperle added a comment.
Rebased.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47846
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/FindSymbols.cpp
c
bsdjhb updated this revision to Diff 152955.
bsdjhb added a comment.
- Add N32EL.
Repository:
rC Clang
https://reviews.llvm.org/D48507
Files:
lib/Driver/ToolChains/FreeBSD.cpp
test/Driver/freebsd.c
Index: test/Driver/freebsd.c
===
rogfer01 added inline comments.
Comment at: include/clang/CodeGen/CGFunctionInfo.h:90
union {
-unsigned DirectOffset; // isDirect() || isExtend()
-unsigned IndirectAlign;// isIndirect()
-unsigned AllocaFieldIndex; // isInAlloca()
+llvm::StructType *Exte
chh updated this revision to Diff 152957.
chh edited the summary of this revision.
https://reviews.llvm.org/D45454
Files:
lib/profile/GCDAProfiling.c
test/profile/Inputs/instrprof-dlopen-dlclose-main.c
Index: test/profile/Inputs/instrprof-dlopen-dlclose-main.c
==
malaperle updated this revision to Diff 152958.
malaperle added a comment.
Rebased.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48159
Files:
clangd/XRefs.cpp
unittests/clangd/TestTU.cpp
unittests/clangd/TestTU.h
unittests/clangd/XRefsTests.cpp
Index: unittests/clang
Wouldn't it be better to keep compatibility with GCC and make
__gcov_flush have default visibility?
- Marco.
Il 26/06/2018 00:21, Xinliang David Li ha scritto:
> I don't have an objection having another interface which is just a
> simple wrapper to __gcov_flush but with default visibility. Also
Author: george.karpenkov
Date: Tue Jun 26 14:12:08 2018
New Revision: 335666
URL: http://llvm.org/viewvc/llvm-project?rev=335666&view=rev
Log:
[analyzer] Do not run visitors until the fixpoint, run only once.
In the current implementation, we run visitors until the fixed point is
reached.
That is
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, george.karpenkov.
Herald added subscribers: cfe-commits, mikhail.ramalho, a.sidorin, rnkovacs,
szepet, baloghadamsoftware.
This patch extends https://reviews.llvm.org/D44120 to Objective-C messages that
can also sometimes retu
rjmccall added inline comments.
Comment at: include/clang/CodeGen/CGFunctionInfo.h:90
union {
-unsigned DirectOffset; // isDirect() || isExtend()
-unsigned IndirectAlign;// isIndirect()
-unsigned AllocaFieldIndex; // isInAlloca()
+llvm::StructType *Exte
davidxl added a comment.
GCC's behavior is not documented and it also has changed over the years.
Unless there is a bug, changing LLVM's gcov_flush visibility can potentially
break clients that depend on this behavior.
https://reviews.llvm.org/D45454
srhines added a comment.
In https://reviews.llvm.org/D45454#1144099, @davidxl wrote:
> GCC's behavior is not documented and it also has changed over the years.
>
> Unless there is a bug, changing LLVM's gcov_flush visibility can potentially
> break clients that depend on this behavior.
I think
Yes, the behavior changed very recently, I would be surprised if
somebody came to depend on it. It's more likely that some clients are
depending on the old behavior.
- Marco.
Il 26/06/2018 22:43, Stephen Hines via Phabricator ha scritto:
> srhines added a comment.
>
> In https://reviews.llvm.org
marco-c added a comment.
Yes, the behavior changed very recently, I would be surprised if
somebody came to depend on it. It's more likely that some clients are
depending on the old behavior.
- Marco.
Il 26/06/2018 22:43, Stephen Hines via Phabricator ha scritto:
> srhines added a comment.
>
>
dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.
Looks pretty good to me - nice work!
Repository:
rL LLVM
https://reviews.llvm.org/D48571
___
cfe-commits mailing list
cfe-commits@lists.ll
tra created this revision.
tra added a reviewer: jlebar.
Herald added subscribers: bixia, sanjoy.
This matches the way NVCC does it. Doing module cleanup at global
destructor phase used to work, but is, apparently, too late for
the CUDA runtime in CUDA-9.2, which ends up crashing with double-free.
Author: paquette
Date: Tue Jun 26 15:09:48 2018
New Revision: 335672
URL: http://llvm.org/viewvc/llvm-project?rev=335672&view=rev
Log:
[MachineOutliner] Emit a warning when using -moutline on unsupported targets
Instead of just saying "flag unused", we should tell the user that the
outliner isn't
tra created this revision.
tra added a reviewer: Hahnfeld.
Herald added subscribers: bixia, jlebar, sanjoy.
That's where CUDA SDK binaries appear to put them on Mac.
https://reviews.llvm.org/D48615
Files:
clang/lib/CodeGen/CGCUDANV.cpp
Index: clang/lib/CodeGen/CGCUDANV.cpp
=
mclow.lists created this revision.
mclow.lists added reviewers: EricWF, ldionne, STL_MSFT.
A massive amount of doinking around in .
https://cplusplus.github.io/LWG/issue2946
https://cplusplus.github.io/LWG/issue3075
https://cplusplus.github.io/LWG/issue3076
This is not quite right yet, but
mclow.lists added a comment.
Ok, for some reason, the four tests that I *added* didn't get into the diff.
https://reviews.llvm.org/D48616
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
1 - 100 of 146 matches
Mail list logo
