dexonsmith added inline comments.
================
Comment at: lib/CodeGen/CGDebugInfo.cpp:3355
+ QualType QTy(ID->getTypeForDecl(), 0);
+ auto it = TypeCache.find(QTy.getAsOpaquePtr());
+ if (it != TypeCache.end()) {
----------------
LLVM style rules suggest UpperCamelCase or INITIALISM rather than "it" here:
https://www.llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly
================
Comment at: lib/CodeGen/CGDebugInfo.cpp:4239
+ // Add methods to interface.
+ for (auto p : ObjCMethodCache) {
+ if (p.second.empty())
----------------
Some comment for "p" here.
================
Comment at: lib/CodeGen/CGDebugInfo.cpp:4244
+ QualType QTy(p.first->getTypeForDecl(), 0);
+ auto it = TypeCache.find(QTy.getAsOpaquePtr());
+ if (it == TypeCache.end())
----------------
And "it" here.
https://reviews.llvm.org/D48241
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
