Author: sammccall
Date: Wed Jun 6 23:55:59 2018
New Revision: 334162
URL: http://llvm.org/viewvc/llvm-project?rev=334162&view=rev
Log:
[clangd] Make workspace/symbols actually rank its results.
Summary: The index doesn't actually return results in ranked order.
Reviewers: hokein
Subscribers: i
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334162: [clangd] Make workspace/symbols actually rank its
results. (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D478
ebevhan added a comment.
Yes, it looks good to me.
Repository:
rC Clang
https://reviews.llvm.org/D46911
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added subscribers: jkorous, MaskRay, ioeric, ilya-biryukov.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47869
Files:
clangd/ClangdServer.cpp
Index: clangd/ClangdServer.cpp
krasimir updated this revision to Diff 150273.
krasimir added a comment.
- Polish
Repository:
rC Clang
https://reviews.llvm.org/D46757
Files:
lib/Format/ContinuationIndenter.cpp
lib/Format/TokenAnnotator.cpp
lib/Format/UnwrappedLineFormatter.cpp
unittests/Format/FormatTestProto.cpp
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/ClangdServer.cpp:305
return CB(InpAST.takeError());
-CB(clangd::findDefinitions(InpAST->AST, Pos, this->FileIdx.get()));
+CB(clang
Author: sammccall
Date: Thu Jun 7 01:16:36 2018
New Revision: 334170
URL: http://llvm.org/viewvc/llvm-project?rev=334170&view=rev
Log:
[clangd] fix unintended fallthrough in scope-based scoring
Modified:
clang-tools-extra/trunk/clangd/Quality.cpp
Modified: clang-tools-extra/trunk/clangd/Qua
Hahnfeld added a comment.
IMO this goes into the right direction, we should use the fast implementation
in libdevice. If LLVM doesn't lower these calls in the NVPTX backend, I think
it's ok to use header wrappers as CUDA already does.
Two questions:
1. Can you explain where this is important f
krasimir created this revision.
Herald added a subscriber: cfe-commits.
We were missing the case when python-style comments in text protos start with
`##`.
Repository:
rC Clang
https://reviews.llvm.org/D47870
Files:
lib/Format/BreakableToken.cpp
lib/Format/FormatTokenLexer.cpp
unittes
ebevhan added inline comments.
Comment at: include/clang/AST/Type.h:6552
+// as a scaled integer.
+std::string FixedPointValueToString(unsigned Radix, unsigned Scale,
+uint64_t Val);
This should probably take an APInt or APSInt
Author: gbuella
Date: Thu Jun 7 01:48:36 2018
New Revision: 334174
URL: http://llvm.org/viewvc/llvm-project?rev=334174&view=rev
Log:
[CodeGen] Improve diagnostics related to target attributes
Summary:
When requirement imposed by __target__ attributes on functions
are not satisfied, prefer printi
hokein updated this revision to Diff 150276.
hokein added a comment.
this->Index => Index.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47869
Files:
clangd/ClangdServer.cpp
Index: clangd/ClangdServer.cpp
===
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334174: [CodeGen] Improve diagnostics related to target
attributes (authored by GBuella, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D46541
Author: hokein
Date: Thu Jun 7 01:49:55 2018
New Revision: 334176
URL: http://llvm.org/viewvc/llvm-project?rev=334176&view=rev
Log:
[clangd] Fix using the incorrect Index for go-to-definition.
Reviewers: sammccall
Subscribers: ilya-biryukov, ioeric, MaskRay, jkorous, cfe-commits
Differential R
This revision was automatically updated to reflect the committed changes.
hokein marked an inline comment as done.
Closed by commit rCTE334176: [clangd] Fix using the incorrect Index for
go-to-definition. (authored by hokein, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D47
mstorsjo added inline comments.
Comment at: test/CodeGen/personality.c:10
-// RUN: %clang_cc1 -triple x86_64-unknown-windows-msvc -D __SEH_EXCEPTIONS__
-fms-extensions -fexceptions -fblocks -fseh-exceptions -S -emit-llvm %s -o - |
FileCheck %s -check-prefix CHECK-WIN-SEH -check
ebevhan added inline comments.
Comment at: test/Sema/address_spaces.c:17
int *_AS1 _AS2 *Z; // expected-error {{multiple address spaces specified
for type}}
+ int *_AS1 _AS1 *M;
Anastasia wrote:
> ebevhan wrote:
> > bader wrote:
> > > I think it might be
ebevhan added a comment.
Actually, wait! One last thing I missed.
Comment at: include/clang/Sema/DeclSpec.h:670
const PrintingPolicy &Policy);
+ bool SetTypeSpecSat(SourceLocation Loc, const char *&PrevSpec,
+ unsigned &DiagID);
---
CarlosAlbertoEnciso added a comment.
Ping.
The review
https://reviews.llvm.org/D44826
is already approved and it is dependent on this patch being reviewed.
Is there anything I can add to this patch?
Thanks very much.
https://reviews.llvm.org/D46190
___
Author: krasimir
Date: Thu Jun 7 02:46:24 2018
New Revision: 334179
URL: http://llvm.org/viewvc/llvm-project?rev=334179&view=rev
Log:
[clang-format] Consider tok::hashhash in python-style comments
Summary: We were missing the case when python-style comments in text protos
start with `##`.
Subs
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rC334179: [clang-format] Consider tok::hashhash in
python-style comments (authored by krasimir, committed by ).
Changed pri
sammccall created this revision.
sammccall added a reviewer: ioeric.
Herald added subscribers: cfe-commits, jkorous, MaskRay, ilya-biryukov.
Now we have most of Sema's code completion signals incorporated in Quality,
which will allow us to give consistent ranking to sema/index results.
Therefore
yvvan updated this revision to Diff 150291.
yvvan marked 8 inline comments as done.
yvvan added a comment.
Address review comments
https://reviews.llvm.org/D46862
Files:
include/clang-c/Index.h
include/clang/Sema/CodeCompleteConsumer.h
test/Index/complete-arrow-dot.cpp
tools/c-index-tes
hans created this revision.
hans added a reviewer: majnemer.
Clang would previously assert here.
https://reviews.llvm.org/D47875
Files:
lib/AST/MicrosoftMangle.cpp
test/CodeGenCXX/mangle-ms-cxx11.cpp
Index: test/CodeGenCXX/mangle-ms-cxx11.cpp
==
ebevhan added inline comments.
Comment at: lib/Sema/SemaType.cpp:1612
+ // Only fixed point types can be saturated
+ if (DS.isTypeSpecSat() && !IsFixedPointType)
+S.Diag(DS.getTypeSpecSatLoc(), diag::err_invalid_saturation_spec)
Also, this does not seem to
hans added a comment.
Please take a look.
I couldn't figure out a way to get a mangled name for this without using debug
info. Do you have any ideas?
https://reviews.llvm.org/D47875
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
takuto.ikuta updated this revision to Diff 150300.
https://reviews.llvm.org/D47578
Files:
llvm/lib/Support/Windows/Process.inc
llvm/unittests/Support/CommandLineTest.cpp
Index: llvm/unittests/Support/CommandLineTest.cpp
===
---
takuto.ikuta added a comment.
I see. Changed not to convert many times.
I confirmed that this passed check-lld, check-llvm and check-clang. If this
looks good for you, can I ask you to merge this?
Thanks.
https://reviews.llvm.org/D47578
___
cfe-
ilya-biryukov added a comment.
Maybe we could add the test cases that the blacklisted members still show up in
completion that don't involve member qualifiers? For example,
struct X : std::vector {
int test( ){
// <-- 'vector' might be a useful completion here.
}
};
Reposit
hfinkel added a comment.
In https://reviews.llvm.org/D47849#1124638, @Hahnfeld wrote:
> IMO this goes into the right direction, we should use the fast implementation
> in libdevice. If LLVM doesn't lower these calls in the NVPTX backend, I think
> it's ok to use header wrappers as CUDA already
ioeric accepted this revision.
ioeric added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/CodeComplete.cpp:542
continue;
- // Destructor completion is rarely useful, and works inconsistently.
- // (s.^ completes ~string, b
hans added a comment.
What's special about size_t though? If I understand your patch correctly, it
would suppress warning about printing NSInteger with %zd, but still warn about
%ld even though ssize_t=long on the target? As a user I'd find this confusing.
If we really want to special-case NSIn
sammccall updated this revision to Diff 150307.
sammccall added a comment.
Added tests and comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47871
Files:
clangd/CodeComplete.cpp
clangd/Quality.cpp
clangd/Quality.h
test/clangd/completion.test
test/clangd/protoco
sammccall marked an inline comment as done.
sammccall added a comment.
Added explicit tests for this feature.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47871
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334192: [clangd] Code completion: drop explicit injected
names/operators, ignore Sema… (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://revie
Author: sammccall
Date: Thu Jun 7 05:49:17 2018
New Revision: 334192
URL: http://llvm.org/viewvc/llvm-project?rev=334192&view=rev
Log:
[clangd] Code completion: drop explicit injected names/operators, ignore Sema
priority
Summary:
Now we have most of Sema's code completion signals incorporated
krasimir updated this revision to Diff 150317.
krasimir added a comment.
- Update comments
Repository:
rC Clang
https://reviews.llvm.org/D46757
Files:
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTestProto.cpp
unittests/Format/FormatTestRawStrings.cpp
unittests/Format/FormatT
krasimir updated this revision to Diff 150320.
krasimir added a comment.
- Add comments tests
Repository:
rC Clang
https://reviews.llvm.org/D46757
Files:
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTestProto.cpp
unittests/Format/FormatTestRawStrings.cpp
unittests/Format/Form
aaron.ballman added a comment.
In https://reviews.llvm.org/D47290#1124866, @hans wrote:
> If we really want to special-case NSInteger, and given that you're targeting
> a specific wide-spread pattern maybe that's the right thing to do, I think we
> should make -Wformat accept (move the warning
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
I don't know much about the python bindings, but this is probably fine.
Repository:
rC Clang
https://reviews.llvm.org/D47864
___
cfe-commits
hans added a comment.
In https://reviews.llvm.org/D47290#1124933, @aaron.ballman wrote:
> In https://reviews.llvm.org/D47290#1124866, @hans wrote:
>
> > If we really want to special-case NSInteger, and given that you're
> > targeting a specific wide-spread pattern maybe that's the right thing to
aaron.ballman added a comment.
In https://reviews.llvm.org/D47290#1124956, @hans wrote:
> In https://reviews.llvm.org/D47290#1124933, @aaron.ballman wrote:
>
> > In https://reviews.llvm.org/D47290#1124866, @hans wrote:
> >
> > > If we really want to special-case NSInteger, and given that you're
On Thu, 7 Jun 2018, 13:54 Hans Wennborg via Phabricator via cfe-commits, <
cfe-commits@lists.llvm.org> wrote:
> hans added a comment.
>
> Please take a look.
>
> I couldn't figure out a way to get a mangled name for this without using
> debug info. Do you have any ideas?
>
struct S { enum {} e; }
hans added a comment.
In https://reviews.llvm.org/D47290#1124964, @aaron.ballman wrote:
> In https://reviews.llvm.org/D47290#1124956, @hans wrote:
>
> > In https://reviews.llvm.org/D47290#1124933, @aaron.ballman wrote:
> >
> > > In https://reviews.llvm.org/D47290#1124866, @hans wrote:
> > >
> > >
gtbercea added inline comments.
Comment at: lib/Headers/__clang_cuda_device_functions.h:65
}
+#if defined(__cplusplus)
__DEVICE__ void __brkpt() { asm volatile("brkpt;"); }
Hahnfeld wrote:
> Why is that only valid for C++?
C does not support overloading of func
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47704
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
gtbercea added a comment.
In https://reviews.llvm.org/D47849#1124638, @Hahnfeld wrote:
> IMO this goes into the right direction, we should use the fast implementation
> in libdevice. If LLVM doesn't lower these calls in the NVPTX backend, I think
> it's ok to use header wrappers as CUDA already
alexfh added a reviewer: djasper.
alexfh added inline comments.
Comment at: lib/Format/BreakableToken.cpp:327
+ TokenText.substr(2, TokenText.size() - 4)
+ .split(Lines, TokenText.count('\r') > 0 ? "\r\n" : "\n");
FYI, there's a global UseCRLF flag in Whi
aaron.ballman added a comment.
In https://reviews.llvm.org/D47290#1124991, @hans wrote:
> In https://reviews.llvm.org/D47290#1124964, @aaron.ballman wrote:
>
> > In https://reviews.llvm.org/D47290#1124956, @hans wrote:
> >
> > > In https://reviews.llvm.org/D47290#1124933, @aaron.ballman wrote:
>
Hahnfeld added a comment.
In https://reviews.llvm.org/D47849#1125019, @gtbercea wrote:
> It's precisely the issue which you report here. Since you don't use device
> specific math functions, you can run into the problem where you may end up
> calling assembly instructions for a different archit
majnemer added inline comments.
Comment at: lib/AST/MicrosoftMangle.cpp:888-891
auto EnumeratorI = ED->enumerator_begin();
-assert(EnumeratorI != ED->enumerator_end());
-Name += "getName();
+if (EnumeratorI == ED->enumerator_end()) {
+ Na
On Thu, Jun 7, 2018 at 4:05 PM, Richard Smith via cfe-commits
wrote:
>
> struct S { enum {} e; };
>
> ... then do something with decltype(S::e). What happens if there are two
> such types in the class?
The bug doesn't reproduce if the enumeration has a name, which is why
it's hard to reference :-
leonardchan added inline comments.
Comment at: include/clang/Sema/DeclSpec.h:670
const PrintingPolicy &Policy);
+ bool SetTypeSpecSat(SourceLocation Loc, const char *&PrevSpec,
+ unsigned &DiagID);
ebevhan wrote:
> Th
hans added a comment.
Thanks!
Comment at: lib/AST/MicrosoftMangle.cpp:888-891
auto EnumeratorI = ED->enumerator_begin();
-assert(EnumeratorI != ED->enumerator_end());
-Name += "getName();
+if (EnumeratorI == ED->enumerator_end()) {
+ Na
probinson added a comment.
@rsmith anything else needed here?
https://reviews.llvm.org/D46190
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xbolva00 added a comment.
Ping
https://reviews.llvm.org/D47135
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ebevhan added inline comments.
Comment at: include/clang/Sema/DeclSpec.h:670
const PrintingPolicy &Policy);
+ bool SetTypeSpecSat(SourceLocation Loc, const char *&PrevSpec,
+ unsigned &DiagID);
leonardchan wrote:
> eb
labath created this revision.
labath added reviewers: erik.pilkington, zturner.
Herald added a subscriber: mgorny.
This kind of functionality is useful to other project apart from clang.
LLDB works with version numbers a lot, but it does not have a convenient
abstraction for this. Moving this clas
labath created this revision.
labath added reviewers: zturner, erik.pilkington.
Herald added a subscriber: mgorny.
This kind of functionality is useful to other project apart from clang.
LLDB works with version numbers a lot, but it does not have a convenient
abstraction for this. Moving this clas
zturner added a comment.
It would be better if you're using a monorepo, that way both parts can just be
one single patch.
Repository:
rL LLVM
https://reviews.llvm.org/D47887
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
labath added a comment.
Yea, one day I'll have to try that out. I'm just putting it off cause it would
nuke all my branches and build folders :/
FWIW, the llvm part can actually be committed without breaking clang or anyone.
Repository:
rL LLVM
https://reviews.llvm.org/D47887
___
bader added inline comments.
Comment at: test/Sema/address_spaces.c:17
int *_AS1 _AS2 *Z; // expected-error {{multiple address spaces specified
for type}}
+ int *_AS1 _AS1 *M;
ebevhan wrote:
> Anastasia wrote:
> > ebevhan wrote:
> > > bader wrote:
> > > >
gramanas updated this revision to Diff 150357.
gramanas added a comment.
Make more elaborate comment.
Repository:
rC Clang
https://reviews.llvm.org/D47097
Files:
lib/CodeGen/CGDecl.cpp
test/CodeGen/debug-info-preserve-scope.c
Index: test/CodeGen/debug-info-preserve-scope.c
tra added a comment.
In https://reviews.llvm.org/D47849#1124638, @Hahnfeld wrote:
> IMO this goes into the right direction, we should use the fast implementation
> in libdevice. If LLVM doesn't lower these calls in the NVPTX backend, I think
> it's ok to use header wrappers as CUDA already does
Author: ctopper
Date: Thu Jun 7 10:28:03 2018
New Revision: 334208
URL: http://llvm.org/viewvc/llvm-project?rev=334208&view=rev
Log:
[X86] Add back builtins for _mm_slli_si128/_mm_srli_si128 and similar
intrinsics.
We still lower them to native shuffle IR, but we do it in CGBuiltin.cpp now.
T
sammccall added a comment.
@ilya-biryukov Ping, anything left for me to do here?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47707
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
emmettneyman updated this revision to Diff 150365.
emmettneyman added a comment.
- refactored cmake and deleted header file
Repository:
rC Clang
https://reviews.llvm.org/D47843
Files:
tools/clang-fuzzer/CMakeLists.txt
tools/clang-fuzzer/ExampleClangLoopProtoFuzzer.cpp
tools/clang-fuzze
manojgupta created this revision.
manojgupta added reviewers: t.p.northover, efriedma, jyknight, chandlerc, rnk,
srhines, void.
Support for this option is needed for building Linux kernel.
This is a very frequently requested feature by kernel developers.
More details : https://lkml.org/lkml/2018
sammccall created this revision.
sammccall added a reviewer: ilya-biryukov.
Herald added a subscriber: cfe-commits.
In particular, stderr etc where the equivalent symbols exist in the global
namespace. Having the symbol instead of the macro helps with ranking, and avoids
the current duplicate stde
efriedma added a comment.
Does IR generation need any special handling for this? We add nonnull
attributes in various places.
Repository:
rC Clang
https://reviews.llvm.org/D47894
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
ormris updated this revision to Diff 150377.
ormris added a comment.
Use AST matchers to select references for preservation
Repository:
rC Clang
https://reviews.llvm.org/D47044
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/LoopWidening.h
lib/StaticAnalyzer/Core/ExprEngine.cpp
vitalybuka updated this revision to Diff 150380.
vitalybuka added a comment.
git clang-format -f --style=file HEAD^
Repository:
rC Clang
https://reviews.llvm.org/D47843
Files:
tools/clang-fuzzer/CMakeLists.txt
tools/clang-fuzzer/ExampleClangLoopProtoFuzzer.cpp
tools/clang-fuzzer/cxx_lo
ethanhs added a comment.
In https://reviews.llvm.org/D47864#1124948, @bkramer wrote:
> I don't know much about the python bindings, but this is probably fine.
Yeah I wasn't really sure who to add so I looked at the commit history. Thank
you for adding the right people.
Repository:
rC Clang
Author: vitalybuka
Date: Thu Jun 7 12:17:46 2018
New Revision: 334216
URL: http://llvm.org/viewvc/llvm-project?rev=334216&view=rev
Log:
Introducing single for loop into clang_proto_fuzzer
Summary:
Created a new protobuf and protobuf-to-C++ "converter" that wraps the entire
C++ code in a single
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334216: Introducing single for loop into clang_proto_fuzzer
(authored by vitalybuka, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D47843
Files:
cfe/trunk/tools/clang-fuzzer/CMakeList
vlad.tsyrklevich added a comment.
Herald added a subscriber: steven_wu.
Hi Tobias, I tracked down the failure self-hosting LLVM with LTO with this
revision to https://bugs.llvm.org/show_bug.cgi?id=37684#c2 and have a fix under
review in https://reviews.llvm.org/D47898. This revision needs to be
Hahnfeld created this revision.
Hahnfeld added a reviewer: tra.
Herald added a subscriber: cfe-commits.
CGM.GetAddrOfConstantCString() sets the adress of the created GlobalValue
to unnamed. When emitting the object file LLVM will mark the surrounding
section as SHF_MERGE iff the string is nul-term
ruiu added inline comments.
Comment at: llvm/lib/Support/Windows/Process.inc:240
+ Filename.assign(Base.begin(), Base.end());
+ return ec;
}
The intention of the code is to return a success, so it is less confusing if
you directly return a success (i.e. std::
smeenai marked 2 inline comments as done.
smeenai added inline comments.
Comment at: test/CodeGen/personality.c:10
-// RUN: %clang_cc1 -triple x86_64-unknown-windows-msvc -D __SEH_EXCEPTIONS__
-fms-extensions -fexceptions -fblocks -fseh-exceptions -S -emit-llvm %s -o - |
FileCh
smeenai updated this revision to Diff 150394.
smeenai marked 2 inline comments as done.
smeenai added a comment.
Add back missing MinGW coverage
Repository:
rC Clang
https://reviews.llvm.org/D47853
Files:
include/clang/Basic/DiagnosticFrontendKinds.td
lib/Frontend/CompilerInvocation.cpp
Author: zturner
Date: Thu Jun 7 12:58:58 2018
New Revision: 334221
URL: http://llvm.org/viewvc/llvm-project?rev=334221&view=rev
Log:
[FileSystem] Split up the OpenFlags enumeration.
This breaks the OpenFlags enumeration into two separate
enumerations: OpenFlags and CreationDisposition. The firs
Author: zturner
Date: Thu Jun 7 12:58:58 2018
New Revision: 334221
URL: http://llvm.org/viewvc/llvm-project?rev=334221&view=rev
Log:
[FileSystem] Split up the OpenFlags enumeration.
This breaks the OpenFlags enumeration into two separate
enumerations: OpenFlags and CreationDisposition. The firs
mstorsjo accepted this revision.
mstorsjo added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Comment at: test/CodeGenCXX/personality.cpp:9
-// RUN: %clang_cc1 -triple i686-unknown-windows-msvc -fexceptions
-fseh-exceptions -fcxx-exceptions -S -emit
Author: smeenai
Date: Thu Jun 7 13:07:52 2018
New Revision: 334224
URL: http://llvm.org/viewvc/llvm-project?rev=334224&view=rev
Log:
[Parse] Use CapturedStmt for @finally on MSVC
The body of a `@finally` needs to be executed on both exceptional and
non-exceptional paths. On landingpad platforms,
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334224: [Parse] Use CapturedStmt for @finally on MSVC
(authored by smeenai, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D47564
Files:
cfe/tr
smeenai updated this revision to Diff 150399.
smeenai added a comment.
Address objc_exception attribute case
Repository:
rC Clang
https://reviews.llvm.org/D47233
Files:
lib/CodeGen/CGCXXABI.h
lib/CodeGen/CGObjCMac.cpp
lib/CodeGen/MicrosoftCXXABI.cpp
test/CodeGenObjC/dllstorage.m
te
smeenai added a comment.
Ping @rjmccall
Repository:
rC Clang
https://reviews.llvm.org/D47233
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: jvesely
Date: Thu Jun 7 13:27:43 2018
New Revision: 334226
URL: http://llvm.org/viewvc/llvm-project?rev=334226&view=rev
Log:
math/fma: Add fp32 software implementation
Passes CTS on carrizo (when forced to use sw fma) and turks.
Reviewer: Tom Stellard
Signed-off-by: Jan Vesely
Added:
Author: jvesely
Date: Thu Jun 7 13:27:56 2018
New Revision: 334227
URL: http://llvm.org/viewvc/llvm-project?rev=334227&view=rev
Log:
r600/fmax: Flush denormals before calling builtin.
Same reason as amdgcn.
Fixes fmax, maxmag CTS on turks.
Reviewer: Tom Stellard
Signed-off-by: Jan Vesely
Adde
Author: jvesely
Date: Thu Jun 7 13:27:58 2018
New Revision: 334228
URL: http://llvm.org/viewvc/llvm-project?rev=334228&view=rev
Log:
r600/fmin: Flush denormals before calling builtin.
Same reason as amdgcn.
Fixes fmin, minmag CTS on turks.
Reviewer: Tom Stellard
Signed-off-by: Jan Vesely
Adde
tejohnson created this revision.
tejohnson added reviewers: pcc, dexonsmith, mehdi_amini.
Herald added subscribers: steven_wu, eraman, inglorion.
Changes to some clang side tests to go with the summary parsing patch.
Depends on https://reviews.llvm.org/D47905.
Repository:
rC Clang
https://re
stephanemoore added a comment.
Is it possible to get someone to land this for me? I don't believe I have
access to land it myself.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46922
___
cfe-commits mailing list
cfe-commits@lists.
manojgupta added a comment.
In https://reviews.llvm.org/D47894#1125406, @efriedma wrote:
> Does IR generation need any special handling for this? We add nonnull
> attributes in various places.
My interpretation is adding nonnull attributes is fine as long is it is not
derived from a pointer
efriedma added a comment.
The problem would come from propagating nonnull-ness from something which isn't
inherently nonnull. For example, strlen has a nonnull argument, so
`strlen(NULL)` is UB, therefore given `int z = strlen(x); if (x) {...}`, we can
remove the null check. (Not sure we actu
Author: ctopper
Date: Thu Jun 7 14:27:41 2018
New Revision: 334237
URL: http://llvm.org/viewvc/llvm-project?rev=334237&view=rev
Log:
[X86] Add builtins for VALIGNQ/VALIGND to enable proper target feature checking.
We still emit shufflevector instructions we just do it from CGBuiltin.cpp now.
Th
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334238: [checks/property-decls] Fix comment in
clang-tidy/objc/PropertyDeclarationCheck. (authored by benhamilton, committed
by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
http
benhamilton added a comment.
> Is it possible to get someone to land this for me? I don't believe I have
> access to land it myself.
Done.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46922
___
cfe-commits mailing list
cfe-commi
Author: rnk
Date: Thu Jun 7 14:39:04 2018
New Revision: 334239
URL: http://llvm.org/viewvc/llvm-project?rev=334239&view=rev
Log:
[MS] Re-add support for the ARM interlocked bittest intrinscs
Adds support for these intrinsics, which are ARM and ARM64 only:
_interlockedbittestandreset_acq
_int
efriedma added a comment.
For the kernel, specifically, strlen() isn't an issue because it builds with
-fno-builtin, but the kernel uses explicit nonnull attributes in a few places.
But I guess we can assume they know what they're doing if nonnull is explicitly
specified.
We probably want to
This should be fixed now with r334239. In for a penny, in for a pound.
On Wed, Jun 6, 2018 at 6:09 PM Grang, Mandeep Singh
wrote:
> @rnk I tried building spec2000/eon for Windows ARM64 and ran into these
> errors:
>
> use of undeclared identifier '_interlockedbittestandset_acq'
> use of undeclar
1 - 100 of 134 matches
Mail list logo
