smeenai marked 2 inline comments as done. smeenai added inline comments.
================ Comment at: test/CodeGen/personality.c:10 -// RUN: %clang_cc1 -triple x86_64-unknown-windows-msvc -D __SEH_EXCEPTIONS__ -fms-extensions -fexceptions -fblocks -fseh-exceptions -S -emit-llvm %s -o - | FileCheck %s -check-prefix CHECK-WIN-SEH -check-prefix CHECK-WIN-SEH-X64 -// RUN: %clang_cc1 -triple i686-unknown-windows-msvc -fexceptions -fblocks -fsjlj-exceptions -S -emit-llvm %s -o - | FileCheck %s -check-prefix CHECK-WIN-SJLJ ---------------- mstorsjo wrote: > I'd prefer if you didn't remove these tests, but instead retarget them to use > a `-gnu` triplet, to keep testing where you can explicitly choose between > sjlj/dwarf/seh for mingw setups. I'll re-add those back; I didnt' realize they weren't already covered. I'm gonna drop the __SEH_EXCEPTIONS__ thing for MinGW, since AFAIK SEH `__try`/`__finally` doesn't work there. ================ Comment at: test/CodeGenCXX/personality.cpp:9 -// RUN: %clang_cc1 -triple i686-unknown-windows-msvc -fexceptions -fseh-exceptions -fcxx-exceptions -S -emit-llvm %s -o - | FileCheck %s -check-prefix CHECK-WIN-SEH -// %clang_cc1 -triple i686-unknown-windows-msvc -fexceptions -fsjlj-exceptions -fcxx-exceptions -S -emit-llvm %s -o - | FileCheck %s -check-prefix CHECK-WIN-SJLJ -// RUN: %clang_cc1 -triple i686-unknown-windows-msvc -D __SEH_EXCEPTIONS__ -fms-extensions -fexceptions -fseh-exceptions -fcxx-exceptions -S -emit-llvm %s -o - | FileCheck %s -check-prefix CHECK-WIN-SEH-X86 ---------------- mstorsjo wrote: > Same here, please keep the existing tests but retarget them to gnu/mingw. This should all be covered by the group of RUN lines right below this one. Repository: rC Clang https://reviews.llvm.org/D47853 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
