MTC added inline comments.
Comment at: lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:234
+ SVal V = UnknownVal();
+ if (MTE) {
+if (MTE->getStorageDuration() != SD_FullExpression) {
An unrelated question. I want to know, what considerations are you
>
>
> Awesome! Does it mean that the optimization for adding less constraints
> was in fact buggy?
>
>
I pretty sure it was not related to the optimizations, I removed them days
ago (in the previous version of this patch) and the bug was still there.
>
> 2. Could it be something unrelated to your
Author: mramalho
Date: Sun Jun 3 17:23:01 2018
New Revision: 333862
URL: http://llvm.org/viewvc/llvm-project?rev=333862&view=rev
Log:
Moved RangedConstraintManager header to the StaticAnalyser include dir
Summary:
Moved `RangedConstraintManager` header from `lib/StaticAnalyzer/Core/` to
`clang
baloghadamsoftware added a comment.
In https://reviews.llvm.org/D35110#1119496, @NoQ wrote:
> Which expressions are constrained? Why does the difference use the whole
> range? Is it something that could have been fixed by the "enforce that
> separately" part in my old comment:
>
> > iterator-re
ebevhan added a comment.
I have this patch uploaded as well: https://reviews.llvm.org/D47630
I suspected that there might be cases for which we would try adding the same
address space to a type, but I noticed that this method doesn't replace
properly.
I don't actually have an example of this, t
rsmith accepted this revision.
rsmith added a comment.
I would like to see a test that virtual function definitions are properly
emitted for classes instantiated from templates (and in particular, that this
triggers instantiation of such virtual member functions so they can be
emitted). Other t
sammccall updated this revision to Diff 149682.
sammccall added a comment.
clearerr() on (partial) successful read, and recover from EAGAIN during fread.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47643
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd
sammccall added a comment.
In https://reviews.llvm.org/D47643#1120385, @malaperle wrote:
> In https://reviews.llvm.org/D47643#1119187, @sammccall wrote:
>
> > @malaperle: would you mind patching this in and checking whether attaching
> > a debugger still works on Mac (this was the reason for the
ioeric added inline comments.
Comment at: clang-doc/Generators.h:25
+//
+// Derived classes must implement the generate*ForInfo methods, which should
+// emit documentation for the specified info in the relevant format. This is
nit: This seems a bit redundant as
yvvan updated this revision to Diff 149683.
yvvan added a comment.
I could not properly test getMainBufferWithPrecompiledPreamble because it's
private and requires some extra context to be called.
But there's another getBufferForFile call in ASTUnit which has similar symptoms
and might cause wr
yvvan updated this revision to Diff 149684.
yvvan added a comment.
fix indentation in unit-test
https://reviews.llvm.org/D47460
Files:
include/clang/Basic/FileManager.h
lib/Basic/FileManager.cpp
lib/Frontend/ASTUnit.cpp
unittests/Frontend/ASTUnitTest.cpp
Index: unittests/Frontend/ASTUn
sammccall updated this revision to Diff 149685.
sammccall added a comment.
Handle one more case where fgets is interrupted.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47643
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/JSONRPCDispatcher.cpp
clang
r.stahl created this revision.
r.stahl added reviewers: a.sidorin, klimek, martong.
Herald added subscribers: cfe-commits, rnkovacs.
Implement full import of macro expansion info with spelling and expansion
locations.
Repository:
rC Clang
https://reviews.llvm.org/D47698
Files:
lib/AST/AST
r.stahl added a comment.
The split-token case should be covered by this, because it takes the correct
TokenLen and the isTokenRange flag. Other than that the split-token
ExpansionInfo is indistinguishable.
What about loaded source locations? Do they need to be handled specifically or
does this
Author: ioeric
Date: Mon Jun 4 02:04:28 2018
New Revision: 333877
URL: http://llvm.org/viewvc/llvm-project?rev=333877&view=rev
Log:
Reland "[clangd] Adapt file migration in r332720"
This reverts commit r333535.
Modified:
clang-tools-extra/trunk/clangd/CMakeLists.txt
clang-tools-extra/tr
Author: ioeric
Date: Mon Jun 4 02:04:25 2018
New Revision: 333876
URL: http://llvm.org/viewvc/llvm-project?rev=333876&view=rev
Log:
Revert "Reland "[clangd] Adapt file migration in r332720""
This reverts commit r333533.
Modified:
clang-tools-extra/trunk/clangd/CMakeLists.txt
clang-tools
Author: ioeric
Date: Mon Jun 4 02:04:12 2018
New Revision: 333874
URL: http://llvm.org/viewvc/llvm-project?rev=333874&view=rev
Log:
Reland "Move #include manipulation code to new lib/Tooling/Inclusions."
This reverts commit r333534 (i.e. reland r332720) after fixing module build.
Differential R
Author: ioeric
Date: Mon Jun 4 02:04:19 2018
New Revision: 333875
URL: http://llvm.org/viewvc/llvm-project?rev=333875&view=rev
Log:
Reland "[clangd] Adapt file migration in r332720"
This reverts commit r332752 (i.e. reland r332721).
Modified:
clang-tools-extra/trunk/clangd/CMakeLists.txt
jmorse updated this revision to Diff 149688.
jmorse added a comment.
Avoid un-necessary call, use APInt::isSameValue rather than operator!=
https://reviews.llvm.org/D47628
Files:
lib/AST/ASTContext.cpp
test/Sema/vla.c
Index: test/Sema/vla.c
jmorse marked 2 inline comments as done.
jmorse added inline comments.
Comment at: lib/AST/ASTContext.cpp:8588
+ Expr *E = VAT->getSizeExpr();
+ if (E && VAT->getSizeExpr()->isIntegerConstantExpr(TheInt, *this))
+return std::make_pair(true, TheInt);
orgads added inline comments.
Comment at: unittests/Frontend/ASTUnitTest.cpp:21
+#define CREATE_AST_UNIT(isVolatile)
\
+ int FD;
\
Macros are evil
tkrupa updated this revision to Diff 149693.
tkrupa added a comment.
Removed CHECK-NOTs for consistency.
Repository:
rC Clang
https://reviews.llvm.org/D41168
Files:
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/avx-builtins.c
test/CodeGen/avx512f-builtins.c
test/CodeGen/avx512vl-builtins.c
takuto.ikuta updated this revision to Diff 149694.
takuto.ikuta added a comment.
Address comments
https://reviews.llvm.org/D47578
Files:
llvm/lib/Support/Windows/Process.inc
llvm/unittests/Support/CommandLineTest.cpp
Index: llvm/unittests/Support/CommandLineTest.cpp
===
ilya-biryukov added a comment.
In https://reviews.llvm.org/D47623#1119426, @ioeric wrote:
> Sorry for the late response Ilya. I was trying to test these cases. So, with
> the current change, if a real "canonical" declaration comes before the friend
> decl, then the reference will still be recor
takuto.ikuta marked 3 inline comments as done.
takuto.ikuta added a comment.
Thank you for review
Comment at: llvm/lib/Support/Windows/Process.inc:251
+ // This may change argv0 like below,
+ // * clang -> clang.exe (just add extension)
+ // * CLANG_~1.EXE -> clang++.exe (ex
yvvan updated this revision to Diff 149697.
yvvan added a comment.
Use fixture in unit-test
https://reviews.llvm.org/D47460
Files:
include/clang/Basic/FileManager.h
lib/Basic/FileManager.cpp
lib/Frontend/ASTUnit.cpp
unittests/Frontend/ASTUnitTest.cpp
Index: unittests/Frontend/ASTUnitTe
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added subscribers: jkorous, MaskRay, ioeric, ilya-biryukov, klimek.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47699
Files:
clangd/index/Index.h
Index: clangd/index/Index.h
==
sammccall created this revision.
sammccall added a reviewer: ioeric.
Herald added subscribers: cfe-commits, jkorous, MaskRay, ilya-biryukov, klimek.
Also made JSON serialize Optional to simplify this.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47701
Files:
clangd/ClangdLS
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47701
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE333881: [clangd] Hover should return null when not
hovering over anything. (authored by sammccall, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D47701?vs=149701&id=149705#toc
Rep
Author: sammccall
Date: Mon Jun 4 03:37:16 2018
New Revision: 333881
URL: http://llvm.org/viewvc/llvm-project?rev=333881&view=rev
Log:
[clangd] Hover should return null when not hovering over anything.
Summary: Also made JSON serialize Optional to simplify this.
Reviewers: ioeric
Subscribers:
Szelethus marked 5 inline comments as done.
Szelethus added a comment.
In https://reviews.llvm.org/D45532#1116992, @george.karpenkov wrote:
> @Szelethus I personally really like this idea, and I think it would be a
> great checker.
> Could you perform more evaluation on other projects?
Thanks
This revision was automatically updated to reflect the committed changes.
Closed by commit rL333882: [clangd] Remove the dead offset fields in Symbol.
(authored by hokein, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D47699
Files:
cla
Author: hokein
Date: Mon Jun 4 03:43:59 2018
New Revision: 333882
URL: http://llvm.org/viewvc/llvm-project?rev=333882&view=rev
Log:
[clangd] Remove the dead offset fields in Symbol.
Reviewers: sammccall
Subscribers: klimek, ilya-biryukov, ioeric, MaskRay, jkorous, cfe-commits
Differential Revi
sammccall accepted this revision.
sammccall added inline comments.
Comment at: clangd/index/SymbolCollector.cpp:302
+ // A declaration created for a friend declaration should not be used as the
+ // canonical declaration in the index. If D is a defintion and is not OrigD,
+ //
ioeric added a comment.
In https://reviews.llvm.org/D47623#1120547, @ilya-biryukov wrote:
> In https://reviews.llvm.org/D47623#1119426, @ioeric wrote:
>
> > Sorry for the late response Ilya. I was trying to test these cases. So,
> > with the current change, if a real "canonical" declaration come
ioeric updated this revision to Diff 149721.
ioeric marked an inline comment as done.
ioeric added a comment.
Herald added a subscriber: mgorny.
- Addressed review comment.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47623
Files:
clangd/CMakeLists.txt
clangd/Headers.h
hokein created this revision.
hokein added a reviewer: alexfh.
Herald added subscribers: xazax.hun, klimek.
This patch improves the check to match the desugared "string" type (so that it
can handle custom-implemented string classes), see the newly-added test.
Repository:
rCTE Clang Tools Extra
ioeric updated this revision to Diff 149723.
ioeric added a comment.
- Revert unintended changes.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47623
Files:
clangd/index/SymbolCollector.cpp
clangd/index/SymbolCollector.h
unittests/clangd/SymbolCollectorTests.cpp
Index:
Author: ioeric
Date: Mon Jun 4 04:31:55 2018
New Revision: 333885
URL: http://llvm.org/viewvc/llvm-project?rev=333885&view=rev
Log:
[clangd] Avoid indexing decls associated with friend decls.
Summary:
These decls are sometime used as the canonical declarations (e.g. for
go-to-def),
which seems
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE333885: [clangd] Avoid indexing decls associated with
friend decls. (authored by ioeric, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D47623?vs=149723&id=149724#toc
Repository:
hokein abandoned this revision.
hokein added a comment.
Abandon this, since @ilya-biryukov has fixed it in
https://reviews.llvm.org/D44480.
Repository:
rC Clang
https://reviews.llvm.org/D46684
___
cfe-commits mailing list
cfe-commits@lists.llvm.
sammccall created this revision.
sammccall added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, jkorous, MaskRay, ioeric, klimek.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47707
Files:
clangd/Quality.cpp
clangd/Quality.h
unittests/clangd/QualityTests
sammccall updated this revision to Diff 149732.
sammccall added a comment.
Forgot to add to debug string.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47707
Files:
clangd/Quality.cpp
clangd/Quality.h
unittests/clangd/QualityTests.cpp
Index: unittests/clangd/QualityTest
ilya-biryukov added a comment.
Is there a way to only downrank them if the query does not start with `_`? That
would cover the cases when I **do** want the symbols starting with underscore.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47707
Author: lebedevri
Date: Mon Jun 4 05:04:51 2018
New Revision: 333891
URL: http://llvm.org/viewvc/llvm-project?rev=333891&view=rev
Log:
[clang][tooling] Don't forget to link to clangToolingInclusions.
Fixes build with shared libs, broken by rL333874.
Some buildbot converage is sorely missing.
Mo
Author: lebedevri
Date: Mon Jun 4 05:04:41 2018
New Revision: 333890
URL: http://llvm.org/viewvc/llvm-project?rev=333890&view=rev
Log:
[clang][tooling] Don't forget to link to clangToolingInclusions.
Fixes build with shared libs, broken by rL333874.
Some buildbot converage is sorely missing.
Mo
That was supposed to be "[clangd][tests] Don't forget to link to
clangToolingInclusions.".
On Mon, Jun 4, 2018 at 3:04 PM, Roman Lebedev via cfe-commits
wrote:
> Author: lebedevri
> Date: Mon Jun 4 05:04:51 2018
> New Revision: 333891
>
> URL: http://llvm.org/viewvc/llvm-project?rev=333891&view=
FYI – This broke `cmake -DBUILD_SHARED_LIBS=TRUE` builds.
> On Jun 4, 2018, at 5:04 AM, Eric Liu via cfe-commits
> wrote:
>
> Author: ioeric
> Date: Mon Jun 4 02:04:12 2018
> New Revision: 333874
>
> URL: http://llvm.org/viewvc/llvm-project?rev=333874&view=rev
> Log:
> Reland "Move #include
This broke building as shared libraries.
I've committed the fix, but the bot coverage is clearly severely missing,
given that such breakages are very often.
Roman.
On Mon, Jun 4, 2018 at 12:04 PM, Eric Liu via cfe-commits
wrote:
> Author: ioeric
> Date: Mon Jun 4 02:04:12 2018
> New Revision:
Thanks for fixing this Roman!
On Mon, Jun 4, 2018 at 2:11 PM Roman Lebedev wrote:
> This broke building as shared libraries.
>
> I've committed the fix, but the bot coverage is clearly severely missing,
> given that such breakages are very often.
>
> Roman.
>
> On Mon, Jun 4, 2018 at 12:04 PM, E
What’s stopping the project from automatically setting BUILD_SHARED_LIBS to
TRUE if asserts are enabled? That’d automatically “force” active developers to
test the scenario on their local machines, but not change the way release
builds work.
> On Jun 4, 2018, at 8:11 AM, Roman Lebedev via cfe-
sammccall added a comment.
In https://reviews.llvm.org/D47707#1120734, @ilya-biryukov wrote:
> Is there a way to only downrank them if the query does not start with `_`?
> That would cover the cases when I **do** want the symbols starting with
> underscore.
This is hard for a few reasons:
-
sammccall updated this revision to Diff 149735.
sammccall added a comment.
FIXMEs pertaining to queries beginning with _, and standard _Names
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47707
Files:
clangd/Quality.cpp
clangd/Quality.h
unittests/clangd/QualityTests.cpp
avt77 updated this revision to Diff 149734.
avt77 added a comment.
To simplify the review I removed all LLVM_DEBUG items - now the patch is really
shorter than it was before.
https://reviews.llvm.org/D47196
Files:
include/clang/Frontend/Utils.h
lib/CodeGen/CodeGenAction.cpp
lib/CodeGen/C
ilya-biryukov added a comment.
After chatting offline: a FIXME mentioning some special cases seems enough
here, we do improve the results in most cases (i.e. for queries that don't
start with an underscore).
Another NIT:
Maybe we could add unittests for names that start with underscore, but are
LukeGeeson updated this revision to Diff 149737.
LukeGeeson marked an inline comment as done.
LukeGeeson added a comment.
-generates range checks in NEON Emitter rather than hardcoding in
SemaChecking.cpp
-uses 'isVCVT_N' to correctly direct the emitter to generate the correct ranges.
https://r
LukeGeeson marked 2 inline comments as done.
LukeGeeson added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:1409
- switch (BuiltinID) {
-#define GET_NEON_OVERLOAD_CHECK
-#include "clang/Basic/arm_neon.inc"
SjoerdMeijer wrote:
> Why do we need to remove
Author: sammccall
Date: Mon Jun 4 06:28:17 2018
New Revision: 333897
URL: http://llvm.org/viewvc/llvm-project?rev=333897&view=rev
Log:
[clangd] Fix inverted test (--gtest_filter strikes again...)
Modified:
clang-tools-extra/trunk/unittests/clangd/XRefsTests.cpp
Modified: clang-tools-extra/t
ilya-biryukov added a subscriber: hokein.
ilya-biryukov added a comment.
The change LG, but I'm not a big expert on C APIs, so I might've missed
something. @ioeric, @hokein, maybe you have some experience with those and
want to take a look?
PS I've checked it on my Mac and lldb seems to attach
sammccall added inline comments.
Comment at: clangd/JSONRPCDispatcher.cpp:70
}
- log(llvm::Twine("--> ") + S);
+ log(llvm::Twine("--> ") + S + "\n");
}
ilya-biryukov wrote:
> Log adds a newline for us, right? Why do we want two newlines here?
Oops, forgot t
This revision was automatically updated to reflect the committed changes.
Closed by commit rC333899: Created a tiny SMT interface and make
Z3ConstraintManager implement it (authored by mramalho, committed by ).
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.
This revision was automatically updated to reflect the committed changes.
Closed by commit rC333903: [analyzer] False positive refutation with Z3
(authored by mramalho, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D45517?vs=149664&id=149764#toc
Repository:
rC Clang
http
ilya-biryukov updated this revision to Diff 149765.
ilya-biryukov marked 5 inline comments as done.
ilya-biryukov added a comment.
- Address review comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46943
Files:
clangd/Quality.cpp
clangd/Quality.h
unittests/clangd/Qu
Higuoxing updated this revision to Diff 149766.
Higuoxing edited the summary of this revision.
Higuoxing added a comment.
Update with test cases :)
https://reviews.llvm.org/D47687
Files:
lib/Sema/SemaExpr.cpp
test/Sema/parentheses.c
Index: test/Sema/parentheses.c
=
asavonic updated this revision to Diff 149763.
asavonic added a comment.
Addressed CR comments, added a diagnostic if shared library was not loaded.
https://reviews.llvm.org/D47190
Files:
include/clang/Basic/DiagnosticFrontendKinds.td
include/clang/Driver/Options.td
include/clang/Lex/Head
ilya-biryukov added inline comments.
Comment at: clangd/Quality.h:52
unsigned References = 0;
+ float ProximityScore = 0.0; /// Proximity score, in a [0,1] interval.
sammccall wrote:
> this belongs in `SymbolRelevanceSignals` rather than this struct. In
>
Author: ibiryukov
Date: Mon Jun 4 07:50:59 2018
New Revision: 333906
URL: http://llvm.org/viewvc/llvm-project?rev=333906&view=rev
Log:
[clangd] Boost scores for decls from current file in completion
Summary: This should, arguably, give better ranking.
Reviewers: ioeric, sammccall
Reviewed By:
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE333906: [clangd] Boost scores for decls from current file
in completion (authored by ibiryukov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D46943?vs=149765&id=149771#toc
Reposi
sammccall added a comment.
oops, just saw this is closed - will fix these nits as I'm touching this file
soon
Comment at: clangd/Quality.h:68
+ /// Proximity between the best declaration and the query location. [0-1]
score
+ /// where 1 is closest
+ float ProximityScore =
gtbercea added a comment.
In https://reviews.llvm.org/D47394#1120255, @Hahnfeld wrote:
> In https://reviews.llvm.org/D47394#1119489, @gtbercea wrote:
>
> > In https://reviews.llvm.org/D47394#1119056, @Hahnfeld wrote:
> >
> > > Hmm, maybe the scope is much larger: I just tried linking an executabl
Author: mramalho
Date: Mon Jun 4 07:40:44 2018
New Revision: 333903
URL: http://llvm.org/viewvc/llvm-project?rev=333903&view=rev
Log:
[analyzer] False positive refutation with Z3
Summary: This is a prototype of a bug reporter visitor that invalidates bug
reports by re-checking constraints of ce
Author: mramalho
Date: Mon Jun 4 07:25:58 2018
New Revision: 333899
URL: http://llvm.org/viewvc/llvm-project?rev=333899&view=rev
Log:
Created a tiny SMT interface and make Z3ConstraintManager implement it
Summary:
This patch implements a simple SMTConstraintManager API, and requires the
implem
lebedev.ri added subscribers: dblaikie, rnk.
lebedev.ri added a comment.
In https://reviews.llvm.org/D47687#1120971, @Higuoxing wrote:
> Update with test cases :)
Thanks.
I do believe we are being overly forgiving for macros.
Sometimes that makes sense, sometimes not, especially there is no pr
gramanas created this revision.
gramanas added a reviewer: vsk.
Herald added subscribers: cfe-commits, JDevlieghere, eraman, aprantl.
This test is a strip down version of a function inside the
amalgamated sqlite source. When converted to IR clang produces
a phi instruction without debug location.
sammccall added inline comments.
Comment at: unittests/clangd/QualityTests.cpp:129
+ Test.Code = R"cpp(
+#include "foo.h"
+int ::test_func_in_header_and_cpp() {
ilya-biryukov wrote:
> sammccall wrote:
> > this is not needed, the `#include` is implicit in
lebedev.ri added reviewers: rjmccall, akyrtzi.
lebedev.ri added a comment.
It seems it was https://reviews.llvm.org/rL119537 that regressed it.
Nice, such a change, no review, no test :)
https://reviews.llvm.org/D47687
___
cfe-commits mailing list
c
dblaikie added a subscriber: Higuoxing.
dblaikie added a comment.
Probably CC someone from apple here & ask about rdar://8678458 - they can
look it up & provide the missing context.
https://reviews.llvm.org/D47687
___
cfe-commits mailing list
cfe-co
Probably CC someone from apple here & ask about rdar://8678458 - they can
look it up & provide the missing context.
On Mon, Jun 4, 2018 at 8:17 AM Roman Lebedev via Phabricator <
revi...@reviews.llvm.org> wrote:
> lebedev.ri added reviewers: rjmccall, akyrtzi.
> lebedev.ri added a comment.
>
> It
rjmccall added a comment.
Well, Sema should always be diagnosing conflicts.
If you don't have a specific reason to allow replacement, I would prefer just
fixing the documentation to state this as a precondition.
Repository:
rC Clang
https://reviews.llvm.org/D47627
___
rjmccall added a comment.
In https://reviews.llvm.org/D47694#1120375, @yaxunl wrote:
> In https://reviews.llvm.org/D47694#1120367, @rjmccall wrote:
>
> > Why not just have the driver disable RTTI in the frontend invocation?
>
>
> CUDA/HIP uses single source for device and host. The host code may
Higuoxing added a comment.
Thanks for reviewing!
I think the logic that *do not emit warning in macros* is not so proper ...
Best Regards,
Xing
https://reviews.llvm.org/D47687
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
Author: tstellar
Date: Mon Jun 4 08:49:27 2018
New Revision: 333910
URL: http://llvm.org/viewvc/llvm-project?rev=333910&view=rev
Log:
Merging r333467:
r333467 | marshall | 2018-05-29 15:25:42 -0700 (Tue, 29 May 2018) | 1 li
vlad.tsyrklevich added a comment.
In https://reviews.llvm.org/D47617#1119268, @NoQ wrote:
> Also does this test need to be z3-specific? We would also not like to crash
> here without z3.
I originally did that so I could specify enabling and testing the z3 backend;
however, looking at the test
aprantl added inline comments.
Comment at: test/CodeGen/debug-info-inline-for.c:2
+// RUN: %clang_cc1 -debug-info-kind=limited -emit-llvm -o - %s | FileCheck %s
+
+int func(int n) {
Please add a comment explaining what is being tested here.
Repository:
rC Cla
Author: tstellar
Date: Mon Jun 4 08:54:00 2018
New Revision: 333922
URL: http://llvm.org/viewvc/llvm-project?rev=333922&view=rev
Log:
Creating release candidate rc2 from release_601 branch
Added:
libunwind/tags/RELEASE_601/rc2/
- copied from r333921, libunwind/branches/release_60/
___
Author: tstellar
Date: Mon Jun 4 08:53:28 2018
New Revision: 333915
URL: http://llvm.org/viewvc/llvm-project?rev=333915&view=rev
Log:
Creating release candidate rc2 from release_601 branch
Added:
libcxx/tags/RELEASE_601/rc2/ (props changed)
- copied from r333914, libcxx/branches/rele
Author: tstellar
Date: Mon Jun 4 08:53:32 2018
New Revision: 333916
URL: http://llvm.org/viewvc/llvm-project?rev=333916&view=rev
Log:
Creating release candidate rc2 from release_601 branch
Added:
libcxxabi/tags/RELEASE_601/rc2/
- copied from r333915, libcxxabi/branches/release_60/
___
craig.topper created this revision.
craig.topper added reviewers: tkrupa, RKSimon, spatel, GBuella.
We recently switch to using a selects in the intrinsics header files for FMA
instructions. But the 512-bit versions support flavors with rounding mode which
must be an Integer Constant Expression.
r.stahl added a comment.
In https://reviews.llvm.org/D46421#1119098, @xazax.hun wrote:
> Sorry for the limited activity. Unfortunately, I have very little time
> reviewing patches lately.
Thanks for getting around to it!
> I think we need to answer the following questions:
>
> - Does this ch
SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.
I think this looks ok now, just some nits inline.
Can you please upload your diffs with more context next time?
Comment at: utils/TableGen/NeonEmitter.cpp:2166
+
Author: leonardchan
Date: Mon Jun 4 09:07:52 2018
New Revision: 333923
URL: http://llvm.org/viewvc/llvm-project?rev=333923&view=rev
Log:
This diff includes changes for supporting the following types.
// Primary fixed point types
signed short _Accum s_short_accum;
signed _Accum s_accum;
signed lo
rnk added a comment.
I'm in favor of this direction. The `var || var && truth_constant` pattern
match seems much more robust than the macro pattern match. It's also consistent
with what we do outside of macros, so it's less special and surprising.
https://reviews.llvm.org/D47687
___
yaxunl added a comment.
In https://reviews.llvm.org/D47694#1121037, @rjmccall wrote:
> In https://reviews.llvm.org/D47694#1120375, @yaxunl wrote:
>
> > In https://reviews.llvm.org/D47694#1120367, @rjmccall wrote:
> >
> > > Why not just have the driver disable RTTI in the frontend invocation?
> >
All chromium bots build with asserts on and we definitely don't want shared
libs :-) Having the people who care about this build config make sure it
keeps working seems like a good approach to me.
On Mon, Jun 4, 2018 at 8:15 AM, David Zarzycki via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
This is n-th time i do this kind of fix.
Sure this does resolve the issue, but it would be much better to use
proper means,
and tell people to fix their code, in an automatic way :)
On Mon, Jun 4, 2018 at 7:36 PM, Nico Weber wrote:
> All chromium bots build with asserts on and we definitely don't
vlad.tsyrklevich created this revision.
vlad.tsyrklevich added reviewers: george.karpenkov, NoQ, ddcc.
Herald added subscribers: cfe-commits, a.sidorin, zzheng, szepet, xazax.hun.
Since Z3 tests have been not been running [1] some tests needed to be
updated. I also added a regression test for [1].
Did you use `arc patch` to get the commit description?
Please make sure that the first line of the commit is reasonable.
In this case it is not reasonable.
On Mon, Jun 4, 2018 at 7:07 PM, Leonard Chan via cfe-commits
wrote:
> Author: leonardchan
> Date: Mon Jun 4 09:07:52 2018
> New Revision: 33
Hi Roman – I agree that people shouldn’t need to manually fix this every time
it happens.
Hi Nico – What is stopping the Chromium buildbots from setting
BUILD_SHARED_LIBS to false? That way the default BUILD_SHARED_LIBS policy of
llvm and/or clang doesn’t matter, right?
Dave
> On Jun 4, 2018
Sorry. I did not notice this. I will be sure to add the title from the
phabricator review as the first line next time.
On Mon, Jun 4, 2018 at 9:44 AM Roman Lebedev wrote:
>
> Did you use `arc patch` to get the commit description?
> Please make sure that the first line of the commit is reasonable.
1 - 100 of 185 matches
Mail list logo
