orgads added inline comments.

================
Comment at: unittests/Frontend/ASTUnitTest.cpp:21
 
+#define CREATE_AST_UNIT(isVolatile)                                            
\
+  int FD;                                                                      
\
----------------
Macros are evil. Maybe use TEST_F, and make these members of the base class?


https://reviews.llvm.org/D47460



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to