ebevhan added inline comments.
Comment at: lib/Basic/TargetInfo.cpp:45
+ AccumWidth = AccumAlign = 32;
+ LongAccumWidth = LongAccumAlign = 64;
SuitableAlign = 64;
rsmith wrote:
> jfb wrote:
> > This seems weird because Targets which don't have these values f
balazske added a comment.
If `BeginSourceFile` is not called on the diagnostic client object, it is not
possible to have compiler warnings or errors that come from the "To" context
while importing something (there is some assertion if a source file related
warning is to be emitted but no source
ebevhan added inline comments.
Comment at: include/clang/AST/Type.h:6551
+
+QualType getCorrespondingSaturatedType(const ASTContext &Context,
+ const QualType &Ty);
These should probably be in ASTContext directly.
=
balazske added a comment.
The new `ASTUnit::beginSourceFile` is only there to simplify the code. It is
possible to get `Ctx`, `PP` and `getDiagnostic()` from outside of `ASTUnit` and
call the same thing, but requires more code to write. Probably a more smart
place to call `BeginSourceFile` can
yvvan updated this revision to Diff 149249.
yvvan added a comment.
This is the proper fix. When we get a buffer for main file we should use the
UserFilesAreVolatile flag to specify if memory mapping needs to occur or not.
https://reviews.llvm.org/D47460
Files:
lib/Frontend/ASTUnit.cpp
Inde
CarlosAlbertoEnciso added a comment.
Ping.
Thanks
https://reviews.llvm.org/D46190
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: dstenb
Date: Thu May 31 02:05:22 2018
New Revision: 333637
URL: http://llvm.org/viewvc/llvm-project?rev=333637&view=rev
Log:
[Driver] Clean up tmp files when deleting Compilation objects
Summary:
In rL327851 the createUniqueFile() and createTemporaryFile()
variants that do not return the
Author: dstenb
Date: Thu May 31 02:05:22 2018
New Revision: 333637
URL: http://llvm.org/viewvc/llvm-project?rev=333637&view=rev
Log:
[Driver] Clean up tmp files when deleting Compilation objects
Summary:
In rL327851 the createUniqueFile() and createTemporaryFile()
variants that do not return the
chill updated this revision to Diff 149252.
chill added a comment.
Update:
- similar changes needed for AArch64
- added/updated tests
https://reviews.llvm.org/D46013
Files:
include/clang/AST/ASTContext.h
include/clang/AST/RecordLayout.h
lib/AST/ASTContext.cpp
lib/AST/RecordLayout.cpp
martong added a comment.
I just wanted to give a detailed justification about why we should import the
whole redecl chain. Consider the following code:
void f(); // prototype
void f() { f(); }
Currently, when we import the prototype we end up having two independent
functions with definition
Uran198 created this revision.
Uran198 added a reviewer: alexfh.
Herald added subscribers: cfe-commits, klimek.
When formatting the following string:
"/*\r\n"
" * Comment with\r\n"
"\r\n"
" * blanks.\r\n"
" */\r\n"
clang-format produced:
"/*\r\n"
" * Comment with\r\n"
"\
baloghadamsoftware added a comment.
Sorry, Artem, but it does not work this way. Even if the symbolic expressions
are constrained to `[-MAX/4..MAX/4]`, after rearrangement the difference still
uses the whole range, thus `m>n` becomes `m-n>0`, where in the false branch the
range for `m-n` is `[M
takuto.ikuta created this revision.
takuto.ikuta added reviewers: thakis, rnk.
Herald added a subscriber: hiraditya.
Herald added a reviewer: alexshap.
Even if we support no-canonical-prefix on
clang-cl(https://reviews.llvm.org/D47480), argv0 becomes absolute path in
clang-cl and that embeds abs
SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.
I agree: these intrinsics are available in v7/A32/A64.
Comment at: lib/CodeGen/CGBuiltin.cpp:7865
}
// FIXME: Sharing loads & stores with 32-bit is compli
baloghadamsoftware added a comment.
Maybe if we could apply somehow a `[-MAX/2..MAX/2]` constraint to both sides of
the rearranged equality in SimpleSValBuilder.
https://reviews.llvm.org/D35110
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
aaron.ballman added inline comments.
Comment at: include/clang/Basic/DiagnosticLexKinds.td:713
+def warn_quoted_include_in_framework_header : Warning<
+ "double-quoted include \"%0\" in framework header, expected system style
include"
+ >, InGroup, DefaultIgnore;
CarlosAlbertoEnciso updated this revision to Diff 149261.
CarlosAlbertoEnciso added a comment.
This patch addresses the reviewers comments:
- Additional test cases to cover: -Wunused, -Wall and -Wno-unused-using
- Formatting in ReleaseNotes
- Removed the '-Wunused-usings' alias (GCC compatibility
aaron.ballman added inline comments.
Comment at: include/clang/Basic/Attr.td:851
+ let Spellings = [GCC<"cpu_specific">];
+ let Args = [VariadicIdentifierArgument<"Cpus">];
+ let Subjects = SubjectList<[Function]>;
erichkeane wrote:
> aaron.ballman wrote:
> >
aaron.ballman added inline comments.
Comment at: clang-tidy/ClangTidyProfiling.cpp:72
+ if (EC) {
+llvm::errs() << "Error opening output file'" << Storage->StoreFilename
+ << "': " << EC.message() << "\n";
Missing a whitespace before the quot
balazske added inline comments.
Comment at: lib/AST/ASTImporter.cpp:88
+ llvm::SmallVector getCanonicalForwardRedeclChain(Decl* D) {
+// Currently only FunctionDecl is supported
+auto FD = cast(D);
Assert for FunctionDecl?
Comment at:
tzik added a comment.
In https://reviews.llvm.org/D47067#1116733, @rsmith wrote:
> Slightly reduced testcase:
>
> template T f(T u, bool b) {
> T t;
> if (b) return t;
> return u;
> }
> struct X { X(); X(const X&); ~X(); void *data; };
>
> template X f(X, bool);
>
>
> ... wh
ruiu added a comment.
Looks like this patch contains two unrelated changes. Please separate your
change from the lit config changes.
https://reviews.llvm.org/D47578
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
erichkeane added inline comments.
Comment at: include/clang/Basic/Attr.td:851
+ let Spellings = [GCC<"cpu_specific">];
+ let Args = [VariadicIdentifierArgument<"Cpus">];
+ let Subjects = SubjectList<[Function]>;
aaron.ballman wrote:
> erichkeane wrote:
> > aar
erichkeane updated this revision to Diff 149276.
erichkeane added a comment.
Shamelessly stealing @aaron.ballman s AttrDocs description of cpu_dispatch
bodies.
https://reviews.llvm.org/D47474
Files:
include/clang/AST/Decl.h
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
in
tzik created this revision.
Herald added a subscriber: cfe-commits.
This is the second attempt of r333500 (Update NRVO logic to support early
return).
The previous one was reverted for a miscompilation for an incorrect NRVO set up
on templates such as:
struct Foo {};
template
T bar()
martong added inline comments.
Comment at: lib/AST/ASTImporter.cpp:88
+ llvm::SmallVector getCanonicalForwardRedeclChain(Decl* D) {
+// Currently only FunctionDecl is supported
+auto FD = cast(D);
balazske wrote:
> Assert for FunctionDecl?
`cast` itself
Author: aaronballman
Date: Thu May 31 06:57:09 2018
New Revision: 333653
URL: http://llvm.org/viewvc/llvm-project?rev=333653&view=rev
Log:
Add a new driver mode to dump compiler feature and extension options.
Add the ability to dump compiler option-related information to a JSON file via
the -com
aaron.ballman closed this revision.
aaron.ballman marked 4 inline comments as done.
aaron.ballman added a comment.
Committed in r333653.
Comment at: test/Frontend/compiler-options-dump.cpp:3
+// RUN: %clang_cc1 -compiler-options-dump -std=c++17 %s -o - | FileCheck %s
--check-p
ahatanak added a comment.
ping
Repository:
rC Clang
https://reviews.llvm.org/D36918
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.
Looks great.
Comment at: docs/ReleaseNotes.rst:126
+namespace n { class C; }
+using n::C; // Never actually used.
+
Maybe include an example with a
Szelethus updated this revision to Diff 149290.
Szelethus added a comment.
- Rebased to 1cefbc5593d2f017ae56a853b0723a31865aa602 (revision 333276)
- Fixed some typos
- Added tests `CyclicPointerTest` and `CyclicVoidPointerTest` to highlight an
issue to be fixed in a later patch
https://reviews.
Author: hiraditya
Date: Thu May 31 07:45:32 2018
New Revision: 333657
URL: http://llvm.org/viewvc/llvm-project?rev=333657&view=rev
Log:
Add dump method for selectors
Differential Revision: https://reviews.llvm.org/D45935
Reviewers: compnerd
Modified:
cfe/trunk/include/clang/Basic/IdentifierT
This revision was automatically updated to reflect the committed changes.
Closed by commit rL333657: Add dump method for selectors (authored by
hiraditya, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D45935?vs=143493&id=149294#toc
Repository:
rL LLVM
https://reviews.llv
LukeGeeson created this revision.
LukeGeeson added a reviewer: SjoerdMeijer.
Herald added a reviewer: javed.absar.
Herald added a subscriber: kristof.beyls.
This fixes the ranges for the vcvth family of FP16 intrinsics in the clang
front end. Previously it was accepting incorrect ranges
-Changed
tzik updated this revision to Diff 149299.
tzik added a comment.
test
Repository:
rC Clang
https://reviews.llvm.org/D47586
Files:
include/clang/AST/Decl.h
include/clang/Sema/Scope.h
lib/Sema/Scope.cpp
lib/Sema/SemaDecl.cpp
lib/Sema/SemaExpr.cpp
lib/Sema/SemaStmt.cpp
lib/Sema/Se
amccarth added a comment.
I was under the impression that some tools rely on the fact that arg[0] is
always expanded to an absolute path. Does this work with lldb and its test
suite?
https://reviews.llvm.org/D47578
___
cfe-commits mailing list
cf
adr26 updated this revision to Diff 149300.
adr26 added a comment.
Hi Reid,
I've added testcases matching the issues I hit in
`microsoft-abi-member-pointers.cpp` (no change to the rest of the fix). If you
are happy with this, please feel free to push.
I checked with MSVC, and as per the added
takuto.ikuta updated this revision to Diff 149304.
takuto.ikuta edited the summary of this revision.
https://reviews.llvm.org/D47578
Files:
llvm/lib/Support/Windows/Process.inc
Index: llvm/lib/Support/Windows/Process.inc
===
---
takuto.ikuta added a comment.
In https://reviews.llvm.org/D47578#1117540, @ruiu wrote:
> Looks like this patch contains two unrelated changes. Please separate your
> change from the lit config changes.
First patch made on some wrong assumption, fixed and reverted test config
change.
In https
leonardchan updated this revision to Diff 149305.
leonardchan marked 6 inline comments as done.
Repository:
rC Clang
https://reviews.llvm.org/D46084
Files:
include/clang-c/Index.h
include/clang/AST/ASTContext.h
include/clang/AST/BuiltinTypes.def
include/clang/Basic/DiagnosticCommonKind
leonardchan added inline comments.
Comment at: include/clang/Basic/TokenKinds.def:393
+// ISO/IEC JTC1 SC22 WG14 N1169 Extension
+KEYWORD(_Accum , KEYALL)
+
rsmith wrote:
> leonardchan wrote:
> > jfb wrote:
> > > ebevhan wrote:
> > > > I beli
leonardchan added inline comments.
Comment at: lib/Basic/TargetInfo.cpp:45
+ AccumWidth = AccumAlign = 32;
+ LongAccumWidth = LongAccumAlign = 64;
SuitableAlign = 64;
leonardchan wrote:
> ebevhan wrote:
> > leonardchan wrote:
> > > rsmith wrote:
> > > > jfb
jkorous added a comment.
I don't particularly like that between setting the DeclContext
(SemaTemplateDeduction.cpp:3814) and actually using it (CheckAccess() in
SemaAccess.cpp:1459) are some 20 stack frames but it looks like you already
tried fixing this "locally" in your initial approach.
I a
ahatanak added a comment.
It doesn't look like it's possible to get the context needed to do
accessibility check (CXXMethodDecl 'method' for 'C::overloadedMethod' in the
test case) from 'Expr *OvlExpr' in CheckAddressOfMemberAccess. It's possible to
get the class in which the member is defined
This revision was automatically updated to reflect the committed changes.
Closed by commit rL333670: [analyzer] Improve performance of the SVal
simplification mechanism. (authored by dergachev, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llv
Author: dergachev
Date: Thu May 31 10:22:38 2018
New Revision: 333670
URL: http://llvm.org/viewvc/llvm-project?rev=333670&view=rev
Log:
[analyzer] Improve performance of the SVal simplification mechanism.
When neither LHS nor RHS of a binary operator expression can be simplified,
return the origi
rnk added a comment.
I think this would be easy to unit test in
llvm/unittests/Support/CommandLine.cpp. We'd just check that the filename is
"SupportTests.exe" on Windows and the path is relative after calling this, I
guess. Right? Look at how ProgramTest.cpp does this to get a reasonable argv0
This revision was automatically updated to reflect the committed changes.
Closed by commit rL333671: [analyzer] Improve performance of the SVal
simplification mechanism further. (authored by dergachev, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://rev
Author: dergachev
Date: Thu May 31 10:27:28 2018
New Revision: 333671
URL: http://llvm.org/viewvc/llvm-project?rev=333671&view=rev
Log:
[analyzer] Improve performance of the SVal simplification mechanism further.
Memoize simplification so that we didn't need to simplify the same symbolic
expressi
amccarth added a comment.
In https://reviews.llvm.org/D47578#1117874, @rnk wrote:
> The LLDB test suite isn't in very good shape on Windows. It is complicated to
> set up and build, I don't want to block this fix on @takuto.ikuta setting up
> that build environment. This is a Windows-only chang
Author: jdevlieghere
Date: Thu May 31 10:36:31 2018
New Revision: 333673
URL: http://llvm.org/viewvc/llvm-project?rev=333673&view=rev
Log:
PrintEscapedString -> printEscapedString
Update PrintEscapedString after renaming it in ADT.
Modified:
clang-tools-extra/trunk/clangd/Protocol.cpp
Modif
EricWF added a comment.
So the reason there are `atime` tests at all is due to the implementation
details of `__last_write_time` here. Essentially we have to do extra work
trying to maintain the access time.
I'm OK with this patches rename. `first` and `second` were certainly not clear.
That b
bruno updated this revision to Diff 149313.
bruno added a comment.
Updated the patch after Duncan and Aaron reviews. I actually went a bit more
aggressive with the fixits, since I realized the conditions for the warning are
already strict enough and we should take the chance to be more clear. Fo
mikhail.ramalho updated this revision to Diff 149317.
mikhail.ramalho marked 6 inline comments as not done.
mikhail.ramalho added a comment.
- Simplified refutation process: it now collects all the constraints in a given
path and, only when it reaches the root node, the refutation manager is crea
mikhail.ramalho added subscribers: dcoughlin, george.karpenkov, NoQ.
mikhail.ramalho added a comment.
Hi,
> Just a bit of context and to have some expectation management regarding
> this patch. The main purpose of this implementation was to back a thesis.
> It was made under a very serious time
pcc created this revision.
pcc added reviewers: tejohnson, dblaikie.
Herald added subscribers: JDevlieghere, hiraditya, eraman, inglorion,
mehdi_amini.
https://reviews.llvm.org/D47597
Files:
clang/lib/CodeGen/BackendUtil.cpp
clang/test/CodeGen/thinlto-split-dwarf.c
llvm/include/llvm/LTO/Co
rsmith added inline comments.
Comment at: lib/Basic/TargetInfo.cpp:45
+ AccumWidth = AccumAlign = 32;
+ LongAccumWidth = LongAccumAlign = 64;
SuitableAlign = 64;
leonardchan wrote:
> leonardchan wrote:
> > ebevhan wrote:
> > > leonardchan wrote:
> > > > rsmi
ruiu added inline comments.
Comment at: llvm/lib/Support/Windows/Process.inc:226
+
+static std::error_code GetLongArgv0Path(const wchar_t *Argv0,
+SmallVectorImpl &Args,
It looks like this function is a bit too complicated.
tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.
LGTM thanks!
https://reviews.llvm.org/D47597
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
Author: pcc
Date: Thu May 31 11:25:59 2018
New Revision: 333677
URL: http://llvm.org/viewvc/llvm-project?rev=333677&view=rev
Log:
IRGen: Write .dwo files when -split-dwarf-file is used together with
-fthinlto-index.
Differential Revision: https://reviews.llvm.org/D47597
Added:
cfe/trunk/tes
This revision was automatically updated to reflect the committed changes.
Closed by commit rL333677: IRGen: Write .dwo files when -split-dwarf-file is
used together with -fthinlto… (authored by pcc, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://review
dexonsmith added inline comments.
Comment at: test/Modules/double-quotes.m:24-25
+
+// The same warnings show up when modules is on but -verify doesn't get it
+// because they only show up under the module A building context.
+// RUN: FileCheck --input-file=%t/stderr %s
-
Author: dergachev
Date: Thu May 31 11:30:41 2018
New Revision: 333679
URL: http://llvm.org/viewvc/llvm-project?rev=333679&view=rev
Log:
[analyzer] Annotate ProgramState update methods with LLVM_NODISCARD.
Because our program states are immutable, methods like "add<>", "set<>", "bind"
create a cop
This revision was automatically updated to reflect the committed changes.
Closed by commit rL333679: [analyzer] Annotate ProgramState update methods with
LLVM_NODISCARD. (authored by dergachev, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llv
aaron.ballman added inline comments.
Comment at: test/Modules/double-quotes.m:27-29
+// CHECK: double-quoted include "A0.h" in framework header, expected
angle-bracketed include instead
+// CHECK: double-quoted include "B.h" in framework header, expected
angle-bracketed includ
Author: rnk
Date: Thu May 31 11:42:29 2018
New Revision: 333680
URL: http://llvm.org/viewvc/llvm-project?rev=333680&view=rev
Log:
Fix null MSInheritanceAttr deref in CXXRecordDecl::getMSInheritanceModel()
Ensure latest MPT decl has a MSInheritanceAttr when instantiating
templates, to avoid null M
This revision was automatically updated to reflect the committed changes.
Closed by commit rC333680: Fix null MSInheritanceAttr deref in
CXXRecordDecl::getMSInheritanceModel() (authored by rnk, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D46664?vs=149300&id=149329#toc
Rep
rnk added a comment.
Thanks for the patch, I committed it as r333680 with a minor modification.
https://reviews.llvm.org/D46664
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnkovacs added a comment.
In https://reviews.llvm.org/D45517#1117898, @mikhail.ramalho wrote:
> Just want to comment here and give thanks again for the first version of
> the refutation code. It's being really helpful to develop the approach this
> code as a base; things would definitely be slo
On Thu, May 31, 2018 at 11:20 AM Peter Collingbourne via Phabricator <
revi...@reviews.llvm.org> wrote:
> pcc created this revision.
> pcc added reviewers: tejohnson, dblaikie.
> Herald added subscribers: JDevlieghere, hiraditya, eraman, inglorion,
> mehdi_amini.
>
> https://reviews.llvm.org/D4759
alekseyshl created this revision.
clang part of the two part patch (LLVM + clang)
LLVM part: https://reviews.llvm.org/D47599
Refer to https://reviews.llvm.org/D47599 for the detailed description.
Repository:
rC Clang
https://reviews.llvm.org/D47600
Files:
include/clang/Driver/Options.td
On Thu, May 31, 2018 at 11:54 AM, David Blaikie wrote:
>
>
> On Thu, May 31, 2018 at 11:20 AM Peter Collingbourne via Phabricator <
> revi...@reviews.llvm.org> wrote:
>
>> pcc created this revision.
>> pcc added reviewers: tejohnson, dblaikie.
>> Herald added subscribers: JDevlieghere, hiraditya,
akyrtzi added a comment.
Thanks for the explanation. Please do add documentation comments for the new
method so people using ASTUnit in their own code have an idea when and why they
would need to call this. Something like "if you intend to emit additional
diagnostics after the ASTUnit is create
adr26 added a comment.
That's a nice change to avoid duplication in
`ClassTemplateSpecializationDecl::getMostRecentDecl()`. Thanks for your help
getting this out the door!
Repository:
rC Clang
https://reviews.llvm.org/D46664
___
cfe-commits mai
NoQ updated this revision to Diff 149337.
NoQ added a comment.
Hmm, actually composition looks very pretty if you use the magic word "impl".
https://reviews.llvm.org/D47350
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h
lib/StaticAnalyzer/Core/ExprEngine.cpp
lib/Stati
stephanemoore updated this revision to Diff 149338.
stephanemoore added a comment.
Removed the last format from the tests. That particular scenario was failing
and it might need additional changes to pass. I also think that particular
scenario is not critical to the change and can be considered
efriedma added reviewers: aemerson, rjmccall.
efriedma added a comment.
I'm not sure Apple will want to mess with their ABI like this... adding some
reviewers.
Otherwise LGTM.
Comment at: lib/CodeGen/TargetInfo.cpp:5790
// than ABI alignment.
- uint64_t ABIAlign = 4;
- u
dexonsmith added inline comments.
Comment at: test/Modules/double-quotes.m:27-29
+// CHECK: double-quoted include "A0.h" in framework header, expected
angle-bracketed include instead
+// CHECK: double-quoted include "B.h" in framework header, expected
angle-bracketed include
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D47157
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
ddcc created this revision.
ddcc added reviewers: george.karpenkov, NoQ.
Herald added subscribers: a.sidorin, szepet, xazax.hun.
Clang does not have a corresponding QualType for a 1-bit APSInt, so use the
BoolTy and extend the APSInt. Split from https://reviews.llvm.org/D35450.
Repository:
rC
On Thu, May 31, 2018 at 12:00 PM Peter Collingbourne
wrote:
>
>
> On Thu, May 31, 2018 at 11:54 AM, David Blaikie
> wrote:
>
>>
>>
>> On Thu, May 31, 2018 at 11:20 AM Peter Collingbourne via Phabricator <
>> revi...@reviews.llvm.org> wrote:
>>
>>> pcc created this revision.
>>> pcc added reviewe
george.karpenkov requested changes to this revision.
george.karpenkov added a comment.
This revision now requires changes to proceed.
Thanks! Looks good with minor changes.
Would it be possible to add tests? I know we have very few unit tests, but I
assume you could actually use an integration t
george.karpenkov added a comment.
👍
https://reviews.llvm.org/D47350
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk added a comment.
Using CapturedStmt to do frontend outlining was the direction I suggested. I
want to hear what @rsmith and @rjmccall think, though.
Comment at: lib/Parse/ParseObjc.cpp:2588
+ bool ShouldCapture = Actions.getASTContext()
+
vlad.tsyrklevich added a comment.
In https://reviews.llvm.org/D47603#1118106, @george.karpenkov wrote:
> Would it be possible to add tests? I know we have very few unit tests, but I
> assume you could actually use an integration test to exercise this path?
I tested this change and it fixes PR3
smeenai updated this revision to Diff 149351.
smeenai edited the summary of this revision.
smeenai added a comment.
@rnk comment
Repository:
rC Clang
https://reviews.llvm.org/D47564
Files:
include/clang/AST/Stmt.h
include/clang/Basic/CapturedStmt.h
include/clang/Sema/ScopeInfo.h
lib/
ddcc added a comment.
In https://reviews.llvm.org/D47603#1118138, @vlad.tsyrklevich wrote:
> In https://reviews.llvm.org/D47603#1118106, @george.karpenkov wrote:
>
> > Would it be possible to add tests? I know we have very few unit tests, but
> > I assume you could actually use an integration te
ddcc updated this revision to Diff 149356.
ddcc added a comment.
Add test, address comments
Repository:
rC Clang
https://reviews.llvm.org/D47603
Files:
lib/StaticAnalyzer/Core/Z3ConstraintManager.cpp
test/Analysis/apsint.c
Index: test/Analysis/apsint.c
==
bruno updated this revision to Diff 149359.
bruno edited the summary of this revision.
bruno added a comment.
Update after Duncan's review: remove header name from the warning message
(since it's already in the fixit)
https://reviews.llvm.org/D47157
Files:
include/clang/Basic/DiagnosticGroup
bruno added inline comments.
Comment at: test/Modules/double-quotes.m:24-25
+
+// The same warnings show up when modules is on but -verify doesn't get it
+// because they only show up under the module A building context.
+// RUN: FileCheck --input-file=%t/stderr %s
--
leonardchan updated this revision to Diff 149360.
leonardchan marked 7 inline comments as done.
Repository:
rC Clang
https://reviews.llvm.org/D46911
Files:
include/clang/AST/ASTContext.h
include/clang/AST/BuiltinTypes.def
include/clang/AST/Type.h
include/clang/Basic/DiagnosticSemaKinds
leonardchan added inline comments.
Comment at: lib/Sema/DeclSpec.cpp:1123
+if (!(TypeSpecType == TST_accum || TypeSpecType == TST_fract)) {
+ S.Diag(TSSatLoc, diag::err_invalid_saturation_spec)
+ << getSpecifierName((TST)TypeSpecType, Policy);
e
bruno updated this revision to Diff 149361.
bruno added a comment.
Update patch after changes to https://reviews.llvm.org/D47157. Also address
some of Volodymyr feedback.
https://reviews.llvm.org/D47301
Files:
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticLexKinds.t
gtbercea added a comment.
> Assuming we do proceed with back-to-CUDA approach, one thing I'd consider
> would be using clang's -fcuda-include-gpubinary option which CUDA uses to
> include GPU code into the host object. You may be able to use it to avoid
> compiling and partially linking .fatbin
bruno marked an inline comment as done.
bruno added inline comments.
Comment at: include/clang/Basic/DiagnosticGroups.td:34-35
def AutoImport : DiagGroup<"auto-import">;
def FrameworkHdrQuotedInclude :
DiagGroup<"quoted-include-in-framework-header">;
+def FrameworkIncludePriva
erik.pilkington created this revision.
erik.pilkington added reviewers: rsmith, EricWF, mclow.lists.
Herald added subscribers: christof, kosarev.
and define `__value_type` as a union between pair
and pair so that various operations can move into/from these pairs
[1]. This is a pretty blatant s
This revision was automatically updated to reflect the committed changes.
Closed by commit rL333703: [WebAssembly] Use Windows EH instructions for Wasm
EH (authored by aheejin, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D44931
Files:
Author: aheejin
Date: Thu May 31 15:18:13 2018
New Revision: 333703
URL: http://llvm.org/viewvc/llvm-project?rev=333703&view=rev
Log:
[WebAssembly] Use Windows EH instructions for Wasm EH
Summary:
Because wasm control flow needs to be structured, using WinEH
instructions to support wasm EH brings
tra added a comment.
In https://reviews.llvm.org/D47394#1118223, @gtbercea wrote:
> I tried this example
> (https://devblogs.nvidia.com/separate-compilation-linking-cuda-device-code/).
> It worked with NVCC but not with clang++. I can produce the main.o particle.o
> and v.o objects as relocata
george.karpenkov accepted this revision.
george.karpenkov added a comment.
This revision is now accepted and ready to land.
Thanks!
Repository:
rC Clang
https://reviews.llvm.org/D47603
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
1 - 100 of 150 matches
Mail list logo
